<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192431</bug_id>
          
          <creation_ts>2018-12-05 14:46:56 -0800</creation_ts>
          <short_desc>Fix MiniBrowser&apos;s entitlements</short_desc>
          <delta_ts>2019-02-09 00:12:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>joepeck</cc>
    
    <cc>opendarwin</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1485449</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2018-12-05 14:46:56 -0800</bug_when>
    <thetext>Fix MiniBrowser&apos;s entitlements</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1485451</commentid>
    <comment_count>1</comment_count>
      <attachid>356661</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2018-12-05 14:49:06 -0800</bug_when>
    <thetext>Created attachment 356661
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504323</commentid>
    <comment_count>2</comment_count>
      <attachid>356661</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2019-02-08 15:14:32 -0800</bug_when>
    <thetext>Comment on attachment 356661
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504325</commentid>
    <comment_count>3</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2019-02-08 15:15:02 -0800</bug_when>
    <thetext>*** Bug 187494 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504327</commentid>
    <comment_count>4</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2019-02-08 15:15:18 -0800</bug_when>
    <thetext>*** Bug 193159 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504507</commentid>
    <comment_count>5</comment_count>
      <attachid>356661</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-08 22:11:53 -0800</bug_when>
    <thetext>Comment on attachment 356661
Patch

Rejecting attachment 356661 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 356661, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=356661&amp;action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192431&amp;ctype=xml&amp;excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 356661 from bug 192431.
Fetching: https://bugs.webkit.org/attachment.cgi?id=356661
Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;, &apos;--reviewer&apos;, u&apos;Joseph Pecoraro&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/MiniBrowser/MiniBrowser.entitlements
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/MiniBrowser.entitlements.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;, &apos;--reviewer&apos;, u&apos;Joseph Pecoraro&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11088193</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504514</commentid>
    <comment_count>6</comment_count>
      <attachid>361597</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2019-02-08 22:23:52 -0800</bug_when>
    <thetext>Created attachment 361597
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504515</commentid>
    <comment_count>7</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2019-02-08 22:24:20 -0800</bug_when>
    <thetext>Thanks for the review Joe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504551</commentid>
    <comment_count>8</comment_count>
      <attachid>361597</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-09 00:11:09 -0800</bug_when>
    <thetext>Comment on attachment 361597
Patch

Clearing flags on attachment: 361597

Committed r241238: &lt;https://trac.webkit.org/changeset/241238&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504552</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-09 00:11:11 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504553</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-09 00:12:41 -0800</bug_when>
    <thetext>&lt;rdar://problem/47939735&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>356661</attachid>
            <date>2018-12-05 14:49:06 -0800</date>
            <delta_ts>2019-02-08 22:23:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192431-20181205144906.patch</filename>
            <type>text/plain</type>
            <size>1863</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmMzYmYwZmVkZWE0M2M5ZDQ3YmI0MDM5ZDY2MWI3MTJm
NTdmMTcxZC4uMWE3YTNkYjU0ZmFiYTlmNjliYjc2NTM5NmIwNDlkYjRhMjI0OWNmNCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDE4LTEyLTA1ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K
KworICAgICAgICBGaXggTWluaUJyb3dzZXIncyBlbnRpdGxlbWVudHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjQzMQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pbmlCcm93c2VyJ3MgRXh0ZW5zaW9u
cyBNYW5hZ2VyIHdhcyBicm9rZW4uIFRoZSBlbnRpdGxlbWVudCB3YXMgbWlzc2luZyBmb3Igb3Bl
bmluZworICAgICAgICBmaWxlcywgbWFraW5nIGl0IGltcG9zc2libGUgdG8gbG9hZCBhbnkgZXh0
ZW5zaW9uLgorCisgICAgICAgICogTWluaUJyb3dzZXIvTWluaUJyb3dzZXIuZW50aXRsZW1lbnRz
OgorCiAyMDE4LTEyLTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmVncmVzc2lvbihQU09OKSBHb29nbGUgT0F1dGggaXMgYnJva2VuIGluIHByaXZhdGUgc2Vz
c2lvbnMKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL01pbmlCcm93c2VyLmVudGl0bGVt
ZW50cyBiL1Rvb2xzL01pbmlCcm93c2VyL01pbmlCcm93c2VyLmVudGl0bGVtZW50cwppbmRleCBl
MDg1ZjRlYTc1OThmNzlhNTEzNWI0OGM5ZTRiNTA1MWI4ZWQ0OTBlLi4yZmI0M2ZiYjhkOTQxYTE5
NjZjNGQ1ZjgwMTJhNjM0MjEyZDFjZTQ1IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9N
aW5pQnJvd3Nlci5lbnRpdGxlbWVudHMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvTWluaUJyb3dz
ZXIuZW50aXRsZW1lbnRzCkBAIC0yLDE1ICsyLDE3IEBACiA8IURPQ1RZUEUgcGxpc3QgUFVCTElD
ICItLy9BcHBsZS8vRFREIFBMSVNUIDEuMC8vRU4iICJodHRwOi8vd3d3LmFwcGxlLmNvbS9EVERz
L1Byb3BlcnR5TGlzdC0xLjAuZHRkIj4KIDxwbGlzdCB2ZXJzaW9uPSIxLjAiPgogPGRpY3Q+CisJ
PGtleT5jb20uYXBwbGUuc2VjdXJpdHkuYXBwLXNhbmRib3g8L2tleT4KKwk8dHJ1ZS8+CiAJPGtl
eT5jb20uYXBwbGUuc2VjdXJpdHkuZGV2aWNlLnVzYjwva2V5PgogCTx0cnVlLz4KLQk8a2V5PmNv
bS5hcHBsZS5zZWN1cml0eS50ZW1wb3JhcnktZXhjZXB0aW9uLm1hY2gtbG9va3VwLmdsb2JhbC1u
YW1lPC9rZXk+Ci0JPHN0cmluZz5jb20uYXBwbGUuU2FmYXJpLlNhZmVCcm93c2luZy5TZXJ2aWNl
PC9zdHJpbmc+Ci0JPGtleT5jb20uYXBwbGUuc2VjdXJpdHkuYXBwLXNhbmRib3g8L2tleT4KKwk8
a2V5PmNvbS5hcHBsZS5zZWN1cml0eS5maWxlcy51c2VyLXNlbGVjdGVkLnJlYWQtb25seTwva2V5
PgogCTx0cnVlLz4KIAk8a2V5PmNvbS5hcHBsZS5zZWN1cml0eS5uZXR3b3JrLmNsaWVudDwva2V5
PgogCTx0cnVlLz4KIAk8a2V5PmNvbS5hcHBsZS5zZWN1cml0eS50ZW1wb3JhcnktZXhjZXB0aW9u
LmZpbGVzLmFic29sdXRlLXBhdGgucmVhZC1vbmx5PC9rZXk+CiAJPHN0cmluZz4vPC9zdHJpbmc+
CisJPGtleT5jb20uYXBwbGUuc2VjdXJpdHkudGVtcG9yYXJ5LWV4Y2VwdGlvbi5tYWNoLWxvb2t1
cC5nbG9iYWwtbmFtZTwva2V5PgorCTxzdHJpbmc+Y29tLmFwcGxlLlNhZmFyaS5TYWZlQnJvd3Np
bmcuU2VydmljZTwvc3RyaW5nPgogPC9kaWN0PgogPC9wbGlzdD4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361597</attachid>
            <date>2019-02-08 22:23:52 -0800</date>
            <delta_ts>2019-02-09 00:11:09 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192431-20190208222352.patch</filename>
            <type>text/plain</type>
            <size>1339</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWFjYjdmMjIyMWUzNmU2YTg5NmZhNzhlYWEyZWM4Yzc5
YzJkYTM5NS4uOGE1YTE4MmVjOGY2MzMyMmQ2ZDFjZWI5MmY0MmZmNzJjN2ZmOGY5ZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDE5LTAyLTA4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K
KworICAgICAgICBGaXggTWluaUJyb3dzZXIncyBlbnRpdGxlbWVudHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjQzMQorCisgICAgICAgIFJldmll
d2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICBNaW5pQnJvd3NlcidzIEV4dGVuc2lv
bnMgTWFuYWdlciB3YXMgYnJva2VuLiBUaGUgZW50aXRsZW1lbnQgd2FzIG1pc3NpbmcgZm9yIG9w
ZW5pbmcKKyAgICAgICAgZmlsZXMsIG1ha2luZyBpdCBpbXBvc3NpYmxlIHRvIGxvYWQgYW55IGV4
dGVuc2lvbi4KKworICAgICAgICAqIE1pbmlCcm93c2VyL01pbmlCcm93c2VyLmVudGl0bGVtZW50
czoKKwogMjAxOS0wMi0wOCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29t
PgogCiAgICAgICAgIFtDb2NvYV0gQXNrIHBsYXRmb3JtIGZvciBnZW5lcmljIGZvbnQgZmFtaWx5
IG1hcHBpbmdzCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9NaW5pQnJvd3Nlci5lbnRp
dGxlbWVudHMgYi9Ub29scy9NaW5pQnJvd3Nlci9NaW5pQnJvd3Nlci5lbnRpdGxlbWVudHMKaW5k
ZXggODMxMDY4NzFmZmM4N2ZhYzI5ZGQyOWEwNjg0MWUyYWZlZTMwNWZjNS4uYzllYTM3NjQ2OGE2
NDk5NzZjOWFlMzhmMjk5YTMyNWRjYjRkYWRiOSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dz
ZXIvTWluaUJyb3dzZXIuZW50aXRsZW1lbnRzCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL01pbmlC
cm93c2VyLmVudGl0bGVtZW50cwpAQCAtNCw2ICs0LDggQEAKIDxkaWN0PgogCTxrZXk+Y29tLmFw
cGxlLnNlY3VyaXR5LmRldmljZS51c2I8L2tleT4KIAk8dHJ1ZS8+CisJPGtleT5jb20uYXBwbGUu
c2VjdXJpdHkuZmlsZXMudXNlci1zZWxlY3RlZC5yZWFkLW9ubHk8L2tleT4KKwk8dHJ1ZS8+CiAJ
PGtleT5jb20uYXBwbGUuc2VjdXJpdHkudGVtcG9yYXJ5LWV4Y2VwdGlvbi5tYWNoLWxvb2t1cC5n
bG9iYWwtbmFtZTwva2V5PgogCTxhcnJheT4KIAkJPHN0cmluZz5jb20uYXBwbGUuU2FmYXJpLlNh
ZmVCcm93c2luZy5TZXJ2aWNlPC9zdHJpbmc+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>