192409 2018-12-05 10:26:33 -0800 webkitpy: Ignore case when comparing device types 2018-12-06 15:05:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192161 https://bugs.webkit.org/show_bug.cgi?id=192162 https://bugs.webkit.org/show_bug.cgi?id=192472 InRadar P2 Normal --- 1 jbedard jbedard commit-queue darin ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1485289 0 jbedard 2018-12-05 10:26:33 -0800 When discussing <https://bugs.webkit.org/show_bug.cgi?id=192161>, which lays the groundwork for <https://bugs.webkit.org/show_bug.cgi?id=192162>, Lucas Forschler pointed out to me that while devices types are always capitalized, platforms are never capitalized. This will no doubt cause confusion when device types are embedded into expected results. To remedy this confusion, we can make the DeviceType class ignore the case of the contained strings when comparing. This means a DeviceType constructed with a lowercase string would match the DeviceType coming from simctl (which will have some letters capitalized) 1485290 1 webkit-bug-importer 2018-12-05 10:27:05 -0800 <rdar://problem/46491558> 1485293 2 356617 jbedard 2018-12-05 10:30:45 -0800 Created attachment 356617 Patch 1485297 3 356617 lforschler 2018-12-05 10:37:50 -0800 Comment on attachment 356617 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356617&action=review lgtm with typo fix. > Tools/ChangeLog:10 > + against DeviceTypes coming form the simulator runtime. typo: from 1485308 4 356620 jbedard 2018-12-05 10:58:08 -0800 Created attachment 356620 Patch for landing 1485344 5 commit-queue 2018-12-05 11:46:58 -0800 The commit-queue encountered the following flaky tests while processing attachment 356620: http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html bug 192418 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1485347 6 commit-queue 2018-12-05 11:47:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 356620: webgl/2.0.0/conformance/more/glsl/arrayOutOfBounds.html bug 192419 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch. 1485396 7 356620 commit-queue 2018-12-05 13:02:54 -0800 Comment on attachment 356620 Patch for landing Clearing flags on attachment: 356620 Committed r238906: <https://trac.webkit.org/changeset/238906> 1485397 8 commit-queue 2018-12-05 13:02:55 -0800 All reviewed patches have been landed. Closing bug. 1485774 9 356620 darin 2018-12-06 12:41:28 -0800 Comment on attachment 356620 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=356620&action=review > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:147 > + def test_comparsion_lower_case(self): Typo here: "comparsion" 1485797 10 jbedard 2018-12-06 13:35:45 -0800 Reopening to attach new patch. 1485798 11 356748 jbedard 2018-12-06 13:35:46 -0800 Created attachment 356748 Patch for landing 1485799 12 jbedard 2018-12-06 13:36:40 -0800 (In reply to Darin Adler from comment #9) > Comment on attachment 356620 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356620&action=review > > > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:147 > > + def test_comparsion_lower_case(self): > > Typo here: "comparsion" Oops, thanks Darin, landing a fix for the typo. 1485825 13 commit-queue 2018-12-06 14:24:59 -0800 The commit-queue encountered the following flaky tests while processing attachment 356748: inspector/canvas/recording-bitmaprenderer.html bug 192475 (author: drousso@apple.com) The commit-queue is continuing to process your patch. 1485828 14 commit-queue 2018-12-06 14:25:05 -0800 The commit-queue encountered the following flaky tests while processing attachment 356748: imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-hangul.html bug 192476 (author: mjs@apple.com) The commit-queue is continuing to process your patch. 1485834 15 commit-queue 2018-12-06 14:50:58 -0800 The commit-queue encountered the following flaky tests while processing attachment 356748: http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch. 1485840 16 commit-queue 2018-12-06 14:51:18 -0800 The commit-queue encountered the following flaky tests while processing attachment 356748: webgl/1.0.2/conformance/more/conformance/methods.html bug 192477 (author: roger_fong@apple.com) workers/bomb.html bug 192050 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. 1485842 17 356748 commit-queue 2018-12-06 15:05:45 -0800 Comment on attachment 356748 Patch for landing Clearing flags on attachment: 356748 Committed r238943: <https://trac.webkit.org/changeset/238943> 1485843 18 commit-queue 2018-12-06 15:05:46 -0800 All reviewed patches have been landed. Closing bug. 356617 2018-12-05 10:30:45 -0800 2018-12-05 10:58:07 -0800 Patch bug-192409-20181205103044.patch text/plain 5167 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODg5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE4LTEyLTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSWdub3JlIGNhc2Ugd2hlbiBjb21wYXJpbmcgZGV2aWNl IHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTI0MDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NDkxNTU4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWxsb3dzIERldmljZVR5cGVz IGNvbnN0cnVjdGVkIHdpdGggbG93ZXJjYXNlIHN0cmluZ3MgdG8gY29ycmVjdGx5IGNvbXBhcmUK KyAgICAgICAgYWdhaW5zdCBEZXZpY2VUeXBlcyBjb21pbmcgZm9ybSB0aGUgc2ltdWxhdG9yIHJ1 bnRpbWUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlLnB5 OgorICAgICAgICAoRGV2aWNlVHlwZS5fX2VxX18pOgorICAgICAgICAoRGV2aWNlVHlwZS5fX2Nv bnRhaW5zX18pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUvZGV2aWNlX3R5cGVf dW5pdHRlc3QucHk6CisgICAgICAgIChEZXZpY2VUeXBlVGVzdCk6CisgICAgICAgIChEZXZpY2VU eXBlVGVzdC50ZXN0X2NvbXBhcnNpb25fbG93ZXJfY2FzZSk6CisKIDIwMTgtMTItMDUgIEFsaWNp YSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtNU0VdW0dTdHJl YW1lcl0gUmVtb3ZlIHRoZSBBcHBlbmRQaXBlbGluZSBzdGF0ZSBtYWNoaW5lCkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvZGV2aWNlX3R5cGUucHkJKHJldmlzaW9uIDIzODg5 NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvZGV2aWNlX3R5cGUucHkJKHdvcmtp bmcgY29weSkKQEAgLTExNywxMSArMTE3LDExIEBAIGNsYXNzIERldmljZVR5cGUob2JqZWN0KToK ICAgICAjIFRoaXMgdGVjaG5pcXVlIG9mIG1hdGNoaW5nIHRyZWF0cyAnTm9uZScgYSB3aWxkLWNh cmQuCiAgICAgZGVmIF9fZXFfXyhzZWxmLCBvdGhlcik6CiAgICAgICAgIGFzc2VydCBpc2luc3Rh bmNlKG90aGVyLCBEZXZpY2VUeXBlKQotICAgICAgICBpZiBzZWxmLmhhcmR3YXJlX2ZhbWlseSBp cyBub3QgTm9uZSBhbmQgb3RoZXIuaGFyZHdhcmVfZmFtaWx5IGlzIG5vdCBOb25lIGFuZCBzZWxm LmhhcmR3YXJlX2ZhbWlseSAhPSBvdGhlci5oYXJkd2FyZV9mYW1pbHk6CisgICAgICAgIGlmIHNl bGYuaGFyZHdhcmVfZmFtaWx5IGlzIG5vdCBOb25lIGFuZCBvdGhlci5oYXJkd2FyZV9mYW1pbHkg aXMgbm90IE5vbmUgYW5kIHNlbGYuaGFyZHdhcmVfZmFtaWx5Lmxvd2VyKCkgIT0gb3RoZXIuaGFy ZHdhcmVfZmFtaWx5Lmxvd2VyKCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKLSAgICAgICAg aWYgc2VsZi5oYXJkd2FyZV90eXBlIGlzIG5vdCBOb25lIGFuZCBvdGhlci5oYXJkd2FyZV90eXBl IGlzIG5vdCBOb25lIGFuZCBzZWxmLmhhcmR3YXJlX3R5cGUgIT0gb3RoZXIuaGFyZHdhcmVfdHlw ZToKKyAgICAgICAgaWYgc2VsZi5oYXJkd2FyZV90eXBlIGlzIG5vdCBOb25lIGFuZCBvdGhlci5o YXJkd2FyZV90eXBlIGlzIG5vdCBOb25lIGFuZCBzZWxmLmhhcmR3YXJlX3R5cGUubG93ZXIoKSAh PSBvdGhlci5oYXJkd2FyZV90eXBlLmxvd2VyKCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UK LSAgICAgICAgaWYgc2VsZi5zb2Z0d2FyZV92YXJpYW50IGlzIG5vdCBOb25lIGFuZCBvdGhlci5z b2Z0d2FyZV92YXJpYW50IGlzIG5vdCBOb25lIGFuZCBzZWxmLnNvZnR3YXJlX3ZhcmlhbnQgIT0g b3RoZXIuc29mdHdhcmVfdmFyaWFudDoKKyAgICAgICAgaWYgc2VsZi5zb2Z0d2FyZV92YXJpYW50 IGlzIG5vdCBOb25lIGFuZCBvdGhlci5zb2Z0d2FyZV92YXJpYW50IGlzIG5vdCBOb25lIGFuZCBz ZWxmLnNvZnR3YXJlX3ZhcmlhbnQubG93ZXIoKSAhPSBvdGhlci5zb2Z0d2FyZV92YXJpYW50Lmxv d2VyKCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYgc2VsZi5zb2Z0d2Fy ZV92ZXJzaW9uIGlzIG5vdCBOb25lIGFuZCBvdGhlci5zb2Z0d2FyZV92ZXJzaW9uIGlzIG5vdCBO b25lIGFuZCBzZWxmLnNvZnR3YXJlX3ZlcnNpb24gIT0gb3RoZXIuc29mdHdhcmVfdmVyc2lvbjoK ICAgICAgICAgICAgIHJldHVybiBGYWxzZQpAQCAtMTI5LDExICsxMjksMTEgQEAgY2xhc3MgRGV2 aWNlVHlwZShvYmplY3QpOgogCiAgICAgZGVmIF9fY29udGFpbnNfXyhzZWxmLCBvdGhlcik6CiAg ICAgICAgIGFzc2VydCBpc2luc3RhbmNlKG90aGVyLCBEZXZpY2VUeXBlKQotICAgICAgICBpZiBz ZWxmLmhhcmR3YXJlX2ZhbWlseSBpcyBub3QgTm9uZSBhbmQgc2VsZi5oYXJkd2FyZV9mYW1pbHkg IT0gb3RoZXIuaGFyZHdhcmVfZmFtaWx5OgorICAgICAgICBpZiBzZWxmLmhhcmR3YXJlX2ZhbWls eSBpcyBub3QgTm9uZSBhbmQgKG5vdCBvdGhlci5oYXJkd2FyZV9mYW1pbHkgb3Igc2VsZi5oYXJk d2FyZV9mYW1pbHkubG93ZXIoKSAhPSBvdGhlci5oYXJkd2FyZV9mYW1pbHkubG93ZXIoKSk6CiAg ICAgICAgICAgICByZXR1cm4gRmFsc2UKLSAgICAgICAgaWYgc2VsZi5oYXJkd2FyZV90eXBlIGlz IG5vdCBOb25lIGFuZCBzZWxmLmhhcmR3YXJlX3R5cGUgIT0gb3RoZXIuaGFyZHdhcmVfdHlwZToK KyAgICAgICAgaWYgc2VsZi5oYXJkd2FyZV90eXBlIGlzIG5vdCBOb25lIGFuZCAobm90IG90aGVy LmhhcmR3YXJlX3R5cGUgb3Igc2VsZi5oYXJkd2FyZV90eXBlLmxvd2VyKCkgIT0gb3RoZXIuaGFy ZHdhcmVfdHlwZS5sb3dlcigpKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQotICAgICAgICBp ZiBzZWxmLnNvZnR3YXJlX3ZhcmlhbnQgaXMgbm90IE5vbmUgYW5kIHNlbGYuc29mdHdhcmVfdmFy aWFudCAhPSBvdGhlci5zb2Z0d2FyZV92YXJpYW50OgorICAgICAgICBpZiBzZWxmLnNvZnR3YXJl X3ZhcmlhbnQgaXMgbm90IE5vbmUgYW5kIChub3Qgb3RoZXIuc29mdHdhcmVfdmFyaWFudCBvciBz ZWxmLnNvZnR3YXJlX3ZhcmlhbnQubG93ZXIoKSAhPSBvdGhlci5zb2Z0d2FyZV92YXJpYW50Lmxv d2VyKCkpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIGlmIHNlbGYuc29mdHdh cmVfdmVyc2lvbiBpcyBub3QgTm9uZSBhbmQgb3RoZXIuc29mdHdhcmVfdmVyc2lvbiBpcyBub3Qg Tm9uZSBhbmQgbm90IG90aGVyLnNvZnR3YXJlX3ZlcnNpb24gaW4gc2VsZi5zb2Z0d2FyZV92ZXJz aW9uOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3hjb2RlL2RldmljZV90eXBlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkveGNvZGUvZGV2aWNlX3R5cGVfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIz ODg5NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvZGV2aWNlX3R5cGVfdW5pdHRl c3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE0MywzICsxNDMsMTUgQEAgY2xhc3MgRGV2aWNlVHlw ZVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydEZhbHNlKERldmlj ZVR5cGUuZnJvbV9zdHJpbmcoJ2lQaG9uZScpIGluIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lQ aG9uZSA2cycpKQogICAgICAgICBzZWxmLmFzc2VydFRydWUoRGV2aWNlVHlwZS5mcm9tX3N0cmlu ZygnaVBob25lJywgVmVyc2lvbigxMSwgMSkpIGluIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lQ aG9uZScsIFZlcnNpb24oMTEpKSkKICAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShEZXZpY2VUeXBl LmZyb21fc3RyaW5nKCdpUGhvbmUnLCBWZXJzaW9uKDExKSkgaW4gRGV2aWNlVHlwZS5mcm9tX3N0 cmluZygnaVBob25lJywgVmVyc2lvbigxMSwgMSkpKQorCisgICAgZGVmIHRlc3RfY29tcGFyc2lv bl9sb3dlcl9jYXNlKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKERldmljZVR5cGUu ZnJvbV9zdHJpbmcoJ2lwaG9uZSBYJyksIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lQaG9uZScp KQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9u ZScpLCBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpUGhvbmUgWCcpKQorICAgICAgICBzZWxmLmFz c2VydEVxdWFsKERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lQaG9uZSBYJyksIERldmljZVR5cGUu ZnJvbV9zdHJpbmcoJ2lwaG9uZScpKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKERldmljZVR5 cGUuZnJvbV9zdHJpbmcoJ2lQaG9uZScpLCBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpcGhvbmUg WCcpKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lw aG9uZSBYJyksIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZScpKQorICAgICAgICBzZWxm LmFzc2VydEVxdWFsKERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZScpLCBEZXZpY2VUeXBl LmZyb21fc3RyaW5nKCdpcGhvbmUgWCcpKQorCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShEZXZp Y2VUeXBlLmZyb21fc3RyaW5nKCdpcGhvbmUgNnMnKSBpbiBEZXZpY2VUeXBlLmZyb21fc3RyaW5n KCdpUGhvbmUnKSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKERldmljZVR5cGUuZnJvbV9zdHJp bmcoJ2lQaG9uZSA2cycpIGluIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZScpKQorICAg ICAgICBzZWxmLmFzc2VydFRydWUoRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaXBob25lIDZzJykg aW4gRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaXBob25lJykpCg== 356620 2018-12-05 10:58:08 -0800 2018-12-06 13:35:44 -0800 Patch for landing bug-192409-20181205105808.patch text/plain 5168 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODg5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE4LTEyLTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSWdub3JlIGNhc2Ugd2hlbiBjb21wYXJpbmcgZGV2aWNl IHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTI0MDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NDkxNTU4PgorCisgICAgICAgIFJldmll d2VkIGJ5IEx1Y2FzIEZvcnNjaGxlci4KKworICAgICAgICBUaGlzIGFsbG93cyBEZXZpY2VUeXBl cyBjb25zdHJ1Y3RlZCB3aXRoIGxvd2VyY2FzZSBzdHJpbmdzIHRvIGNvcnJlY3RseSBjb21wYXJl CisgICAgICAgIGFnYWluc3QgRGV2aWNlVHlwZXMgY29taW5nIGZyb20gdGhlIHNpbXVsYXRvciBy dW50aW1lLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9kZXZpY2VfdHlwZS5w eToKKyAgICAgICAgKERldmljZVR5cGUuX19lcV9fKToKKyAgICAgICAgKERldmljZVR5cGUuX19j b250YWluc19fKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBl X3VuaXR0ZXN0LnB5OgorICAgICAgICAoRGV2aWNlVHlwZVRlc3QpOgorICAgICAgICAoRGV2aWNl VHlwZVRlc3QudGVzdF9jb21wYXJzaW9uX2xvd2VyX2Nhc2UpOgorCiAyMDE4LTEyLTA1ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFJlbW92ZSB0aGUgQXBwZW5kUGlwZWxpbmUgc3RhdGUgbWFjaGluZQpJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9kZXZpY2VfdHlwZS5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlLnB5CShyZXZpc2lvbiAyMzg4 OTUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTcsMTEgKzExNywxMSBAQCBjbGFzcyBEZXZpY2VUeXBlKG9iamVjdCk6 CiAgICAgIyBUaGlzIHRlY2huaXF1ZSBvZiBtYXRjaGluZyB0cmVhdHMgJ05vbmUnIGEgd2lsZC1j YXJkLgogICAgIGRlZiBfX2VxX18oc2VsZiwgb3RoZXIpOgogICAgICAgICBhc3NlcnQgaXNpbnN0 YW5jZShvdGhlciwgRGV2aWNlVHlwZSkKLSAgICAgICAgaWYgc2VsZi5oYXJkd2FyZV9mYW1pbHkg aXMgbm90IE5vbmUgYW5kIG90aGVyLmhhcmR3YXJlX2ZhbWlseSBpcyBub3QgTm9uZSBhbmQgc2Vs Zi5oYXJkd2FyZV9mYW1pbHkgIT0gb3RoZXIuaGFyZHdhcmVfZmFtaWx5OgorICAgICAgICBpZiBz ZWxmLmhhcmR3YXJlX2ZhbWlseSBpcyBub3QgTm9uZSBhbmQgb3RoZXIuaGFyZHdhcmVfZmFtaWx5 IGlzIG5vdCBOb25lIGFuZCBzZWxmLmhhcmR3YXJlX2ZhbWlseS5sb3dlcigpICE9IG90aGVyLmhh cmR3YXJlX2ZhbWlseS5sb3dlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAg IGlmIHNlbGYuaGFyZHdhcmVfdHlwZSBpcyBub3QgTm9uZSBhbmQgb3RoZXIuaGFyZHdhcmVfdHlw ZSBpcyBub3QgTm9uZSBhbmQgc2VsZi5oYXJkd2FyZV90eXBlICE9IG90aGVyLmhhcmR3YXJlX3R5 cGU6CisgICAgICAgIGlmIHNlbGYuaGFyZHdhcmVfdHlwZSBpcyBub3QgTm9uZSBhbmQgb3RoZXIu aGFyZHdhcmVfdHlwZSBpcyBub3QgTm9uZSBhbmQgc2VsZi5oYXJkd2FyZV90eXBlLmxvd2VyKCkg IT0gb3RoZXIuaGFyZHdhcmVfdHlwZS5sb3dlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNl Ci0gICAgICAgIGlmIHNlbGYuc29mdHdhcmVfdmFyaWFudCBpcyBub3QgTm9uZSBhbmQgb3RoZXIu c29mdHdhcmVfdmFyaWFudCBpcyBub3QgTm9uZSBhbmQgc2VsZi5zb2Z0d2FyZV92YXJpYW50ICE9 IG90aGVyLnNvZnR3YXJlX3ZhcmlhbnQ6CisgICAgICAgIGlmIHNlbGYuc29mdHdhcmVfdmFyaWFu dCBpcyBub3QgTm9uZSBhbmQgb3RoZXIuc29mdHdhcmVfdmFyaWFudCBpcyBub3QgTm9uZSBhbmQg c2VsZi5zb2Z0d2FyZV92YXJpYW50Lmxvd2VyKCkgIT0gb3RoZXIuc29mdHdhcmVfdmFyaWFudC5s b3dlcigpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIGlmIHNlbGYuc29mdHdh cmVfdmVyc2lvbiBpcyBub3QgTm9uZSBhbmQgb3RoZXIuc29mdHdhcmVfdmVyc2lvbiBpcyBub3Qg Tm9uZSBhbmQgc2VsZi5zb2Z0d2FyZV92ZXJzaW9uICE9IG90aGVyLnNvZnR3YXJlX3ZlcnNpb246 CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKQEAgLTEyOSwxMSArMTI5LDExIEBAIGNsYXNzIERl dmljZVR5cGUob2JqZWN0KToKIAogICAgIGRlZiBfX2NvbnRhaW5zX18oc2VsZiwgb3RoZXIpOgog ICAgICAgICBhc3NlcnQgaXNpbnN0YW5jZShvdGhlciwgRGV2aWNlVHlwZSkKLSAgICAgICAgaWYg c2VsZi5oYXJkd2FyZV9mYW1pbHkgaXMgbm90IE5vbmUgYW5kIHNlbGYuaGFyZHdhcmVfZmFtaWx5 ICE9IG90aGVyLmhhcmR3YXJlX2ZhbWlseToKKyAgICAgICAgaWYgc2VsZi5oYXJkd2FyZV9mYW1p bHkgaXMgbm90IE5vbmUgYW5kIChub3Qgb3RoZXIuaGFyZHdhcmVfZmFtaWx5IG9yIHNlbGYuaGFy ZHdhcmVfZmFtaWx5Lmxvd2VyKCkgIT0gb3RoZXIuaGFyZHdhcmVfZmFtaWx5Lmxvd2VyKCkpOgog ICAgICAgICAgICAgcmV0dXJuIEZhbHNlCi0gICAgICAgIGlmIHNlbGYuaGFyZHdhcmVfdHlwZSBp cyBub3QgTm9uZSBhbmQgc2VsZi5oYXJkd2FyZV90eXBlICE9IG90aGVyLmhhcmR3YXJlX3R5cGU6 CisgICAgICAgIGlmIHNlbGYuaGFyZHdhcmVfdHlwZSBpcyBub3QgTm9uZSBhbmQgKG5vdCBvdGhl ci5oYXJkd2FyZV90eXBlIG9yIHNlbGYuaGFyZHdhcmVfdHlwZS5sb3dlcigpICE9IG90aGVyLmhh cmR3YXJlX3R5cGUubG93ZXIoKSk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKLSAgICAgICAg aWYgc2VsZi5zb2Z0d2FyZV92YXJpYW50IGlzIG5vdCBOb25lIGFuZCBzZWxmLnNvZnR3YXJlX3Zh cmlhbnQgIT0gb3RoZXIuc29mdHdhcmVfdmFyaWFudDoKKyAgICAgICAgaWYgc2VsZi5zb2Z0d2Fy ZV92YXJpYW50IGlzIG5vdCBOb25lIGFuZCAobm90IG90aGVyLnNvZnR3YXJlX3ZhcmlhbnQgb3Ig c2VsZi5zb2Z0d2FyZV92YXJpYW50Lmxvd2VyKCkgIT0gb3RoZXIuc29mdHdhcmVfdmFyaWFudC5s b3dlcigpKToKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICBpZiBzZWxmLnNvZnR3 YXJlX3ZlcnNpb24gaXMgbm90IE5vbmUgYW5kIG90aGVyLnNvZnR3YXJlX3ZlcnNpb24gaXMgbm90 IE5vbmUgYW5kIG5vdCBvdGhlci5zb2Z0d2FyZV92ZXJzaW9uIGluIHNlbGYuc29mdHdhcmVfdmVy c2lvbjoKICAgICAgICAgICAgIHJldHVybiBGYWxzZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS94Y29kZS9kZXZpY2VfdHlwZV91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAy Mzg4OTUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlX3VuaXR0 ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsMyArMTQzLDE1IEBAIGNsYXNzIERldmljZVR5 cGVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShEZXZp Y2VUeXBlLmZyb21fc3RyaW5nKCdpUGhvbmUnKSBpbiBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdp UGhvbmUgNnMnKSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKERldmljZVR5cGUuZnJvbV9zdHJp bmcoJ2lQaG9uZScsIFZlcnNpb24oMTEsIDEpKSBpbiBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdp UGhvbmUnLCBWZXJzaW9uKDExKSkpCiAgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoRGV2aWNlVHlw ZS5mcm9tX3N0cmluZygnaVBob25lJywgVmVyc2lvbigxMSkpIGluIERldmljZVR5cGUuZnJvbV9z dHJpbmcoJ2lQaG9uZScsIFZlcnNpb24oMTEsIDEpKSkKKworICAgIGRlZiB0ZXN0X2NvbXBhcnNp b25fbG93ZXJfY2FzZShzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChEZXZpY2VUeXBl LmZyb21fc3RyaW5nKCdpcGhvbmUgWCcpLCBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpUGhvbmUn KSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpcGhv bmUnKSwgRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaVBob25lIFgnKSkKKyAgICAgICAgc2VsZi5h c3NlcnRFcXVhbChEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpUGhvbmUgWCcpLCBEZXZpY2VUeXBl LmZyb21fc3RyaW5nKCdpcGhvbmUnKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChEZXZpY2VU eXBlLmZyb21fc3RyaW5nKCdpUGhvbmUnKSwgRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaXBob25l IFgnKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdp cGhvbmUgWCcpLCBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpcGhvbmUnKSkKKyAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbChEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpcGhvbmUnKSwgRGV2aWNlVHlw ZS5mcm9tX3N0cmluZygnaXBob25lIFgnKSkKKworICAgICAgICBzZWxmLmFzc2VydFRydWUoRGV2 aWNlVHlwZS5mcm9tX3N0cmluZygnaXBob25lIDZzJykgaW4gRGV2aWNlVHlwZS5mcm9tX3N0cmlu ZygnaVBob25lJykpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShEZXZpY2VUeXBlLmZyb21fc3Ry aW5nKCdpUGhvbmUgNnMnKSBpbiBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdpcGhvbmUnKSkKKyAg ICAgICAgc2VsZi5hc3NlcnRUcnVlKERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZSA2cycp IGluIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZScpKQo= 356748 2018-12-06 13:35:46 -0800 2018-12-06 15:05:45 -0800 Patch for landing bug-192409-20181206133545.patch text/plain 1723 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODkzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSWdub3JlIGNhc2Ugd2hlbiBjb21wYXJpbmcgZGV2aWNl IHR5cGVzIChGb2xsb3ctdXAgZml4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkyNDA5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjQ5MTU1OD4K KworICAgICAgICBVbnJldmlld2VkIHR5cG8gZml4LgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS94Y29kZS9kZXZpY2VfdHlwZV91bml0dGVzdC5weToKKyAgICAgICAgKERldmljZVR5cGVU ZXN0LnRlc3RfY29tcGFyaXNvbl9sb3dlcl9jYXNlKToKKyAgICAgICAgKERldmljZVR5cGVUZXN0 LnRlc3RfY29tcGFyc2lvbl9sb3dlcl9jYXNlKTogRGVsZXRlZC4KKwogMjAxOC0xMi0wNiAgV2Vu c29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBXS1dl YlZpZXcgc2hvdWxkIG1hdGNoIFVJVGV4dFZpZXcgYmVoYXZpb3Igd2hlbiBlZGl0aW5nIHRleHQg d2l0aCBhbiBSVEwga2V5Ym9hcmQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUv ZGV2aWNlX3R5cGVfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS94Y29kZS9kZXZpY2VfdHlwZV91bml0dGVzdC5weQkocmV2aXNpb24gMjM4OTM5KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9kZXZpY2VfdHlwZV91bml0dGVzdC5weQkod29y a2luZyBjb3B5KQpAQCAtMTQ0LDcgKzE0NCw3IEBAIGNsYXNzIERldmljZVR5cGVUZXN0KHVuaXR0 ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKERldmljZVR5cGUuZnJvbV9z dHJpbmcoJ2lQaG9uZScsIFZlcnNpb24oMTEsIDEpKSBpbiBEZXZpY2VUeXBlLmZyb21fc3RyaW5n KCdpUGhvbmUnLCBWZXJzaW9uKDExKSkpCiAgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoRGV2aWNl VHlwZS5mcm9tX3N0cmluZygnaVBob25lJywgVmVyc2lvbigxMSkpIGluIERldmljZVR5cGUuZnJv bV9zdHJpbmcoJ2lQaG9uZScsIFZlcnNpb24oMTEsIDEpKSkKIAotICAgIGRlZiB0ZXN0X2NvbXBh cnNpb25fbG93ZXJfY2FzZShzZWxmKToKKyAgICBkZWYgdGVzdF9jb21wYXJpc29uX2xvd2VyX2Nh c2Uoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoRGV2aWNlVHlwZS5mcm9tX3N0cmlu ZygnaXBob25lIFgnKSwgRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaVBob25lJykpCiAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwoRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaXBob25lJyksIERldmlj ZVR5cGUuZnJvbV9zdHJpbmcoJ2lQaG9uZSBYJykpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo RGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaVBob25lIFgnKSwgRGV2aWNlVHlwZS5mcm9tX3N0cmlu ZygnaXBob25lJykpCg==