192386 2018-12-04 15:06:08 -0800 DFG's StrengthReduction phase should not reduce Construct into DirectContruct when the executable does not have constructAbility. 2018-12-04 19:24:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1485033 0 mark.lam 2018-12-04 15:06:08 -0800 This violates an invariant documented by a RELEASE_ASSERT in operationLinkDirectCall(). <rdar://problem/46445516> 1485038 1 356544 mark.lam 2018-12-04 15:16:42 -0800 Created attachment 356544 proposed patch. 1485113 2 356544 mark.lam 2018-12-04 18:57:32 -0800 Comment on attachment 356544 proposed patch. Thanks for the review. Landing now. 1485117 3 356544 commit-queue 2018-12-04 19:24:01 -0800 Comment on attachment 356544 proposed patch. Clearing flags on attachment: 356544 Committed r238884: <https://trac.webkit.org/changeset/238884> 1485118 4 commit-queue 2018-12-04 19:24:03 -0800 All reviewed patches have been landed. Closing bug. 356544 2018-12-04 15:16:42 -0800 2018-12-04 19:24:01 -0800 proposed patch. bug-192386.patch text/plain 2742 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzg4NzcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTEyLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBERkcncyBTdHJlbmd0aFJlZHVjdGlvbiBwaGFzZSBzaG91bGQgbm90IHJl ZHVjZSBDb25zdHJ1Y3QgaW50byBEaXJlY3RDb250cnVjdCB3aGVuIHRoZSBleGVjdXRhYmxlIGRv ZXMgbm90IGhhdmUgY29uc3RydWN0QWJpbGl0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjM4NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY0 NDU1MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBzdHJlc3MvcmVncmVzcy0xOTIzODYuanM6IEFkZGVkLgorCiAyMDE4LTEyLTA0ICBDYWlvIExp bWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIFN1 cHBvcnQgbG9naWMgb3BlcmF0aW9ucwpJbmRleDogSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xOTIz ODYuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xOTIzODYuanMJKG5v bmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xOTIzODYuanMJKHdvcmtpbmcg Y29weSkKQEAgLTAsMCArMSwxMiBAQAorLy9AIHJlcXVpcmVPcHRpb25zKCItLWppdFBvbGljeVNj YWxlPTAiKQorCitmdW5jdGlvbiBmb28oeCkgeworICAgIHRyeSB7CisgICAgICAgIG5ldyB4KCk7 CisgICAgfSBjYXRjaCB7CisgICAgfQorfQorCitmb28oZnVuY3Rpb24oKSB7fSk7Citmb3IgKGxl dCBpID0gMDsgaSA8IDEwMDAwOyArK2kpCisgICAgZm9vKCgpID0+IHVuZGVmaW5lZCk7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODg3NikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAx OC0xMi0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgREZHJ3Mg U3RyZW5ndGhSZWR1Y3Rpb24gcGhhc2Ugc2hvdWxkIG5vdCByZWR1Y2UgQ29uc3RydWN0IGludG8g RGlyZWN0Q29udHJ1Y3Qgd2hlbiB0aGUgZXhlY3V0YWJsZSBkb2VzIG5vdCBoYXZlIGNvbnN0cnVj dEFiaWxpdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTIzODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NDQ1NTE2PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdmlvbGF0ZXMgYW4gaW52 YXJpYW50IGRvY3VtZW50ZWQgYnkgYSBSRUxFQVNFX0FTU0VSVCBpbiBvcGVyYXRpb25MaW5rRGly ZWN0Q2FsbCgpLgorCisgICAgICAgICogZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OlN0cmVuZ3RoUmVkdWN0aW9uUGhhc2U6OmhhbmRsZU5vZGUp OgorCiAyMDE4LTEyLTA0ICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAg ICAgICBbRVNOZXh0XVtCaWdJbnRdIFN1cHBvcnQgbG9naWMgb3BlcmF0aW9ucwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9u UGhhc2UuY3BwCShyZXZpc2lvbiAyMzg4NzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MTQsNiAr OTE0LDkgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIAog ICAgICAgICAgICAgaWYgKEZ1bmN0aW9uRXhlY3V0YWJsZSogZnVuY3Rpb25FeGVjdXRhYmxlID0g anNEeW5hbWljQ2FzdDxGdW5jdGlvbkV4ZWN1dGFibGUqPih2bSgpLCBleGVjdXRhYmxlKSkgewor ICAgICAgICAgICAgICAgIGlmIChtX25vZGUtPm9wKCkgPT0gQ29uc3RydWN0ICYmIGZ1bmN0aW9u RXhlY3V0YWJsZS0+Y29uc3RydWN0QWJpbGl0eSgpID09IENvbnN0cnVjdEFiaWxpdHk6OkNhbm5v dENvbnN0cnVjdCkKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisKICAgICAgICAgICAgICAg ICAvLyBXZSBuZWVkIHRvIHVwZGF0ZSBtX3BhcmFtZXRlclNsb3RzIGJlZm9yZSB3ZSBnZXQgdG8g dGhlIGJhY2tlbmQsIGJ1dCB3ZSBkb24ndAogICAgICAgICAgICAgICAgIC8vIHdhbnQgdG8gZG8g dG9vIG11Y2ggb2YgdGhpcy4KICAgICAgICAgICAgICAgICB1bnNpZ25lZCBudW1BbGxvY2F0ZWRB cmdzID0K