192354 2018-12-03 22:13:10 -0800 Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node 2018-12-04 12:07:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192119 InRadar P2 Normal --- 192059 1 hi mattbaker commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1484731 0 hi 2018-12-03 22:13:10 -0800 * STEPS TO REPRODUCE: 1. open WebInspector 2. show the Elements tab 3. click on a node in the DOM tree 4. move to the next/previous element using the down/up arrow keys => the newly selected node should be highlighted 1484751 1 webkit-bug-importer 2018-12-03 23:16:49 -0800 <rdar://problem/46444438> 1484753 2 356474 mattbaker 2018-12-03 23:30:22 -0800 Created attachment 356474 Patch 1484918 3 356474 joepeck 2018-12-04 11:18:03 -0800 Comment on attachment 356474 Patch r=me 1484951 4 356474 commit-queue 2018-12-04 12:07:17 -0800 Comment on attachment 356474 Patch Clearing flags on attachment: 356474 Committed r238871: <https://trac.webkit.org/changeset/238871> 1484952 5 commit-queue 2018-12-04 12:07:18 -0800 All reviewed patches have been landed. Closing bug. 356474 2018-12-03 23:30:22 -0800 2018-12-04 12:07:17 -0800 Patch bug-192354-20181203233015.patch text/plain 2023 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj YzhlYjkxOGFiMWM1ZTg1YTc1OWQ1MjViZmIwYjE1NWI5OTU0OWVkLi41NTBiYTY0YThjM2ZlNDc1 OGI4YjE2NWVjZmE0NWFmMjRjYzRkMmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0xMi0wMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjM4NjAyKTogRWxlbWVudHM6 IGNoYW5naW5nIHNlbGVjdGlvbiBubyBsb25nZXIgaGlnaGxpZ2h0cyB0aGUgc2VsZWN0ZWQgbm9k ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMzU0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjQ0NDQzOD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91 dGxpbmUuanM6CisgICAgICAgIChXSS5UcmVlT3V0bGluZS5wcm90b3R5cGUuX3RyZWVLZXlEb3du KToKKyAgICAgICAgKFdJLlRyZWVPdXRsaW5lLnByb3RvdHlwZS5faGFuZGxlTW91c2VEb3duKToK KwogMjAxOC0xMi0wMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHM6ICQwIGlzIHNob3duIGZvciBhbGwgc2VsZWN0ZWQg ZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVHJlZU91dGxpbmUuanMKaW5kZXggOTZmNDk1NzE3ZmQzNDBmZmI0ODc3OTg3NTBj YWY2YjE5MGVmMzI2ZC4uYzJjOTdhNTQxNzI1ODlkNzhkNWQxOTBjYjg3MGYyNDMxNmIzOGMyNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJl ZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVHJlZU91dGxpbmUuanMKQEAgLTYwOCw4ICs2MDgsMTEgQEAgV0kuVHJlZU91dGxpbmUgPSBj bGFzcyBUcmVlT3V0bGluZSBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgICAgIGhhbmRs ZWQgPSB0aGlzLnRyZWVPdXRsaW5lLm9uc3BhY2UodGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50KTsK ICAgICAgICAgfQogCi0gICAgICAgIGlmICghaGFuZGxlZCkKKyAgICAgICAgaWYgKCFoYW5kbGVk KSB7CisgICAgICAgICAgICB0aGlzLl9pdGVtV2FzU2VsZWN0ZWRCeVVzZXIgPSB0cnVlOwogICAg ICAgICAgICAgaGFuZGxlZCA9IHRoaXMuX3NlbGVjdGlvbkNvbnRyb2xsZXIuaGFuZGxlS2V5RG93 bihldmVudCk7CisgICAgICAgICAgICB0aGlzLl9pdGVtV2FzU2VsZWN0ZWRCeVVzZXIgPSBmYWxz ZTsKKyAgICAgICAgfQogCiAgICAgICAgIGlmIChuZXh0U2VsZWN0ZWRFbGVtZW50KSB7CiAgICAg ICAgICAgICBuZXh0U2VsZWN0ZWRFbGVtZW50LnJldmVhbCgpOwpAQCAtOTk5LDcgKzEwMDIsOSBA QCBXSS5UcmVlT3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAg ICAgICAgIGlmIChpc05hTihpbmRleCkpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAg dGhpcy5faXRlbVdhc1NlbGVjdGVkQnlVc2VyID0gdHJ1ZTsKICAgICAgICAgdGhpcy5fc2VsZWN0 aW9uQ29udHJvbGxlci5oYW5kbGVJdGVtTW91c2VEb3duKGluZGV4LCBldmVudCk7CisgICAgICAg IHRoaXMuX2l0ZW1XYXNTZWxlY3RlZEJ5VXNlciA9IGZhbHNlOwogICAgIH0KIAogICAgIF9pbmRl eE9mVHJlZUVsZW1lbnQodHJlZUVsZW1lbnQpCg==