192263 2018-11-30 15:57:19 -0800 Add generic implementations to FileSystemPOSIX.cpp 2018-12-01 11:35:37 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen commit-queue don.olmstead fujii mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1483801 0 chris.reid 2018-11-30 15:57:19 -0800 Add generic POSIX implementations for stringFromFileSystemRepresentation, fileSystemRepresentation, moveFile, and getVolumeFreeSpace. 1483833 1 356260 chris.reid 2018-11-30 16:32:18 -0800 Created attachment 356260 Patch 1483854 2 chris.reid 2018-11-30 17:04:47 -0800 I was wondering if any of these should replace cocoa's implementations. stringFromFileSystemRepresentation is based off of CF's functionality on osx, Glib percent encodes most non-alphanumeric characters. There are however a couple of cases where CF's stringFromFileSystemRepresentation and String::fromUTF8 don't match with certain invalid utf-8 sequences. 1483863 3 356267 chris.reid 2018-11-30 17:20:04 -0800 Created attachment 356267 Patch 1483971 4 356267 ysuzuki 2018-12-01 04:32:06 -0800 Comment on attachment 356267 Patch r=me 1484013 5 356267 commit-queue 2018-12-01 11:34:51 -0800 Comment on attachment 356267 Patch Clearing flags on attachment: 356267 Committed r238782: <https://trac.webkit.org/changeset/238782> 1484014 6 commit-queue 2018-12-01 11:34:53 -0800 All reviewed patches have been landed. Closing bug. 1484016 7 webkit-bug-importer 2018-12-01 11:35:37 -0800 <rdar://problem/46397333> 356260 2018-11-30 16:32:18 -0800 2018-11-30 17:20:04 -0800 Patch 192263.diff text/plain 2622 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYWVkODc3NzFjMi4uMTA3OGNjZjExZjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMS0zMCAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgQWRkIGdlbmVyaWMgaW1wbGVtZW50YXRpb25zIHRvIEZpbGVTeXN0 ZW1QT1NJWC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MjI2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgIEFkZCBn ZW5lcmljIEZpbGVTeXN0ZW1QT1NJWCBpbXBsZW1lbnRhdGlvbnMgZm9yOgorICAgICAgICAgICAg LSBzdHJpbmdGcm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uCisgICAgICAgICAgICAtIGZpbGVT eXN0ZW1SZXByZXNlbnRhdGlvbgorICAgICAgICAgICAgLSBtb3ZlRmlsZQorICAgICAgICAgICAg LSBnZXRWb2x1bWVGcmVlU3BhY2UKKworICAgICAgICBBbHNvIHJlbW92aW5nIGFuIHVubmVlZGVk IFBMQVRGT1JNKEdUSykgY2hlY2sgc2luY2UgR1RLIGlzIG9ubHkgdXNpbmcgRmlsZVN5c3RlbUds aWIKKworICAgICAgICAqIHBsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHA6CisKIDIw MTgtMTEtMTkgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMjM4MzUwKSBbY3VybF0gQ2VydGlmaWNhdGVJbmZvLmg6IGVycm9y OiB0ZW1wbGF0ZSBzcGVjaWFsaXphdGlvbiByZXF1aXJlcyAndGVtcGxhdGU8PicKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCmluZGV4IDZi NzMyMDY5NjEyLi4xZWVhZmQ0MDcyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSA8 bGliZ2VuLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDxzeXMvc3RhdC5oPgorI2lu Y2x1ZGUgPHN5cy9zdGF0dmZzLmg+CiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVkZSA8 dW5pc3RkLmg+CiAjaW5jbHVkZSA8d3RmL0VudW1UcmFpdHMuaD4KQEAgLTM4MSw3ICszODIsNDUg QEAgVmVjdG9yPFN0cmluZz4gbGlzdERpcmVjdG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIGNvbnN0 IFN0cmluZyYgZmlsdGVyKQogICAgIHJldHVybiBlbnRyaWVzOwogfQogCi0jaWYgIU9TKERBUldJ TikgfHwgUExBVEZPUk0oR1RLKQorI2lmICFQTEFURk9STShDT0NPQSkKK1N0cmluZyBzdHJpbmdG cm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGNvbnN0IGNoYXIqIHBhdGgpCit7CisgICAgaWYg KCFwYXRoKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisKKyAgICByZXR1cm4gU3RyaW5nOjpm cm9tVVRGOChwYXRoKTsKK30KKworQ1N0cmluZyBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29u c3QgU3RyaW5nJiBwYXRoKQoreworICAgIHJldHVybiBwYXRoLnV0ZjgoKTsKK30KKworYm9vbCBt b3ZlRmlsZShjb25zdCBTdHJpbmcmIG9sZFBhdGgsIGNvbnN0IFN0cmluZyYgbmV3UGF0aCkKK3sK KyAgICBhdXRvIG9sZEZpbGVuYW1lID0gZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKG9sZFBhdGgp OworICAgIGlmICghb2xkRmlsZW5hbWUuaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIGF1dG8gbmV3RmlsZW5hbWUgPSBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24obmV3UGF0 aCk7CisgICAgaWYgKCFuZXdGaWxlbmFtZS5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgcmV0dXJuIHJlbmFtZShvbGRGaWxlbmFtZS5kYXRhKCksIG5ld0ZpbGVuYW1lLmRh dGEoKSkgIT0gLTE7Cit9CisKK2Jvb2wgZ2V0Vm9sdW1lRnJlZVNwYWNlKGNvbnN0IFN0cmluZyYg cGF0aCwgdWludDY0X3QmIGZyZWVTcGFjZSkKK3sKKyAgICBzdHJ1Y3Qgc3RhdHZmcyBmaWxlU3lz dGVtU3RhdDsKKyAgICBpZiAoc3RhdHZmcyhmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGF0aCku ZGF0YSgpLCAmZmlsZVN5c3RlbVN0YXQpKSB7CisgICAgICAgIGZyZWVTcGFjZSA9IGZpbGVTeXN0 ZW1TdGF0LmZfYmF2YWlsICogZmlsZVN5c3RlbVN0YXQuZl9mcnNpemU7CisgICAgICAgIHJldHVy biB0cnVlOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7Cit9CisjZW5kaWYKKworI2lmICFPUyhE QVJXSU4pCiBTdHJpbmcgb3BlblRlbXBvcmFyeUZpbGUoY29uc3QgU3RyaW5nJiBwcmVmaXgsIFBs YXRmb3JtRmlsZUhhbmRsZSYgaGFuZGxlKQogewogICAgIGNoYXIgYnVmZmVyW1BBVEhfTUFYXTsK 356267 2018-11-30 17:20:04 -0800 2018-12-01 11:34:51 -0800 Patch 192263-2.diff text/plain 2620 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYWVkODc3NzFjMi4uMTA3OGNjZjExZjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMS0zMCAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgQWRkIGdlbmVyaWMgaW1wbGVtZW50YXRpb25zIHRvIEZpbGVTeXN0 ZW1QT1NJWC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MjI2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgIEFkZCBn ZW5lcmljIEZpbGVTeXN0ZW1QT1NJWCBpbXBsZW1lbnRhdGlvbnMgZm9yOgorICAgICAgICAgICAg LSBzdHJpbmdGcm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uCisgICAgICAgICAgICAtIGZpbGVT eXN0ZW1SZXByZXNlbnRhdGlvbgorICAgICAgICAgICAgLSBtb3ZlRmlsZQorICAgICAgICAgICAg LSBnZXRWb2x1bWVGcmVlU3BhY2UKKworICAgICAgICBBbHNvIHJlbW92aW5nIGFuIHVubmVlZGVk IFBMQVRGT1JNKEdUSykgY2hlY2sgc2luY2UgR1RLIGlzIG9ubHkgdXNpbmcgRmlsZVN5c3RlbUds aWIKKworICAgICAgICAqIHBsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHA6CisKIDIw MTgtMTEtMTkgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMjM4MzUwKSBbY3VybF0gQ2VydGlmaWNhdGVJbmZvLmg6IGVycm9y OiB0ZW1wbGF0ZSBzcGVjaWFsaXphdGlvbiByZXF1aXJlcyAndGVtcGxhdGU8PicKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCmluZGV4IDZi NzMyMDY5NjEyLi4xZTY4MjMxNzFkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSA8 bGliZ2VuLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDxzeXMvc3RhdC5oPgorI2lu Y2x1ZGUgPHN5cy9zdGF0dmZzLmg+CiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVkZSA8 dW5pc3RkLmg+CiAjaW5jbHVkZSA8d3RmL0VudW1UcmFpdHMuaD4KQEAgLTM4MSw3ICszODIsNDUg QEAgVmVjdG9yPFN0cmluZz4gbGlzdERpcmVjdG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIGNvbnN0 IFN0cmluZyYgZmlsdGVyKQogICAgIHJldHVybiBlbnRyaWVzOwogfQogCi0jaWYgIU9TKERBUldJ TikgfHwgUExBVEZPUk0oR1RLKQorI2lmICFQTEFURk9STShDT0NPQSkKK1N0cmluZyBzdHJpbmdG cm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGNvbnN0IGNoYXIqIHBhdGgpCit7CisgICAgaWYg KCFwYXRoKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisKKyAgICByZXR1cm4gU3RyaW5nOjpm cm9tVVRGOChwYXRoKTsKK30KKworQ1N0cmluZyBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29u c3QgU3RyaW5nJiBwYXRoKQoreworICAgIHJldHVybiBwYXRoLnV0ZjgoKTsKK30KKworYm9vbCBt b3ZlRmlsZShjb25zdCBTdHJpbmcmIG9sZFBhdGgsIGNvbnN0IFN0cmluZyYgbmV3UGF0aCkKK3sK KyAgICBhdXRvIG9sZEZpbGVuYW1lID0gZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKG9sZFBhdGgp OworICAgIGlmIChvbGRGaWxlbmFtZS5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor CisgICAgYXV0byBuZXdGaWxlbmFtZSA9IGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihuZXdQYXRo KTsKKyAgICBpZiAobmV3RmlsZW5hbWUuaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIHJldHVybiByZW5hbWUob2xkRmlsZW5hbWUuZGF0YSgpLCBuZXdGaWxlbmFtZS5kYXRh KCkpICE9IC0xOworfQorCitib29sIGdldFZvbHVtZUZyZWVTcGFjZShjb25zdCBTdHJpbmcmIHBh dGgsIHVpbnQ2NF90JiBmcmVlU3BhY2UpCit7CisgICAgc3RydWN0IHN0YXR2ZnMgZmlsZVN5c3Rl bVN0YXQ7CisgICAgaWYgKHN0YXR2ZnMoZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKHBhdGgpLmRh dGEoKSwgJmZpbGVTeXN0ZW1TdGF0KSkgeworICAgICAgICBmcmVlU3BhY2UgPSBmaWxlU3lzdGVt U3RhdC5mX2JhdmFpbCAqIGZpbGVTeXN0ZW1TdGF0LmZfZnJzaXplOworICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorI2VuZGlmCisKKyNpZiAhT1MoREFS V0lOKQogU3RyaW5nIG9wZW5UZW1wb3JhcnlGaWxlKGNvbnN0IFN0cmluZyYgcHJlZml4LCBQbGF0 Zm9ybUZpbGVIYW5kbGUmIGhhbmRsZSkKIHsKICAgICBjaGFyIGJ1ZmZlcltQQVRIX01BWF07Cg==