192211 2018-11-29 19:43:54 -0800 Web Inspector: Audit: enabling/disabling an audit should put it's container group into an intermediate state 2019-01-10 21:57:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 190754 192210 1 hi hi hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1483365 0 hi 2018-11-29 19:43:54 -0800 This specifically refers to the <input type="checkbox"> used for enabling/disabling the audit when editing. - disabling a group should also disable all of its descendants - enabling a group should also enable all of its descendants - enabling/disabling a descendant should put the group (recursively up the chain) into an indeterminate [-] state if there are other children that are disabled/enabled 1484401 1 webkit-bug-importer 2018-12-03 10:42:37 -0800 <rdar://problem/46423621> 1484547 2 356412 hi 2018-12-03 15:03:46 -0800 Created attachment 356412 Patch 1493599 3 hi 2019-01-10 20:55:53 -0800 Merged into <https://webkit.org/b/192210>. 356412 2018-12-03 15:03:46 -0800 2019-01-10 20:55:59 -0800 Patch 192211.diff text/plain 4545 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFmNmNlNmRmN2NkLi5mOTYzNTg3Y2YwMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMTItMDMgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1 ZGl0OiBlbmFibGluZy9kaXNhYmxpbmcgYW4gYXVkaXQgc2hvdWxkIHB1dCBpdCdzIGNvbnRhaW5l ciBncm91cCBpbnRvIGFuIGludGVybWVkaWF0ZSBzdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMjExCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NjQyMzYyMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0F1ZGl0VGVzdEdyb3VwLmpzOgorICAgICAgICAo V0kuQXVkaXRUZXN0R3JvdXAucHJvdG90eXBlLmdldCBkaXNhYmxlZCk6IEFkZGVkLgorICAgICAg ICAoV0kuQXVkaXRUZXN0R3JvdXAucHJvdG90eXBlLnNldCBkaXNhYmxlZCk6IEFkZGVkLgorICAg ICAgICAoV0kuQXVkaXRUZXN0R3JvdXAucHJvdG90eXBlLl9oYW5kbGVUZXN0RGlzYWJsZWRDaGFu Z2VkKToKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUcmVlRWxlbWVudC5q czoKKyAgICAgICAgKFdJLkF1ZGl0VHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVUZXN0R3Jv dXBEaXNhYmxlZCk6IEFkZGVkLgorICAgICAgICAoV0kuQXVkaXRUcmVlRWxlbWVudC5wcm90b3R5 cGUuX2hhbmRsZVRlc3REaXNhYmxlZENoYW5nZWQpOgorICAgICAgICAoV0kuQXVkaXRUcmVlRWxl bWVudC5wcm90b3R5cGUuX2hhbmRsZU1hbmFnZXJFZGl0aW5nQ2hhbmdlZCk6CisKIDIwMTgtMTEt MjkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEF1ZGl0OiBhbGxvdyBhdWRpdHMgdG8gYmUgZW5hYmxlZC9kaXNhYmxlZApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0F1ZGl0VGVz dEdyb3VwLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0F1 ZGl0VGVzdEdyb3VwLmpzCmluZGV4IGYwMWVkNTdkZDA4Li5kNTViNTRjMTE1MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0F1ZGl0VGVzdEdy b3VwLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9B dWRpdFRlc3RHcm91cC5qcwpAQCAtODYsNiArODYsMjEgQEAgV0kuQXVkaXRUZXN0R3JvdXAgPSBj bGFzcyBBdWRpdFRlc3RHcm91cCBleHRlbmRzIFdJLkF1ZGl0VGVzdEJhc2UKIAogICAgIGdldCB0 ZXN0cygpIHsgcmV0dXJuIHRoaXMuX3Rlc3RzOyB9CiAKKyAgICBnZXQgZGlzYWJsZWQoKQorICAg IHsKKyAgICAgICAgcmV0dXJuIHN1cGVyLmRpc2FibGVkOworICAgIH0KKworICAgIHNldCBkaXNh YmxlZChkaXNhYmxlZCkKKyAgICB7CisgICAgICAgIGlmICghdGhpcy5fcHJldmVudERpc2FibGVk UHJvcGFnYXRpb24pIHsKKyAgICAgICAgICAgIGZvciAobGV0IHRlc3Qgb2YgdGhpcy5fdGVzdHMp CisgICAgICAgICAgICAgICAgdGVzdC5kaXNhYmxlZCA9IGRpc2FibGVkOworICAgICAgICB9CisK KyAgICAgICAgc3VwZXIuZGlzYWJsZWQgPSBkaXNhYmxlZDsKKyAgICB9CisKICAgICBzdG9wKCkK ICAgICB7CiAgICAgICAgIC8vIENhbGxlZCBmcm9tIFdJLkF1ZGl0TWFuYWdlci4KQEAgLTE2NSw4 ICsxODAsMTQgQEAgV0kuQXVkaXRUZXN0R3JvdXAgPSBjbGFzcyBBdWRpdFRlc3RHcm91cCBleHRl bmRzIFdJLkF1ZGl0VGVzdEJhc2UKICAgICAgICAgbGV0IGVuYWJsZWRUZXN0Q291bnQgPSB0aGlz Ll90ZXN0cy5maWx0ZXIoKHRlc3QpID0+ICF0ZXN0LmRpc2FibGVkKS5sZW5ndGg7CiAgICAgICAg IGlmIChldmVudC50YXJnZXQuZGlzYWJsZWQgJiYgIWVuYWJsZWRUZXN0Q291bnQpCiAgICAgICAg ICAgICB0aGlzLmRpc2FibGVkID0gdHJ1ZTsKLSAgICAgICAgZWxzZSBpZiAoIWV2ZW50LnRhcmdl dC5kaXNhYmxlZCAmJiBlbmFibGVkVGVzdENvdW50ID09PSAxKQorICAgICAgICBlbHNlIGlmICgh ZXZlbnQudGFyZ2V0LmRpc2FibGVkICYmIGVuYWJsZWRUZXN0Q291bnQgPT09IDEpIHsKKyAgICAg ICAgICAgIHRoaXMuX3ByZXZlbnREaXNhYmxlZFByb3BhZ2F0aW9uID0gdHJ1ZTsKICAgICAgICAg ICAgIHRoaXMuZGlzYWJsZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIHRoaXMuX3ByZXZlbnREaXNh YmxlZFByb3BhZ2F0aW9uID0gZmFsc2U7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAv LyBEb24ndCBjaGFuZ2UgYGRpc2FibGVkYCwgYXMgd2UncmUgY3VycmVudGx5IGluIGFuICJpbmRl dGVybWluYXRlIiBzdGF0ZS4KKyAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVu ZXJzKFdJLkF1ZGl0VGVzdEJhc2UuRXZlbnQuRGlzYWJsZWRDaGFuZ2VkKTsKKyAgICAgICAgfQog ICAgIH0KIAogICAgIF9oYW5kbGVUZXN0UHJvZ3Jlc3MoZXZlbnQpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUcmVlRWxl bWVudC5qcwppbmRleCBmYWU1NWEyM2ExNi4uZjg0ZDRkZmJiZDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VHJlZUVsZW1lbnQuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUcmVl RWxlbWVudC5qcwpAQCAtMjE1LDYgKzIxNSwxNCBAQCBXSS5BdWRpdFRyZWVFbGVtZW50ID0gY2xh c3MgQXVkaXRUcmVlRWxlbWVudCBleHRlbmRzIFdJLkdlbmVyYWxUcmVlRWxlbWVudAogICAgICAg ICB0aGlzLnN0YXR1cy52YWx1ZSA9IHByb2dyZXNzIHx8IDA7CiAgICAgfQogCisgICAgX3VwZGF0 ZVRlc3RHcm91cERpc2FibGVkKCkKKyAgICB7CisgICAgICAgIHRoaXMuc3RhdHVzLmNoZWNrZWQg PSAhdGhpcy5yZXByZXNlbnRlZE9iamVjdC5kaXNhYmxlZDsKKworICAgICAgICBpZiAodGhpcy5y ZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdJLkF1ZGl0VGVzdEdyb3VwKQorICAgICAgICAg ICAgdGhpcy5zdGF0dXMuaW5kZXRlcm1pbmF0ZSA9IHRoaXMucmVwcmVzZW50ZWRPYmplY3QudGVz dHMuc29tZSgodGVzdCkgPT4gdGVzdC5kaXNhYmxlZCAhPT0gdGhpcy5yZXByZXNlbnRlZE9iamVj dC50ZXN0c1swXS5kaXNhYmxlZCk7CisgICAgfQorCiAgICAgX2hhbmRsZVRlc3RDYXNlQ29tcGxl dGVkKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5yZW1vdmVF dmVudExpc3RlbmVyKFdJLkF1ZGl0VGVzdEJhc2UuRXZlbnQuQ29tcGxldGVkLCB0aGlzLl9oYW5k bGVUZXN0Q2FzZUNvbXBsZXRlZCwgdGhpcyk7CkBAIC0yMjUsNyArMjMzLDcgQEAgV0kuQXVkaXRU cmVlRWxlbWVudCA9IGNsYXNzIEF1ZGl0VHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5HZW5lcmFsVHJl ZUVsZW1lbnQKICAgICBfaGFuZGxlVGVzdERpc2FibGVkQ2hhbmdlZChldmVudCkKICAgICB7CiAg ICAgICAgIGlmICh0aGlzLnN0YXR1cyBpbnN0YW5jZW9mIEhUTUxJbnB1dEVsZW1lbnQgJiYgdGhp cy5zdGF0dXMudHlwZSA9PT0gImNoZWNrYm94IikKLSAgICAgICAgICAgIHRoaXMuc3RhdHVzLmNo ZWNrZWQgPSAhdGhpcy5yZXByZXNlbnRlZE9iamVjdC5kaXNhYmxlZDsKKyAgICAgICAgICAgIHRo aXMuX3VwZGF0ZVRlc3RHcm91cERpc2FibGVkKCk7CiAgICAgfQogCiAgICAgX2hhbmRsZVRlc3RS ZXN1bHRDbGVhcmVkKGV2ZW50KQpAQCAtMjY5LDcgKzI3Nyw3IEBAIFdJLkF1ZGl0VHJlZUVsZW1l bnQgPSBjbGFzcyBBdWRpdFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuR2VuZXJhbFRyZWVFbGVtZW50 CiAKICAgICAgICAgICAgIHRoaXMuc3RhdHVzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaW5w dXQiKTsKICAgICAgICAgICAgIHRoaXMuc3RhdHVzLnR5cGUgPSAiY2hlY2tib3giOwotICAgICAg ICAgICAgdGhpcy5zdGF0dXMuY2hlY2tlZCA9ICF0aGlzLnJlcHJlc2VudGVkT2JqZWN0LmRpc2Fi bGVkOworICAgICAgICAgICAgdGhpcy5fdXBkYXRlVGVzdEdyb3VwRGlzYWJsZWQoKTsKICAgICAg ICAgICAgIHRoaXMuc3RhdHVzLmFkZEV2ZW50TGlzdGVuZXIoImNoYW5nZSIsICgpID0+IHsKICAg ICAgICAgICAgICAgICB0aGlzLnJlcHJlc2VudGVkT2JqZWN0LmRpc2FibGVkID0gIXRoaXMucmVw cmVzZW50ZWRPYmplY3QuZGlzYWJsZWQ7CiAgICAgICAgICAgICB9KTsK