192201 2018-11-29 16:50:52 -0800 Overflow scrolling layers need to be self-painting 2018-11-30 16:41:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser ajuma dino fred.wang simon.fraser thorton tsavell webkit-bug-importer oldest_to_newest 1483294 0 simon.fraser 2018-11-29 16:50:52 -0800 Overflow scrolling layers need to be self-painting 1483295 1 356092 simon.fraser 2018-11-29 16:52:24 -0800 Created attachment 356092 Patch 1483296 2 webkit-bug-importer 2018-11-29 16:53:22 -0800 <rdar://problem/46359460> 1483297 3 simon.fraser 2018-11-29 16:54:34 -0800 Depends on a previous patch. 1483367 4 simon.fraser 2018-11-29 19:48:34 -0800 https://trac.webkit.org/changeset/238725/webkit 1483514 5 ajuma 2018-11-30 07:12:09 -0800 (In reply to Simon Fraser (smfr) from comment #0) > Overflow scrolling layers need to be self-painting Won't this change paint order for those overflow scrollers that didn't get self-painting layers before? (Since instead of being painted when other in-flow elements are painted they'll now get painted with other self-painting layers.) 1483544 6 tsavell 2018-11-30 09:08:32 -0800 The new test added in https://trac.webkit.org/changeset/238725/webkit compositing/scrolling/overflow-scrolling-layers-are-self-painting.html is failing Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/compositing/scrolling/overflow-scrolling-layers-are-self-painting-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/compositing/scrolling/overflow-scrolling-layers-are-self-painting-actual.txt @@ -14,11 +14,11 @@ (GraphicsLayer (offsetFromRenderer width=-1 height=-1) (position 1.00 1.00) - (bounds 285.00 285.00) + (bounds 300.00 300.00) (children 1 (GraphicsLayer (offsetFromRenderer width=1 height=1) - (bounds 285.00 2000.00) + (bounds 300.00 2000.00) ) ) ) History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fscrolling%2Foverflow-scrolling-layers-are-self-painting.html 1483577 7 simon.fraser 2018-11-30 10:16:25 -0800 Test needs iOS results (though I could have sworn I ran the test for iOS before landing). (In reply to Ali Juma from comment #5) > (In reply to Simon Fraser (smfr) from comment #0) > > Overflow scrolling layers need to be self-painting > > Won't this change paint order for those overflow scrollers that didn't get > self-painting layers before? (Since instead of being painted when other > in-flow elements are painted they'll now get painted with other > self-painting layers.) Yes, but I'm not sure we have a choice. We do the same for things like video and canvas, and it hasn't been a problem. 1483839 8 tsavell 2018-11-30 16:41:35 -0800 added iOS specific expectations in https://trac.webkit.org/changeset/238765/webkit 356092 2018-11-29 16:52:24 -0800 2018-11-29 16:57:18 -0800 Patch bug-192201-20181129165223.patch text/plain 4747 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM1MjkzYzE1NzVmYTBl NTUzNGIwM2M0YmM1Y2QxNmYxM2I2ZDMzNS4uMzI1YjZhZDQxZGIyMTU2MmI1ZWFiMzUyNWNjNTlh NTc4NTcwMmU0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTExLTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE92ZXJmbG93IHNj cm9sbGluZyBsYXllcnMgbmVlZCB0byBiZSBzZWxmLXBhaW50aW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIyMDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIE92ZXJmbG93IHNjcm9sbGlu ZyBsYXllcnMgcGFpbnQgdGhlaXIgY29udGVudHMsIHNvIG5lZWQgdG8gYmUgc2VsZi1wYWludGlu ZyBpbiB0aGUgUmVuZGVyTGF5ZXIgc2Vuc2UuCisgICAgICAgIAorICAgICAgICBXaXRob3V0IHRo aXMgY2hhbmdlLCB0aGUgb3ZlcmZsb3cgaW4gdGhlIHRlc3RjYXNlIGRvZXNuJ3QgZ2V0IGFueSBj b21wb3NpdGluZyBsYXllcnMuCisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcvc2Nyb2xsaW5n L292ZXJmbG93LXNjcm9sbGluZy1sYXllcnMtYXJlLXNlbGYtcGFpbnRpbmcuaHRtbAorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyOjpjYWxjdWxhdGVDbGlwUmVjdHMgY29uc3QpOgorCiAyMDE4LTExLTI5ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBpbnRlcm5h bCBmZWF0dXJlIGZsYWcgdG8gZW5hYmxlIGFzeW5jIG92ZXJmbG93IHNjcm9sbGluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggNjJiZjk2M2M0OGQ5OGVkNDA3 NmFlNDg1MjZiOGJiZDIwMjM1NDQ2OS4uODBjMWJiZTc0ZTNiNWIwNGQ2NTUzZmE3Yzk0NGJmZDA4 ODk5NjFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC02 MTIwLDYgKzYxMjAsNyBAQCBib29sIFJlbmRlckxheWVyOjpzaG91bGRCZVNlbGZQYWludGluZ0xh eWVyKCkgY29uc3QKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICByZXR1cm4gaGFzT3Zlcmxh eVNjcm9sbGJhcnMoKQorICAgICAgICB8fCBjYW5Vc2VDb21wb3NpdGVkU2Nyb2xsaW5nKCkKICAg ICAgICAgfHwgcmVuZGVyZXIoKS5pc1RhYmxlUm93KCkKICAgICAgICAgfHwgcmVuZGVyZXIoKS5p c0NhbnZhcygpCiAgICAgICAgIHx8IHJlbmRlcmVyKCkuaXNWaWRlbygpCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWViYWI2 NjU4MTEzYTAzNDUwYjUwNDgwOTZjYmU3YjgzMzBiZDhlYy4uNGY2Zjk2OGEwZWNiNDNlMTg3MWZj MTNjZTg1MTAwMmQ5OTU4NGJjYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTExLTI5ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE92ZXJmbG93 IHNjcm9sbGluZyBsYXllcnMgbmVlZCB0byBiZSBzZWxmLXBhaW50aW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIyMDEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL3Njcm9sbGlu Zy9vdmVyZmxvdy1zY3JvbGxpbmctbGF5ZXJzLWFyZS1zZWxmLXBhaW50aW5nLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogY29tcG9zaXRpbmcvc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9s bGluZy1sYXllcnMtYXJlLXNlbGYtcGFpbnRpbmcuaHRtbDogQWRkZWQuCisKIDIwMTgtMTEtMjgg IERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtFUyBNb2R1bGVzXSBB bGxvdyAubWpzIGNvbnRlbnQgd2hlbiBsb2FkZWQgZnJvbSBmaWxlOi8vCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9jb21wb3NpdGluZy9zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsaW5nLWxheWVy cy1hcmUtc2VsZi1wYWludGluZy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGlu Zy9zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsaW5nLWxheWVycy1hcmUtc2VsZi1wYWludGluZy1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmFjNmZlN2JlY2I4OWMzYzE5YmIxOWMwYTgyZjM4MmZl NzMyYTdiZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3Njcm9s bGluZy9vdmVyZmxvdy1zY3JvbGxpbmctbGF5ZXJzLWFyZS1zZWxmLXBhaW50aW5nLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDMxIEBACisoR3JhcGhpY3NMYXllcgorICAoYW5jaG9yIDAuMDAgMC4w MCkKKyAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAoY2hpbGRyZW4gMQorICAgIChHcmFwaGlj c0xheWVyCisgICAgICAoYm91bmRzIDgwMC4wMCA2MDAuMDApCisgICAgICAoY29udGVudHNPcGFx dWUgMSkKKyAgICAgIChjaGlsZHJlbiAxCisgICAgICAgIChHcmFwaGljc0xheWVyCisgICAgICAg ICAgKHBvc2l0aW9uIDguMDAgOC4wMCkKKyAgICAgICAgICAoYm91bmRzIDMwMi4wMCAzMDIuMDAp CisgICAgICAgICAgKGRyYXdzQ29udGVudCAxKQorICAgICAgICAgIChjaGlsZHJlbiAxCisgICAg ICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgICAgICAob2Zmc2V0RnJvbVJlbmRlcmVy IHdpZHRoPS0xIGhlaWdodD0tMSkKKyAgICAgICAgICAgICAgKHBvc2l0aW9uIDEuMDAgMS4wMCkK KyAgICAgICAgICAgICAgKGJvdW5kcyAyODUuMDAgMjg1LjAwKQorICAgICAgICAgICAgICAoY2hp bGRyZW4gMQorICAgICAgICAgICAgICAgIChHcmFwaGljc0xheWVyCisgICAgICAgICAgICAgICAg ICAob2Zmc2V0RnJvbVJlbmRlcmVyIHdpZHRoPTEgaGVpZ2h0PTEpCisgICAgICAgICAgICAgICAg ICAoYm91bmRzIDI4NS4wMCAyMDAwLjAwKQorICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAg ICAgKQorICAgICAgICAgICAgKQorICAgICAgICAgICkKKyAgICAgICAgKQorICAgICAgKQorICAg ICkKKyAgKQorKQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9zY3JvbGxp bmcvb3ZlcmZsb3ctc2Nyb2xsaW5nLWxheWVycy1hcmUtc2VsZi1wYWludGluZy5odG1sIGIvTGF5 b3V0VGVzdHMvY29tcG9zaXRpbmcvc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9sbGluZy1sYXllcnMt YXJlLXNlbGYtcGFpbnRpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45NDcwODkwNjg2MDBlMzdiMTQxNjky ZWVhMjMzZGU4M2I1YmEyZTI0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9sbGluZy1sYXllcnMtYXJlLXNlbGYtcGFpbnRp bmcuaHRtbApAQCAtMCwwICsxLDM0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+ CisgICAgPHN0eWxlPgorICAgICAgICAuc2Nyb2xsZXIgeworICAgICAgICAgICAgb3ZlcmZsb3c6 IHNjcm9sbDsKKyAgICAgICAgICAgIGhlaWdodDogMzAwcHg7CisgICAgICAgICAgICB3aWR0aDog MzAwcHg7CisgICAgICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICAgICAgfQor ICAgICAgICAuY29udGVudHMgeworICAgICAgICAgICAgaGVpZ2h0OiAyMDAwcHg7CisgICAgICAg IH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikgeworICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAg ICBpbnRlcm5hbHMuc2V0dGluZ3Muc2V0QXN5bmNPdmVyZmxvd1Njcm9sbGluZ0VuYWJsZWQodHJ1 ZSk7ICAgICAgICAgICAgCisgICAgICAgIH0KKworICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcignbG9hZCcsICgpID0+IHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQor ICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdsYXllci10cmVlJykuaW5u ZXJUZXh0ID0gd2luZG93LmludGVybmFscy5sYXllclRyZWVBc1RleHQoZG9jdW1lbnQpOworICAg ICAgICAgICAgCisgICAgICAgIH0sIGZhbHNlKTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorICAgIDxkaXYgY2xhc3M9InNjcm9sbGVyIj4KKyAgICAgICAgPGRpdiBjbGFzcz0iY29u dGVudHMiPjwvZGl2PgorICAgIDwvZGl2PgorPHByZSBpZD0ibGF5ZXItdHJlZSI+PC9wcmU+Cis8 L2JvZHk+Cis8L2h0bWw+Cg==