192183 2018-11-29 14:56:41 -0800 [ContentObservation] Make WKSetObservedContentChange logic more explicit 2018-11-29 15:09:34 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1483194 0 zalan 2018-11-29 14:56:41 -0800 ssia 1483197 1 356062 zalan 2018-11-29 14:58:51 -0800 Created attachment 356062 Patch 1483213 2 356062 simon.fraser 2018-11-29 15:03:47 -0800 Comment on attachment 356062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356062&action=review > Source/WebCore/platform/ios/wak/WKContentObservation.cpp:82 > + if (_WKContentChange == WKContentVisibilityChange) Would be nice if the enum were ordered so you could do a > check here. 1483221 3 zalan 2018-11-29 15:08:32 -0800 Committed r238699: <https://trac.webkit.org/changeset/238699> 1483223 4 webkit-bug-importer 2018-11-29 15:09:34 -0800 <rdar://problem/46355931> 356062 2018-11-29 14:58:51 -0800 2018-11-29 15:03:47 -0800 Patch bug-192183-20181129145850.patch text/plain 2326 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU0ZjE2YTgyNzhkNGRl MzI2NWM5YjlhZGQwZWI5YjQ1YzUwY2MwNS4uZmJkN2I3ZGM3MGUxZDFkZGI4YjVjOTMxY2MwZTQ0 ZjU0MzY3MGMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTExLTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRPYnNlcnZhdGlv bl0gTWFrZSBXS1NldE9ic2VydmVkQ29udGVudENoYW5nZSBsb2dpYyBtb3JlIGV4cGxpY2l0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMTgzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9pb3Mvd2FrL1dLQ29udGVudE9ic2VydmF0aW9uLmNwcDoKKyAgICAgICAgKFdLU2V0T2JzZXJ2 ZWRDb250ZW50Q2hhbmdlKToKKyAgICAgICAgKFdlYlRocmVhZFJlbW92ZU9ic2VydmVkRE9NVGlt ZXIpOgorCiAyMDE4LTExLTI5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0NvbnRlbnRPYnNlcnZhdGlvbl0gRE9NVGltZXI6Omluc3RhbGwgc2hvdWxkIGV4cGxp Y2l0bHkgY2hlY2sgaWYgdGltZXIgb2JzZXJ2YXRpb24gaXMgb24KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0tDb250ZW50T2JzZXJ2YXRpb24uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XS0NvbnRlbnRPYnNlcnZhdGlvbi5jcHAKaW5k ZXggYmI3MTkyMGQxMDE1MWIxODk2OTI1Zjk2MzQwMDMyOWNiY2NmYWEzOS4uOGNmYTBlYzg3Y2Nh YmFlMWRiMDhiOGJhNjdiOWJmMjkyZDVhNTFiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW9zL3dhay9XS0NvbnRlbnRPYnNlcnZhdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XS0NvbnRlbnRPYnNlcnZhdGlvbi5jcHAKQEAgLTU1LDcg KzU1LDYgQEAgdm9pZCBXS1N0b3BPYnNlcnZpbmdDb250ZW50Q2hhbmdlcyh2b2lkKQogICAgIF9X S09ic2VydmluZ0NvbnRlbnRDaGFuZ2VzID0gZmFsc2U7CiB9CiAKLQogdm9pZCBXS1N0YXJ0T2Jz ZXJ2aW5nRE9NVGltZXJTY2hlZHVsaW5nKHZvaWQpCiB7CiAgICAgX1dLT2JzZXJ2aW5nRE9NVGlt ZXJTY2hlZHVsaW5nID0gdHJ1ZTsKQEAgLTc3LDEzICs3NiwyNCBAQCBXS0NvbnRlbnRDaGFuZ2Ug V0tPYnNlcnZlZENvbnRlbnRDaGFuZ2Uodm9pZCkKICAgICByZXR1cm4gX1dLQ29udGVudENoYW5n ZTsKIH0KIAotdm9pZCBXS1NldE9ic2VydmVkQ29udGVudENoYW5nZShXS0NvbnRlbnRDaGFuZ2Ug YUNoYW5nZSkKK3ZvaWQgV0tTZXRPYnNlcnZlZENvbnRlbnRDaGFuZ2UoV0tDb250ZW50Q2hhbmdl IGNoYW5nZSkKIHsKLSAgICBpZiAoYUNoYW5nZSA+IF9XS0NvbnRlbnRDaGFuZ2UgJiYgKF9XS09i c2VydmluZ0RPTVRpbWVyU2NoZWR1bGluZyB8fCBhQ2hhbmdlICE9IFdLQ29udGVudEluZGV0ZXJt aW5hdGVDaGFuZ2UpKSB7Ci0gICAgICAgIF9XS0NvbnRlbnRDaGFuZ2UgPSBhQ2hhbmdlOwotICAg ICAgICBpZiAoX1dLQ29udGVudENoYW5nZSA9PSBXS0NvbnRlbnRWaXNpYmlsaXR5Q2hhbmdlKQot ICAgICAgICAgICAgV2ViVGhyZWFkQ2xlYXJPYnNlcnZlZERPTVRpbWVycygpOworICAgIC8vIFdl J3ZlIGFscmVhZHkgaGF2ZSBhIGRlZmluaXRlIGFuc3dlci4KKyAgICBpZiAoX1dLQ29udGVudENo YW5nZSA9PSBXS0NvbnRlbnRWaXNpYmlsaXR5Q2hhbmdlKQorICAgICAgICByZXR1cm47CisKKyAg ICBpZiAoY2hhbmdlID09IFdLQ29udGVudFZpc2liaWxpdHlDaGFuZ2UpIHsKKyAgICAgICAgX1dL Q29udGVudENoYW5nZSA9IGNoYW5nZTsKKyAgICAgICAgLy8gRG9uJ3QgbmVlZCB0byBsaXN0ZW4g dG8gRE9NIHRpbWVycyBhbnltb3JlLgorICAgICAgICBXZWJUaHJlYWRDbGVhck9ic2VydmVkRE9N VGltZXJzKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBpZiAoY2hhbmdlID09IFdL Q29udGVudEluZGV0ZXJtaW5hdGVDaGFuZ2UpIHsKKyAgICAgICAgX1dLQ29udGVudENoYW5nZSA9 IGNoYW5nZTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKIH0KIAogdXNpbmcgRE9NVGltZXJMaXN0ID0gSGFzaFNldDx2b2lkKj47Cg==