192174 2018-11-29 13:22:52 -0800 Web Inspector: Uncaught Exception opening Web Inspector to Debugger Tab 2018-11-30 13:15:37 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1483125 0 joepeck 2018-11-29 13:22:52 -0800 Uncaught Exception opening Web Inspector to Debugger Tab Trying to load watch expressions, the panel uses InspectorBackend.runAfterPendingDispatches which tries to use WI.mainTarget.connection but the target doesn't exist it. Lets make it do something if there is no main target. 1483128 1 356041 joepeck 2018-11-29 13:24:15 -0800 Created attachment 356041 [PATCH] Proposed Fix 1483190 2 356041 hi 2018-11-29 14:47:08 -0800 Comment on attachment 356041 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=356041&action=review r=me > Source/WebInspectorUI/UserInterface/Protocol/Connection.js:82 > + this._deferredScripts.push(callback); NIT: Shouldn't this also be called `_deferredCallbacks` while you're renaming things? > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:178 > + setTimeout(callback); This won't preserve the order of execution, which I'm not sure is something we entirely care about, but is something to consider nonetheless. Maybe add a `_deferredCallbacks` like `WI.Connection`? Also, instead of directly checking `WI.mainTarget`, could we utilize `WI.whenTargetsAvailable` to fire all `_deferredCallbacks`? 1483676 3 356041 joepeck 2018-11-30 12:43:42 -0800 Comment on attachment 356041 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=356041&action=review >> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:178 >> + setTimeout(callback); > > This won't preserve the order of execution, which I'm not sure is something we entirely care about, but is something to consider nonetheless. Maybe add a `_deferredCallbacks` like `WI.Connection`? > > Also, instead of directly checking `WI.mainTarget`, could we utilize `WI.whenTargetsAvailable` to fire all `_deferredCallbacks`? Hmm, I should just call it immediately. That will preserve order. 1483697 4 joepeck 2018-11-30 13:14:10 -0800 https://trac.webkit.org/r238750 1483698 5 webkit-bug-importer 2018-11-30 13:15:37 -0800 <rdar://problem/46381949> 356041 2018-11-29 13:24:15 -0800 2018-11-30 12:43:42 -0800 [PATCH] Proposed Fix exception-1.patch text/plain 2870 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAwYWFmNTQ3YzViLi5lNDgwZTMwMzY1NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMTEtMjkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBVbmNhdWdodCBFeGNlcHRpb24gb3BlbmluZyBXZWIgSW5zcGVjdG9yIHRvIERlYnVnZ2VyIFRh YgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMTc0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmQuanM6CisgICAgICAgIChJbnNwZWN0 b3JCYWNrZW5kQ2xhc3MucHJvdG90eXBlLnJ1bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMpOgorICAg ICAgICBEaXNwYXRjaCB0aGUgY2FsbGJhY2sgd2l0aCBhIHRpbWVvdXQgaWYgdGhlcmUgaXMgbm8g YmFja2VuZCB0YXJnZXQgeWV0CisgICAgICAgIHNvIGl0IGRvZXNuJ3QgZ2V0IGxvc3QuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1Byb3RvY29sL0Nvbm5lY3Rpb24uanM6CisgICAgICAgIChJ bnNwZWN0b3JCYWNrZW5kLkNvbm5lY3Rpb24ucHJvdG90eXBlLnJ1bkFmdGVyUGVuZGluZ0Rpc3Bh dGNoZXMpOgorICAgICAgICBDaGFuZ2UgdGhlIGFtYmlndW91cyBuYW1lICJzY3JpcHQiIHRvIHRo ZSBtb3JlIGZhbWlsaWFyICJjYWxsYmFjayIuCisKIDIwMTgtMTEtMjggIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNT SU9OKD8pOiBhbGwgIlNob3cgKiIgZGV2ZWxvcCBtZW51IGl0ZW1zIGNhdXNlIHRoZSBwYWdlIHRv IGNyYXNoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Q cm90b2NvbC9Db25uZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvUHJvdG9jb2wvQ29ubmVjdGlvbi5qcwppbmRleCA5MTYyNGMyNTY2My4uNGI2MGQ1NDg0ZDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29s L0Nvbm5lY3Rpb24uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv UHJvdG9jb2wvQ29ubmVjdGlvbi5qcwpAQCAtNzIsMTQgKzcyLDE0IEBAIEluc3BlY3RvckJhY2tl bmQuQ29ubmVjdGlvbiA9IGNsYXNzIEluc3BlY3RvckJhY2tlbmRDb25uZWN0aW9uCiAgICAgICAg ICAgICB0aGlzLl9kaXNwYXRjaEV2ZW50KG1lc3NhZ2VPYmplY3QpOwogICAgIH0KIAotICAgIHJ1 bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMoc2NyaXB0KQorICAgIHJ1bkFmdGVyUGVuZGluZ0Rpc3Bh dGNoZXMoY2FsbGJhY2spCiAgICAgewotICAgICAgICBjb25zb2xlLmFzc2VydCh0eXBlb2Ygc2Ny aXB0ID09PSAiZnVuY3Rpb24iKTsKKyAgICAgICAgY29uc29sZS5hc3NlcnQodHlwZW9mIGNhbGxi YWNrID09PSAiZnVuY3Rpb24iKTsKIAogICAgICAgICBpZiAoIXRoaXMuX3BlbmRpbmdSZXNwb25z ZXMuc2l6ZSkKLSAgICAgICAgICAgIHNjcmlwdC5jYWxsKHRoaXMpOworICAgICAgICAgICAgY2Fs bGJhY2suY2FsbCh0aGlzKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgdGhpcy5fZGVmZXJy ZWRTY3JpcHRzLnB1c2goc2NyaXB0KTsKKyAgICAgICAgICAgIHRoaXMuX2RlZmVycmVkU2NyaXB0 cy5wdXNoKGNhbGxiYWNrKTsKICAgICB9CiAKICAgICAvLyBQcm90ZWN0ZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJh Y2tlbmQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9J bnNwZWN0b3JCYWNrZW5kLmpzCmluZGV4IDg4MmQ4YzRmNjJjLi5iMjIxM2I0ZmEwMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVj dG9yQmFja2VuZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Q cm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kLmpzCkBAIC0xNzIsMTAgKzE3MiwxNSBAQCBJbnNwZWN0 b3JCYWNrZW5kQ2xhc3MgPSBjbGFzcyBJbnNwZWN0b3JCYWNrZW5kQ2xhc3MKICAgICAgICAgSW5z cGVjdG9yQmFja2VuZC5iYWNrZW5kQ29ubmVjdGlvbi5kaXNwYXRjaChtZXNzYWdlKTsKICAgICB9 CiAKLSAgICBydW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKHNjcmlwdCkKKyAgICBydW5BZnRlclBl bmRpbmdEaXNwYXRjaGVzKGNhbGxiYWNrKQogICAgIHsKKyAgICAgICAgaWYgKCFXSS5tYWluVGFy Z2V0KSB7CisgICAgICAgICAgICBzZXRUaW1lb3V0KGNhbGxiYWNrKTsKKyAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIC8vIEZJWE1FOiBTaG91bGQgdGhpcyByZXNwZWN0 IHBlbmRpbmcgZGlzcGF0Y2hlcyBpbiBhbGwgY29ubmVjdGlvbnM/Ci0gICAgICAgIFdJLm1haW5U YXJnZXQuY29ubmVjdGlvbi5ydW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKHNjcmlwdCk7CisgICAg ICAgIFdJLm1haW5UYXJnZXQuY29ubmVjdGlvbi5ydW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKGNh bGxiYWNrKTsKICAgICB9CiAKICAgICBhY3RpdmF0ZURvbWFpbihkb21haW5OYW1lLCBhY3RpdmF0 aW9uRGVidWdnYWJsZVR5cGVzKQo=