192138 2018-11-29 00:03:14 -0800 Factor out configuration of the file upload image picker 2018-11-29 10:28:47 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz aestes joepeck thorton wenson_hsieh oldest_to_newest 1482859 0 conrad_shultz 2018-11-29 00:03:14 -0800 Factor out configuration of the file upload image picker 1482860 1 conrad_shultz 2018-11-29 00:03:44 -0800 <rdar://problem/46334871> 1482861 2 355983 conrad_shultz 2018-11-29 00:07:30 -0800 Created attachment 355983 Patch 1482863 3 355983 thorton 2018-11-29 00:27:39 -0800 Comment on attachment 355983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355983&action=review > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:433 > + ASSERT(_imagePicker); humorous that you assert the ivar and then use the parameter. why the assert? 1483006 4 355983 conrad_shultz 2018-11-29 10:14:53 -0800 Comment on attachment 355983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355983&action=review >> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:433 >> + ASSERT(_imagePicker); > > humorous that you assert the ivar and then use the parameter. why the assert? Whoops... typo! I originally was using the ivar, then changed to a parameter. Will update. 1483013 5 conrad_shultz 2018-11-29 10:27:47 -0800 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@238674 268f45cc-cd09-0410-ab3c-d52691b4dbfc 1483014 6 conrad_shultz 2018-11-29 10:28:47 -0800 https://trac.webkit.org/changeset/238674/webkit 355983 2018-11-29 00:07:30 -0800 2018-11-29 00:27:39 -0800 Patch bug-192138-20181129000729.patch text/plain 3140 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY0OTUwYmYwYTUzOWUzZjlh MzUxNzQzY2NkZjFmZDY4NWJkNzYwY2YuLmQ1NDBkMWU0NzJiOWFkOGM2MDdmOTA5NGVhZmE5N2Iz Y2IwOGQ2ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTEtMjkgIENvbnJhZCBT aHVsdHogIDxjb25yYWRfc2h1bHR6QGFwcGxlLmNvbT4KKworICAgICAgICBGYWN0b3Igb3V0IGNv bmZpZ3VyYXRpb24gb2YgdGhlIGZpbGUgdXBsb2FkIGltYWdlIHBpY2tlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMTM4CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NjMzNDg3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCeSBmYWN0b3JpbmcgY29uZmlndXJhdGlvbiBvZiB0aGUgcGlja2VyIGlu dG8gaXRzIG93biBtZXRob2QsIGl0IG1ha2VzIGl0IGVhc2llcgorICAgICAgICB0byBhcHBseSBj dXN0b20gY29uZmlndXJhdGlvbiBpbiBzdWJjbGFzc2VzIGluIHRoZSBmdXR1cmUuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tOgorICAgICAgICAo LVtXS0ZpbGVVcGxvYWRQYW5lbCBfc2hvd1Bob3RvUGlja2VyV2l0aFNvdXJjZVR5cGU6XSk6Cisg ICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIF9jb25maWd1cmVJbWFnZVBpY2tlcjpdKToKKwog MjAxOC0xMS0yOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04oPyk6IGFsbCAiU2hvdyAqIiBkZXZlbG9wIG1l bnUgaXRlbXMgY2F1c2UgdGhlIHBhZ2UgdG8gY3Jhc2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQppbmRleCA4NjJiMTIy MWYxMTY1ZDRjMjNjMDlmYTNmNGFmODFjNzFmNTVjNWRiLi43ZGEzNjcxYWIzZGFjMWUxZmRlOWJl YjgxZTdiNGNhM2E5YzU3MmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCkBAIC00MTMsMTcgKzQxMywxMSBAQCBz dGF0aWMgTlNBcnJheSAqVVRJc0Zvck1JTUVUeXBlcyhOU0FycmF5ICptaW1lVHlwZXMpCiAtICh2 b2lkKV9zaG93UGhvdG9QaWNrZXJXaXRoU291cmNlVHlwZTooVUlJbWFnZVBpY2tlckNvbnRyb2xs ZXJTb3VyY2VUeXBlKXNvdXJjZVR5cGUKIHsKICAgICBBU1NFUlQoW1VJSW1hZ2VQaWNrZXJDb250 cm9sbGVyIGlzU291cmNlVHlwZUF2YWlsYWJsZTpzb3VyY2VUeXBlXSk7Ci0gICAgCisKICAgICBf aW1hZ2VQaWNrZXIgPSBhZG9wdE5TKFtbVUlJbWFnZVBpY2tlckNvbnRyb2xsZXIgYWxsb2NdIGlu aXRdKTsKLSAgICBbX2ltYWdlUGlja2VyIHNldERlbGVnYXRlOnNlbGZdOworICAgIFtzZWxmIF9j b25maWd1cmVJbWFnZVBpY2tlcjpfaW1hZ2VQaWNrZXIuZ2V0KCldOwogICAgIFtfaW1hZ2VQaWNr ZXIgc2V0U291cmNlVHlwZTpzb3VyY2VUeXBlXTsKLSAgICBbX2ltYWdlUGlja2VyIHNldEFsbG93 c0VkaXRpbmc6Tk9dOwotICAgIFtfaW1hZ2VQaWNrZXIgc2V0TW9kYWxQcmVzZW50YXRpb25TdHls ZTpVSU1vZGFsUHJlc2VudGF0aW9uRnVsbFNjcmVlbl07Ci0gICAgW19pbWFnZVBpY2tlciBfc2V0 QWxsb3dzTXVsdGlwbGVTZWxlY3Rpb246X2FsbG93TXVsdGlwbGVGaWxlc107CiAgICAgW19pbWFn ZVBpY2tlciBzZXRNZWRpYVR5cGVzOltzZWxmIF9tZWRpYVR5cGVzRm9yUGlja2VyU291cmNlVHlw ZTpzb3VyY2VUeXBlXV07Ci0KLSAgICBpZiAoX21lZGlhQ2FwdHVyZVR5cGUgIT0gV2ViQ29yZTo6 TWVkaWFDYXB0dXJlVHlwZU5vbmUpCi0gICAgICAgIFtfaW1hZ2VQaWNrZXIgc2V0Q2FtZXJhRGV2 aWNlOmNhbWVyYURldmljZUZvck1lZGlhQ2FwdHVyZVR5cGUoX21lZGlhQ2FwdHVyZVR5cGUpXTsK ICAgICAKICAgICAvLyBVc2UgYSBwb3BvdmVyIG9uIHRoZSBpUGFkIGlmIHRoZSBzb3VyY2UgdHlw ZSBpcyBub3QgdGhlIGNhbWVyYS4KICAgICAvLyBUaGUgY2FtZXJhIHdpbGwgdXNlIGEgZnVsbHNj cmVlbiwgbW9kYWwgdmlldyBjb250cm9sbGVyLgpAQCAtNDM0LDYgKzQyOCwxOCBAQCBzdGF0aWMg TlNBcnJheSAqVVRJc0Zvck1JTUVUeXBlcyhOU0FycmF5ICptaW1lVHlwZXMpCiAgICAgICAgIFtz ZWxmIF9wcmVzZW50RnVsbHNjcmVlblZpZXdDb250cm9sbGVyOl9pbWFnZVBpY2tlci5nZXQoKSBh bmltYXRlZDpZRVNdOwogfQogCistICh2b2lkKV9jb25maWd1cmVJbWFnZVBpY2tlcjooVUlJbWFn ZVBpY2tlckNvbnRyb2xsZXIgKilpbWFnZVBpY2tlcgoreworICAgIEFTU0VSVChfaW1hZ2VQaWNr ZXIpOworICAgIFtpbWFnZVBpY2tlciBzZXREZWxlZ2F0ZTpzZWxmXTsKKyAgICBbaW1hZ2VQaWNr ZXIgc2V0QWxsb3dzRWRpdGluZzpOT107CisgICAgW2ltYWdlUGlja2VyIHNldE1vZGFsUHJlc2Vu dGF0aW9uU3R5bGU6VUlNb2RhbFByZXNlbnRhdGlvbkZ1bGxTY3JlZW5dOworICAgIFtpbWFnZVBp Y2tlciBfc2V0QWxsb3dzTXVsdGlwbGVTZWxlY3Rpb246X2FsbG93TXVsdGlwbGVGaWxlc107CisK KyAgICBpZiAoX21lZGlhQ2FwdHVyZVR5cGUgIT0gV2ViQ29yZTo6TWVkaWFDYXB0dXJlVHlwZU5v bmUpCisgICAgICAgIFtpbWFnZVBpY2tlciBzZXRDYW1lcmFEZXZpY2U6Y2FtZXJhRGV2aWNlRm9y TWVkaWFDYXB0dXJlVHlwZShfbWVkaWFDYXB0dXJlVHlwZSldOworfQorCiAjcHJhZ21hIG1hcmsg LSBQcmVzZW50aW5nIFZpZXcgQ29udHJvbGxlcnMKIAogLSAodm9pZClfcHJlc2VudE1lbnVPcHRp b25Gb3JDdXJyZW50SW50ZXJmYWNlSWRpb206KFVJVmlld0NvbnRyb2xsZXIgKil2aWV3Q29udHJv bGxlcgo=