192110 2018-11-28 15:16:38 -0800 ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h. 2018-11-28 17:23:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo dbates ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1482688 0 mark.lam 2018-11-28 15:16:38 -0800 Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore (and other projects) as well as JSC. Hence, there's no reason why ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h. <rdar://problem/46317746> 1482699 1 355927 mark.lam 2018-11-28 15:24:35 -0800 Created attachment 355927 proposed patch. 1482756 2 mark.lam 2018-11-28 17:23:19 -0800 Thanks for the review. Landed in r238650: <http://trac.webkit.org/r238650>. 355927 2018-11-28 15:24:35 -0800 2018-11-28 15:27:11 -0800 proposed patch. bug-192110.patch text/plain 2752 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM4NjQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE4LTExLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF TkFCTEVfU0VQQVJBVEVEX1dYX0hFQVAgbmVlZHMgdG8gYmUgZGVmaW5lZCBpbiBQbGF0Zm9ybS5o LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMTEw CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjMxNzc0Nj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvbmZpZy5oOgorCiAyMDE4LTExLTI4ICBL ZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgZ2VuZXJh dGUte2Rlcml2ZWQsdW5pZmllZH0tc291cmNlcyBzY3JpcHRzIHRvIHN1cHBvcnQgZ2VuZXJhdGlu ZyAueGNmaWxlbGlzdCBmaWxlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaAkocmV2aXNpb24g MjM4NjIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkp CkBAIC0zNywxMSArMzcsMyBAQAogI2VuZGlmCiAKICNpbmNsdWRlIDx3dGYvRGlzYWxsb3dDVHlw ZS5oPgotCi0jaWYgIWRlZmluZWQoRU5BQkxFX1NFUEFSQVRFRF9XWF9IRUFQKQotI2lmICghRU5B QkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSB8fCAhQ1BVKEFSTTY0RSkpICYmIFBMQVRGT1JNKElP U19GQU1JTFkpICYmIENQVShBUk02NCkKLSNkZWZpbmUgRU5BQkxFX1NFUEFSQVRFRF9XWF9IRUFQ IDEKLSNlbHNlCi0jZGVmaW5lIEVOQUJMRV9TRVBBUkFURURfV1hfSEVBUCAwCi0jZW5kaWYKLSNl bmRpZiAvLyAhZGVmaW5lZChFTkFCTEVfU0VQQVJBVEVEX1dYX0hFQVApCkluZGV4OiBTb3VyY2Uv V1RGL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNp b24gMjM4NjIyKQorKysgU291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxOSBAQAorMjAxOC0xMS0yOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisK KyAgICAgICAgRU5BQkxFX1NFUEFSQVRFRF9XWF9IRUFQIG5lZWRzIHRvIGJlIGRlZmluZWQgaW4g UGxhdGZvcm0uaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MjExMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYzMTc3NDY+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29udHJhcnkgbXkgcHJldmlv dXMgY2xhaW0gaW4gcjIzODU2NCwgRU5BQkxFX1NFUEFSQVRFRF9XWF9IRUFQIG5lZWRzIHRvIGJl CisgICAgICAgIGRlZmluZWQgaW4gUGxhdGZvcm0uaCBiZWNhdXNlIGl0IGlzIGFsc28gbmVlZGVk IGluIFdlYkNvcmUgZm9yIHRoZSBDU1MgSklULiAgQWxzbworICAgICAgICBjb250cmFyeSB0byBt eSBwcmV2aW91cyBjbGFpbSwgRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSBpcyBkZWZpbmVk IGZvciBXZWJDb3JlCisgICAgICAgIChhbmQgb3RoZXIgcHJvamVjdHMpIGFzIHdlbGwgYXMgSlND LiAgSGVuY2UsIHRoZXJlJ3Mgbm8gcmVhc29uIHdoeQorICAgICAgICBFTkFCTEVfU0VQQVJBVEVE X1dYX0hFQVAgY2Fubm90IGJlIGRlZmluZWQgaW4gUGxhdGZvcm0uaC4KKworICAgICAgICAqIHd0 Zi9QbGF0Zm9ybS5oOgorCiAyMDE4LTExLTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBhbm90aGVyIE9TIHZlcnNpb24gY2hlY2sgZnJvbSBO ZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAyMzg2MjIp CisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC05NjUsNiAr OTY1LDE0IEBACiAjZGVmaW5lIEpJVF9PUEVSQVRJT04KICNlbmRpZgogCisjaWZuZGVmIEVOQUJM RV9TRVBBUkFURURfV1hfSEVBUAorI2lmICghRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSB8 fCAhQ1BVKEFSTTY0RSkpICYmIFBMQVRGT1JNKElPU19GQU1JTFkpICYmIENQVShBUk02NCkKKyNk ZWZpbmUgRU5BQkxFX1NFUEFSQVRFRF9XWF9IRUFQIDEKKyNlbHNlCisjZGVmaW5lIEVOQUJMRV9T RVBBUkFURURfV1hfSEVBUCAwCisjZW5kaWYKKyNlbmRpZgorCiAvKiBDb25maWd1cmUgdGhlIGlu dGVycHJldGVyICovCiAjaWYgQ09NUElMRVIoR0NDX0NPTVBBVElCTEUpCiAjZGVmaW5lIEhBVkVf Q09NUFVURURfR09UTyAxCg==