19211 2008-05-23 03:45:30 -0700 Changing the sorting while a resource is selected unhighlights it 2008-05-29 14:26:51 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rik timothy aroben timothy oldest_to_newest 81288 0 rik 2008-05-23 03:45:30 -0700 Steps to reproduce : 1. Go to http://webkit.org 2. Open the Inspector in the Resources tab 3. Select the HTML page 4. Sort by latency The HTML page is not highlighted If you sort by start time, then by end time and finally by latency, the resource is highlighted. 81818 1 rik 2008-05-29 00:34:38 -0700 The buggy line seems to be #1424 in ResourcesPanel.js. By the way, it's impossible to set a breakpoint on line 1425. 81861 2 21414 timothy 2008-05-29 10:35:05 -0700 Created attachment 21414 Proposed patch 81863 3 21414 aroben 2008-05-29 10:42:53 -0700 Comment on attachment 21414 Proposed patch r=me 81891 4 timothy 2008-05-29 14:26:51 -0700 Landed in r34211. 21414 2008-05-29 10:35:05 -0700 2008-05-29 10:42:53 -0700 Proposed patch 0001-Fixes-a-bug-where-the-className-would-be-reset-for-R.patch text/plain 4015 timothy RnJvbSA1MzIxZWYxNzZjZTFlNDIyYmZjMDhkYmEyMjA0OTJjNWQyNDVhMWRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUaHUsIDI5IE1heSAyMDA4IDEwOjM1OjE3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZXMgYSBidWcgd2hlcmUgdGhlIGNsYXNzTmFtZSB3b3VsZCBiZSByZXNldCBmb3IgUmVzb3VyY2UK IHRyZWUgZWxlbWVudHMgYW5kIHRoZSBzZWxlY3RlZCBzdGF0ZSB3b3VsZCBiZSBsb3N0LiBUaGlz IGNvdWxkCiBoYXBwZW4gd2hlbiBzb3J0aW5nIHRoZSByZXNvdXJjZXMuCgpodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMTEKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKKiBwYWdlL2luc3BlY3Rvci9SZXNvdXJjZXNQYW5lbC5qczoKKFdlYkluc3BlY3Rvci5S ZXNvdXJjZVNpZGViYXJUcmVlRWxlbWVudC5wcm90b3R5cGUucmVmcmVzaCk6IENhbGwKcmVtb3Zl TWF0Y2hpbmdTdHlsZUNsYXNzZXMgdG8gcmVtb3ZlIHByZXZpb3VzIGNhdGVnb3J5IGNsYXNzZXMg aW5zdGVhZApvZiBzZXR0aW5nIHRoZSB3aG9sZSBjbGFzc05hbWUgZGlyZWN0bHkuCiogcGFnZS9p bnNwZWN0b3IvdXRpbGl0aWVzLmpzOgooRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlU3R5bGVDbGFz cyk6IE1vdmVkIGNvZGUgdG8KcmVtb3ZlTWF0Y2hpbmdTdHlsZUNsYXNzZXMgYW5kIGNhbGwgcmVt b3ZlTWF0Y2hpbmdTdHlsZUNsYXNzZXMuCihFbGVtZW50LnByb3RvdHlwZS5yZW1vdmVNYXRjaGlu Z1N0eWxlQ2xhc3Nlcyk6IEFkZGVkLiBDb2RlIG1vdmVkIGZyb20KcmVtb3ZlU3R5bGVDbGFzcyBh bmQgZG9uJ3QgZXNjYXBlIHRoZSBzdHJpbmcuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysrKysrKysKIFdlYkNvcmUvcGFn ZS9pbnNwZWN0b3IvUmVzb3VyY2VzUGFuZWwuanMgfCAgICA3ICsrKystLS0KIFdlYkNvcmUvcGFn ZS9pbnNwZWN0b3IvdXRpbGl0aWVzLmpzICAgICAgfCAgICA3ICsrKysrKy0KIDMgZmlsZXMgY2hh bmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlkYzVjNTguLjA3ZWU1NzAg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjUgQEAKIDIwMDgtMDUtMjkgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw bGUuY29tPgogCisgICAgICAgIEZpeGVzIGEgYnVnIHdoZXJlIHRoZSBjbGFzc05hbWUgd291bGQg YmUgcmVzZXQgZm9yIFJlc291cmNlCisgICAgICAgIHRyZWUgZWxlbWVudHMgYW5kIHRoZSBzZWxl Y3RlZCBzdGF0ZSB3b3VsZCBiZSBsb3N0LiBUaGlzIGNvdWxkCisgICAgICAgIGhhcHBlbiB3aGVu IHNvcnRpbmcgdGhlIHJlc291cmNlcy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL1Jlc291cmNlc1BhbmVsLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclRyZWVFbGVtZW50LnByb3RvdHlwZS5y ZWZyZXNoKTogQ2FsbAorICAgICAgICByZW1vdmVNYXRjaGluZ1N0eWxlQ2xhc3NlcyB0byByZW1v dmUgcHJldmlvdXMgY2F0ZWdvcnkgY2xhc3NlcyBpbnN0ZWFkCisgICAgICAgIG9mIHNldHRpbmcg dGhlIHdob2xlIGNsYXNzTmFtZSBkaXJlY3RseS4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci91 dGlsaXRpZXMuanM6CisgICAgICAgIChFbGVtZW50LnByb3RvdHlwZS5yZW1vdmVTdHlsZUNsYXNz KTogTW92ZWQgY29kZSB0bworICAgICAgICByZW1vdmVNYXRjaGluZ1N0eWxlQ2xhc3NlcyBhbmQg Y2FsbCByZW1vdmVNYXRjaGluZ1N0eWxlQ2xhc3Nlcy4KKyAgICAgICAgKEVsZW1lbnQucHJvdG90 eXBlLnJlbW92ZU1hdGNoaW5nU3R5bGVDbGFzc2VzKTogQWRkZWQuIENvZGUgbW92ZWQgZnJvbQor ICAgICAgICByZW1vdmVTdHlsZUNsYXNzIGFuZCBkb24ndCBlc2NhcGUgdGhlIHN0cmluZy4KKwor MjAwOC0wNS0yOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAgICAg ICAgRml4ZXMgdGhlIHJlZ3Jlc3Npb24gd2hlcmUgaW1hZ2UgcmVzb3VyY2VzIGRvbid0IGhhdmUg YSBwcmV2aWV3IGljb24uCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NTAwCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1Jlc291 cmNlc1BhbmVsLmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9SZXNvdXJjZXNQYW5lbC5qcwpp bmRleCA2MzRmNDZlLi5kMmUyNmI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9y L1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvUmVzb3VyY2Vz UGFuZWwuanMKQEAgLTE0MzYsOSArMTQzNiwxMCBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRl YmFyVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgICAgIHRoaXMucmVmcmVzaFRpdGxl cygpOwogCi0gICAgICAgIHZhciBuZXdDbGFzc05hbWUgPSAic2lkZWJhci10cmVlLWl0ZW0gcmVz b3VyY2Utc2lkZWJhci10cmVlLWl0ZW0gcmVzb3VyY2VzLWNhdGVnb3J5LSIgKyB0aGlzLnJlc291 cmNlLmNhdGVnb3J5Lm5hbWU7Ci0gICAgICAgIGlmICh0aGlzLl9saXN0SXRlbU5vZGUgJiYgdGhp cy5fbGlzdEl0ZW1Ob2RlLmNsYXNzTmFtZSAhPT0gbmV3Q2xhc3NOYW1lKQotICAgICAgICAgICAg dGhpcy5fbGlzdEl0ZW1Ob2RlLmNsYXNzTmFtZSA9IG5ld0NsYXNzTmFtZTsKKyAgICAgICAgaWYg KCF0aGlzLl9saXN0SXRlbU5vZGUuaGFzU3R5bGVDbGFzcygicmVzb3VyY2VzLWNhdGVnb3J5LSIg KyB0aGlzLnJlc291cmNlLmNhdGVnb3J5Lm5hbWUpKSB7CisgICAgICAgICAgICB0aGlzLl9saXN0 SXRlbU5vZGUucmVtb3ZlTWF0Y2hpbmdTdHlsZUNsYXNzZXMoInJlc291cmNlcy1jYXRlZ29yeS1c XHcrIik7CisgICAgICAgICAgICB0aGlzLl9saXN0SXRlbU5vZGUuYWRkU3R5bGVDbGFzcygicmVz b3VyY2VzLWNhdGVnb3J5LSIgKyB0aGlzLnJlc291cmNlLmNhdGVnb3J5Lm5hbWUpOworICAgICAg ICB9CiAgICAgfSwKIAogICAgIHJlZnJlc2hJY29uOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL3V0aWxpdGllcy5qcyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0 b3IvdXRpbGl0aWVzLmpzCmluZGV4IDg4MDg0ODAuLjdlODc0MTMgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvdXRpbGl0aWVzLmpzCisrKyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0 b3IvdXRpbGl0aWVzLmpzCkBAIC0xMDYsNyArMTA2LDEyIEBAIEVsZW1lbnQucHJvdG90eXBlLnJl bW92ZVN0eWxlQ2xhc3MgPSBmdW5jdGlvbihjbGFzc05hbWUpCiAgICAgICAgIHJldHVybjsKICAg ICB9CiAKLSAgICB2YXIgcmVnZXggPSBuZXcgUmVnRXhwKCIoXnxcXHMrKSIgKyBjbGFzc05hbWUu ZXNjYXBlRm9yUmVnRXhwKCkgKyAiKCR8XFxzKykiKTsKKyAgICB0aGlzLnJlbW92ZU1hdGNoaW5n U3R5bGVDbGFzc2VzKGNsYXNzTmFtZS5lc2NhcGVGb3JSZWdFeHAoKSk7Cit9CisKK0VsZW1lbnQu cHJvdG90eXBlLnJlbW92ZU1hdGNoaW5nU3R5bGVDbGFzc2VzID0gZnVuY3Rpb24oY2xhc3NOYW1l UmVnZXgpCit7CisgICAgdmFyIHJlZ2V4ID0gbmV3IFJlZ0V4cCgiKF58XFxzKykiICsgY2xhc3NO YW1lUmVnZXggKyAiKCR8XFxzKykiKTsKICAgICBpZiAocmVnZXgudGVzdCh0aGlzLmNsYXNzTmFt ZSkpCiAgICAgICAgIHRoaXMuY2xhc3NOYW1lID0gdGhpcy5jbGFzc05hbWUucmVwbGFjZShyZWdl eCwgIiAiKTsKIH0KLS0gCjEuNS40LjQKCg==