192099 2018-11-28 13:33:31 -0800 Fix unnecessary call to [NSApplication sharedApplication] 2018-12-03 10:32:12 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Mac macOS 10.14 RESOLVED FIXED InRadar P2 Normal --- 1 skoppisetty webkit-unassigned commit-queue darin ggaren webkit-bug-importer oldest_to_newest 1482622 0 skoppisetty 2018-11-28 13:33:31 -0800 [NSApplication sharedApplication] call is no longer needed in platformInitializeWebProcess as [NSApplication _accessibilityInitialize] will call [NSApplication sharedApplication]. 1482628 1 355912 skoppisetty 2018-11-28 13:40:23 -0800 Created attachment 355912 Patch 1483051 2 355912 ggaren 2018-11-29 11:34:23 -0800 Comment on attachment 355912 Patch r=me 1483068 3 355912 commit-queue 2018-11-29 11:59:50 -0800 Comment on attachment 355912 Patch Clearing flags on attachment: 355912 Committed r238681: <https://trac.webkit.org/changeset/238681> 1483069 4 commit-queue 2018-11-29 11:59:52 -0800 All reviewed patches have been landed. Closing bug. 1483070 5 webkit-bug-importer 2018-11-29 12:01:30 -0800 <rdar://problem/46349668> 1484229 6 355912 darin 2018-12-02 16:12:26 -0800 Comment on attachment 355912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355912&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:187 > // Currently, it is also needed to allocate and initialize an NSApplication object. The patch should have removed this comment, too. It now makes no sense! 1484390 7 355912 skoppisetty 2018-12-03 10:32:12 -0800 Comment on attachment 355912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355912&action=review >> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:187 >> // Currently, it is also needed to allocate and initialize an NSApplication object. > > The patch should have removed this comment, too. It now makes no sense! I think the statement still makes sense as [NSApplication _accessibilityInitialize] allocates and initializes an NSApplication object before doing the accessibility initialization. This patch only removes the double call to [NSApplication sharedApplication], not the dependency of initializing an NSApplication object. 355912 2018-11-28 13:40:23 -0800 2018-11-29 11:59:50 -0800 Patch bug-192099-20181128134023.patch text/plain 1759 skoppisetty U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYwZTZjZTVhOTc3NzczZWEy OTk1YTkyZGZhMDhiZTU2MjVkN2M1ZGMuLjcxNTAyMDQ3YmYwZWUxMGUzZGYxYTIwNzc3NTNlMTI1 ODFkYWIwZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTEtMjggIFN1cmVzaCBL b3BwaXNldHR5ICA8c2tvcHBpc2V0dHlAYXBwbGUuY29tPgorCisgICAgICAgIEFkZHJlc3NlZCBh IEZJWE1FIGJ5IHJlbW92aW5nIGFuIHVubmVjZXNzYXJ5IGNhbGwgdG8gW05TQXBwbGljYXRpb24g c2hhcmVkQXBwbGljYXRpb25dLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkyMDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW05TQXBwbGljYXRpb24gc2hhcmVkQXBwbGljYXRpb25dIGNhbGwgaXMgbm8g bG9uZ2VyIG5lZWRlZCBpbiBwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzIGFzIFtOU0FwcGxp Y2F0aW9uIF9hY2Nlc3NpYmlsaXR5SW5pdGlhbGl6ZV0gY2FsbHMgW05TQXBwbGljYXRpb24gc2hh cmVkQXBwbGljYXRpb25dLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNz Q29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6 ZVdlYlByb2Nlc3MpOgorCiAyMDE4LTExLTI4ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzg2MjAuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1t IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRl eCBiYzhhZGE4MDZhMGQyNDA0NDQ4YzFiNWE5OWEyZjUzZGM3MWRjYjM3Li41ZWQ3ZjEwYzMxYjU5 OGE1ZGYyM2FjZDE2ZGM5NDYwMDZhZjRjNGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTE4NSw4ICsxODUsNiBAQCB2b2lk IFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0 aW9uUGFyYW1ldGVycyYmIHBhcgogI2lmIFBMQVRGT1JNKE1BQykgJiYgRU5BQkxFKFdFQlBST0NF U1NfTlNSVU5MT09QKQogICAgIC8vIE5lZWQgdG8gaW5pdGlhbGl6ZSBhY2Nlc3NpYmlsaXR5IGZv ciBWb2ljZU92ZXIgdG8gd29yayB3aGVuIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgaXMgdXNpbmcg TlNSdW5Mb29wLgogICAgIC8vIEN1cnJlbnRseSwgaXQgaXMgYWxzbyBuZWVkZWQgdG8gYWxsb2Nh dGUgYW5kIGluaXRpYWxpemUgYW4gTlNBcHBsaWNhdGlvbiBvYmplY3QuCi0gICAgLy8gRklYTUU6 IFJlbW92ZSB0aGUgZm9sbG93aW5nIGxpbmUgd2hlbiByZGFyOi8vcHJvYmxlbS8zNjMyMzU2OSBp cyBmaXhlZC4KLSAgICBbTlNBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl07CiAgICAgW05T QXBwbGljYXRpb24gX2FjY2Vzc2liaWxpdHlJbml0aWFsaXplXTsKICNlbmRpZgogCg==