192080 2018-11-28 09:22:26 -0800 webkitbot gets an HTTP 302 error when using the 'hi' command 2018-11-28 09:53:36 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari 11 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lforschler lforschler ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1482455 0 lforschler 2018-11-28 09:22:26 -0800 webkitbot: hi returns an HTTP 302 error. In the code, I see that WKR also pukes when using this command, so it's likely we need to special case webkitbot the same way to do WKR. 1482466 1 355879 lforschler 2018-11-28 09:42:51 -0800 Created attachment 355879 v1 patch for review. 1482468 2 355879 ap 2018-11-28 09:46:55 -0800 Comment on attachment 355879 v1 patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=355879&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:123 > quips = tool.bugs.quips() A better approach would be to delete all code related to quips - it's not used at all at this point. 1482475 3 lforschler 2018-11-28 09:52:09 -0800 Committed r238618: <https://trac.webkit.org/changeset/238618> 1482479 4 webkit-bug-importer 2018-11-28 09:53:36 -0800 <rdar://problem/46312665> 355879 2018-11-28 09:42:51 -0800 2018-11-28 09:46:55 -0800 v1 patch for review. 192080.patch text/plain 1596 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODYxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTExLTI4ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggd2Via2l0Ym90IGhpIGNvbW1hbmQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIwODAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v bC9ib3QvaXJjX2NvbW1hbmQucHk6CisgICAgICAgIChIaS5leGVjdXRlKToKKwogMjAxOC0xMS0y OCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW1F1aXJr XSBVc2Ugbm9uLWNvbGxhcHNlZCB2ZXJ0aWNhbCBtYXJnaW4gdmFsdWVzIHdoZW4gdGhlIGNvbnRh aW5lciBpcyBzdHJldGNoZWQgdG8gdGhlIHNpemUgb2YgdGhlIElDQi4KSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQkocmV2aXNpb24gMjM4 NjE2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQko d29ya2luZyBjb3B5KQpAQCAtMTE3LDggKzExNyw5IEBAIGNsYXNzIEhpKElSQ0NvbW1hbmQpOgog ICAgIGRlZiBleGVjdXRlKHNlbGYsIG5pY2ssIGFyZ3MsIHRvb2wsIHNoZXJpZmYpOgogICAgICAg ICBpZiBsZW4oYXJncykgYW5kIHJlLm1hdGNoKHNoZXJpZmYubmFtZSgpICsgcidfKlxzKiFccyon LCAnICcuam9pbihhcmdzKSk6CiAgICAgICAgICAgICByZXR1cm4gIiVzOiBoaSAlcyEiICUgKG5p Y2ssIG5pY2spCi0gICAgICAgIGlmIHNoZXJpZmYubmFtZSgpID09ICdXS1InOiAgIyBGb3Igc29t ZSB1bmtub3duIHJlYXNvbiwgV0tSIGNhbid0IHVzZSB0b29sLmJ1Z3MucXVpcHMoKS4KLSAgICAg ICAgICAgIHJldHVybiAiWW91J3JlIGRvaW5nIGl0IHdyb25nIgorICAgICAgICBieXBhc3NfcXVp cHMgPSBbJ1dLUicsICd3ZWJraXRib3QnXQorICAgICAgICBpZiBzaGVyaWZmLm5hbWUoKSBpbiBi eXBhc3NfcXVpcHM6ICAjIEZvciBzb21lIHVua25vd24gcmVhc29uLCBXS1Ivd2Via2l0Ym90IGNh bid0IHVzZSB0b29sLmJ1Z3MucXVpcHMoKS4KKyAgICAgICAgICAgIHJldHVybiAiJXM6IGhpICVz ISIgJSAobmljaywgbmljaykKICAgICAgICAgcXVpcHMgPSB0b29sLmJ1Z3MucXVpcHMoKQogICAg ICAgICBxdWlwcy5hcHBlbmQoJyJPbmx5IHlvdSBjYW4gcHJldmVudCBmb3Jlc3QgZmlyZXMuIiAt LSBTbW9rZXkgdGhlIEJlYXInKQogICAgICAgICByZXR1cm4gcmFuZG9tLmNob2ljZShxdWlwcykK