192054 2018-11-27 16:38:20 -0800 Modernize version checks for same site cookie support 2018-11-28 09:21:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap achristensen benjamin cdumez cmarcelo dbates dino ews-watchlist thorton webkit-bug-importer youennf oldest_to_newest 1482234 0 ap 2018-11-27 16:38:20 -0800 More bikeshedding. 1482237 1 355816 ap 2018-11-27 16:39:45 -0800 Created attachment 355816 proposed patch 1482309 2 355816 thorton 2018-11-27 18:30:37 -0800 Comment on attachment 355816 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355816&action=review This one seems reasonable. > Source/WTF/wtf/Platform.h:1384 > +/* FIXME: Should this be enabled or IOS_FAMILY, not just IOS? */ Surely, no? 1482452 3 ap 2018-11-28 09:20:29 -0800 Committed http://trac.webkit.org/r238614 > Surely, no? Seems almost certain, but I didn't feel like making a behavior change here. 1482454 4 webkit-bug-importer 2018-11-28 09:21:32 -0800 <rdar://problem/46311672> 355816 2018-11-27 16:39:45 -0800 2018-11-27 18:30:37 -0800 proposed patch VersionMacro4.txt text/plain 4443 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzg1NzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTExLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybml6ZSB2ZXJzaW9uIGNoZWNrcyBmb3Ig c2FtZSBzaXRlIGNvb2tpZSBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTIwNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE4LTExLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIE1vZGVybml6ZSB0aGUgY2hl Y2sgZm9yIGFzeW5jIF9zYXZlQ29va2llcyBleGlzdGVuY2UKSW5kZXg6IFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2 aXNpb24gMjM4NTcyKQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5 KQpAQCAtMTM4MCwzICsxMzgwLDggQEAKICNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19Y X1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQwMCkgfHwgUExBVEZPUk0oSU9TKQogI2RlZmlu ZSBIQVZFX0ZPVU5EQVRJT05fV0lUSF9TQVZFX0NPT0tJRVNfV0lUSF9DT01QTEVUSU9OX0hBTkRM RVIgMQogI2VuZGlmCisKKy8qIEZJWE1FOiBTaG91bGQgdGhpcyBiZSBlbmFibGVkIG9yIElPU19G QU1JTFksIG5vdCBqdXN0IElPUz8gKi8KKyNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19Y X1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQwMCkgfHwgUExBVEZPUk0oSU9TKQorI2RlZmlu ZSBIQVZFX0ZPVU5EQVRJT05fV0lUSF9TQU1FX1NJVEVfQ09PS0lFX1NVUFBPUlQgMQorI2VuZGlm CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODU5MSkKKysrIFNvdXJjZS9XZWJD b3JlL1BBTC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxOC0x MS0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBNb2Rl cm5pemUgdmVyc2lvbiBjaGVja3MgZm9yIHNhbWUgc2l0ZSBjb29raWUgc3VwcG9ydAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMDU0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvc3BpL2NmL0NG TmV0d29ya1NQSS5oOgorCiAyMDE4LTExLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIE1vZGVybml6ZSB0aGUgY2hlY2sgZm9yIGFzeW5jIF9zYXZlQ29v a2llcyBleGlzdGVuY2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0 d29ya1NQSS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NG TmV0d29ya1NQSS5oCShyZXZpc2lvbiAyMzg1NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9QQUwvcGFs L3NwaS9jZi9DRk5ldHdvcmtTUEkuaAkod29ya2luZyBjb3B5KQpAQCAtMjA2LDggKzIwNiwxMCBA QCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBOU1VSTFNlc3Npb25DCiAtIChOU0RpY3Rpb25h cnkgKilfdGltaW5nRGF0YTsKIEBwcm9wZXJ0eSAocmVhZHdyaXRlLCBjb3B5KSBOU1N0cmluZyAq X3BhdGhUb0Rvd25sb2FkVGFza0ZpbGU7CiBAcHJvcGVydHkgKGNvcHkpIE5TU3RyaW5nICpfc3Rv cmFnZVBhcnRpdGlvbklkZW50aWZpZXI7CisjaWYgSEFWRShGT1VOREFUSU9OX1dJVEhfU0FNRV9T SVRFX0NPT0tJRV9TVVBQT1JUKQogQHByb3BlcnR5IChudWxsYWJsZSwgcmVhZHdyaXRlLCByZXRh aW4pIE5TVVJMICpfc2l0ZUZvckNvb2tpZXM7CiBAcHJvcGVydHkgKHJlYWR3cml0ZSkgQk9PTCBf aXNUb3BMZXZlbE5hdmlnYXRpb247CisjZW5kaWYKICNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01B Q19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMCkgfHwgKFBMQVRGT1JNKElPU19G QU1JTFkpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDExMDAwMCkKIEBw cm9wZXJ0eSAobm9uYXRvbWljLCBhc3NpZ24pIEJPT0wgX3ByZWNvbm5lY3Q7CiAjZW5kaWYKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCShyZXZpc2lvbiAyMzg1ODEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTExLTI3ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybml6ZSB2ZXJzaW9uIGNoZWNr cyBmb3Igc2FtZSBzaXRlIGNvb2tpZSBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIwNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRh VGFza0NvY29hLm1tOiAoV2ViS2l0Ojp1cGRhdGVUYXNrV2l0aEZpcnN0UGFydHlGb3JTYW1lU2l0 ZUNvb2tpZXMpOgorICAgICAgICBBbHNvIHJlbW92ZWQgcnVudGltZSBjaGVja3MsIHdoaWNoIGFy ZSBubyBsb25nZXIgcmVsZXZhbnQuCisKIDIwMTgtMTEtMjcgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV0tOYXZpZ2F0aW9uLkF1dG9tYXRpY1ZpZXdS ZWxvYWRBZnRlcldlYlByb2Nlc3NDcmFzaCBhc3NlcnRzIGFmdGVyIHIyMzg1MzgKSW5kZXg6IFNv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3Jr RGF0YVRhc2tDb2NvYS5tbQkocmV2aXNpb24gMjM4NTcyKQorKysgU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQkod29ya2luZyBjb3B5KQpA QCAtMTUyLDEyICsxNTIsMTAgQEAgc3RhdGljIHZvaWQgdXBkYXRlVGFza1dpdGhGaXJzdFBhcnR5 Rm9yUwogewogICAgIGlmIChyZXF1ZXN0LmlzU2FtZVNpdGVVbnNwZWNpZmllZCgpKQogICAgICAg ICByZXR1cm47Ci0jaWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMDE0MDApIHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9P U19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDApCisjaWYgSEFWRShGT1VOREFUSU9OX1dJ VEhfU0FNRV9TSVRFX0NPT0tJRV9TVVBQT1JUKQogICAgIHN0YXRpYyBOU1VSTCAqZW1wdHlVUkwg PSBbW05TVVJMIGFsbG9jXSBpbml0V2l0aFN0cmluZzpAIiJdOwotICAgIGlmIChbdGFzayByZXNw b25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHNldF9zaXRlRm9yQ29va2llczopXSkKLSAgICAgICAg dGFzay5fc2l0ZUZvckNvb2tpZXMgPSByZXF1ZXN0LmlzU2FtZVNpdGUoKSA/IHRhc2suY3VycmVu dFJlcXVlc3QuVVJMIDogZW1wdHlVUkw7Ci0gICAgaWYgKFt0YXNrIHJlc3BvbmRzVG9TZWxlY3Rv cjpAc2VsZWN0b3Ioc2V0X2lzVG9wTGV2ZWxOYXZpZ2F0aW9uOildKQotICAgICAgICB0YXNrLl9p c1RvcExldmVsTmF2aWdhdGlvbiA9IHJlcXVlc3QuaXNUb3BTaXRlKCk7CisgICAgdGFzay5fc2l0 ZUZvckNvb2tpZXMgPSByZXF1ZXN0LmlzU2FtZVNpdGUoKSA/IHRhc2suY3VycmVudFJlcXVlc3Qu VVJMIDogZW1wdHlVUkw7CisgICAgdGFzay5faXNUb3BMZXZlbE5hdmlnYXRpb24gPSByZXF1ZXN0 LmlzVG9wU2l0ZSgpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0odGFzayk7CiAjZW5kaWYK