192046 2018-11-27 15:45:27 -0800 Remove another OS version check from NetworkDataTaskCocoa.mm 2018-11-28 09:30:01 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap achristensen beidson benjamin cdumez cmarcelo dbates dino ews-watchlist thorton webkit-bug-importer oldest_to_newest 1482181 0 ap 2018-11-27 15:45:27 -0800 More bikeshedding. 1482186 1 355799 ap 2018-11-27 15:47:22 -0800 Created attachment 355799 proposed patch 1482187 2 ap 2018-11-27 15:47:58 -0800 This also fixes the check, which should have been about SDK version, not target OS version. 1482198 3 355799 thorton 2018-11-27 16:03:56 -0800 Comment on attachment 355799 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355799&action=review > Source/WTF/wtf/Platform.h:1385 > +#define HAVE_INACCURATE_NULLABILITY_SPECIFIER_ON_NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER 1 Should we do the same thing? HAVE(NSHTTPCOOKIESTORAGE_INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY_SPECIFIER)? 1482199 4 355799 thorton 2018-11-27 16:04:21 -0800 Comment on attachment 355799 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355799&action=review >> Source/WTF/wtf/Platform.h:1385 >> +#define HAVE_INACCURATE_NULLABILITY_SPECIFIER_ON_NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER 1 > > Should we do the same thing? HAVE(NSHTTPCOOKIESTORAGE_INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY_SPECIFIER)? I ALSO THINK YOU CAN PROBABLY LEAVE OUT THE WORD SPECIFIER 1482200 5 thorton 2018-11-27 16:04:37 -0800 (because the nullability... is inaccurate) 1482212 6 355807 ap 2018-11-27 16:21:00 -0800 Created attachment 355807 proposed patch Sure thing, changed as you suggested (but keeping the double underscore) 1482339 7 355807 achristensen 2018-11-27 20:13:16 -0800 Comment on attachment 355807 proposed patch I'm not sure how this helps anything, but r=me 1482456 8 ap 2018-11-28 09:28:31 -0800 Committed http://trac.webkit.org/r238615 1482457 9 webkit-bug-importer 2018-11-28 09:30:01 -0800 <rdar://problem/46311922> 355799 2018-11-27 15:47:22 -0800 2018-11-27 16:21:00 -0800 proposed patch VersionMacro3.txt text/plain 2879 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzg1NzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTExLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBhbm90aGVyIE9TIHZlcnNpb24gY2hl Y2sgZnJvbSBOZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxOC0xMS0yNyAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm5pemUg dGhlIGNoZWNrIGZvciBhc3luYyBfc2F2ZUNvb2tpZXMgZXhpc3RlbmNlCkluZGV4OiBTb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgJKHJldmlzaW9uIDIzODU3MikKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtp bmcgY29weSkKQEAgLTEzODAsMyArMTM4MCw3IEBACiAjaWYgKFBMQVRGT1JNKE1BQykgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDApIHx8IFBMQVRGT1JNKElPUykK ICNkZWZpbmUgSEFWRV9GT1VOREFUSU9OX1dJVEhfU0FWRV9DT09LSUVTX1dJVEhfQ09NUExFVElP Tl9IQU5ETEVSIDEKICNlbmRpZgorCisjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZF UlNJT05fTUFYX0FMTE9XRUQgPCAxMDE0MDAKKyNkZWZpbmUgSEFWRV9JTkFDQ1VSQVRFX05VTExB QklMSVRZX1NQRUNJRklFUl9PTl9OU0hUVFBDT09LSUVTVE9SQUdFX19JTklUV0lUSElERU5USUZJ RVIgMQorI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjM4NTgxKQorKysgU291cmNlL1dl YktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0xMS0y NyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUg YW5vdGhlciBPUyB2ZXJzaW9uIGNoZWNrIGZyb20gTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjA0NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5l dHdvcmtEYXRhVGFza0NvY29hOjpzdGF0ZWxlc3NDb29raWVTdG9yYWdlKToKKwogMjAxOC0xMS0y NyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBXS05h dmlnYXRpb24uQXV0b21hdGljVmlld1JlbG9hZEFmdGVyV2ViUHJvY2Vzc0NyYXNoIGFzc2VydHMg YWZ0ZXIgcjIzODUzOApJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9O ZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCShyZXZpc2lvbiAyMzg1NzIp CisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0Nv Y29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsMTEgKzExNywxMSBAQCBOU0hUVFBDb29raWVT dG9yYWdlICpOZXR3b3JrRGF0YVRhc2tDb2NvCiB7CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVk PFJldGFpblB0cjxOU0hUVFBDb29raWVTdG9yYWdlPj4gc3RhdGVsZXNzQ29va2llU3RvcmFnZTsK ICAgICBpZiAoIXN0YXRlbGVzc0Nvb2tpZVN0b3JhZ2UuZ2V0KCkpIHsKLSNpZiAoUExBVEZPUk0o TUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTAxMzAwKQorI2lmIEhB VkUoSU5BQ0NVUkFURV9OVUxMQUJJTElUWV9TUEVDSUZJRVJfT05fTlNIVFRQQ09PS0lFU1RPUkFH RV9fSU5JVFdJVEhJREVOVElGSUVSKQogICAgICAgICBJR05PUkVfTlVMTF9DSEVDS19XQVJOSU5H U19CRUdJTgogI2VuZGlmCiAgICAgICAgIHN0YXRlbGVzc0Nvb2tpZVN0b3JhZ2UuZ2V0KCkgPSBh ZG9wdE5TKFtbTlNIVFRQQ29va2llU3RvcmFnZSBhbGxvY10gX2luaXRXaXRoSWRlbnRpZmllcjpu aWwgcHJpdmF0ZTpZRVNdKTsKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEIDwgMTAxMzAwKQorI2lmIEhBVkUoSU5BQ0NVUkFURV9OVUxMQUJJTElU WV9TUEVDSUZJRVJfT05fTlNIVFRQQ09PS0lFU1RPUkFHRV9fSU5JVFdJVEhJREVOVElGSUVSKQog ICAgICAgICBJR05PUkVfTlVMTF9DSEVDS19XQVJOSU5HU19FTkQKICNlbmRpZgogICAgICAgICBz dGF0ZWxlc3NDb29raWVTdG9yYWdlLmdldCgpLmdldCgpLmNvb2tpZUFjY2VwdFBvbGljeSA9IE5T SFRUUENvb2tpZUFjY2VwdFBvbGljeU5ldmVyOwo= 355807 2018-11-27 16:21:00 -0800 2018-11-27 20:13:16 -0800 proposed patch VersionMacro3.txt text/plain 2855 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzg1NzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTExLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBhbm90aGVyIE9TIHZlcnNpb24gY2hl Y2sgZnJvbSBOZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxOC0xMS0yNyAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm5pemUg dGhlIGNoZWNrIGZvciBhc3luYyBfc2F2ZUNvb2tpZXMgZXhpc3RlbmNlCkluZGV4OiBTb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgJKHJldmlzaW9uIDIzODU3MikKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtp bmcgY29weSkKQEAgLTEzODAsMyArMTM4MCw3IEBACiAjaWYgKFBMQVRGT1JNKE1BQykgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDApIHx8IFBMQVRGT1JNKElPUykK ICNkZWZpbmUgSEFWRV9GT1VOREFUSU9OX1dJVEhfU0FWRV9DT09LSUVTX1dJVEhfQ09NUExFVElP Tl9IQU5ETEVSIDEKICNlbmRpZgorCisjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZF UlNJT05fTUFYX0FMTE9XRUQgPCAxMDE0MDAKKyNkZWZpbmUgSEFWRV9OU0hUVFBDT09LSUVTVE9S QUdFX19JTklUV0lUSElERU5USUZJRVJfV0lUSF9JTkFDQ1VSQVRFX05VTExBQklMSVRZIDEKKyNl bmRpZgpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODU4MSkKKysrIFNvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTEtMjcgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFub3RoZXIg T1MgdmVyc2lvbiBjaGVjayBmcm9tIE5ldHdvcmtEYXRhVGFza0NvY29hLm1tCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIwNDYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2Nv Y29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0 YVRhc2tDb2NvYTo6c3RhdGVsZXNzQ29va2llU3RvcmFnZSk6CisKIDIwMTgtMTEtMjcgIFRpbSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV0tOYXZpZ2F0aW9u LkF1dG9tYXRpY1ZpZXdSZWxvYWRBZnRlcldlYlByb2Nlc3NDcmFzaCBhc3NlcnRzIGFmdGVyIHIy Mzg1MzgKSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0Rh dGFUYXNrQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQkocmV2aXNpb24gMjM4NTcyKQorKysgU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQko d29ya2luZyBjb3B5KQpAQCAtMTE3LDExICsxMTcsMTEgQEAgTlNIVFRQQ29va2llU3RvcmFnZSAq TmV0d29ya0RhdGFUYXNrQ29jbwogewogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxSZXRhaW5Q dHI8TlNIVFRQQ29va2llU3RvcmFnZT4+IHN0YXRlbGVzc0Nvb2tpZVN0b3JhZ2U7CiAgICAgaWYg KCFzdGF0ZWxlc3NDb29raWVTdG9yYWdlLmdldCgpKSB7Ci0jaWYgKFBMQVRGT1JNKE1BQykgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTMwMCkKKyNpZiBIQVZFKE5TSFRU UENPT0tJRVNUT1JBR0VfX0lOSVRXSVRISURFTlRJRklFUl9XSVRIX0lOQUNDVVJBVEVfTlVMTEFC SUxJVFkpCiAgICAgICAgIElHTk9SRV9OVUxMX0NIRUNLX1dBUk5JTkdTX0JFR0lOCiAjZW5kaWYK ICAgICAgICAgc3RhdGVsZXNzQ29va2llU3RvcmFnZS5nZXQoKSA9IGFkb3B0TlMoW1tOU0hUVFBD b29raWVTdG9yYWdlIGFsbG9jXSBfaW5pdFdpdGhJZGVudGlmaWVyOm5pbCBwcml2YXRlOllFU10p OwotI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQg PCAxMDEzMDApCisjaWYgSEFWRShOU0hUVFBDT09LSUVTVE9SQUdFX19JTklUV0lUSElERU5USUZJ RVJfV0lUSF9JTkFDQ1VSQVRFX05VTExBQklMSVRZKQogICAgICAgICBJR05PUkVfTlVMTF9DSEVD S19XQVJOSU5HU19FTkQKICNlbmRpZgogICAgICAgICBzdGF0ZWxlc3NDb29raWVTdG9yYWdlLmdl dCgpLmdldCgpLmNvb2tpZUFjY2VwdFBvbGljeSA9IE5TSFRUUENvb2tpZUFjY2VwdFBvbGljeU5l dmVyOwo=