192042 2018-11-27 15:08:07 -0800 [Win] listDirectory in FileSystemWin.cpp should not skip all directories 2018-11-29 18:17:34 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=56331 InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen bfulgham commit-queue don.olmstead fujii pvollan webkit-bug-importer oldest_to_newest 1482155 0 chris.reid 2018-11-27 15:08:07 -0800 ASSERT(diskUsage >= databaseFileSize); is failing in SQLiteIDBBackingStore.cpp with mozilla's indexdb demo https://mdn.mozillademos.org/en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB$samples/Full_IndexedDB_example?revision=1436833 SQLiteIDBBackingStore.cpp: > uint64_t diskUsage = 0; > for (auto& directory : FileSystem::listDirectory(m_absoluteDatabaseDirectory, "*")) { > for (auto& file : FileSystem::listDirectory(directory, "*.sqlite3"_s)) > diskUsage += SQLiteFileSystem::getDatabaseFileSize(file); > } > ASSERT(diskUsage >= databaseFileSize); FileSystem::listDirectory(m_absoluteDatabaseDirectory, "*") doesn't return anything because windows' listDirectory implementation never returns any child directories. So diskUsage is always 0 for this case. 1482201 1 355804 chris.reid 2018-11-27 16:06:22 -0800 Created attachment 355804 Patch 1482257 2 355804 don.olmstead 2018-11-27 17:05:46 -0800 Comment on attachment 355804 Patch LGTM 1482306 3 355804 bfulgham 2018-11-27 18:17:41 -0800 Comment on attachment 355804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355804&action=review > Source/WebCore/ChangeLog:8 > + Covered by existing tests. Does this allow us to unskip a test on Windows? 1482376 4 355804 fujii 2018-11-28 00:01:59 -0800 Comment on attachment 355804 Patch good catch. 1482540 5 chris.reid 2018-11-28 11:17:40 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 355804 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355804&action=review > > > Source/WebCore/ChangeLog:8 > > + Covered by existing tests. > > Does this allow us to unskip a test on Windows? It appears so, all storage tests are currently skipped on wincairo and all indexeddb tests seem to fail that assert. I believe most indexeddb tests should be passing now, I'll run through storage tests and update the expectations. 1483017 6 356021 chris.reid 2018-11-29 10:33:53 -0800 Created attachment 356021 patch 1483056 7 don.olmstead 2018-11-29 11:40:18 -0800 The WinCairo bot seems to just be in bad shape. Guessing you compiled on wincairo so we can assume all is well. 1483097 8 chris.reid 2018-11-29 12:43:25 -0800 (In reply to Don Olmstead from comment #7) > The WinCairo bot seems to just be in bad shape. Guessing you compiled on > wincairo so we can assume all is well. > "bin64\WebKitTestRunner.exe". The process cannot access the file because it is being used by another process Yeah, I'm not sure why WebKitTestRunner.exe would be in use on wincairo EWS 1483337 9 356021 commit-queue 2018-11-29 18:16:26 -0800 Comment on attachment 356021 patch Clearing flags on attachment: 356021 Committed r238723: <https://trac.webkit.org/changeset/238723> 1483338 10 commit-queue 2018-11-29 18:16:28 -0800 All reviewed patches have been landed. Closing bug. 1483339 11 webkit-bug-importer 2018-11-29 18:17:34 -0800 <rdar://problem/46361645> 355804 2018-11-27 16:06:22 -0800 2018-11-29 10:33:53 -0800 Patch 192042.diff text/plain 1747 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYWVkODc3NzFjMi4uMmQwOTYxYWZlZmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0xMS0yNyAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW1dpbl0gbGlzdERpcmVjdG9yeSBpbiBGaWxlU3lzdGVtV2luLmNw cCBzaG91bGQgbm90IHNraXAgYWxsIGRpcmVjdG9yaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIwNDIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLiAKKwor ICAgICAgICBDaGFuZ2UgbGlzdERpcmVjdG9yeSBpbiBGaWxlU3lzdGVtV2luIHRvIG1hdGNoIEZp bGVTeXN0ZW1QT1NJWCdzIGJlaGF2aW9yLgorICAgICAgICBsaXN0RGlyZWN0b3J5IHNob3VsZCBv bmx5IHNraXAgdGhlIGN1cnJlbnQgYW5kIHByZXZpb3VzIGRpcmVjdG9yaWVzLgorCisgICAgICAg IGxpc3REaXJlY3RvcnkgaXMgbm90IHJldHVybmluZyBhbnkgY2hpbGQgZGlyZWN0b3JpZXMgd2hp Y2ggaXMgY2F1c2luZworICAgICAgICBBU1NFUlQoZGlza1VzYWdlID49IGRhdGFiYXNlRmlsZVNp emUpIGluIFNRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAgdG8gZmFpbC4KKworICAgICAgICAqIHBs YXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcDoKKwogMjAxOC0xMS0xOSAgRnVqaWkgSGlyb25v cmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyMzgz NTApIFtjdXJsXSBDZXJ0aWZpY2F0ZUluZm8uaDogZXJyb3I6IHRlbXBsYXRlIHNwZWNpYWxpemF0 aW9uIHJlcXVpcmVzICd0ZW1wbGF0ZTw+JwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2lu L0ZpbGVTeXN0ZW1XaW4uY3BwCmluZGV4IDc4ZDU2ZTc5NWQxLi40OWZhMTQ0MTJhOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcApAQCAtNTIzLDcg KzUyMyw4IEBAIFZlY3RvcjxTdHJpbmc+IGxpc3REaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBkaXJl Y3RvcnksIGNvbnN0IFN0cmluZyYgZmlsdGVyKQogICAgICAgICByZXR1cm4gZW50cmllczsKIAog ICAgIGRvIHsKLSAgICAgICAgaWYgKHdhbGtlci5kYXRhKCkuZHdGaWxlQXR0cmlidXRlcyAmIEZJ TEVfQVRUUklCVVRFX0RJUkVDVE9SWSkKKyAgICAgICAgaWYgKHdhbGtlci5kYXRhKCkuZHdGaWxl QXR0cmlidXRlcyAmIEZJTEVfQVRUUklCVVRFX0RJUkVDVE9SWQorICAgICAgICAgICAgJiYgKCF3 Y3NjbXAod2Fsa2VyLmRhdGEoKS5jRmlsZU5hbWUsIEwiLiIpIHx8ICF3Y3NjbXAod2Fsa2VyLmRh dGEoKS5jRmlsZU5hbWUsIEwiLi4iKSkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAg ICBlbnRyaWVzLmFwcGVuZChkaXJlY3RvcnkgKyAiXFwiICsgcmVpbnRlcnByZXRfY2FzdDxjb25z dCBVQ2hhcio+KHdhbGtlci5kYXRhKCkuY0ZpbGVOYW1lKSk7Cg== 356021 2018-11-29 10:33:53 -0800 2018-11-29 18:16:26 -0800 patch 192042-2.diff text/plain 6336 chris.reid ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOThmYmEyZWQ2Ny4uN2Y3NWMwOTQyM2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOC0xMS0yOSAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CisKKyAg ICAgICAgW1dpbl0gbGlzdERpcmVjdG9yeSBpbiBGaWxlU3lzdGVtV2luLmNwcCBzaG91bGQgbm90 IHNraXAgYWxsIGRpcmVjdG9yaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTIwNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFbmFibGUgc3RvcmFnZSB0ZXN0cyBvbiBXaW5DYWlybyBhbmQgYWRkaW5n IGluaXRpYWwgdGVzdCBleHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW5jYWly by9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE4LTExLTE5ICBKdXN0aW4gRmFuICA8anVzdGluX2Zh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdQVV0gQmVnaW4gaW1wbGVtZW50aW5nIFdlYkdQ VVRleHR1cmUsIFdlYkdQVVRleHR1cmVWaWV3LCBhbmQgV2ViR1BVVGV4dHVyZUZvcm1hdEVudW0s IGFuZCBXZWJHUFVTd2FwQ2hhaW46OmNvbmZpZ3VyZSB1cGdyYWRlcwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd2luY2Fpcm8vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggM2E0MTRjMzM2YjEuLmE2 ZTQ3MjRkZDlmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW5jYWlyby9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTE2OTcsNiArMTY5Nyw2MiBAQCBlZGl0aW5nL3VuZG8vdW5kby1kZWxldGVX b3JkLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjICAg RW5kIEVkaXRpbmcgRmFpbHVyZXMgICAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKICMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjCiAKKyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCisjIyMjIyMjIyMj IyMjIyMjIyMjIyMjICAgICAgICBTdG9yYWdlIElzc3VlcyAgICAgICAgICAgICAgIyMjIyMjIyMj IyMjIyMjIyMjIyMjIworIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKKworIyBUT0RPIFRoZXNlIHRl c3RzIGZhaWx1cmVzIG5lZWQgdG8gYmUgaW52ZXN0aWdhdGVkCisKKyMgVGV4dCBkaWZmIGZhaWx1 cmVzCitzdG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL2Jsb2NrZWQtZmlsZS1hY2Nlc3Mu aHRtbCBbIEZhaWx1cmUgXQorc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2RhdGUtYmFzaWMtcHJp dmF0ZS5odG1sIFsgRmFpbHVyZSBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vZGF0ZS1iYXNp Yy5odG1sIFsgRmFpbHVyZSBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vZ2V0LWtleXJhbmdl LXByaXZhdGUuaHRtbCBbIEZhaWx1cmUgXQorc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2dldC1r ZXlyYW5nZS5odG1sIFsgRmFpbHVyZSBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRib2Jq ZWN0c3RvcmUtZGVsZXRlLTEtcHJpdmF0ZS5odG1sIFsgRmFpbHVyZSBdCitzdG9yYWdlL2luZGV4 ZWRkYi9tb2Rlcm4vaWRib2JqZWN0c3RvcmUtZGVsZXRlLTEuaHRtbCBbIEZhaWx1cmUgXQorc3Rv cmFnZS9pbmRleGVkZGIvd2FzbS1leGNlcHRpb25zLmh0bWwgWyBGYWlsdXJlIF0KKworIyBUT0RP IEV4Y2x1ZGUgV2ViU1FMIHRlc3RzOgord2Via2l0Lm9yZy9iLzExNjU1OSBzdG9yYWdlL3dlYnNx bC8gWyBTa2lwIF0KKworIyBDcmFzaGluZyBpbmRleGVkZGIgdGVzdHMKK3N0b3JhZ2UvaW5kZXhl ZGRiL21vZGVybi9hdXRvaW5jcmVtZW50LWFib3J0Lmh0bWwgWyBDcmFzaCBQYXNzIF0KK3N0b3Jh Z2UvaW5kZXhlZGRiL21vZGVybi9tdWx0aXBsZS1vYmplY3RzdG9yZS1pbmRleC1jdXJzb3ItY29s bGlzaW9uLmh0bWwgWyBDcmFzaCBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9vYmpl Y3RzdG9yZS1jdXJzb3ItYWR2YW5jZS1mYWlsdXJlcy1wcml2YXRlLmh0bWwgWyBDcmFzaCBQYXNz IF0KK3N0b3JhZ2UvaW5kZXhlZGRiL2ludmFsaWQta2V5cy5odG1sIFsgQ3Jhc2ggUGFzcyBdCitz dG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRib2JqZWN0c3RvcmUtZ2V0LWZhaWx1cmVzLmh0bWwg WyBDcmFzaCBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi93b3JrZXJzLWRpc2FibGVk Lmh0bWwgWyBDcmFzaCBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi93b3JrZXJzLWVu YWJsZS5odG1sIFsgQ3Jhc2ggIFBhc3MgXQorWyBEZWJ1ZyBdIHN0b3JhZ2UvaW5kZXhlZGRiL2tl eS10eXBlLWFycmF5LXByaXZhdGUuaHRtbCBbIENyYXNoIF0KK1sgRGVidWcgXSBzdG9yYWdlL2lu ZGV4ZWRkYi9rZXktdHlwZS1hcnJheS5odG1sIFsgQ3Jhc2ggXQorCisjIEZsYWt5IHRpbWVvdXRz CitzdG9yYWdlL2luZGV4ZWRkYi9jbG9uZS1leGNlcHRpb24uaHRtbCBbIFRpbWVvdXQgUGFzcyBd CitzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vb2JqZWN0c3RvcmUtcmVuYW1lLTEuaHRtbCBbIFRp bWVvdXQgUGFzcyBdCitzdG9yYWdlL3dlYnNxbC9vcGVuLWRhdGFiYXNlLWNyZWF0aW9uLWNhbGxi YWNrLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQorc3RvcmFnZS93ZWJzcWwvc3RhdGVtZW50LWVycm9y LWNhbGxiYWNrLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQorc3RvcmFnZS93ZWJzcWwvdHJhbnNhY3Rp b24tZXJyb3ItY2FsbGJhY2staXNvbGF0ZWQtd29ybGQuaHRtbCBbIFRpbWVvdXQgUGFzcyBdCitz dG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vYWJvcnRlZC1wdXQuaHRtbCBbIFRpbWVvdXQgUGFzcyBd CisKKyMgRmxha3kgdGVzdHMKK3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9sZWFrLTEuaHRtbCBb IFNraXAgXQorc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2luZGV4LXJlbmFtZS0xLmh0bWwgWyBT a2lwIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy5odG1sIFsgU2tpcCBd CitzdG9yYWdlL2luZGV4ZWRkYi9vYmplY3RzdG9yZS1iYXNpY3Mtd29ya2Vycy5odG1sIFsgU2tp cCBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRidHJhbnNhY3Rpb24tb2JqZWN0c3RvcmUt ZmFpbHVyZXMuaHRtbCBbIFNraXAgXQorc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2lkYnRyYW5z YWN0aW9uLW9iamVjdHN0b3JlLWZhaWx1cmVzLXByaXZhdGUuaHRtbCBbIFNraXAgXQorc3RvcmFn ZS9pbmRleGVkZGIvbWV0YWRhdGEuaHRtbCBbIFNraXAgXQorc3RvcmFnZS9pbmRleGVkZGIvZGF0 YWJhc2Utb2RkLW5hbWVzLmh0bWwgWyBTa2lwIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL2xhenktaW5k ZXgtcG9wdWxhdGlvbi5odG1sIFsgU2tpcCBdCitzdG9yYWdlL2luZGV4ZWRkYi90cmFuc2FjdGlv bi1iYXNpY3MuaHRtbCBbIFNraXAgXQorc3RvcmFnZS9pbmRleGVkZGIvaW50dmVyc2lvbi1yZXZl cnQtb24tYWJvcnQuaHRtbCBbIFNraXAgXQorc3RvcmFnZS9pbmRleGVkZGIvdmVyc2lvbi1jaGFu Z2UtYWJvcnQuaHRtbCBbIFNraXAgXQorCisjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIworIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjICAgRW5kIFN0b3JhZ2UgSXNzdWVzcyAgICMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMKKyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCisKICMvLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgVEVNUE9SQVJZIFNLSVBTIC0tIHRoZXNlIGFyZWFz IHN0aWxsIG5lZWQgdG8gYmUgYWRkcmVzc2VkIGluZGl2aWR1YWxseQogIy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLwpAQCAtMTc4NSw3ICsxODQxLDYgQEAgc2Nyb2xsYmFycyBbIFNr aXAgXQogc2Nyb2xsaW5nY29vcmRpbmF0b3IgWyBTa2lwIF0KIHNlY3VyaXR5IFsgU2tpcCBdCiBz cHV0bmlrIFsgU2tpcCBdCi1zdG9yYWdlIFsgU2tpcCBdCiBzdmcgWyBTa2lwIF0KIHRhYmxlcyBb IFNraXAgXQogdHJhbnNpdGlvbnMgWyBTa2lwIF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYWVkODc3NzFjMi4u NGUzY2I4ZTg1MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxOC0xMS0yNyAgQ2hy aXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gbGlz dERpcmVjdG9yeSBpbiBGaWxlU3lzdGVtV2luLmNwcCBzaG91bGQgbm90IHNraXAgYWxsIGRpcmVj dG9yaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTIwNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIGxpc3REaXJlY3RvcnkgaXMgbm90 IHJldHVybmluZyBhbnkgY2hpbGQgZGlyZWN0b3JpZXMgd2hpY2ggaXMgY2F1c2luZworICAgICAg ICBBU1NFUlQoZGlza1VzYWdlID49IGRhdGFiYXNlRmlsZVNpemUpIGluIFNRTGl0ZUlEQkJhY2tp bmdTdG9yZS5jcHAgdG8gZmFpbC4KKworICAgICAgICBDaGFuZ2UgbGlzdERpcmVjdG9yeSBpbiBG aWxlU3lzdGVtV2luIHRvIG1hdGNoIEZpbGVTeXN0ZW1QT1NJWCdzIGJlaGF2aW9yLgorICAgICAg ICBsaXN0RGlyZWN0b3J5IHNob3VsZCBvbmx5IHNraXAgdGhlIGN1cnJlbnQgYW5kIHByZXZpb3Vz IGRpcmVjdG9yaWVzLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3Bw OgorCiAyMDE4LTExLTE5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIzODM1MCkgW2N1cmxdIENlcnRpZmljYXRlSW5mby5o OiBlcnJvcjogdGVtcGxhdGUgc3BlY2lhbGl6YXRpb24gcmVxdWlyZXMgJ3RlbXBsYXRlPD4nCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKaW5kZXggNzhk NTZlNzk1ZDEuLjQ5ZmExNDQxMmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2lu L0ZpbGVTeXN0ZW1XaW4uY3BwCkBAIC01MjMsNyArNTIzLDggQEAgVmVjdG9yPFN0cmluZz4gbGlz dERpcmVjdG9yeShjb25zdCBTdHJpbmcmIGRpcmVjdG9yeSwgY29uc3QgU3RyaW5nJiBmaWx0ZXIp CiAgICAgICAgIHJldHVybiBlbnRyaWVzOwogCiAgICAgZG8gewotICAgICAgICBpZiAod2Fsa2Vy LmRhdGEoKS5kd0ZpbGVBdHRyaWJ1dGVzICYgRklMRV9BVFRSSUJVVEVfRElSRUNUT1JZKQorICAg ICAgICBpZiAod2Fsa2VyLmRhdGEoKS5kd0ZpbGVBdHRyaWJ1dGVzICYgRklMRV9BVFRSSUJVVEVf RElSRUNUT1JZCisgICAgICAgICAgICAmJiAoIXdjc2NtcCh3YWxrZXIuZGF0YSgpLmNGaWxlTmFt ZSwgTCIuIikgfHwgIXdjc2NtcCh3YWxrZXIuZGF0YSgpLmNGaWxlTmFtZSwgTCIuLiIpKSkKICAg ICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGVudHJpZXMuYXBwZW5kKGRpcmVjdG9yeSAr ICJcXCIgKyByZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4od2Fsa2VyLmRhdGEoKS5jRmls ZU5hbWUpKTsK