19204 2008-05-22 22:56:19 -0700 Inspector should highlight source lines when following links to them 2008-05-22 23:10:52 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben aroben timothy oldest_to_newest 81271 0 aroben 2008-05-22 22:56:19 -0700 The Inspector should highlight source lines when following links to them. This would make it much easier to spot the line in question. 81272 1 21308 aroben 2008-05-22 23:01:04 -0700 Created attachment 21308 patch v1 + ChangeLog 81273 2 aroben 2008-05-22 23:10:52 -0700 Committed in r34055 21308 2008-05-22 23:01:04 -0700 2008-05-22 23:02:47 -0700 patch v1 + ChangeLog 0001--Fix-Bug-19204-Inspector-should-highlight-so.patch text/plain 6460 aroben RnJvbSBiNjE4MjRjZDU0YmFjZDhjOTAzN2M2YTlmMmNmMTFjMmU5ZmMyNDQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBU aHUsIDIyIE1heSAyMDA4IDIzOjAyOjQ0IC0wNzAwClN1YmplY3Q6IFtQRlJdICAgICAgICAgRml4 IEJ1ZyAxOTIwNDogSW5zcGVjdG9yIHNob3VsZCBoaWdobGlnaHQgc291cmNlIGxpbmVzIHdoZW4g Zm9sbG93aW5nIGxpbmtzIHRvIHRoZW0KCiAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTIwND4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgIFRlc3Q6IG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvaGlnaGxpZ2h0LXNvdXJj ZS1saW5lLmh0bWwKCiAgICAgICAgKiBtYW51YWwtdGVzdHMvaW5zcGVjdG9yL2hpZ2hsaWdodC1z b3VyY2UtbGluZS5odG1sOiBBZGRlZC4KICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL1Jlc291cmNl c1BhbmVsLmpzOgogICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90eXBl LnNob3dSZXNvdXJjZSk6IENhbGwKICAgICAgICBoaWdobGlnaHRMaW5lIG9uIHRoZSB2aWV3IGlm IHRoYXQgZnVuY3Rpb24gZXhpc3RzLgogICAgICAgICogcGFnZS9pbnNwZWN0b3IvU291cmNlRnJh bWUuanM6CiAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuaGlnaGxp Z2h0TGluZSk6IEFkZGVkLiBBZGRzIHRoZQogICAgICAgIHdlYmtpdC1oaWdobGlnaHRlZC1saW5l IGNsYXNzIHRvIHRoZSByZWxldmFudCBsaW5lLCB0aGVuIHJlbW92ZXMgaXQKICAgICAgICBhZnRl ciBhIHNob3J0IGRlbGF5LgogICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90 eXBlLl9sb2FkZWQpOiBBZGRlZCBzdHlsZXMgZm9yIHRoZQogICAgICAgIGhpZ2hsaWdodGVkIGxp bmUocykuCiAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9Tb3VyY2VWaWV3LmpzOgogICAgICAgIChX ZWJJbnNwZWN0b3IuU291cmNlVmlldy5wcm90b3R5cGUuaGlnaGxpZ2h0TGluZSk6IEFkZGVkLiBD YWxscwogICAgICAgIHRocm91Z2ggdG8gdGhlIFNvdXJjZUZyYW1lLgotLS0KIFdlYkNvcmUvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyNSArKysrKysrKysr KysrKysrKysrKwogLi4uL2luc3BlY3Rvci9oaWdobGlnaHQtc291cmNlLWxpbmUuaHRtbCAgICAg ICAgICAgfCAgICA0ICsrKwogV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9SZXNvdXJjZXNQYW5lbC5q cyAgICAgICAgICAgfCAgICA4ICsrKystCiBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1NvdXJjZUZy YW1lLmpzICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysKIFdlYkNvcmUvcGFnZS9pbnNwZWN0 b3IvU291cmNlVmlldy5qcyAgICAgICAgICAgICAgIHwgICAgNiArKysrCiA1IGZpbGVzIGNoYW5n ZWQsIDUyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQg V2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2hpZ2hsaWdodC1zb3VyY2UtbGluZS5odG1s CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBiNjE4MmI5Li5jOTkzMWRlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDA4LTA1LTIyICBBZGFtIFJvYmVu ICA8YXJvYmVuQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggQnVnIDE5MjA0OiBJbnNwZWN0b3Ig c2hvdWxkIGhpZ2hsaWdodCBzb3VyY2UgbGluZXMgd2hlbiBmb2xsb3dpbmcKKyAgICAgICAgbGlu a3MgdG8gdGhlbQorCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkyMDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGVzdDogbWFudWFsLXRlc3RzL2luc3BlY3Rvci9oaWdobGlnaHQtc291cmNlLWxpbmUu aHRtbAorCisgICAgICAgICogbWFudWFsLXRlc3RzL2luc3BlY3Rvci9oaWdobGlnaHQtc291cmNl LWxpbmUuaHRtbDogQWRkZWQuCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvUmVzb3VyY2VzUGFu ZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90eXBlLnNo b3dSZXNvdXJjZSk6IENhbGwKKyAgICAgICAgaGlnaGxpZ2h0TGluZSBvbiB0aGUgdmlldyBpZiB0 aGF0IGZ1bmN0aW9uIGV4aXN0cy4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9Tb3VyY2VGcmFt ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuaGlnaGxp Z2h0TGluZSk6IEFkZGVkLiBBZGRzIHRoZQorICAgICAgICB3ZWJraXQtaGlnaGxpZ2h0ZWQtbGlu ZSBjbGFzcyB0byB0aGUgcmVsZXZhbnQgbGluZSwgdGhlbiByZW1vdmVzIGl0CisgICAgICAgIGFm dGVyIGEgc2hvcnQgZGVsYXkuCisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJv dG90eXBlLl9sb2FkZWQpOiBBZGRlZCBzdHlsZXMgZm9yIHRoZQorICAgICAgICBoaWdobGlnaHRl ZCBsaW5lKHMpLgorICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL1NvdXJjZVZpZXcuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU291cmNlVmlldy5wcm90b3R5cGUuaGlnaGxpZ2h0TGluZSk6IEFk ZGVkLiBDYWxscworICAgICAgICB0aHJvdWdoIHRvIHRoZSBTb3VyY2VGcmFtZS4KKworMjAwOC0w NS0yMiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGEgdGVz dCBmb3IgY2FsbGluZyBhIE5vZGVMaXN0IGFzIGEgZnVuY3Rpb24gd2hpbGUgcHJvZmlsaW5nCiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgS2V2aW4gTWNDdWxsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9oaWdobGlnaHQtc291cmNlLWxpbmUuaHRtbCBiL1dl YkNvcmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9oaWdobGlnaHQtc291cmNlLWxpbmUuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yNTIwNDg1Ci0tLSAvZGV2L251bGwK KysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2hpZ2hsaWdodC1zb3VyY2UtbGlu ZS5odG1sCkBAIC0wLDAgKzEsNCBAQAorPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjA0Ij5CdWcgMTkyMDQ6IEluc3BlY3RvciBz aG91bGQgaGlnaGxpZ2h0IHNvdXJjZSBsaW5lcyB3aGVuIGZvbGxvd2luZyBsaW5rcyB0byB0aGVt PC9hPi48L3A+Cis8cD5UbyB0ZXN0LCBvcGVuIHRoZSBJbnNwZWN0b3IgYW5kIHJlbG9hZCB0aGlz IHBhZ2UuIFRoZW4gb3BlbiB0aGUgSW5zcGVjdG9yJ3MgQ29uc29sZSBhbmQgY2xpY2sgdGhlIGxp bmsgZm9yIHRoZSBtYXJrdXAgZXJyb3IuIFlvdSBzaG91bGQgc2VlIHRoZSBsaW5lIGNvbnRhaW5p bmcgdGhlIGVycm9yIGJyaWVmbHkgaGlnaGxpZ2h0ZWQgaW4gdGhlIHNvdXJjZSB2aWV3LjwvcD4K KworPHA+VGhpcyBsaW5lIGNvbnRhaW5zIGEgbWFya3VwIGVycm9yPC9pPi48L3A+CmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1Jlc291cmNlc1BhbmVsLmpzIGIvV2ViQ29yZS9w YWdlL2luc3BlY3Rvci9SZXNvdXJjZXNQYW5lbC5qcwppbmRleCAzZDYzZDliLi4xMTRlM2RiIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1Jlc291cmNlc1BhbmVsLmpzCisrKyBi L1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvUmVzb3VyY2VzUGFuZWwuanMKQEAgLTQyOCw4ICs0Mjgs MTIgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAg dmlldy5oZWFkZXJzVmlzaWJsZSA9IHRydWU7CiAgICAgICAgIHZpZXcuc2hvdyh0aGlzLnJlc291 cmNlVmlld3MpOwogCi0gICAgICAgIGlmIChsaW5lICYmIHZpZXcucmV2ZWFsTGluZSkKLSAgICAg ICAgICAgIHZpZXcucmV2ZWFsTGluZShsaW5lKTsKKyAgICAgICAgaWYgKGxpbmUpIHsKKyAgICAg ICAgICAgIGlmICh2aWV3LnJldmVhbExpbmUpCisgICAgICAgICAgICAgICAgdmlldy5yZXZlYWxM aW5lKGxpbmUpOworICAgICAgICAgICAgaWYgKHZpZXcuaGlnaGxpZ2h0TGluZSkKKyAgICAgICAg ICAgICAgICB2aWV3LmhpZ2hsaWdodExpbmUobGluZSk7CisgICAgICAgIH0KIAogICAgICAgICBp ZiAocmVzb3VyY2UuX3Jlc291cmNlc1RyZWVFbGVtZW50KSB7CiAgICAgICAgICAgICByZXNvdXJj ZS5fcmVzb3VyY2VzVHJlZUVsZW1lbnQucmV2ZWFsKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bh Z2UvaW5zcGVjdG9yL1NvdXJjZUZyYW1lLmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9Tb3Vy Y2VGcmFtZS5qcwppbmRleCBmMzJiOTQyLi44YmViNWNmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bh Z2UvaW5zcGVjdG9yL1NvdXJjZUZyYW1lLmpzCisrKyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3Iv U291cmNlRnJhbWUuanMKQEAgLTE2NCw2ICsxNjQsMTUgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZy YW1lLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKKyAgICBoaWdobGlnaHRMaW5l OiBmdW5jdGlvbihsaW5lTnVtYmVyKQorICAgIHsKKyAgICAgICAgdmFyIHNvdXJjZVJvdyA9IHRo aXMuc291cmNlUm93KGxpbmVOdW1iZXIpOworICAgICAgICBpZiAoIXNvdXJjZVJvdykKKyAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgc291cmNlUm93LmFkZFN0eWxlQ2xhc3MoIndlYmtpdC1o aWdobGlnaHRlZC1saW5lIik7CisgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7IHNvdXJj ZVJvdy5yZW1vdmVTdHlsZUNsYXNzKCJ3ZWJraXQtaGlnaGxpZ2h0ZWQtbGluZSIpIH0sIDMwMCk7 CisgICAgfSwKKwogICAgIF9sb2FkZWQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIFdlYklu c3BlY3Rvci5hZGRNYWluRXZlbnRMaXN0ZW5lcnModGhpcy5lbGVtZW50LmNvbnRlbnREb2N1bWVu dCk7CkBAIC0xODgsNiArMTk3LDggQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlw ZSA9IHsKICAgICAgICAgc3R5bGVUZXh0ICs9ICIud2Via2l0LWJyZWFrcG9pbnQtZGlzYWJsZWQu d2Via2l0LWV4ZWN1dGlvbi1saW5lIC53ZWJraXQtbGluZS1udW1iZXIgeyBjb2xvcjogdHJhbnNw YXJlbnQ7IGJhY2tncm91bmQtaW1hZ2U6IC13ZWJraXQtY2FudmFzKGJyZWFrcG9pbnQtZGlzYWJs ZWQtcHJvZ3JhbS1jb3VudGVyKTsgfVxuIjsKICAgICAgICAgc3R5bGVUZXh0ICs9ICIud2Via2l0 LWV4ZWN1dGlvbi1saW5lIC53ZWJraXQtbGluZS1jb250ZW50IHsgYmFja2dyb3VuZC1jb2xvcjog cmdiKDE3MSwgMTkxLCAyNTQpOyBvdXRsaW5lOiAxcHggc29saWQgcmdiKDY0LCAxMTUsIDI0NCk7 IH1cbiI7CiAgICAgICAgIHN0eWxlVGV4dCArPSAiLndlYmtpdC1oZWlnaHQtc2l6ZWQtdG8tZml0 IHsgb3ZlcmZsb3cteTogaGlkZGVuIH1cbiI7CisgICAgICAgIHN0eWxlVGV4dCArPSAiLndlYmtp dC1saW5lLWNvbnRlbnQgeyBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsgfVxuIjsKKyAgICAgICAg c3R5bGVUZXh0ICs9ICIud2Via2l0LWhpZ2hsaWdodGVkLWxpbmUgLndlYmtpdC1saW5lLWNvbnRl bnQgeyBiYWNrZ3JvdW5kLWNvbG9yOiByZ2IoMjU1LCAyNTUsIDEyMCk7IC13ZWJraXQtdHJhbnNp dGlvbi1wcm9wZXJ0eTogYmFja2dyb3VuZC1jb2xvcjsgLXdlYmtpdC10cmFuc2l0aW9uLWR1cmF0 aW9uOiAxczsgfVxuIjsKIAogICAgICAgICBzdHlsZUVsZW1lbnQudGV4dENvbnRlbnQgPSBzdHls ZVRleHQ7CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU291cmNlVmlldy5q cyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU291cmNlVmlldy5qcwppbmRleCBhY2IyYTFlLi43 ZDA2MzE4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1NvdXJjZVZpZXcuanMK KysrIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9Tb3VyY2VWaWV3LmpzCkBAIC04OSw2ICs4OSwx MiBAQCBXZWJJbnNwZWN0b3IuU291cmNlVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMu c291cmNlRnJhbWUucmV2ZWFsTGluZShsaW5lTnVtYmVyKTsKICAgICB9LAogCisgICAgaGlnaGxp Z2h0TGluZTogZnVuY3Rpb24obGluZU51bWJlcikKKyAgICB7CisgICAgICAgIHRoaXMuc2V0dXBT b3VyY2VGcmFtZUlmTmVlZGVkKCk7CisgICAgICAgIHRoaXMuc291cmNlRnJhbWUuaGlnaGxpZ2h0 TGluZShsaW5lTnVtYmVyKTsKKyAgICB9LAorCiAgICAgYWRkTWVzc2FnZTogZnVuY3Rpb24obXNn KQogICAgIHsKICAgICAgICAgdGhpcy5zb3VyY2VGcmFtZS5hZGRNZXNzYWdlKG1zZyk7Ci0tIAox LjUuNC40LjUzNy5nYjc1YWEKCg==