192033 2018-11-27 13:42:35 -0800 r238510 broke scopes of size zero 2018-11-28 08:54:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191958 InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff rmorisset ryanhaddad ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1482085 0 saam 2018-11-27 13:42:35 -0800 Because maxScopeOffset() for the SymbolTable will be UINT_MAX, this loop runs for UINT_MAX iterations: for (ScopeOffset offset { 0 }; offset <= symbolTable->maxScopeOffset(); offset += 1) { ... } 1482086 1 saam 2018-11-27 13:44:58 -0800 <rdar://problem/46281734> 1482095 2 355773 saam 2018-11-27 13:51:58 -0800 Created attachment 355773 patch 1482098 3 keith_miller 2018-11-27 13:56:05 -0800 r=me. 1482297 4 355773 commit-queue 2018-11-27 18:03:29 -0800 Comment on attachment 355773 patch Clearing flags on attachment: 355773 Committed r238596: <https://trac.webkit.org/changeset/238596> 1482298 5 commit-queue 2018-11-27 18:03:31 -0800 All reviewed patches have been landed. Closing bug. 1482440 6 ryanhaddad 2018-11-28 08:54:41 -0800 *** Bug 192015 has been marked as a duplicate of this bug. *** 355773 2018-11-27 13:51:58 -0800 2018-11-27 18:03:29 -0800 patch a-backup.diff text/plain 2932 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzg1NzMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTExLTI3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIHIyMzg1MTAgYnJva2Ugc2NvcGVzIG9mIHNpemUgemVybworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMDMzCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80NjI4MTczND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9yMjM4NTEwLWJhZC1sb29wLmpzOiBBZGRlZC4K KyAgICAgICAgKGZvbyk6CisKIDIwMTgtMTEtMjcgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzODUwOS4KSW5k ZXg6IEpTVGVzdHMvc3RyZXNzL3IyMzg1MTAtYmFkLWxvb3AuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9zdHJlc3MvcjIzODUxMC1iYWQtbG9vcC5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3Rz L3N0cmVzcy9yMjM4NTEwLWJhZC1sb29wLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAg QEAKK2Z1bmN0aW9uIGZvbygpIHsKKyAgICByZXR1cm4gZnVuY3Rpb24gKCkgeworICAgICAgICBl dmFsKCk7CisgICAgfQorfQorbm9JbmxpbmUoZm9vKTsKKworZm9yIChsZXQgaSA9IDA7IGkgPCAx MDAwMDA7ICsraSkgeworICAgIGZvbygpOyAgICAKK30KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gMjM4NTY1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTExLTI3ICBTYWFtIGJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIHIyMzg1MTAgYnJva2Ugc2NvcGVzIG9m IHNpemUgemVybworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkyMDMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjI4MTczND4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjM4NTEwLCBJIHdyb3Rl IHRoZSBsb29wIGxpa2UgdGhpczogCisgICAgICAgIGBmb3IgKFNjb3BlT2Zmc2V0IG9mZnNldCB7 IDAgfTsgb2Zmc2V0IDw9IHN5bWJvbFRhYmxlLT5tYXhTY29wZU9mZnNldCgpOyBvZmZzZXQgKz0g MSlgCisgICAgICAgIAorICAgICAgICBUaGlzIGJyZWFrcyBmb3Igc2NvcGVzIG9mIHNpemUgemVy byBiZWNhdXNlIG1heFNjb3BlT2Zmc2V0KCkgd2lsbCBiZSBVSU5UX01BWC4KKyAgICAgICAgCisg ICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBieSB3cml0aW5nIHRoZSBsb29wIGFzOgorICAg ICAgICBgZm9yICh1bnNpZ25lZCBvZmZzZXQgPSAwOyBvZmZzZXQgPCBzeW1ib2xUYWJsZS0+c2Nv cGVTaXplKCk7ICsrb2Zmc2V0KWAKKworICAgICAgICAqIGRmZy9ERkdPYmplY3RBbGxvY2F0aW9u U2lua2luZ1BoYXNlLmNwcDoKKwogMjAxOC0xMS0yNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBs ZS5jb20+CiAKICAgICAgICAgSW50cm9kdWNpbmcgYSBFTkFCTEVfU0VQQVJBVEVEX1dYX0hFQVAg bWFjcm8uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRp b25TaW5raW5nUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAJKHJldmlzaW9uIDIzODU2NSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQ aGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg3OCw5ICs4NzgsOSBAQCBwcml2YXRlOgogICAg ICAgICAgICAgewogICAgICAgICAgICAgICAgIFN5bWJvbFRhYmxlKiBzeW1ib2xUYWJsZSA9IG5v ZGUtPmNhc3RPcGVyYW5kPFN5bWJvbFRhYmxlKj4oKTsKICAgICAgICAgICAgICAgICBMYXp5Tm9k ZSBpbml0aWFsVmFsdWUobV9ncmFwaC5mcmVlemUobm9kZS0+aW5pdGlhbGl6YXRpb25WYWx1ZUZv ckFjdGl2YXRpb24oKSkpOwotICAgICAgICAgICAgICAgIGZvciAoU2NvcGVPZmZzZXQgb2Zmc2V0 IHsgMCB9OyBvZmZzZXQgPD0gc3ltYm9sVGFibGUtPm1heFNjb3BlT2Zmc2V0KCk7IG9mZnNldCAr PSAxKSB7CisgICAgICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBvZmZzZXQgPSAwOyBvZmZzZXQg PCBzeW1ib2xUYWJsZS0+c2NvcGVTaXplKCk7ICsrb2Zmc2V0KSB7CiAgICAgICAgICAgICAgICAg ICAgIHdyaXRlcy5hZGQoCi0gICAgICAgICAgICAgICAgICAgICAgICBQcm9tb3RlZExvY2F0aW9u RGVzY3JpcHRvcihDbG9zdXJlVmFyUExvYywgb2Zmc2V0Lm9mZnNldCgpKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgIFByb21vdGVkTG9jYXRpb25EZXNjcmlwdG9yKENsb3N1cmVWYXJQTG9jLCBv ZmZzZXQpLAogICAgICAgICAgICAgICAgICAgICAgICAgaW5pdGlhbFZhbHVlKTsKICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB9Cg==