192024 2018-11-27 12:01:32 -0800 [GTK|WPE] Allow disable WebRTC unified plan SDP through an env var 2018-11-27 13:49:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier tsaunier berto cgarcia commit-queue ews-watchlist gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1482024 0 tsaunier 2018-11-27 12:01:32 -0800 [GTK|WPE] Allow disable WebRTC unified plan SDP through an env var 1482025 1 355757 tsaunier 2018-11-27 12:02:21 -0800 Created attachment 355757 Patch 1482029 2 ews-watchlist 2018-11-27 12:05:55 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1482044 3 355757 mcatanzaro 2018-11-27 12:23:26 -0800 Comment on attachment 355757 Patch It's a *slightly* odd place for this, but I suppose it's fine. Please document it at https://trac.webkit.org/wiki/EnvironmentVariables. 1482056 4 tsaunier 2018-11-27 12:41:00 -0800 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 355757 [details] > Patch > > It's a *slightly* odd place for this, but I suppose it's fine. Please > document it at https://trac.webkit.org/wiki/EnvironmentVariables. Done. 1482089 5 commit-queue 2018-11-27 13:48:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 355757: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. 1482092 6 355757 commit-queue 2018-11-27 13:48:55 -0800 Comment on attachment 355757 Patch Clearing flags on attachment: 355757 Committed r238574: <https://trac.webkit.org/changeset/238574> 1482093 7 commit-queue 2018-11-27 13:48:56 -0800 All reviewed patches have been landed. Closing bug. 1482094 8 webkit-bug-importer 2018-11-27 13:49:30 -0800 <rdar://problem/46287595> 355757 2018-11-27 12:02:21 -0800 2018-11-27 13:48:55 -0800 Patch bug-192024-20181127170220.patch text/plain 1561 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRhOGFjYzg2N2Q4OTBmNTZm ODAyZTM5MmE5NDM5ZTM0NDBkYjA4ZDYuLjdhY2I4MWU2NzZhY2ZjOThmOWNmZTRmYjYxMmJmM2Vm ZDAzYzdhOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTEtMjcgIFRoaWJhdWx0 IFNhdW5pZXIgIDx0c2F1bmllckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEt8V1BFXSBBbGxv dyBkaXNhYmxpbmcgV2ViUlRDIHVuaWZpZWQgcGxhbiBTRFAgdGhyb3VnaCBhbiBlbnYgdmFyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTIwMjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJLaXRTZXR0aW5nc0Nv bnN0cnVjdGVkKToKKwogMjAxOC0xMS0yNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFw cGxlLmNvbT4KIAogICAgICAgICBDb21wbGV0aW9uSGFuZGxlci1iYXNlZCBhc3luYyBJUEMgbWVz c2FnZXMgb25seSB3b3JrIHdoZW4gdGhlIGNvbXBsZXRpb24gaGFuZGxlciB0YWtlcyBhIHNpbmds ZSBhcmd1bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv V2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0U2V0dGluZ3MuY3BwCmluZGV4IDk4MTlkOTFkZjQyNGI4N2U2ZjJkMjQzNDkwZmYyMjllODZh YjI5M2EuLjRlYzdmOTgxMzlhMDcxZmNiZDE2ODJhMjA2NmQ5MGE3YTlmNGE3MTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHAK QEAgLTE3OCw2ICsxNzgsOSBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0NvbnN0cnVjdGVk KEdPYmplY3QqIG9iamVjdCkKICAgICBXZWJQcmVmZXJlbmNlcyogcHJlZnMgPSBzZXR0aW5ncy0+ cHJpdi0+cHJlZmVyZW5jZXMuZ2V0KCk7CiAgICAgcHJlZnMtPnNldFNob3VsZFJlc3BlY3RJbWFn ZU9yaWVudGF0aW9uKHRydWUpOwogCisgICAgaWYgKGdfZ2V0ZW52KCJXRUJLSVRfV0VCUlRDX0RJ U0FCTEVfVU5JRklFRF9QTEFOIikpCisgICAgICAgIHByZWZzLT5zZXRXZWJSVENVbmlmaWVkUGxh bkVuYWJsZWQoRkFMU0UpOworCiAgICAgYm9vbCBtZWRpYVN0cmVhbUVuYWJsZWQgPSBwcmVmcy0+ bWVkaWFTdHJlYW1FbmFibGVkKCk7CiAgICAgcHJlZnMtPnNldE1lZGlhRGV2aWNlc0VuYWJsZWQo bWVkaWFTdHJlYW1FbmFibGVkKTsKICAgICBwcmVmcy0+c2V0UGVlckNvbm5lY3Rpb25FbmFibGVk KG1lZGlhU3RyZWFtRW5hYmxlZCk7Cg==