192022 2018-11-27 11:37:42 -0800 Safe browsing warning details need to be visible on High Sierra 2018-11-28 14:12:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton tsavell webkit-bug-importer oldest_to_newest 1481996 0 achristensen 2018-11-27 11:37:42 -0800 Safe browsing warning details need to be visible on High Sierra 1482006 1 355753 achristensen 2018-11-27 11:42:26 -0800 Created attachment 355753 Patch 1482075 2 355753 thorton 2018-11-27 13:22:56 -0800 Comment on attachment 355753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355753&action=review > Source/WebKit/ChangeLog:8 > + Something about AppKit, autolayout, view insertion order, and NSTextView makes the text layout with initial size of {0, 0} on High Sierra. The verb form is "lay out". Also this is super vague. And a weirdly pseudoscientific fix. 1482208 3 achristensen 2018-11-27 16:15:20 -0800 https://trac.webkit.org/changeset/238585/webkit 1482210 4 webkit-bug-importer 2018-11-27 16:16:39 -0800 <rdar://problem/46293149> 1482463 5 tsavell 2018-11-28 09:41:05 -0800 It looks like the change in https://trac.webkit.org/changeset/238585/webkit#file4 has caused an API failure on iOS Failed TestWebKitAPI.SafeBrowsing.VisitUnsafeWebsite /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:215 Expected: (warning.subviews.firstObject.subviews[2].frame.size.height) > (0), actual: 0 vs 0 1482621 6 achristensen 2018-11-28 13:25:39 -0800 Thanks, Truitt! I'm looking into it. 1482655 7 achristensen 2018-11-28 14:12:38 -0800 http://trac.webkit.org/r238641 355753 2018-11-27 11:42:26 -0800 2018-11-27 13:22:56 -0800 Patch bug-192022-20181127114225.patch text/plain 6740 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzg1MjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTExLTI3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU2FmZSBicm93c2lu ZyB3YXJuaW5nIHRleHQgbmVlZHMgdG8gYmUgdmlzaWJsZSBvbiBIaWdoIFNpZXJyYQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyMDIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZXRoaW5nIGFib3V0 IEFwcEtpdCwgYXV0b2xheW91dCwgdmlldyBpbnNlcnRpb24gb3JkZXIsIGFuZCBOU1RleHRWaWV3 IG1ha2VzIHRoZSB0ZXh0IGxheW91dCB3aXRoIGluaXRpYWwgc2l6ZSBvZiB7MCwgMH0gb24gSGln aCBTaWVycmEuCisgICAgICAgIFVzaW5nIGFuIE5TVGV4dEZpZWxkIGluc3RlYWQgbWFrZXMgdGhl IGRldGFpbHMgdmlzaWJsZS4gIENvdmVyZWQgYnkgYW4gQVBJIHRlc3QuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJvd3NpbmdXYXJuaW5nLmg6CisgICAgICAgICogVUlQcm9j ZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbToKKyAgICAgICAgKG1ha2VMYWJlbCk6 CisgICAgICAgICgtW1dLU2FmZUJyb3dzaW5nV2FybmluZyBhZGRDb250ZW50XSk6CisgICAgICAg ICgtW1dLU2FmZUJyb3dzaW5nV2FybmluZyBzaG93RGV0YWlsc0NsaWNrZWRdKToKKyAgICAgICAg KC1bV0tTYWZlQnJvd3NpbmdXYXJuaW5nIGxheW91dFRleHRdKToKKyAgICAgICAgKG1ha2VUaXRs ZUxhYmVsKTogRGVsZXRlZC4KKwogMjAxOC0xMS0yNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbmFtZSBXS1dlYlZpZXcuX3NhZmVCcm93 c2luZ1dhcm5pbmdGb3JUZXN0aW5nIHRvIF9zYWZlQnJvd3NpbmdXYXJuaW5nIHRvIHVzZSBpdCBm b3IgbW9yZSB0aGFuIHRlc3RpbmcKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29h L1dLU2FmZUJyb3dzaW5nV2FybmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5oCShyZXZpc2lvbiAyMzg1MjcpCisr KyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NhZmVCcm93c2luZ1dhcm5pbmcuaAko d29ya2luZyBjb3B5KQpAQCAtNTcsNyArNTcsNyBAQCB1c2luZyBSZWN0VHlwZSA9IENHUmVjdDsK IEBwYWNrYWdlCiAgICAgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChWYXJpYW50PFdlYktpdDo6Q29u dGludWVVbnNhZmVMb2FkLCBXZWJDb3JlOjpVUkw+JiYpPiBfY29tcGxldGlvbkhhbmRsZXI7CiAg ICAgUmVmUHRyPGNvbnN0IFdlYktpdDo6U2FmZUJyb3dzaW5nV2FybmluZz4gX3dhcm5pbmc7Ci0g ICAgUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PFdLU2FmZUJyb3dzaW5nVGV4dFZpZXcgKj4+IF90 ZXh0Vmlld3M7CisgICAgV2Vha09iakNQdHI8V0tTYWZlQnJvd3NpbmdUZXh0Vmlldz4gX2RldGFp bHM7CiB9CiAKIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihSZWN0VHlwZSlmcmFtZSBz YWZlQnJvd3NpbmdXYXJuaW5nOihjb25zdCBXZWJLaXQ6OlNhZmVCcm93c2luZ1dhcm5pbmcmKXdh cm5pbmcgY29tcGxldGlvbkhhbmRsZXI6KENvbXBsZXRpb25IYW5kbGVyPHZvaWQoVmFyaWFudDxX ZWJLaXQ6OkNvbnRpbnVlVW5zYWZlTG9hZCwgV2ViQ29yZTo6VVJMPiYmKT4mJiljb21wbGV0aW9u SGFuZGxlcjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dz aW5nV2FybmluZy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9XS1NhZmVCcm93c2luZ1dhcm5pbmcubW0JKHJldmlzaW9uIDIzODUyNykKKysrIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbQkod29ya2luZyBj b3B5KQpAQCAtMTk3LDEyICsxOTcsOCBAQCBzdGF0aWMgQnV0dG9uVHlwZSAqbWFrZUJ1dHRvbihX YXJuaW5nSXRlCiAjZW5kaWYKIH0KIAotc3RhdGljIFZpZXdUeXBlICptYWtlVGl0bGVMYWJlbChO U1N0cmluZyAqdGl0bGUsIFZpZXdUeXBlICp3YXJuaW5nKQorc3RhdGljIFZpZXdUeXBlICptYWtl TGFiZWwoTlNBdHRyaWJ1dGVkU3RyaW5nICphdHRyaWJ1dGVkU3RyaW5nKQogewotICAgIGF1dG8g YXR0cmlidXRlZFN0cmluZyA9IFtbW05TQXR0cmlidXRlZFN0cmluZyBhbGxvY10gaW5pdFdpdGhT dHJpbmc6dGl0bGUgYXR0cmlidXRlczpAewotICAgICAgICBOU0ZvbnRBdHRyaWJ1dGVOYW1lOltG b250VHlwZSBib2xkU3lzdGVtRm9udE9mU2l6ZTp0aXRsZVNpemVdLAotICAgICAgICBOU0ZvcmVn cm91bmRDb2xvckF0dHJpYnV0ZU5hbWU6Y29sb3JGb3JJdGVtKFdhcm5pbmdJdGVtOjpUaXRsZVRl eHQsIHdhcm5pbmcpCi0gICAgfV0gYXV0b3JlbGVhc2VdOwogI2lmIFBMQVRGT1JNKE1BQykKICAg ICByZXR1cm4gW05TVGV4dEZpZWxkIGxhYmVsV2l0aEF0dHJpYnV0ZWRTdHJpbmc6YXR0cmlidXRl ZFN0cmluZ107CiAjZWxzZQpAQCAtMjUxLDE1ICsyNDcsMTkgQEAgLSAoaW5zdGFuY2V0eXBlKWlu aXRXaXRoRnJhbWU6KFJlY3RUeXBlKQogLSAodm9pZClhZGRDb250ZW50CiB7CiAgICAgYXV0byBl eGNsYW1hdGlvblBvaW50ID0gW1tXS1NhZmVCcm93c2luZ0V4Y2xhbWF0aW9uUG9pbnQgbmV3XSBh dXRvcmVsZWFzZV07Ci0gICAgYXV0byB0aXRsZSA9IG1ha2VUaXRsZUxhYmVsKF93YXJuaW5nLT50 aXRsZSgpLCBzZWxmKTsKLSAgICBhdXRvIHdhcm5pbmcgPSBbW1tXS1NhZmVCcm93c2luZ1RleHRW aWV3IGFsbG9jXSBpbml0V2l0aEF0dHJpYnV0ZWRTdHJpbmc6W1tbTlNBdHRyaWJ1dGVkU3RyaW5n IGFsbG9jXSBpbml0V2l0aFN0cmluZzpfd2FybmluZy0+d2FybmluZygpIGF0dHJpYnV0ZXM6QHsg TlNGb250QXR0cmlidXRlTmFtZTpbRm9udFR5cGUgc3lzdGVtRm9udE9mU2l6ZTp0ZXh0U2l6ZV0g fV0gYXV0b3JlbGVhc2VdIGZvcldhcm5pbmc6c2VsZl0gYXV0b3JlbGVhc2VdOworICAgIGF1dG8g dGl0bGUgPSBtYWtlTGFiZWwoW1tbTlNBdHRyaWJ1dGVkU3RyaW5nIGFsbG9jXSBpbml0V2l0aFN0 cmluZzpfd2FybmluZy0+dGl0bGUoKSBhdHRyaWJ1dGVzOkB7CisgICAgICAgIE5TRm9udEF0dHJp YnV0ZU5hbWU6W0ZvbnRUeXBlIGJvbGRTeXN0ZW1Gb250T2ZTaXplOnRpdGxlU2l6ZV0sCisgICAg ICAgIE5TRm9yZWdyb3VuZENvbG9yQXR0cmlidXRlTmFtZTpjb2xvckZvckl0ZW0oV2FybmluZ0l0 ZW06OlRpdGxlVGV4dCwgc2VsZikKKyAgICB9XSBhdXRvcmVsZWFzZV0pOworICAgIGF1dG8gd2Fy bmluZyA9IG1ha2VMYWJlbChbW1tOU0F0dHJpYnV0ZWRTdHJpbmcgYWxsb2NdIGluaXRXaXRoU3Ry aW5nOl93YXJuaW5nLT53YXJuaW5nKCkgYXR0cmlidXRlczpAeworICAgICAgICBOU0ZvbnRBdHRy aWJ1dGVOYW1lOltGb250VHlwZSBzeXN0ZW1Gb250T2ZTaXplOnRleHRTaXplXSwKKyAgICAgICAg TlNGb3JlZ3JvdW5kQ29sb3JBdHRyaWJ1dGVOYW1lOmNvbG9yRm9ySXRlbShXYXJuaW5nSXRlbTo6 TWVzc2FnZVRleHQsIHNlbGYpCisgICAgfV0gYXV0b3JlbGVhc2VdKTsKICAgICBhdXRvIHNob3dE ZXRhaWxzID0gbWFrZUJ1dHRvbihXYXJuaW5nSXRlbTo6U2hvd0RldGFpbHNCdXR0b24sIHNlbGYs IEBzZWxlY3RvcihzaG93RGV0YWlsc0NsaWNrZWQpKTsKICAgICBhdXRvIGdvQmFjayA9IG1ha2VC dXR0b24oV2FybmluZ0l0ZW06OkdvQmFja0J1dHRvbiwgc2VsZiwgQHNlbGVjdG9yKGdvQmFja0Ns aWNrZWQpKTsKICAgICBhdXRvIGJveCA9IFtbVmlld1R5cGUgbmV3XSBhdXRvcmVsZWFzZV07CiAg ICAgc2V0QmFja2dyb3VuZChib3gsIGNvbG9yRm9ySXRlbShXYXJuaW5nSXRlbTo6Qm94QmFja2dy b3VuZCwgc2VsZikpOwogICAgIGJveC5sYXllci5jb3JuZXJSYWRpdXMgPSBib3hDb3JuZXJSYWRp dXM7Ci0gICAgX3RleHRWaWV3cyA9IGFkb3B0TlMoW05TTXV0YWJsZUFycmF5IG5ld10pOwotICAg IFtfdGV4dFZpZXdzIGFkZE9iamVjdDp3YXJuaW5nXTsKIAogICAgIGZvciAoVmlld1R5cGUgKnZp ZXcgaW4gQFtleGNsYW1hdGlvblBvaW50LCB0aXRsZSwgd2FybmluZywgZ29CYWNrLCBzaG93RGV0 YWlsc10pIHsKICAgICAgICAgdmlldy50cmFuc2xhdGVzQXV0b3Jlc2l6aW5nTWFza0ludG9Db25z dHJhaW50cyA9IE5POwpAQCAtMzA2LDcgKzMwNiw3IEBAIC0gKHZvaWQpc2hvd0RldGFpbHNDbGlj a2VkCiAgICAgTlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyAqdGV4dCA9IFtbX3dhcm5pbmctPmRl dGFpbHMoKSBtdXRhYmxlQ29weV0gYXV0b3JlbGVhc2VdOwogICAgIFt0ZXh0IGFkZEF0dHJpYnV0 ZXM6QHsgTlNGb250QXR0cmlidXRlTmFtZTpbRm9udFR5cGUgc3lzdGVtRm9udE9mU2l6ZTp0ZXh0 U2l6ZV0gfSByYW5nZTpOU01ha2VSYW5nZSgwLCB0ZXh0Lmxlbmd0aCldOwogICAgIFdLU2FmZUJy b3dzaW5nVGV4dFZpZXcgKmRldGFpbHMgPSBbW1tXS1NhZmVCcm93c2luZ1RleHRWaWV3IGFsbG9j XSBpbml0V2l0aEF0dHJpYnV0ZWRTdHJpbmc6dGV4dCBmb3JXYXJuaW5nOnNlbGZdIGF1dG9yZWxl YXNlXTsKLSAgICBbX3RleHRWaWV3cyBhZGRPYmplY3Q6ZGV0YWlsc107CisgICAgX2RldGFpbHMg PSBkZXRhaWxzOwogICAgIFZpZXdUeXBlICpib3R0b20gPSBbW1ZpZXdUeXBlIG5ld10gYXV0b3Jl bGVhc2VdOwogICAgIHNldEJhY2tncm91bmQoYm90dG9tLCBjb2xvckZvckl0ZW0oV2FybmluZ0l0 ZW06OkJveEJhY2tncm91bmQsIHNlbGYpKTsKICAgICBib3R0b20ubGF5ZXIuY29ybmVyUmFkaXVz ID0gYm94Q29ybmVyUmFkaXVzOwpAQCAtMzU4LDggKzM1OCw3IEBAIC0gKHZvaWQpc2hvd0RldGFp bHNDbGlja2VkCiAKIC0gKHZvaWQpbGF5b3V0VGV4dAogewotICAgIGZvciAoV0tTYWZlQnJvd3Np bmdUZXh0VmlldyAqdmlldyBpbiBfdGV4dFZpZXdzLmdldCgpKQotICAgICAgICBbdmlldyBpbnZh bGlkYXRlSW50cmluc2ljQ29udGVudFNpemVdOworICAgIFtfZGV0YWlscyBpbnZhbGlkYXRlSW50 cmluc2ljQ29udGVudFNpemVdOwogfQogCiAjaWYgUExBVEZPUk0oTUFDKQpJbmRleDogVG9vbHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjM4NTYx KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTgtMTEtMjcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKwor ICAgICAgICBTYWZlIGJyb3dzaW5nIHdhcm5pbmcgdGV4dCBuZWVkcyB0byBiZSB2aXNpYmxlIG9u IEhpZ2ggU2llcnJhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTIwMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2FmZUJyb3dzaW5nLm1tOgor ICAgICAgICAoVEVTVCk6CisKIDIwMTgtMTEtMjcgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYXBwXSBBZGQgc3VwcG9ydCB0byBjb21tdW5pY2F0 ZSB3aXRoIEJ1aWxkYm90IChGb2xsb3ctdXAgZml4KQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9TYWZlQnJvd3NpbmcubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TYWZlQnJvd3NpbmcubW0JKHJldmlzaW9u IDIzODUyNykKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2FmZUJy b3dzaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMTIsNiArMjEyLDcgQEAgVEVTVChTYWZlQnJv d3NpbmcsIFZpc2l0VW5zYWZlV2Vic2l0ZSkKICAgICBhdXRvIHdlYlZpZXcgPSBzYWZlQnJvd3Np bmdWaWV3KCk7CiAgICAgYXV0byB3YXJuaW5nID0gW3dlYlZpZXcgX3NhZmVCcm93c2luZ1dhcm5p bmddOwogICAgIEVYUEVDVF9FUSh3YXJuaW5nLnN1YnZpZXdzLmNvdW50LCAxdWxsKTsKKyAgICBF WFBFQ1RfR1Qod2FybmluZy5zdWJ2aWV3cy5maXJzdE9iamVjdC5zdWJ2aWV3c1syXS5mcmFtZS5z aXplLmhlaWdodCwgMCk7CiAgICAgY2hlY2tUaXRsZUFuZENsaWNrKHdhcm5pbmcuc3Vidmlld3Mu Zmlyc3RPYmplY3Quc3Vidmlld3NbNF0sICJTaG93IERldGFpbHMiKTsKICAgICBFWFBFQ1RfRVEo d2FybmluZy5zdWJ2aWV3cy5jb3VudCwgMnVsbCk7CiAgICAgRVhQRUNUX0ZBTFNFKGNvbW1pdHRl ZE5hdmlnYXRpb24pOwo=