191996 2018-11-26 21:47:59 -0800 WebKit.AddAndRemoveDataDetectors hits a debug assertion after r238515 2018-11-27 08:04:30 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes commit-queue dino thorton webkit-bug-importer oldest_to_newest 1481833 0 wenson_hsieh 2018-11-26 21:47:59 -0800 From logging in decode(Decoder& decoder, NSArray<Class> *allowedClasses), it looks like what's happening is that the allowedClasses contains: @[ NSArray.class, DDScannerResult.class ] ...however, the decoded object is a type of __NSArrayM, which is not exactly equal to NSArray.class (instead, it's one of the concrete implementations of NSArray). Example crash trace (from https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/1014/steps/run-api-tests/logs/stdio) TestWebKitAPI.WebKit.AddAndRemoveDataDetectors ASSERTION FAILED: [allowedClasses containsObject:[object class]] /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h(57) : std::optional<RetainPtr<T> > IPC::decode(IPC::Decoder &, NSArray<Class> *) [T = NSArray] 1 0x106fbd359 WTFCrash 2 0x10ab7975b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10af506d4 std::optional<WTF::RetainPtr<NSArray> > IPC::decode<NSArray>(IPC::Decoder&, NSArray<objc_class*>*) 4 0x10af5038b WebKit::DataDetectionResult::decode(IPC::Decoder&) 5 0x10bb8556c std::optional<WebKit::DataDetectionResult> IPC::ArgumentCoder<WebKit::DataDetectionResult>::decode<WebKit::DataDetectionResult, (void*)0>(IPC::Decoder&) 6 0x10bb65f54 IPC::Decoder& IPC::Decoder::operator>><WebKit::DataDetectionResult, (void*)0>(std::optional<WebKit::DataDetectionResult>&) 7 0x10bb65e59 Messages::WebPage::DetectDataInAllFrames::callReply(IPC::Decoder&, WTF::CompletionHandler<void (WebKit::DataDetectionResult&&)>&&) 1481834 1 355713 wenson_hsieh 2018-11-26 21:55:45 -0800 Created attachment 355713 Patch 1481837 2 355713 commit-queue 2018-11-26 23:48:32 -0800 Comment on attachment 355713 Patch Rejecting attachment 355713 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355713, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=355713&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191996&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 355713 from bug 191996. Fetching: https://bugs.webkit.org/attachment.cgi?id=355713 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 6de0a5f9bcacc234f9c83bb8294967b7e9cbebbd and refs/remotes/origin/master differ, using rebase: :040000 040000 5eef4691356aae46f7034c7d6599789a6993bce1 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 6de0a5f9bcacc234f9c83bb8294967b7e9cbebbd and refs/remotes/origin/master differ, using rebase: :040000 040000 5eef4691356aae46f7034c7d6599789a6993bce1 bfc2fa26c7b37ea3520ffa0f235d1a7be3453b52 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/10163574 1481900 3 355731 wenson_hsieh 2018-11-27 07:12:39 -0800 Created attachment 355731 Rebase on trunk 1481907 4 355731 commit-queue 2018-11-27 07:51:49 -0800 Comment on attachment 355731 Rebase on trunk Clearing flags on attachment: 355731 Committed r238553: <https://trac.webkit.org/changeset/238553> 1481910 5 webkit-bug-importer 2018-11-27 08:04:30 -0800 <rdar://problem/46276314> 355713 2018-11-26 21:55:45 -0800 2018-11-26 23:48:32 -0800 Patch bug-191996-20181126215544.patch text/plain 2435 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3YmNhZDgyOTg5ZDRmZDlj OTU2NjA5ZjU5NWVkYjJhMDY2MWMxYzUuLjk1OTY5OGYwNDVkY2U0Mzk0NjUzYTJiNTdmMDhiNWVl MTRiMDNkZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMTEtMjYgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0LkFkZEFuZFJl bW92ZURhdGFEZXRlY3RvcnMgaGl0cyBhIGRlYnVnIGFzc2VydGlvbiBhZnRlciByMjM4NTE1Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5OTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFzc2Vy dGlvbiBpcyBoaXQgYmVjYXVzZSBgZGVjb2RlKERlY29kZXImIGRlY29kZXIsIE5TQXJyYXk8Q2xh c3M+ICphbGxvd2VkQ2xhc3NlcylgIGV4cGVjdHMgdGhlIGRlY29kZWQKKyAgICAgICAgb2JqZWN0 IChvZiBjbGFzcyBgX05TQXJyYXlNYCkgdG8gYmUgZXF1YWwgdG8gYE5TQXJyYXkuY2xhc3NgLgor CisgICAgICAgIFdlIGZpeCB0aGUgZGVidWcgYXNzZXJ0aW9uIGJ5IHJlbGF4aW5nIGEgZGVidWcg YXNzZXJ0aW9uIHdoZW4gZGVjb2Rpbmcgc2VjdXJlbHktY29kYWJsZSBvYmplY3RzIG92ZXIgSVBD LgorICAgICAgICBJbnN0ZWFkIG9mIGNoZWNraW5nIHRoYXQgdGhlIGNsYXNzIG9mIHRoZSBkZWNv ZGVkIG9iamVjdCBpcyBlcXVhbCB0byBvbmUgb2YgdGhlIGFsbG93ZWQgY2xhc3NlcywgY2hlY2sg dGhhdCB0aGUKKyAgICAgICAgb2JqZWN0IGlzIGEga2luZCBvZiBhbnkgb2YgdGhlIGFsbG93ZWQg Y2xhc3Nlcy4KKworICAgICAgICAqIFNoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLmg6 CisgICAgICAgIChJUEM6OmlzT2JqZWN0Q2xhc3NBbGxvd2VkKToKKyAgICAgICAgKElQQzo6ZGVj b2RlKToKKwogMjAxOC0xMS0yNiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBJbnNlcnQgPGF0dGFjaG1lbnQ+IGVsZW1lbnRzIHVuZGVyIGVkaXRhYmxl IGltYWdlcyB0byBtYWtlIHRoZWlyIGJhY2tpbmcgZGF0YSBhY2Nlc3NpYmxlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLmggYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLmgKaW5kZXggYTJiMTM4 MGUyNjkzZTlkNTIxNWM3ZWJkNmY0N2NhZWI3MTdhNDQzNS4uZDg1ZDM4ODg2ZWEwZWI1ZWExMzMy NmFhNTUwYWVlMzM4NDRhZDg2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29j b2EvQXJndW1lbnRDb2RlcnNDb2NvYS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29h L0FyZ3VtZW50Q29kZXJzQ29jb2EuaApAQCAtNDMsNiArNDMsMTkgQEAgc3RkOjpvcHRpb25hbDxS ZXRhaW5QdHI8VD4+IGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBDbGFzcyBhbGxvd2VkQ2xhc3Mp CiAgICAgcmV0dXJuIGRlY29kZTxUPihkZWNvZGVyLCBAWyBhbGxvd2VkQ2xhc3MgXSk7CiB9CiAK KyNpZm5kZWYgTkRFQlVHCisKK3N0YXRpYyBpbmxpbmUgYm9vbCBpc09iamVjdENsYXNzQWxsb3dl ZChpZCBvYmplY3QsIE5TQXJyYXk8Q2xhc3M+ICphbGxvd2VkQ2xhc3NlcykKK3sKKyAgICBmb3Ig KENsYXNzIGFsbG93ZWRDbGFzcyBpbiBhbGxvd2VkQ2xhc3NlcykgeworICAgICAgICBpZiAoW29i amVjdCBpc0tpbmRPZkNsYXNzOmFsbG93ZWRDbGFzc10pCisgICAgICAgICAgICByZXR1cm4gdHJ1 ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCisjZW5kaWYKKwogdGVtcGxhdGU8dHlw ZW5hbWUgVD4KIHN0ZDo6b3B0aW9uYWw8UmV0YWluUHRyPFQ+PiBkZWNvZGUoRGVjb2RlciYgZGVj b2RlciwgTlNBcnJheTxDbGFzcz4gKmFsbG93ZWRDbGFzc2VzKQogewpAQCAtNTQsNyArNjcsNyBA QCBzdGQ6Om9wdGlvbmFsPFJldGFpblB0cjxUPj4gZGVjb2RlKERlY29kZXImIGRlY29kZXIsIE5T QXJyYXk8Q2xhc3M+ICphbGxvd2VkQ2xhcwogICAgICAgICByZXR1cm4geyBudWxscHRyIH07CiAK ICAgICBpZCBvYmplY3QgPSByZXN1bHQtPmxlYWtSZWYoKTsKLSAgICBBU1NFUlQoW2FsbG93ZWRD bGFzc2VzIGNvbnRhaW5zT2JqZWN0OltvYmplY3QgY2xhc3NdXSk7CisgICAgQVNTRVJUKGlzT2Jq ZWN0Q2xhc3NBbGxvd2VkKG9iamVjdCwgYWxsb3dlZENsYXNzZXMpKTsKICAgICByZXR1cm4geyBh ZG9wdE5TKHN0YXRpY19jYXN0PFQgKj4ob2JqZWN0KSkgfTsKIH0KIAo= 355731 2018-11-27 07:12:39 -0800 2018-11-27 07:51:49 -0800 Rebase on trunk bug-191996-20181127071239.patch text/plain 2413 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc2ZmQzZjQwODkwYmY3Njk5 ZjAzMDg0YzFlMWEzOGQ3Mzg0NzNjNTAuLjc0MTNkZTBmY2QxZmFhZGRiZTI0YzJjOGU4ZTVmNTdm MDk3N2U1NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMTEtMjYgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0LkFkZEFuZFJl bW92ZURhdGFEZXRlY3RvcnMgaGl0cyBhIGRlYnVnIGFzc2VydGlvbiBhZnRlciByMjM4NTE1Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5OTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIFRoaXMgYXNzZXJ0aW9u IGlzIGhpdCBiZWNhdXNlIGBkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgTlNBcnJheTxDbGFzcz4g KmFsbG93ZWRDbGFzc2VzKWAgZXhwZWN0cyB0aGUgZGVjb2RlZAorICAgICAgICBvYmplY3QgKG9m IGNsYXNzIGBfTlNBcnJheU1gKSB0byBiZSBlcXVhbCB0byBgTlNBcnJheS5jbGFzc2AuCisKKyAg ICAgICAgV2UgZml4IHRoZSBjcmFzaCBieSByZWxheGluZyB0aGUgZGVidWcgYXNzZXJ0aW9uIHdo ZW4gZGVjb2Rpbmcgc2VjdXJlbHktY29kYWJsZSBvYmplY3RzIG92ZXIgSVBDLiBJbnN0ZWFkIG9m CisgICAgICAgIGNoZWNraW5nIHRoYXQgdGhlIGNsYXNzIG9mIHRoZSBkZWNvZGVkIG9iamVjdCBp cyBlcXVhbCB0byBvbmUgb2YgdGhlIGFsbG93ZWQgY2xhc3NlcywgY2hlY2sgdGhhdCB0aGUgb2Jq ZWN0IGlzIGEKKyAgICAgICAga2luZCBvZiBhbnkgb2YgdGhlIGFsbG93ZWQgY2xhc3Nlcy4KKwor ICAgICAgICAqIFNoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLmg6CisgICAgICAgIChJ UEM6OmlzT2JqZWN0Q2xhc3NBbGxvd2VkKToKKyAgICAgICAgKElQQzo6ZGVjb2RlKToKKwogMjAx OC0xMS0yNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRmFj dG9yIG1hc2sgbGF5ZXIgYXBwbHlpbmcgaW4gUmVtb3RlTGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVy IGludG8gYSBzaGFyZWQgZnVuY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVk L0NvY29hL0FyZ3VtZW50Q29kZXJzQ29jb2EuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29h L0FyZ3VtZW50Q29kZXJzQ29jb2EuaAppbmRleCBhMmIxMzgwZTI2OTNlOWQ1MjE1YzdlYmQ2ZjQ3 Y2FlYjcxN2E0NDM1Li5kODVkMzg4ODZlYTBlYjVlYTEzMzI2YWE1NTBhZWUzMzg0NGFkODY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29h LmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvQXJndW1lbnRDb2RlcnNDb2NvYS5o CkBAIC00Myw2ICs0MywxOSBAQCBzdGQ6Om9wdGlvbmFsPFJldGFpblB0cjxUPj4gZGVjb2RlKERl Y29kZXImIGRlY29kZXIsIENsYXNzIGFsbG93ZWRDbGFzcykKICAgICByZXR1cm4gZGVjb2RlPFQ+ KGRlY29kZXIsIEBbIGFsbG93ZWRDbGFzcyBdKTsKIH0KIAorI2lmbmRlZiBOREVCVUcKKworc3Rh dGljIGlubGluZSBib29sIGlzT2JqZWN0Q2xhc3NBbGxvd2VkKGlkIG9iamVjdCwgTlNBcnJheTxD bGFzcz4gKmFsbG93ZWRDbGFzc2VzKQoreworICAgIGZvciAoQ2xhc3MgYWxsb3dlZENsYXNzIGlu IGFsbG93ZWRDbGFzc2VzKSB7CisgICAgICAgIGlmIChbb2JqZWN0IGlzS2luZE9mQ2xhc3M6YWxs b3dlZENsYXNzXSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICByZXR1cm4g ZmFsc2U7Cit9CisKKyNlbmRpZgorCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogc3RkOjpvcHRpb25h bDxSZXRhaW5QdHI8VD4+IGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBOU0FycmF5PENsYXNzPiAq YWxsb3dlZENsYXNzZXMpCiB7CkBAIC01NCw3ICs2Nyw3IEBAIHN0ZDo6b3B0aW9uYWw8UmV0YWlu UHRyPFQ+PiBkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgTlNBcnJheTxDbGFzcz4gKmFsbG93ZWRD bGFzCiAgICAgICAgIHJldHVybiB7IG51bGxwdHIgfTsKIAogICAgIGlkIG9iamVjdCA9IHJlc3Vs dC0+bGVha1JlZigpOwotICAgIEFTU0VSVChbYWxsb3dlZENsYXNzZXMgY29udGFpbnNPYmplY3Q6 W29iamVjdCBjbGFzc11dKTsKKyAgICBBU1NFUlQoaXNPYmplY3RDbGFzc0FsbG93ZWQob2JqZWN0 LCBhbGxvd2VkQ2xhc3NlcykpOwogICAgIHJldHVybiB7IGFkb3B0TlMoc3RhdGljX2Nhc3Q8VCAq PihvYmplY3QpKSB9OwogfQogCg==