191981 2018-11-26 14:56:46 -0800 Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing 2018-11-26 15:08:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1481701 0 achristensen 2018-11-26 14:56:46 -0800 Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing 1481703 1 355680 achristensen 2018-11-26 14:57:44 -0800 Created attachment 355680 Patch 1481709 2 355680 thorton 2018-11-26 14:59:02 -0800 Comment on attachment 355680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355680&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:474 > -@property (nonatomic, readonly) UIView *_safeBrowsingWarningForTesting WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); > +@property (nonatomic, readonly) UIView *_safeBrowsingWarning WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); If you're going to 'use it for more than just testing', you need to move it out of the WKTesting category too. 1481717 3 achristensen 2018-11-26 15:07:19 -0800 Done! http://trac.webkit.org/r238527 1481718 4 webkit-bug-importer 2018-11-26 15:08:35 -0800 <rdar://problem/46258443> 355680 2018-11-26 14:57:44 -0800 2018-11-26 14:59:02 -0800 Patch bug-191981-20181126145744.patch text/plain 7417 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzg1MDMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTI2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVuYW1lIFdLV2Vi Vmlldy5fc2FmZUJyb3dzaW5nV2FybmluZ0ZvclRlc3RpbmcgdG8gX3NhZmVCcm93c2luZ1dhcm5p bmcgdG8gdXNlIGl0IGZvciBtb3JlIHRoYW4gdGVzdGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zYWZlQnJvd3NpbmdXYXJuaW5nXSk6CisgICAg ICAgICgtW1dLV2ViVmlldyBfc2FmZUJyb3dzaW5nV2FybmluZ0ZvclRlc3RpbmddKTogRGVsZXRl ZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKwog MjAxOC0xMS0yNiAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAg VXNlIEZ1bGwgU2NyZWVuIGNvbnNpc3RlbnRseSBpbiBsb2NhbGl6YWJsZSBzdHJpbmdzLgpJbmRl eDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCShy ZXZpc2lvbiAyMzg1MDMpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02ODQ4LDEyICs2ODQ4LDEyIEBAIC0gKHZvaWQp X3NldFNoYXJlU2hlZXRDb21wbGV0ZXNJbW1lZGlhdGUKIH0KIAogI2lmIFBMQVRGT1JNKE1BQykK LS0gKE5TVmlldyAqKV9zYWZlQnJvd3NpbmdXYXJuaW5nRm9yVGVzdGluZworLSAoTlNWaWV3ICop X3NhZmVCcm93c2luZ1dhcm5pbmcKIHsKICAgICByZXR1cm4gX2ltcGwtPnNhZmVCcm93c2luZ1dh cm5pbmcoKTsKIH0KICNlbHNlCi0tIChVSVZpZXcgKilfc2FmZUJyb3dzaW5nV2FybmluZ0ZvclRl c3RpbmcKKy0gKFVJVmlldyAqKV9zYWZlQnJvd3NpbmdXYXJuaW5nCiB7CiAgICAgcmV0dXJuIF9z YWZlQnJvd3NpbmdXYXJuaW5nLmdldCgpOwogfQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCShyZXZpc2lvbiAyMzg1 MDMpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0 ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NzEsOSArNDcxLDkgQEAgdHlwZWRlZiBOU19PUFRJT05T KE5TVUludGVnZXIsIF9XS1JlY3RFZAogLSAodm9pZClfYWNjZXNzaWJpbGl0eUNsZWFyU2VsZWN0 aW9uIFdLX0FQSV9BVkFJTEFCTEUoaW9zKDExLjMpKTsKIC0gKFVJVmlldyAqKV9mdWxsU2NyZWVu UGxhY2Vob2xkZXJWaWV3IFdLX0FQSV9BVkFJTEFCTEUoaW9zKDEyLjApKTsKIAotQHByb3BlcnR5 IChub25hdG9taWMsIHJlYWRvbmx5KSBVSVZpZXcgKl9zYWZlQnJvd3NpbmdXYXJuaW5nRm9yVGVz dGluZyBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEp KTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgVUlWaWV3ICpfc2FmZUJyb3dzaW5n V2FybmluZyBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19U QkEpKTsKICNlbHNlCi1AcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TVmlldyAqX3Nh ZmVCcm93c2luZ1dhcm5pbmdGb3JUZXN0aW5nIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdLX01B Q19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5 KSBOU1ZpZXcgKl9zYWZlQnJvd3NpbmdXYXJuaW5nIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdL X01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogLSAodm9pZClfZGlzbWlzc0NvbnRlbnRSZWxh dGl2ZUNoaWxkV2luZG93cyBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMy40KSk7CiAtICh2 b2lkKV9zZXRGcmFtZTooTlNSZWN0KXJlY3QgYW5kU2Nyb2xsQnk6KE5TU2l6ZSlvZmZzZXQgV0tf QVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTMuNCkpOwogLSAodm9pZClfYmVnaW5EZWZlcnJpbmdW aWV3SW5XaW5kb3dDaGFuZ2VzIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzLjQpKTsKSW5k ZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlz aW9uIDIzODUyNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDE4LTExLTI2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmVuYW1lIFdLV2ViVmlldy5fc2FmZUJyb3dzaW5nV2FybmluZ0Zv clRlc3RpbmcgdG8gX3NhZmVCcm93c2luZ1dhcm5pbmcgdG8gdXNlIGl0IGZvciBtb3JlIHRoYW4g dGVzdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkxOTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1NhZmVCcm93c2luZy5tbToKKyAgICAg ICAgKFRFU1QpOgorICAgICAgICAoc2FmZUJyb3dzaW5nVmlldyk6CisKIDIwMTgtMTEtMjYgIEFh a2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYXBwXSBT ZXQgRm9yZWlnbiBLZXlzIGluIEVXUyBEamFuZ28gYXBwIG1vZGVscwpJbmRleDogVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TYWZlQnJvd3NpbmcubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TYWZlQnJvd3NpbmcubW0J KHJldmlzaW9uIDIzODUwMykKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvU2FmZUJyb3dzaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsMTMgKzE1NywxMyBAQCBU RVNUKFNhZmVCcm93c2luZywgUHJlZmVyZW5jZSkKICAgICBbd2ViVmlldyBzZXROYXZpZ2F0aW9u RGVsZWdhdGU6ZGVsZWdhdGUuZ2V0KCldOwogICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IGNvbmZp Z3VyYXRpb25dLnByZWZlcmVuY2VzLnNhZmVCcm93c2luZ0VuYWJsZWQpOwogICAgIFt3ZWJWaWV3 IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6cmVzb3VyY2VVUkwoQCJz aW1wbGUiKV1dOwotICAgIHdoaWxlICghW3dlYlZpZXcgX3NhZmVCcm93c2luZ1dhcm5pbmdGb3JU ZXN0aW5nXSkKKyAgICB3aGlsZSAoIVt3ZWJWaWV3IF9zYWZlQnJvd3NpbmdXYXJuaW5nXSkKICAg ICAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3AoKTsKICAgICBbd2ViVmlldyBj b25maWd1cmF0aW9uXS5wcmVmZXJlbmNlcy5zYWZlQnJvd3NpbmdFbmFibGVkID0gTk87CiAgICAg W3dlYlZpZXcgbG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpyZXNvdXJj ZVVSTChAInNpbXBsZTIiKV1dOwogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZG9uZSk7 CiAgICAgRVhQRUNUX0ZBTFNFKFt3ZWJWaWV3IGNvbmZpZ3VyYXRpb25dLnByZWZlcmVuY2VzLnNh ZmVCcm93c2luZ0VuYWJsZWQpOwotICAgIEVYUEVDVF9GQUxTRShbd2ViVmlldyBfc2FmZUJyb3dz aW5nV2FybmluZ0ZvclRlc3RpbmddKTsKKyAgICBFWFBFQ1RfRkFMU0UoW3dlYlZpZXcgX3NhZmVC cm93c2luZ1dhcm5pbmddKTsKIH0KIAogc3RhdGljIFJldGFpblB0cjxXS1dlYlZpZXc+IHNhZmVC cm93c2luZ1ZpZXcoKQpAQCAtMTc0LDEwICsxNzQsMTAgQEAgc3RhdGljIFJldGFpblB0cjxXS1dl YlZpZXc+IHNhZmVCcm93c2luZwogICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1dLV2ViVmll dyBuZXddKTsKICAgICBbd2ViVmlldyBzZXROYXZpZ2F0aW9uRGVsZWdhdGU6ZGVsZWdhdGUuZ2V0 KCldOwogICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhV Ukw6cmVzb3VyY2VVUkwoQCJzaW1wbGUiKV1dOwotICAgIHdoaWxlICghW3dlYlZpZXcgX3NhZmVC cm93c2luZ1dhcm5pbmdGb3JUZXN0aW5nXSkKKyAgICB3aGlsZSAoIVt3ZWJWaWV3IF9zYWZlQnJv d3NpbmdXYXJuaW5nXSkKICAgICAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3Ao KTsKICNpZiAhUExBVEZPUk0oTUFDKQotICAgIFtbd2ViVmlldyBfc2FmZUJyb3dzaW5nV2Fybmlu Z0ZvclRlc3RpbmddIGRpZE1vdmVUb1dpbmRvd107CisgICAgW1t3ZWJWaWV3IF9zYWZlQnJvd3Np bmdXYXJuaW5nXSBkaWRNb3ZlVG9XaW5kb3ddOwogI2VuZGlmCiAgICAgcmV0dXJuIHdlYlZpZXc7 CiB9CkBAIC0yMDEsMTYgKzIwMSwxNiBAQCBzdGF0aWMgdm9pZCBjaGVja1RpdGxlQW5kQ2xpY2so VUlCdXR0b24gCiBURVNUKFNhZmVCcm93c2luZywgR29CYWNrKQogewogICAgIGF1dG8gd2ViVmll dyA9IHNhZmVCcm93c2luZ1ZpZXcoKTsKLSAgICBhdXRvIHdhcm5pbmcgPSBbd2ViVmlldyBfc2Fm ZUJyb3dzaW5nV2FybmluZ0ZvclRlc3RpbmddOworICAgIGF1dG8gd2FybmluZyA9IFt3ZWJWaWV3 IF9zYWZlQnJvd3NpbmdXYXJuaW5nXTsKICAgICBhdXRvIGJveCA9IHdhcm5pbmcuc3Vidmlld3Mu Zmlyc3RPYmplY3Q7CiAgICAgY2hlY2tUaXRsZUFuZENsaWNrKGJveC5zdWJ2aWV3c1szXSwgIkdv IEJhY2siKTsKLSAgICBFWFBFQ1RfRVEoW3dlYlZpZXcgX3NhZmVCcm93c2luZ1dhcm5pbmdGb3JU ZXN0aW5nXSwgbmlsKTsKKyAgICBFWFBFQ1RfRVEoW3dlYlZpZXcgX3NhZmVCcm93c2luZ1dhcm5p bmddLCBuaWwpOwogfQogCiBURVNUKFNhZmVCcm93c2luZywgVmlzaXRVbnNhZmVXZWJzaXRlKQog ewogICAgIGF1dG8gd2ViVmlldyA9IHNhZmVCcm93c2luZ1ZpZXcoKTsKLSAgICBhdXRvIHdhcm5p bmcgPSBbd2ViVmlldyBfc2FmZUJyb3dzaW5nV2FybmluZ0ZvclRlc3RpbmddOworICAgIGF1dG8g d2FybmluZyA9IFt3ZWJWaWV3IF9zYWZlQnJvd3NpbmdXYXJuaW5nXTsKICAgICBFWFBFQ1RfRVEo d2FybmluZy5zdWJ2aWV3cy5jb3VudCwgMXVsbCk7CiAgICAgY2hlY2tUaXRsZUFuZENsaWNrKHdh cm5pbmcuc3Vidmlld3MuZmlyc3RPYmplY3Quc3Vidmlld3NbNF0sICJTaG93IERldGFpbHMiKTsK ICAgICBFWFBFQ1RfRVEod2FybmluZy5zdWJ2aWV3cy5jb3VudCwgMnVsbCk7CkBAIC0yMjIsOSAr MjIyLDkgQEAgVEVTVChTYWZlQnJvd3NpbmcsIFZpc2l0VW5zYWZlV2Vic2l0ZSkKIFRFU1QoU2Fm ZUJyb3dzaW5nLCBOYXZpZ2F0aW9uQ2xlYXJzV2FybmluZykKIHsKICAgICBhdXRvIHdlYlZpZXcg PSBzYWZlQnJvd3NpbmdWaWV3KCk7Ci0gICAgRVhQRUNUX05FKFt3ZWJWaWV3IF9zYWZlQnJvd3Np bmdXYXJuaW5nRm9yVGVzdGluZ10sIG5pbCk7CisgICAgRVhQRUNUX05FKFt3ZWJWaWV3IF9zYWZl QnJvd3NpbmdXYXJuaW5nXSwgbmlsKTsKICAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpbTlNVUkxS ZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOltbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9yUmVzb3Vy Y2U6QCJzaW1wbGUyIiB3aXRoRXh0ZW5zaW9uOkAiaHRtbCIgc3ViZGlyZWN0b3J5OkAiVGVzdFdl YktpdEFQSS5yZXNvdXJjZXMiXV1dOwotICAgIHdoaWxlIChbd2ViVmlldyBfc2FmZUJyb3dzaW5n V2FybmluZ0ZvclRlc3RpbmddKQorICAgIHdoaWxlIChbd2ViVmlldyBfc2FmZUJyb3dzaW5nV2Fy bmluZ10pCiAgICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNwaW5SdW5Mb29wKCk7CiB9CiAK QEAgLTI0MCwxNyArMjQwLDE3IEBAIFRFU1QoU2FmZUJyb3dzaW5nLCBTaG93V2FybmluZ1NQSSkK ICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyQ2FsbGVkID0gdHJ1ZTsKICAgICAgICAgfV07 CiAjaWYgIVBMQVRGT1JNKE1BQykKLSAgICAgICAgW1t3ZWJWaWV3IF9zYWZlQnJvd3NpbmdXYXJu aW5nRm9yVGVzdGluZ10gZGlkTW92ZVRvV2luZG93XTsKKyAgICAgICAgW1t3ZWJWaWV3IF9zYWZl QnJvd3NpbmdXYXJuaW5nXSBkaWRNb3ZlVG9XaW5kb3ddOwogI2VuZGlmCiAgICAgfTsKIAogICAg IHNob3dXYXJuaW5nKCk7Ci0gICAgY2hlY2tUaXRsZUFuZENsaWNrKFt3ZWJWaWV3IF9zYWZlQnJv d3NpbmdXYXJuaW5nRm9yVGVzdGluZ10uc3Vidmlld3MuZmlyc3RPYmplY3Quc3Vidmlld3NbM10s ICJHbyBCYWNrIik7CisgICAgY2hlY2tUaXRsZUFuZENsaWNrKFt3ZWJWaWV3IF9zYWZlQnJvd3Np bmdXYXJuaW5nXS5zdWJ2aWV3cy5maXJzdE9iamVjdC5zdWJ2aWV3c1szXSwgIkdvIEJhY2siKTsK ICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmNvbXBsZXRpb25IYW5kbGVyQ2FsbGVkKTsK ICAgICBFWFBFQ1RfRkFMU0Uoc2hvdWxkQ29udGludWVWYWx1ZSk7CiAKICAgICBzaG93V2Fybmlu ZygpOwotICAgIFtbd2ViVmlldyBfc2FmZUJyb3dzaW5nV2FybmluZ0ZvclRlc3RpbmddIHBlcmZv cm1TZWxlY3RvcjpOU1NlbGVjdG9yRnJvbVN0cmluZyhAImNsaWNrZWRPbkxpbms6Iikgd2l0aE9i amVjdDpbV0tXZWJWaWV3IF92aXNpdFVuc2FmZVdlYnNpdGVTZW50aW5lbF1dOworICAgIFtbd2Vi VmlldyBfc2FmZUJyb3dzaW5nV2FybmluZ10gcGVyZm9ybVNlbGVjdG9yOk5TU2VsZWN0b3JGcm9t U3RyaW5nKEAiY2xpY2tlZE9uTGluazoiKSB3aXRoT2JqZWN0OltXS1dlYlZpZXcgX3Zpc2l0VW5z YWZlV2Vic2l0ZVNlbnRpbmVsXV07CiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZjb21w bGV0aW9uSGFuZGxlckNhbGxlZCk7CiAgICAgRVhQRUNUX1RSVUUoc2hvdWxkQ29udGludWVWYWx1 ZSk7CiB9Cg==