191975 2018-11-26 12:13:24 -0800 Intersection Observer: rootMargin: '' gives weird results 2018-11-28 07:07:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser ajuma ajuma commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1481621 0 355665 simon.fraser 2018-11-26 12:13:24 -0800 Created attachment 355665 Testcase Setting rootMargin to an empty string causes weird behavior (intersection observations in the wrong place). Doesn't happen in Chrome. 1481954 1 355746 ajuma 2018-11-27 10:22:11 -0800 Created attachment 355746 Patch 1481973 2 ajuma 2018-11-27 11:08:09 -0800 Upstream PR for the new WPT is https://github.com/web-platform-tests/wpt/pull/14266 1482096 3 355746 simon.fraser 2018-11-27 13:53:24 -0800 Comment on attachment 355746 Patch Nice. 1482422 4 355746 commit-queue 2018-11-28 07:06:26 -0800 Comment on attachment 355746 Patch Clearing flags on attachment: 355746 Committed r238610: <https://trac.webkit.org/changeset/238610> 1482423 5 commit-queue 2018-11-28 07:06:27 -0800 All reviewed patches have been landed. Closing bug. 1482424 6 webkit-bug-importer 2018-11-28 07:07:35 -0800 <rdar://problem/46309082> 355665 2018-11-26 12:13:24 -0800 2018-11-26 12:13:24 -0800 Testcase simple-observer.html text/html 2269 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIg Y29udGVudD0id2lkdGg9NjAwIj4KICAgIDxzdHlsZT4KICAgICAgICBib2R5IHsKICAgICAgICAg ICAgaGVpZ2h0OiA1MDAwMHB4OwogICAgICAgIH0KICAgICAgICAKICAgICAgICAjdGFyZ2V0IHsK ICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICB3aWR0aDogMTcwcHg7 CiAgICAgICAgICAgIGhlaWdodDogMjAwcHg7CiAgICAgICAgICAgIHRvcDogMjgwMHB4OwogICAg ICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgICAgICAgICBib3gtc2hhZG93OiAw IDAgMnB4IDIwcHggc2lsdmVyOwogICAgICAgIH0KICAgICAgICAKICAgICAgICAjbG9nZ2luZyB7 CiAgICAgICAgICAgIHBvc2l0aW9uOiBmaXhlZDsKICAgICAgICAgICAgZm9udC1zaXplOiAxMHB4 OwogICAgICAgICAgICB0b3A6IDEwcHg7CiAgICAgICAgICAgIGxlZnQ6IDIwMHB4OwogICAgICAg ICAgICB3aWR0aDogODAlOwogICAgICAgICAgICBoZWlnaHQ6IDgwMHB4OwogICAgICAgICAgICBv dmVyZmxvdzogc2Nyb2xsOwogICAgICAgICAgICAtd2Via2l0LW92ZXJmbG93LXNjcm9sbGluZzog dG91Y2g7CiAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMCwgMCwgMCwgMC4xKTsK ICAgICAgICAgICAgYm9yZGVyLXJhZGl1czogMTBweDsKICAgICAgICAgICAgbWFyZ2luOiA1cHg7 CiAgICAgICAgICAgIGNvbG9yOiBncmF5OwogICAgICAgIH0KICAgIDwvc3R5bGU+CiAgICA8c2Ny aXB0PgogICAgICAgIGZ1bmN0aW9uIGFkZFRvTG9nKHMpCiAgICAgICAgewogICAgICAgICAgICB2 YXIgbG9nZ2luZyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdsb2dnaW5nJyk7CiAgICAgICAg ICAgIGxvZ2dpbmcudGV4dENvbnRlbnQgKz0gcyArICJcbiI7CiAgICAgICAgICAgIGxvZ2dpbmcu c2Nyb2xsVG9wID0gNDAwMDAwOwogICAgICAgIH0KICAgICAgICAKICAgICAgICBmdW5jdGlvbiBp bnRlcnNlY3RlZENhbGxiYWNrKGVudHJpZXMpCiAgICAgICAgewogICAgICAgICAgICBhZGRUb0xv ZygnJyk7CiAgICAgICAgICAgIGFkZFRvTG9nKCdjYWxsYmFjayB3aXRoICcgKyBlbnRyaWVzLmxl bmd0aCArICcgZW50cmllcycpOwogICAgICAgICAgICBmb3IgKHZhciBlbnRyeSBvZiBlbnRyaWVz KSB7CiAgICAgICAgICAgICAgICBhZGRUb0xvZygndGltZTogJyArIGVudHJ5LnRpbWUudG9GaXhl ZCgzKSk7CiAgICAgICAgICAgICAgICBhZGRUb0xvZygncm9vdEJvdW5kczogICAgICAgICAnICsg SlNPTi5zdHJpbmdpZnkoZW50cnkucm9vdEJvdW5kcykpOwogICAgICAgICAgICAgICAgYWRkVG9M b2coJ2JvdW5kaW5nQ2xpZW50UmVjdDogJyArIEpTT04uc3RyaW5naWZ5KGVudHJ5LmJvdW5kaW5n Q2xpZW50UmVjdCkpOwogICAgICAgICAgICAgICAgYWRkVG9Mb2coJ2ludGVyc2VjdGlvblJlY3Q6 ICAgJyArIEpTT04uc3RyaW5naWZ5KGVudHJ5LmludGVyc2VjdGlvblJlY3QpKTsKICAgICAgICAg ICAgICAgIGFkZFRvTG9nKCdpbnRlcnNlY3Rpb25SYXRpbzogICcgKyBlbnRyeS5pbnRlcnNlY3Rp b25SYXRpbyk7CgogICAgICAgICAgICAgICAgYWRkVG9Mb2coJ2FjdHVhbCBCQ1I6ICAgICAgICAg JyArIEpTT04uc3RyaW5naWZ5KGVudHJ5LnRhcmdldC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKSkp OwogICAgICAgICAgICB9CiAgICAgICAgfQoKICAgICAgICB2YXIgb2JzZXJ2ZXI7CiAgICAgICAg ZnVuY3Rpb24gZG9TZXR1cCgpCiAgICAgICAgewogICAgICAgICAgICBvYnNlcnZlciA9IG5ldyBJ bnRlcnNlY3Rpb25PYnNlcnZlcihpbnRlcnNlY3RlZENhbGxiYWNrLCB7CiAgICAgICAgICAgICAg ICB0aHJlc2hvbGQ6IFsgMCwgMC4xLCAwLjIsIDAuMywgMC40LCAwLjUsIDAuNiwgMC43LCAwLjgs IDAuOSwgMSBdLAogICAgICAgICAgICAgICAgcm9vdE1hcmdpbjogJycKICAgICAgICAgICAgfSk7 CiAgICAgICAgICAgIAogICAgICAgICAgICB2YXIgdGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3RhcmdldCcpOwogICAgICAgICAgICBvYnNlcnZlci5vYnNlcnZlKHRhcmdldCk7CiAg ICAgICAgfQogICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZG9TZXR1cCwg ZmFsc2UpOwogICAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjxwcmUgaWQ9ImxvZ2dpbmciPjwv cHJlPgo8ZGl2IGlkPSJ0YXJnZXQiPgo8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg== 355746 2018-11-27 10:22:11 -0800 2018-11-28 07:06:26 -0800 Patch bug-191975-20181127132210.patch text/plain 4499 ajuma U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkxN2U4ZjlhMjk2Yzlh Y2FjMzhkNzFiZDU2MDdhNzc5Mjk1N2Y0MC4uOTQzZDBjMTQwOTcwMWZkNTZkZGY5YTUyZTI3MTRl YzQ4ZTBhOTk1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTExLTI3ICBBbGkg SnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnRlcnNlY3Rpb24gT2JzZXJ2 ZXI6IHJvb3RNYXJnaW46ICcnIGdpdmVzIHdlaXJkIHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTk3NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29udmVydGluZyB0aGUgcm9vdE1h cmdpbiBzdHJpbmcgaW50byBhIExlbmd0aEJveCwgZXhwbGljaXRseSBjb25zdHJ1Y3QgYSBMZW5n dGgKKyAgICAgICAgb2Ygc2l6ZSAwcHggZm9yIGVhY2ggZGltZW5zaW9uLCBpbnN0ZWFkIG9mIHVz aW5nIExlbmd0aCdzIGRlZmF1bHQgY29uc3RydWN0b3IuIFRoZQorICAgICAgICBkZWZhdWx0IGNv bnN0cnVjdG9yIGNyZWF0ZXMgYSBMZW5ndGggd2l0aCB2YWx1ZSBBdXRvLCB3aGljaCBjYXVzZXMg dXMgdG8gaW5jb3JyZWN0bHkKKyAgICAgICAgYXBwbHkgYSBub24temVybyByb290TWFyZ2luLgor CisgICAgICAgIFRlc3Q6IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaW50ZXJzZWN0 aW9uLW9ic2VydmVyL2VtcHR5LXJvb3QtbWFyZ2luLmh0bWwKKworICAgICAgICAqIHBhZ2UvSW50 ZXJzZWN0aW9uT2JzZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VSb290TWFyZ2lu KToKKwogMjAxOC0xMS0yNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjIzODA3OCk6IERvIG5vdCBkcmF3IGNhcHMgbG9jayBpbmRpY2F0 b3Igd2hlbiBTdHJvbmcgUGFzc3dvcmQgYnV0dG9uIGlzIHNob3duCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ludGVyc2VjdGlvbk9ic2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvSW50ZXJzZWN0aW9uT2JzZXJ2ZXIuY3BwCmluZGV4IGMxYzlhODhhZjIzMmIxZTE1Nzlk ODhjNTExMGQ2ZGI4M2EzZjNlMTYuLjBiNGVmMjg4YjM2ZjliNzFjZDY2YzNiZjZhMDUxNWUzOTEx YmNjYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSW50ZXJzZWN0aW9uT2JzZXJ2 ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSW50ZXJzZWN0aW9uT2JzZXJ2ZXIuY3Bw CkBAIC02MCw3ICs2MCw3IEBAIHN0YXRpYyBFeGNlcHRpb25PcjxMZW5ndGhCb3g+IHBhcnNlUm9v dE1hcmdpbihTdHJpbmcmIHJvb3RNYXJnaW4pCiAgICAgc3dpdGNoIChtYXJnaW5zLnNpemUoKSkg ewogICAgIGNhc2UgMDoKICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDQ7ICsraSkK LSAgICAgICAgICAgIG1hcmdpbnMuYXBwZW5kKExlbmd0aCgpKTsKKyAgICAgICAgICAgIG1hcmdp bnMuYXBwZW5kKExlbmd0aCgwLCBGaXhlZCkpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIDE6 CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCAzOyArK2kpCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL0NoYW5nZUxvZwppbmRleCBjZGMyZjliMTcwZDRiNGEyODAzNzlkMmM4ZTM3ZmU5MWUwNDAy MWQxLi40NzM2Y2I0MWQ1ODYxNDFjYzRiZmFmMDY1MzM1YzU5MjM1ZTJjYzVmIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOC0xMS0yNyAgQWxpIEp1 bWEgIDxhanVtYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW50ZXJzZWN0aW9uIE9ic2VydmVy OiByb290TWFyZ2luOiAnJyBnaXZlcyB3ZWlyZCByZXN1bHRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5NzUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGVzdCBjb3ZlcmFnZS4KKworICAgICAg ICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvZW1wdHktcm9vdC1t YXJnaW4tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMv aW50ZXJzZWN0aW9uLW9ic2VydmVyL2VtcHR5LXJvb3QtbWFyZ2luLmh0bWw6IEFkZGVkLgorCiAy MDE4LTExLTI2ICBKYXZpZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtjc3MtZ3JpZF0gYWJzb2x1dGUgcG9zaXRpb25lZCBjaGlsZCBpcyBzaXplZCB3cm9u Z2x5IHdoZW4gdXNpbmcgYXV0by1maXQsIGdlbmVyYXRpbmcgc3B1cmlvdXMgY29sbGFwc2VkIHRy YWNrcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvZW1wdHktcm9vdC1tYXJnaW4tZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9pbnRlcnNlY3Rp b24tb2JzZXJ2ZXIvZW1wdHktcm9vdC1tYXJnaW4tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE2 YjM2ZmEyYzgyNDMwZmJiYzg5Y2EzZTg5YjQ0ODQ1ODRjZjE1OWMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ludGVyc2VjdGlv bi1vYnNlcnZlci9lbXB0eS1yb290LW1hcmdpbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBA CisKK1BBU1MgQW4gZW1wdHkgcm9vdE1hcmdpbiBzdHJpbmcgaXMgaW50ZXJwcmV0ZWQgYXMgYSBt YXJnaW4gb2Ygc2l6ZSB6ZXJvIAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ludGVyc2VjdGlvbi1vYnNlcnZlci9lbXB0eS1yb290LW1h cmdpbi5odG1sIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9p bnRlcnNlY3Rpb24tb2JzZXJ2ZXIvZW1wdHktcm9vdC1tYXJnaW4uaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40 OGM5YWE0ZDUzNWZhMGI2NWMwNGNmMjYyMmU0NzFjYmFkZTIyNGI0Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9pbnRlcnNlY3Rp b24tb2JzZXJ2ZXIvZW1wdHktcm9vdC1tYXJnaW4uaHRtbApAQCAtMCwwICsxLDI4IEBACis8IURP Q1RZUEUgaHRtbD4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3Nj cmlwdD4KKworPHN0eWxlPgorI3RhcmdldCB7CisgIHdpZHRoOiAxMDBweDsKKyAgaGVpZ2h0OiAx MDBweDsKKyAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47Cit9Cis8L3N0eWxlPgorCis8ZGl2IGlk PSJ0YXJnZXQiPjwvZGl2PgorCis8c2NyaXB0PgordmFyIHRhcmdldCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0YXJnZXQiKTsKK2FzeW5jX3Rlc3QoKHQpID0+IHsKKyAgICB2YXIgb2JzZXJ2 ZXIgPSBuZXcgSW50ZXJzZWN0aW9uT2JzZXJ2ZXIodC5zdGVwX2Z1bmNfZG9uZSgoZW50cmllcykg PT4geworICAgICAgICB2YXIgcm9vdEJvdW5kcyA9IGVudHJpZXNbMF0ucm9vdEJvdW5kczsKKyAg ICAgICAgYXNzZXJ0X2VxdWFscyhyb290Qm91bmRzLmxlZnQsIDApOworICAgICAgICBhc3NlcnRf ZXF1YWxzKHJvb3RCb3VuZHMucmlnaHQsIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jbGllbnRX aWR0aCk7CisgICAgICAgIGFzc2VydF9lcXVhbHMocm9vdEJvdW5kcy50b3AsIDApOworICAgICAg ICBhc3NlcnRfZXF1YWxzKHJvb3RCb3VuZHMuYm90dG9tLCBkb2N1bWVudC5kb2N1bWVudEVsZW1l bnQuY2xpZW50SGVpZ2h0KTsKKyAgICAgICAgb2JzZXJ2ZXIuZGlzY29ubmVjdCgpOworICAgIH0p LCB7IHJvb3RNYXJnaW46ICIiIH0pOworICAgIG9ic2VydmVyLm9ic2VydmUoZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInRhcmdldCIpKTsKK30sICJBbiBlbXB0eSByb290TWFyZ2luIHN0cmluZyBp cyBpbnRlcnByZXRlZCBhcyBhIG1hcmdpbiBvZiBzaXplIHplcm8iKTsKKzwvc2NyaXB0Pgo=