191949 2018-11-24 21:31:53 -0800 [LFC] Floating code should use typed positions (PositionInContextRoot). 2018-11-25 13:32:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1481350 0 zalan 2018-11-24 21:31:53 -0800 instead of LayoutUnit 1481351 1 355581 zalan 2018-11-24 21:33:18 -0800 Created attachment 355581 Patch 1481403 2 zalan 2018-11-25 13:30:40 -0800 Committed r238480: <https://trac.webkit.org/changeset/238480> 1481404 3 webkit-bug-importer 2018-11-25 13:32:00 -0800 <rdar://problem/46233009> 355581 2018-11-24 21:33:18 -0800 2018-11-25 10:03:57 -0800 Patch bug-191949-20181124213317.patch text/plain 5481 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTEwNDUwZTQ2ZWJiYmQw ZTdhMmI1NDNlYTA2ODE5MWNmNjhjZmQ0ZS4uNzRiMTkyZGY2ZWJiYzFkNzI5ZTMwNDUwY2IxYTQ1 ZDQyZTFjNTQ2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTExLTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRmxvYXRpbmcgY29k ZSBzaG91bGQgdXNlIHR5cGVkIHBvc2l0aW9ucyAoUG9zaXRpb25JbkNvbnRleHRSb290KS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTk0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBQb3NpdGlv bkluQ29udGV4dFJvb3QgaW5zdGVhZCBvZiBMYXlvdXRVbml0LgorCisgICAgICAgICogbGF5b3V0 L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Rmxv YXRpbmdTdGF0ZTo6Y29uc3RyYWludHMgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 OjpGbG9hdGluZ1N0YXRlOjpib3R0b20gY29uc3QpOgorICAgICAgICAqIGxheW91dC9mbG9hdHMv RmxvYXRpbmdTdGF0ZS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpGbG9hdGluZ1N0YXRl OjpsZWZ0Qm90dG9tIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6RmxvYXRpbmdT dGF0ZTo6cmlnaHRCb3R0b20gY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpGbG9h dGluZ1N0YXRlOjpib3R0b20gY29uc3QpOgorCiAyMDE4LTExLTIzICBaYWxhbiBCdXRqYXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBZGQgc3VwcG9ydCBmb3IgdmFy aWFibGUgaGVpZ2h0IHJ1bnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxv YXRzL0Zsb2F0aW5nU3RhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9h dGluZ1N0YXRlLmNwcAppbmRleCA5MGY4MTFhZGM2OGQ4ZjI3ZWYzMTljYWNlNTA3MGEzZTY2OWNm YzgxLi5kMTk2NWFjNDEwN2NkZTJmNGM0YTM3NjVlMDdjOWU3NzljMWFlMGMxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKQEAgLTg2LDcgKzg2 LDcgQEAgdm9pZCBGbG9hdGluZ1N0YXRlOjphcHBlbmQoY29uc3QgQm94JiBsYXlvdXRCb3gpCiAg ICAgbV9mbG9hdHMuYXBwZW5kKHsgbGF5b3V0Qm94LCAqdGhpcyB9KTsKIH0KIAotRmxvYXRpbmdT dGF0ZTo6Q29uc3RyYWludHMgRmxvYXRpbmdTdGF0ZTo6Y29uc3RyYWludHMoTGF5b3V0VW5pdCB2 ZXJ0aWNhbFBvc2l0aW9uLCBjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9vdCkgY29uc3QK K0Zsb2F0aW5nU3RhdGU6OkNvbnN0cmFpbnRzIEZsb2F0aW5nU3RhdGU6OmNvbnN0cmFpbnRzKFBv c2l0aW9uSW5Db250ZXh0Um9vdCB2ZXJ0aWNhbFBvc2l0aW9uLCBjb25zdCBCb3gmIGZvcm1hdHRp bmdDb250ZXh0Um9vdCkgY29uc3QKIHsKICAgICBpZiAoaXNFbXB0eSgpKQogICAgICAgICByZXR1 cm4geyB9OwpAQCAtMTM0LDE0ICsxMzQsMTQgQEAgRmxvYXRpbmdTdGF0ZTo6Q29uc3RyYWludHMg RmxvYXRpbmdTdGF0ZTo6Y29uc3RyYWludHMoTGF5b3V0VW5pdCB2ZXJ0aWNhbFBvc2l0aW8KICAg ICByZXR1cm4gY29uc3RyYWludHM7CiB9CiAKLXN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4gRmxv YXRpbmdTdGF0ZTo6Ym90dG9tKGNvbnN0IEJveCYgZm9ybWF0dGluZ0NvbnRleHRSb290LCBDbGVh ciB0eXBlKSBjb25zdAorc3RkOjpvcHRpb25hbDxQb3NpdGlvbkluQ29udGV4dFJvb3Q+IEZsb2F0 aW5nU3RhdGU6OmJvdHRvbShjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9vdCwgQ2xlYXIg dHlwZSkgY29uc3QKIHsKICAgICBpZiAobV9mbG9hdHMuaXNFbXB0eSgpKQogICAgICAgICByZXR1 cm4geyB9OwogCiAgICAgLy8gVE9ETzogQ3VycmVudGx5IHRoaXMgaXMgb25seSBjYWxsZWQgb25j ZSBmb3IgZWFjaCBmb3JtYXR0aW5nIGNvbnRleHQgcm9vdCB3aXRoIGZsb2F0cyBwZXIgbGF5b3V0 LgogICAgIC8vIENhY2hlIHRoZSB2YWx1ZSBpZiB3ZSBlbmQgdXAgY2FsbGluZyBpdCBtb3JlIGZy ZXF1ZW50bHkgKGFuZCB1cGRhdGUgaXQgYXQgYXBwZW5kL3JlbW92ZSkuCi0gICAgc3RkOjpvcHRp b25hbDxMYXlvdXRVbml0PiBib3R0b207CisgICAgc3RkOjpvcHRpb25hbDxQb3NpdGlvbkluQ29u dGV4dFJvb3Q+IGJvdHRvbTsKICAgICBmb3IgKGF1dG8mIGZsb2F0SXRlbSA6IG1fZmxvYXRzKSB7 CiAgICAgICAgIC8vIElnbm9yZSBmbG9hdHMgZnJvbSBvdGhlciBmb3JtYXR0aW5nIGNvbnRleHRz IHdoZW4gdGhlIGZsb2F0aW5nIHN0YXRlIGlzIGluaGVyaXRlZC4KICAgICAgICAgaWYgKCFmbG9h dEl0ZW0uaW5Gb3JtYXR0aW5nQ29udGV4dChmb3JtYXR0aW5nQ29udGV4dFJvb3QpKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuaAppbmRleCA2ZjE2ZWRmZWM5 N2MwOGYyMjQ2NGM4N2E3OGJmZDgwN2NjYWI4MmIxLi4zYjFjZmEyMmM4MzhiMmRkOGQ4MWI5ZTVk MWNkZWEwOTg1MjliMjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRz L0Zsb2F0aW5nU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0 aW5nU3RhdGUuaApAQCAtNTQsMTUgKzU0LDE1IEBAIHB1YmxpYzoKIAogICAgIGNvbnN0IEJveCYg cm9vdCgpIGNvbnN0IHsgcmV0dXJuICptX2Zvcm1hdHRpbmdDb250ZXh0Um9vdDsgfQogCi0gICAg c3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiBsZWZ0Qm90dG9tKGNvbnN0IEJveCYgZm9ybWF0dGlu Z0NvbnRleHRSb290KSBjb25zdDsKLSAgICBzdGQ6Om9wdGlvbmFsPExheW91dFVuaXQ+IHJpZ2h0 Qm90dG9tKGNvbnN0IEJveCYgZm9ybWF0dGluZ0NvbnRleHRSb290KSBjb25zdDsKLSAgICBzdGQ6 Om9wdGlvbmFsPExheW91dFVuaXQ+IGJvdHRvbShjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0 Um9vdCkgY29uc3Q7CisgICAgc3RkOjpvcHRpb25hbDxQb3NpdGlvbkluQ29udGV4dFJvb3Q+IGxl ZnRCb3R0b20oY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNvbnN0OworICAgIHN0 ZDo6b3B0aW9uYWw8UG9zaXRpb25JbkNvbnRleHRSb290PiByaWdodEJvdHRvbShjb25zdCBCb3gm IGZvcm1hdHRpbmdDb250ZXh0Um9vdCkgY29uc3Q7CisgICAgc3RkOjpvcHRpb25hbDxQb3NpdGlv bkluQ29udGV4dFJvb3Q+IGJvdHRvbShjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9vdCkg Y29uc3Q7CiAKICAgICBzdHJ1Y3QgQ29uc3RyYWludHMgewotICAgICAgICBzdGQ6Om9wdGlvbmFs PExheW91dFVuaXQ+IGxlZnQ7Ci0gICAgICAgIHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4gcmln aHQ7CisgICAgICAgIHN0ZDo6b3B0aW9uYWw8UG9zaXRpb25JbkNvbnRleHRSb290PiBsZWZ0Owor ICAgICAgICBzdGQ6Om9wdGlvbmFsPFBvc2l0aW9uSW5Db250ZXh0Um9vdD4gcmlnaHQ7CiAgICAg fTsKLSAgICBDb25zdHJhaW50cyBjb25zdHJhaW50cyhMYXlvdXRVbml0IHZlcnRpY2FsUG9zaXRp b24sIGNvbnN0IEJveCYgZm9ybWF0dGluZ0NvbnRleHRSb290KSBjb25zdDsKKyAgICBDb25zdHJh aW50cyBjb25zdHJhaW50cyhQb3NpdGlvbkluQ29udGV4dFJvb3QgdmVydGljYWxQb3NpdGlvbiwg Y29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNvbnN0OwogCiAgICAgY2xhc3MgRmxv YXRJdGVtIHsKICAgICBwdWJsaWM6CkBAIC05MCwyNiArOTAsMjYgQEAgcHJpdmF0ZToKIAogICAg IExheW91dFN0YXRlJiBsYXlvdXRTdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbGF5b3V0U3RhdGU7 IH0KIAotICAgIHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4gYm90dG9tKGNvbnN0IEJveCYgZm9y bWF0dGluZ0NvbnRleHRSb290LCBDbGVhcikgY29uc3Q7CisgICAgc3RkOjpvcHRpb25hbDxQb3Np dGlvbkluQ29udGV4dFJvb3Q+IGJvdHRvbShjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9v dCwgQ2xlYXIpIGNvbnN0OwogCiAgICAgTGF5b3V0U3RhdGUmIG1fbGF5b3V0U3RhdGU7CiAgICAg V2Vha1B0cjxjb25zdCBCb3g+IG1fZm9ybWF0dGluZ0NvbnRleHRSb290OwogICAgIEZsb2F0TGlz dCBtX2Zsb2F0czsKIH07CiAKLWlubGluZSBzdGQ6Om9wdGlvbmFsPExheW91dFVuaXQ+IEZsb2F0 aW5nU3RhdGU6OmxlZnRCb3R0b20oY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNv bnN0CitpbmxpbmUgc3RkOjpvcHRpb25hbDxQb3NpdGlvbkluQ29udGV4dFJvb3Q+IEZsb2F0aW5n U3RhdGU6OmxlZnRCb3R0b20oY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNvbnN0 CiB7IAogICAgIEFTU0VSVChmb3JtYXR0aW5nQ29udGV4dFJvb3QuZXN0YWJsaXNoZXNGb3JtYXR0 aW5nQ29udGV4dCgpKTsKICAgICByZXR1cm4gYm90dG9tKGZvcm1hdHRpbmdDb250ZXh0Um9vdCwg Q2xlYXI6OkxlZnQpOwogfQogCi1pbmxpbmUgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiBGbG9h dGluZ1N0YXRlOjpyaWdodEJvdHRvbShjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9vdCkg Y29uc3QKK2lubGluZSBzdGQ6Om9wdGlvbmFsPFBvc2l0aW9uSW5Db250ZXh0Um9vdD4gRmxvYXRp bmdTdGF0ZTo6cmlnaHRCb3R0b20oY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNv bnN0CiB7CiAgICAgQVNTRVJUKGZvcm1hdHRpbmdDb250ZXh0Um9vdC5lc3RhYmxpc2hlc0Zvcm1h dHRpbmdDb250ZXh0KCkpOwogICAgIHJldHVybiBib3R0b20oZm9ybWF0dGluZ0NvbnRleHRSb290 LCBDbGVhcjo6UmlnaHQpOwogfQogCi1pbmxpbmUgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiBG bG9hdGluZ1N0YXRlOjpib3R0b20oY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNv bnN0CitpbmxpbmUgc3RkOjpvcHRpb25hbDxQb3NpdGlvbkluQ29udGV4dFJvb3Q+IEZsb2F0aW5n U3RhdGU6OmJvdHRvbShjb25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9vdCkgY29uc3QKIHsK ICAgICBBU1NFUlQoZm9ybWF0dGluZ0NvbnRleHRSb290LmVzdGFibGlzaGVzRm9ybWF0dGluZ0Nv bnRleHQoKSk7CiAgICAgcmV0dXJuIGJvdHRvbShmb3JtYXR0aW5nQ29udGV4dFJvb3QsIENsZWFy OjpCb3RoKTsK