191946 2018-11-24 11:11:31 -0800 Remove now unnecessary specialized ListHashSet from InlineItem.h 2018-11-24 16:38:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam commit-queue webkit-bug-importer zalan oldest_to_newest 1481314 0 sam 2018-11-24 11:11:31 -0800 Remove now unnecessary specialized ListHashSet from InlineItem.h 1481315 1 355567 sam 2018-11-24 11:13:32 -0800 Created attachment 355567 Patch 1481317 2 zalan 2018-11-24 16:10:27 -0800 (In reply to Sam Weinig from comment #1) > Created attachment 355567 [details] > Patch Thanks Sam! You are the best! 1481318 3 355567 commit-queue 2018-11-24 16:37:13 -0800 Comment on attachment 355567 Patch Clearing flags on attachment: 355567 Committed r238472: <https://trac.webkit.org/changeset/238472> 1481319 4 commit-queue 2018-11-24 16:37:14 -0800 All reviewed patches have been landed. Closing bug. 1481320 5 webkit-bug-importer 2018-11-24 16:38:27 -0800 <rdar://problem/46229420> 355567 2018-11-24 11:13:32 -0800 2018-11-24 16:37:13 -0800 Patch bug-191946-20181124111332.patch text/plain 5674 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODQ3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE4LTExLTI0ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIG5vdyB1bm5lY2Vzc2FyeSBz cGVjaWFsaXplZCBMaXN0SGFzaFNldCBmcm9tIElubGluZUl0ZW0uaAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTQ2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IHRoYXQgTGlzdEhhc2hTZXQgc3Vw cG9ydHMgcmF3IHBvaW50ZXIgb3ZlcmxvYWRzIGZvciBzbWFydCBwb2ludGVycywKKyAgICAgICAg d2UgY2FuIGZpeCB0aGUgRklYTUUgaW4gSW5saW5lSXRlbS5oIGFuZCByZW1vdmUgdGhlIHNwZWNp YWxpemVkIExpc3RIYXNoU2V0CisgICAgICAgIGFuZCBMaXN0SGFzaFNldDo6ZmluZCBjYWxscy4K KworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250 ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRl eHQ6OnNwbGl0SW5saW5lUnVuSWZOZWVkZWQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6Y29sbGVjdElubGluZUNvbnRlbnRGb3JTdWJ0 cmVlIGNvbnN0KToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt YXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5s aW5lRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjpydW5XaWR0aCk6CisgICAgICAgICogbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lSXRlbS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpJbmxpbmVJdGVtSGFzaEZ1bmN0aW9uczo6aGFzaCk6IERlbGV0ZWQuCisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OklubGluZUl0ZW1IYXNoRnVuY3Rpb25zOjplcXVhbCk6IERlbGV0ZWQu CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUl0ZW1IYXNoVHJhbnNsYXRvcjo6aGFz aCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUl0ZW1IYXNoVHJh bnNsYXRvcjo6ZXF1YWwpOiBEZWxldGVkLgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUxpbmVCcmVha2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5s aW5lTGluZUJyZWFrZXI6OnRleHRXaWR0aCBjb25zdCk6CisKIDIwMTgtMTEtMjQgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gU09GVF9MSU5LX0NMQVNT X0ZPUl97SEVBREVSLFNPVVJDRX0gc2hvdWxkIGdlbmVyYXRlIGEgbW9yZSBjb25jaXNlIGdldHRl ciBmdW5jdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcAkocmV2 aXNpb24gMjM4NDcwKQorKysgU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjIsNyArMTYy LDcgQEAgdm9pZCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6c3BsaXRJbmxpbgogICAgICAgICB1 bmNvbW1pdHRlZCA9IHsgfTsKICAgICB9OwogCi0gICAgZm9yIChhdXRvIGl0ZXJhdG9yID0gaW5s aW5lQ29udGVudC5maW5kPGNvbnN0IElubGluZUl0ZW0mLCBJbmxpbmVJdGVtSGFzaFRyYW5zbGF0 b3I+KGlubGluZVJ1bi5pbmxpbmVJdGVtKCkpOyBpdGVyYXRvciAhPSBpbmxpbmVDb250ZW50LmVu ZCgpICYmIHJlbWFuaW5nTGVuZ3RoID4gMDsgKytpdGVyYXRvcikgeworICAgIGZvciAoYXV0byBp dGVyYXRvciA9IGlubGluZUNvbnRlbnQuZmluZCgmaW5saW5lUnVuLmlubGluZUl0ZW0oKSk7IGl0 ZXJhdG9yICE9IGlubGluZUNvbnRlbnQuZW5kKCkgJiYgcmVtYW5pbmdMZW5ndGggPiAwOyArK2l0 ZXJhdG9yKSB7CiAgICAgICAgIGF1dG8mIGlubGluZUl0ZW0gPSAqKml0ZXJhdG9yOwogCiAgICAg ICAgIC8vIFNraXAgYWxsIG5vbi1pbmZsb3cgYm94ZXMgKGZsb2F0cywgb3V0LW9mLWZsb3cgcG9z aXRpb25lZCBlbGVtZW50cykuIFRoZXkgZG9uJ3QgcGFydGljaXBhdGUgaW4gdGhlIGlubGluZSBy dW4gY29udGV4dC4KQEAgLTQ4OSw3ICs0ODksNyBAQCB2b2lkIElubGluZUZvcm1hdHRpbmdDb250 ZXh0Ojpjb2xsZWN0SW5sCiAgICAgICAgIGF1dG8mIGlubGluZUNvbnRlbnQgPSBpbmxpbmVGb3Jt YXR0aW5nU3RhdGUuaW5saW5lQ29udGVudCgpOwogCiAgICAgICAgIGlmIChsYXN0SW5saW5lQm94 QmVmb3JlQ29udGFpbmVyKSB7Ci0gICAgICAgICAgICBhdXRvIGl0ZXJhdG9yID0gaW5saW5lQ29u dGVudC5maW5kPGNvbnN0IElubGluZUl0ZW0mLCBJbmxpbmVJdGVtSGFzaFRyYW5zbGF0b3I+KCps YXN0SW5saW5lQm94QmVmb3JlQ29udGFpbmVyKTsKKyAgICAgICAgICAgIGF1dG8gaXRlcmF0b3Ig PSBpbmxpbmVDb250ZW50LmZpbmQobGFzdElubGluZUJveEJlZm9yZUNvbnRhaW5lcik7CiAgICAg ICAgICAgICBmaXJzdERlc2NlbmRhbnRJbmxpbmVCb3ggPSAoKisraXRlcmF0b3IpLmdldCgpOwog ICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIGZpcnN0RGVzY2VuZGFudElubGluZUJveCA9IGlu bGluZUNvbnRlbnQuZmlyc3QoKS5nZXQoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZv cm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCShyZXZpc2lvbiAyMzg0NzApCisrKyBTb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdl b21ldHJ5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgwLDcgKzE4MCw3IEBAIExheW91dFVuaXQg SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6Okdlb20KIHsKICAgICBMYXlvdXRVbml0IHdpZHRoOwog ICAgIGF1dG8gc3RhcnRQb3NpdGlvbiA9IGZyb207Ci0gICAgYXV0byBpdGVyYXRvciA9IGlubGlu ZUNvbnRlbnQuZmluZDxjb25zdCBJbmxpbmVJdGVtJiwgSW5saW5lSXRlbUhhc2hUcmFuc2xhdG9y PihpbmxpbmVJdGVtKTsKKyAgICBhdXRvIGl0ZXJhdG9yID0gaW5saW5lQ29udGVudC5maW5kKCZp bmxpbmVJdGVtKTsKICAgICBhdXRvIGlubGluZUl0ZW1FbmQgPSBpbmxpbmVDb250ZW50LmVuZCgp OwogICAgIHdoaWxlIChsZW5ndGgpIHsKICAgICAgICAgQVNTRVJUKGl0ZXJhdG9yICE9IGlubGlu ZUl0ZW1FbmQpOwpJbmRleDogU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lSXRlbS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUl0ZW0uaAkocmV2aXNpb24gMjM4NDcwKQorKysgU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lSXRlbS5oCSh3b3JraW5nIGNvcHkpCkBA IC04MywxNyArODMsNyBAQCBwcml2YXRlOgogICAgIExheW91dFVuaXQgbV9ub25CcmVha2FibGVF bmQ7CiB9OwogCi0vLyBGSVhNRTogRml4IEhhc2hTZXQvTGlzdEhhc2hTZXQgdG8gc3VwcG9ydCBz bWFydCBwb2ludGVyIHR5cGVzLgotc3RydWN0IElubGluZUl0ZW1IYXNoRnVuY3Rpb25zIHsKLSAg ICBzdGF0aWMgdW5zaWduZWQgaGFzaChjb25zdCBzdGQ6OnVuaXF1ZV9wdHI8SW5saW5lSXRlbT4m IGtleSkgeyByZXR1cm4gUHRySGFzaDxJbmxpbmVJdGVtKj46Omhhc2goa2V5LmdldCgpKTsgfQot ICAgIHN0YXRpYyBib29sIGVxdWFsKGNvbnN0IHN0ZDo6dW5pcXVlX3B0cjxJbmxpbmVJdGVtPiYg YSwgY29uc3Qgc3RkOjp1bmlxdWVfcHRyPElubGluZUl0ZW0+JiBiKSB7IHJldHVybiBhLmdldCgp ID09IGIuZ2V0KCk7IH0KLX07Ci0KLXN0cnVjdCBJbmxpbmVJdGVtSGFzaFRyYW5zbGF0b3Igewot ICAgIHN0YXRpYyB1bnNpZ25lZCBoYXNoKGNvbnN0IElubGluZUl0ZW0mIGtleSkgeyByZXR1cm4g UHRySGFzaDxjb25zdCBJbmxpbmVJdGVtKj46Omhhc2goJmtleSk7IH0KLSAgICBzdGF0aWMgYm9v bCBlcXVhbChjb25zdCBzdGQ6OnVuaXF1ZV9wdHI8SW5saW5lSXRlbT4mIGEsIGNvbnN0IElubGlu ZUl0ZW0mIGIpIHsgcmV0dXJuIGEuZ2V0KCkgPT0gJmI7IH0KLX07Ci11c2luZyBJbmxpbmVDb250 ZW50ID0gTGlzdEhhc2hTZXQ8c3RkOjp1bmlxdWVfcHRyPElubGluZUl0ZW0+LCBJbmxpbmVJdGVt SGFzaEZ1bmN0aW9ucz47Cit1c2luZyBJbmxpbmVDb250ZW50ID0gTGlzdEhhc2hTZXQ8c3RkOjp1 bmlxdWVfcHRyPElubGluZUl0ZW0+PjsKIAogaW5saW5lIElubGluZUl0ZW06OklubGluZUl0ZW0o Y29uc3QgQm94JiBsYXlvdXRCb3gpCiAgICAgOiBtX2xheW91dEJveChsYXlvdXRCb3gpCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp bmcvSW5saW5lTGluZUJyZWFrZXIuY3BwCShyZXZpc2lvbiAyMzg0NzApCisrKyBTb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE2MSw3ICsxNjEsNyBAQCBMYXlvdXRVbml0IElubGluZUxpbmVCcmVha2Vy Ojp0ZXh0V2lkdGgoCiAKICAgICAvLyBGSVhNRTogSXQgZG9lcyBub3QgZG8gcHJvcGVyIGtlcm5p bmcvbGlnYXR1cmUgaGFuZGxpbmcuCiAgICAgTGF5b3V0VW5pdCB3aWR0aDsKLSAgICBhdXRvIGl0 ZXJhdG9yID0gbV9pbmxpbmVDb250ZW50LmZpbmQ8Y29uc3QgSW5saW5lSXRlbSYsIElubGluZUl0 ZW1IYXNoVHJhbnNsYXRvcj4oaW5saW5lSXRlbSk7CisgICAgYXV0byBpdGVyYXRvciA9IG1faW5s aW5lQ29udGVudC5maW5kKCZpbmxpbmVJdGVtKTsKICAgICBhdXRvIGlubGluZUl0ZW1FbmQgPSBt X2lubGluZUNvbnRlbnQuZW5kKCk7CiAgICAgd2hpbGUgKGxlbmd0aCkgewogICAgICAgICBBU1NF UlQoaXRlcmF0b3IgIT0gaW5saW5lSXRlbUVuZCk7Cg==