191945 2018-11-24 10:24:42 -0800 [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm 2018-11-24 17:46:04 -0800 1 1 1 Unclassified WebKit HTML Editing Other Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1481308 0 wenson_hsieh 2018-11-24 10:24:42 -0800 SSIA 1481309 1 355566 wenson_hsieh 2018-11-24 10:31:15 -0800 Created attachment 355566 Patch 1481322 2 355566 commit-queue 2018-11-24 17:46:02 -0800 Comment on attachment 355566 Patch Clearing flags on attachment: 355566 Committed r238473: <https://trac.webkit.org/changeset/238473> 1481323 3 commit-queue 2018-11-24 17:46:04 -0800 All reviewed patches have been landed. Closing bug. 355566 2018-11-24 10:31:15 -0800 2018-11-24 17:46:02 -0800 Patch bug-191945-20181124103111.patch text/plain 6813 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYzNDdhZmUxMDkyNzM3 ODVkMjQxYzcwZGVjOGNjZDRkYTFhNDJhYS4uOWFiYzU5NzZlNmVkNGNlYTZlMjU2NTE1NDUxMDE4 ZWE1ODVjOGRiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTExLTI0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gRml4 IGEgZmV3IGxvY2FsaXphYmxlIHN0cmluZyBkZXNjcmlwdGlvbnMgaW4gV2ViRWRpdENvbW1hbmRQ cm94eS5jcHAgYW5kIFdlYkVkaXRvckNsaWVudC5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUnVuIGB1cGRhdGUtd2Via2l0LWxvY2FsaXphYmxlLXN0 cmluZ3NgLgorCisgICAgICAgICogZW4ubHByb2ovTG9jYWxpemFibGUuc3RyaW5nczoKKwogMjAx OC0xMS0yMyAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtX ZWJBdXRoTl0gRW5hYmxlIFdlYiBBdXRoZW50aWNhdGlvbiBhcyBhbiBleHBlcmltZW50YWwgZmVh dHVyZSBmb3IgbWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZDI5YmQ1MWY3OWQ3ZDViNjRlMzAxYTlhNTc1YjFh MTQ4YmM3ODRmYS4uMTQyZmQyMjY4MDgzY2VkYzhiZTc3ZDU0MWNiMTZiNTliZjhkZWFhOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0xMS0yNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29u X2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIEZpeCBhIGZldyBsb2NhbGl6YWJs ZSBzdHJpbmcgZGVzY3JpcHRpb25zIGluIFdlYkVkaXRDb21tYW5kUHJveHkuY3BwIGFuZCBXZWJF ZGl0b3JDbGllbnQubW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MTk0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlcGxhY2Ugc29tZSBhIGNvdXBsZSBvZiBjb21tYW5kIHVuZG8gYWN0aW9uIG5hbWUg ZGVzY3JpcHRpb25zIHdpdGggIlVuZG8gYWN0aW9uIG5hbWUiLCB0byBtYXRjaCBhbGwgb3RoZXIK KyAgICAgICAgZWRpdCBjb21tYW5kcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJFZGl0Q29t bWFuZFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRWRpdENvbW1hbmRQcm94eTo6bmFt ZUZvckVkaXRBY3Rpb24pOgorCiAyMDE4LTExLTIzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXBsYWNlIExheWVyT3JWaWV3IHR5cGVkZWYgd2l0aCBhIGNs YXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5kZXggYmI3ZTVlMGMwN2IzZjIzNTYyNGYy MTI4MzUzOTE1M2M1YzY5MDhmMS4uN2JlOTZlM2UwN2UyNDgzZTNkYmJhMTZlNTJiMmI0M2EzYjYw M2M0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4 LTExLTI0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAg IFtDb2NvYV0gRml4IGEgZmV3IGxvY2FsaXphYmxlIHN0cmluZyBkZXNjcmlwdGlvbnMgaW4gV2Vi RWRpdENvbW1hbmRQcm94eS5jcHAgYW5kIFdlYkVkaXRvckNsaWVudC5tbQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJF ZGl0b3JDbGllbnQubW06CisgICAgICAgICh1bmRvTmFtZUZvckVkaXRBY3Rpb24pOgorCiAyMDE4 LTExLTIzICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAg IEVuYWJsZSBkcmFnIGFuZCBkcm9wIHN1cHBvcnQgZm9yIGlPU01hYwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncyBiL1NvdXJjZS9XZWJDb3Jl L2VuLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggNjAxNmQzMGM4OWFlYWRjZWY3OTI4 OTcwZjNiMTQyMTJkMWZjOTI2Yi4uNWYxYjU4OWQyMTNmOWI3M2RmYjFmZDVmMTdkZGEyMTgwZDJj NTg2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3Ry aW5ncworKysgYi9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCkBA IC0xODcsMTAgKzE4NywxMCBAQAogLyogTWVkaWEgQ29udHJvbHMgY29udGV4dCBtZW51IGl0ZW0g Ki8KICJDb250cm9scyIgPSAiQ29udHJvbHMiOwogCi0vKiBDb252ZXJ0IHRvIG9yZGVyZWQgbGlz dCBhY3Rpb24gbmFtZSAqLworLyogVW5kbyBhY3Rpb24gbmFtZSAqLwogIkNvbnZlcnQgdG8gT3Jk ZXJlZCBMaXN0IChVbmRvIGFjdGlvbiBuYW1lKSIgPSAiQ29udmVydCB0byBPcmRlcmVkIExpc3Qi OwogCi0vKiBDb252ZXJ0IHRvIHVub3JkZXJlZCBsaXN0IGFjdGlvbiBuYW1lICovCisvKiBVbmRv IGFjdGlvbiBuYW1lICovCiAiQ29udmVydCB0byBVbm9yZGVyZWQgTGlzdCAoVW5kbyBhY3Rpb24g bmFtZSkiID0gIkNvbnZlcnQgdG8gVW5vcmRlcmVkIExpc3QiOwogCiAvKiBDb3B5IGNvbnRleHQg bWVudSBpdGVtICovCkBAIC01OTUsMTIgKzU5NSwxMiBAQAogLyogU2VhcmNoIGluIFNwb3RsaWdo dCBjb250ZXh0IG1lbnUgaXRlbSAqLwogIlNlYXJjaCBpbiBTcG90bGlnaHQiID0gIlNlYXJjaCBp biBTcG90bGlnaHQiOwogCi0vKiBTZWFyY2ggd2l0aCBzZWFyY2ggcHJvdmlkZXIgY29udGV4dCBt ZW51IGl0ZW0gd2l0aCBwcm92aWRlciBuYW1lIGluc2VydGVkICovCi0iU2VhcmNoIHdpdGggJUAi ID0gIlNlYXJjaCB3aXRoICVAIjsKLQogLyogU2VhcmNoIHRoZSBXZWIgY29udGV4dCBtZW51IGl0 ZW0gKi8KICJTZWFyY2ggdGhlIFdlYiIgPSAiU2VhcmNoIHRoZSBXZWIiOwogCisvKiBTZWFyY2gg d2l0aCBzZWFyY2ggcHJvdmlkZXIgY29udGV4dCBtZW51IGl0ZW0gd2l0aCBwcm92aWRlciBuYW1l IGluc2VydGVkICovCisiU2VhcmNoIHdpdGggJUAiID0gIlNlYXJjaCB3aXRoICVAIjsKKwogLyog VmFsaWRhdGlvbiBtZXNzYWdlIGZvciByZXF1aXJlZCBmaWxlIGlucHV0cyB0aGF0IGhhdmUgbm8g dmFsdWUgKi8KICJTZWxlY3QgYSBmaWxlIiA9ICJTZWxlY3QgYSBmaWxlIjsKIApAQCAtODIwLDYg KzgyMCw5IEBACiAvKiBhY2Nlc3NpYmlsaXR5IHJvbGUgZGVzY3JpcHRpb24gZm9yIGEgVVJMIGZp ZWxkLiAqLwogIlVSTCBmaWVsZCIgPSAiVVJMIGZpZWxkIjsKIAorLyogVW5hY2NlcHRhYmxlIFRM UyBjZXJ0aWZpY2F0ZSBlcnJvciAqLworIlVuYWNjZXB0YWJsZSBUTFMgY2VydGlmaWNhdGUiID0g IlVuYWNjZXB0YWJsZSBUTFMgY2VydGlmaWNhdGUiOworCiAvKiBVbmRlcmxpbmUgY29udGV4dCBt ZW51IGl0ZW0gKi8KICJVbmRlcmxpbmUiID0gIlVuZGVybGluZSI7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkVkaXRDb21tYW5kUHJveHkuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViRWRpdENvbW1hbmRQcm94eS5jcHAKaW5kZXggY2RiNTYyZjU5N2Zj Yjg5OTQ3OTIxOTA2MWMzY2RhMjhkMmM0ZWFkMC4uY2Q1N2M2MmZiNGRiNzVlZWZhNzBkOGVlOWU0 MjE3ZWZiNDFhNzBjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViRWRp dENvbW1hbmRQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViRWRpdENv bW1hbmRQcm94eS5jcHAKQEAgLTE3NCw5ICsxNzQsOSBAQCBTdHJpbmcgV2ViRWRpdENvbW1hbmRQ cm94eTo6bmFtZUZvckVkaXRBY3Rpb24oRWRpdEFjdGlvbiBlZGl0QWN0aW9uKQogICAgIC8vIEZJ WE1FOiBXZSBzaG91bGQgZ2l2ZSBpbnRlcm5hbCBjbGllbnRzIGEgd2F5IHRvIG92ZXJyaWRlIHRo ZXNlIHVuZG8gbmFtZXMuIEZvciBpbnN0YW5jZSwgTWFpbCByZWZlcnMgdG8gb3JkZXJlZCBhbmQg dW5vcmRlcmVkIGxpc3RzIGFzICJudW1iZXJlZCIgYW5kICJidWxsZXRlZCIgbGlzdHMsIHJlc3Bl Y3RpdmVseSwKICAgICAvLyBkZXNwaXRlIHRoZSBmYWN0IHRoYXQgb3JkZXJlZCBhbmQgdW5vcmRl cmVkIGxpc3RzIGFyZSBub3QgbmVjZXNzYXJpbHkgZGlzcGxheWVkIHVzaW5nIGJ1bGxldHMgYW5k IG51bWVyYWxzLgogICAgIGNhc2UgRWRpdEFjdGlvbjo6Q29udmVydFRvT3JkZXJlZExpc3Q6Ci0g ICAgICAgIHJldHVybiBXRUJfVUlfU1RSSU5HX0tFWSgiQ29udmVydCB0byBPcmRlcmVkIExpc3Qi LCAiQ29udmVydCB0byBPcmRlcmVkIExpc3QgKFVuZG8gYWN0aW9uIG5hbWUpIiwgIkNvbnZlcnQg dG8gb3JkZXJlZCBsaXN0IGFjdGlvbiBuYW1lIik7CisgICAgICAgIHJldHVybiBXRUJfVUlfU1RS SU5HX0tFWSgiQ29udmVydCB0byBPcmRlcmVkIExpc3QiLCAiQ29udmVydCB0byBPcmRlcmVkIExp c3QgKFVuZG8gYWN0aW9uIG5hbWUpIiwgIlVuZG8gYWN0aW9uIG5hbWUiKTsKICAgICBjYXNlIEVk aXRBY3Rpb246OkNvbnZlcnRUb1Vub3JkZXJlZExpc3Q6Ci0gICAgICAgIHJldHVybiBXRUJfVUlf U1RSSU5HX0tFWSgiQ29udmVydCB0byBVbm9yZGVyZWQgTGlzdCIsICJDb252ZXJ0IHRvIFVub3Jk ZXJlZCBMaXN0IChVbmRvIGFjdGlvbiBuYW1lKSIsICJDb252ZXJ0IHRvIHVub3JkZXJlZCBsaXN0 IGFjdGlvbiBuYW1lIik7CisgICAgICAgIHJldHVybiBXRUJfVUlfU1RSSU5HX0tFWSgiQ29udmVy dCB0byBVbm9yZGVyZWQgTGlzdCIsICJDb252ZXJ0IHRvIFVub3JkZXJlZCBMaXN0IChVbmRvIGFj dGlvbiBuYW1lKSIsICJVbmRvIGFjdGlvbiBuYW1lIik7CiAgICAgfQogICAgIHJldHVybiBTdHJp bmcoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBw b3J0L1dlYkVkaXRvckNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVT dXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQppbmRleCAyZWIyMGIyMzQzMTM2NjFhNmM0NWUwN2Nj ZmFiMGM4ZWY5ZDIzMDMyLi45ZmQwYzEyMjZmMmJjODQ5Y2E2NTA5MDU2NmFhMjI0NzNmOWQyODhl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJF ZGl0b3JDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBv cnQvV2ViRWRpdG9yQ2xpZW50Lm1tCkBAIC02NTMsOCArNjUzLDggQEAgc3RhdGljIE5TU3RyaW5n KiB1bmRvTmFtZUZvckVkaXRBY3Rpb24oRWRpdEFjdGlvbiBlZGl0QWN0aW9uKQogICAgIGNhc2Ug RWRpdEFjdGlvbjo6SXRhbGljczogcmV0dXJuIFVJX1NUUklOR19LRVlfSU5URVJOQUwoIkl0YWxp Y3MiLCAiSXRhbGljcyAoVW5kbyBhY3Rpb24gbmFtZSkiLCAiVW5kbyBhY3Rpb24gbmFtZSIpOwog ICAgIGNhc2UgRWRpdEFjdGlvbjo6RGVsZXRlOiByZXR1cm4gVUlfU1RSSU5HX0tFWV9JTlRFUk5B TCgiRGVsZXRlIiwgIkRlbGV0ZSAoVW5kbyBhY3Rpb24gbmFtZSkiLCAiVW5kbyBhY3Rpb24gbmFt ZSIpOwogICAgIGNhc2UgRWRpdEFjdGlvbjo6RGljdGF0aW9uOiByZXR1cm4gVUlfU1RSSU5HX0tF WV9JTlRFUk5BTCgiRGljdGF0aW9uIiwgIkRpY3RhdGlvbiAoVW5kbyBhY3Rpb24gbmFtZSkiLCAi VW5kbyBhY3Rpb24gbmFtZSIpOwotICAgIGNhc2UgRWRpdEFjdGlvbjo6Q29udmVydFRvT3JkZXJl ZExpc3Q6IHJldHVybiBVSV9TVFJJTkdfS0VZX0lOVEVSTkFMKCJDb252ZXJ0IHRvIE9yZGVyZWQg TGlzdCIsICJDb252ZXJ0IHRvIE9yZGVyZWQgTGlzdCAoVW5kbyBhY3Rpb24gbmFtZSkiLCAiQ29u dmVydCB0byBvcmRlcmVkIGxpc3QgYWN0aW9uIG5hbWUiKTsKLSAgICBjYXNlIEVkaXRBY3Rpb246 OkNvbnZlcnRUb1Vub3JkZXJlZExpc3Q6IHJldHVybiBVSV9TVFJJTkdfS0VZX0lOVEVSTkFMKCJD b252ZXJ0IHRvIFVub3JkZXJlZCBMaXN0IiwgIkNvbnZlcnQgdG8gVW5vcmRlcmVkIExpc3QgKFVu ZG8gYWN0aW9uIG5hbWUpIiwgIkNvbnZlcnQgdG8gdW5vcmRlcmVkIGxpc3QgYWN0aW9uIG5hbWUi KTsKKyAgICBjYXNlIEVkaXRBY3Rpb246OkNvbnZlcnRUb09yZGVyZWRMaXN0OiByZXR1cm4gVUlf U1RSSU5HX0tFWV9JTlRFUk5BTCgiQ29udmVydCB0byBPcmRlcmVkIExpc3QiLCAiQ29udmVydCB0 byBPcmRlcmVkIExpc3QgKFVuZG8gYWN0aW9uIG5hbWUpIiwgIlVuZG8gYWN0aW9uIG5hbWUiKTsK KyAgICBjYXNlIEVkaXRBY3Rpb246OkNvbnZlcnRUb1Vub3JkZXJlZExpc3Q6IHJldHVybiBVSV9T VFJJTkdfS0VZX0lOVEVSTkFMKCJDb252ZXJ0IHRvIFVub3JkZXJlZCBMaXN0IiwgIkNvbnZlcnQg dG8gVW5vcmRlcmVkIExpc3QgKFVuZG8gYWN0aW9uIG5hbWUpIiwgIlVuZG8gYWN0aW9uIG5hbWUi KTsKICAgICB9CiAgICAgcmV0dXJuIG5pbDsKIH0K