191935 2018-11-23 17:57:32 -0800 [ews-app] Add support to communicate with Buildbot 2018-11-26 17:10:59 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1481222 0 aakash_jain 2018-11-23 17:57:32 -0800 ews-app needs to send patches to Buildbot using 'buildbot try' command. We should add that feature. 1481234 1 355550 aakash_jain 2018-11-23 19:06:20 -0800 Created attachment 355550 Proposed patch Part of patch series. Therefore wouldn't apply to ToT without applying other patches first. 1481641 2 355550 lforschler 2018-11-26 12:51:04 -0800 Comment on attachment 355550 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355550&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:44 > + _log.warn('Error in executing: {}, rc={}'.format(command, return_code)) This should be: Error executing: or Error while executing: 1481712 3 355550 kocsen_chung 2018-11-26 14:59:56 -0800 Comment on attachment 355550 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355550&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:35 > + command = ['buildbot', 'try', '--connect=pb', '--master={}:{}'.format(config.BUG_SERVER_HOST, config.BUILDBOT_SERVER_PORT), nit: Have every `--flag [param]` pair be in it's own new line for readability. >> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:44 >> + _log.warn('Error in executing: {}, rc={}'.format(command, return_code)) > > This should be: > Error executing: > or > Error while executing: nit: spell out `rc` => `return code` and have it be on a new line. 1481771 4 aakash_jain 2018-11-26 17:08:26 -0800 > nit: > Have every `--flag [param]` pair be in it's own new line for readability. Sure. > nit: spell out `rc` => `return code` Done > and have it be on a new line. Tried with and without new line, having on same line seems more readable. > > This should be: > > Error executing: Changed. 1481772 5 aakash_jain 2018-11-26 17:09:21 -0800 Committed r238535: <http://trac.webkit.org/changeset/238535> 1481773 6 webkit-bug-importer 2018-11-26 17:10:59 -0800 <rdar://problem/46262314> 355550 2018-11-23 19:06:20 -0800 2018-11-26 12:51:04 -0800 Proposed patch 0005-ews-app-Add-support-to-communicate-with-Buildbot.patch text/plain 4097 aakash_jain RnJvbSBhN2RiMWVmNDRkNTExMjZhNWRiNjg3OTdiMzFhMTRhN2Q1Zjg2ZTlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBGcmksIDIzIE5vdiAyMDE4IDE4OjAwOjU2IC0wODAwClN1YmplY3Q6IFtQQVRDSCA1LzVd IFtld3MtYXBwXSBBZGQgc3VwcG9ydCB0byBjb21tdW5pY2F0ZSB3aXRoIEJ1aWxkYm90CiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTM1CgpSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KCiogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29tbW9uL2J1 aWxkYm90LnB5OiBBZGRlZC4KKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24v X19pbml0X18ucHk6IEFkZGVkLgotLS0KIC4uLi9ld3MtYXBwL2V3cy9jb21tb24vX19pbml0X18u cHkgICAgICAgICAgICB8ICAwCiAuLi4vZXdzLWFwcC9ld3MvY29tbW9uL2J1aWxkYm90LnB5ICAg ICAgICAgICAgfCA0NiArKysrKysrKysrKysrKysrKysrCiBUb29scy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAxMCArKysrCiAzIGZpbGVzIGNoYW5nZWQsIDU2IGlu c2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYXBwL2V3cy9jb21tb24vX19pbml0X18ucHkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3QucHkKCmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vX19pbml0X18u cHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vX19pbml0X18u cHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmU2OWRlMjliYjJkCmRp ZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVp bGRib3QucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVp bGRib3QucHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjVmMTgwN2M3 NDM5Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9l d3MvY29tbW9uL2J1aWxkYm90LnB5CkBAIC0wLDAgKzEsNDYgQEAKKyMgQ29weXJpZ2h0IChDKSAy MDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucworIyBhcmUgbWV0OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJlZGlz dHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJp Z2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRX QVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJ UycnIEFORAorIyBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorIyBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisjIERJU0NM QUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUyBC RSBMSUFCTEUgRk9SCisjIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFM LCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwKKyMgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQg Tk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IKKyMgU0VS VklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJV UFRJT04pIEhPV0VWRVIKKyMgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwg V0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwKKyMgT1IgVE9SVCAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI RSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1wb3J0IGxvZ2dpbmcKK2ltcG9ydCBvcworaW1wb3J0 IHN1YnByb2Nlc3MKKworaW1wb3J0IGV3cy5jb25maWcgYXMgY29uZmlnCisKK19sb2cgPSBsb2dn aW5nLmdldExvZ2dlcihfX25hbWVfXykKKworCitjbGFzcyBCdWlsZGJvdCgpOgorICAgIEBjbGFz c21ldGhvZAorICAgIGRlZiBzZW5kX3BhdGNoX3RvX2J1aWxkYm90KGNscywgcGF0Y2hfcGF0aCwg cHJvcGVydGllcz1bXSk6CisgICAgICAgIGNvbW1hbmQgPSBbJ2J1aWxkYm90JywgJ3RyeScsICct LWNvbm5lY3Q9cGInLCAnLS1tYXN0ZXI9e306e30nLmZvcm1hdChjb25maWcuQlVHX1NFUlZFUl9I T1NULCBjb25maWcuQlVJTERCT1RfU0VSVkVSX1BPUlQpLAorICAgICAgICAgICAgICAgICAgICAn LS11c2VybmFtZT17fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9QQl9VU0VSTkFNRSksICctLXBh c3N3ZD17fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9QQl9QQVNTV09SRCksCisgICAgICAgICAg ICAgICAgICAgICctLWRpZmY9e30nLmZvcm1hdChwYXRjaF9wYXRoKSwgJy0tcmVwb3NpdG9yeT0n XQorICAgICAgICBmb3IgcHJvcGVydHkgaW4gcHJvcGVydGllczoKKyAgICAgICAgICAgIGNvbW1h bmQuYXBwZW5kKCctLXByb3BlcnR5PXt9Jy5mb3JtYXQocHJvcGVydHkpKQorCisgICAgICAgIF9s b2cuZGVidWcoJ0V4ZWN1dGluZyBjb21tYW5kOiB7fScuZm9ybWF0KGNvbW1hbmQpKQorICAgICAg ICByZXR1cm5fY29kZSA9IHN1YnByb2Nlc3MuY2FsbChjb21tYW5kKQorICAgICAgICBpZiByZXR1 cm5fY29kZToKKyAgICAgICAgICAgIF9sb2cud2FybignRXJyb3IgaW4gZXhlY3V0aW5nOiB7fSwg cmM9e30nLmZvcm1hdChjb21tYW5kLCByZXR1cm5fY29kZSkpCisKKyAgICAgICAgcmV0dXJuIHJl dHVybl9jb2RlCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggMjNlZjY5OTUwNTAuLjM0MzgxOWJlNGZlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTEtMjMgIEFh a2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtld3MtYXBwXSBB ZGQgc3VwcG9ydCB0byBjb21tdW5pY2F0ZSB3aXRoIEJ1aWxkYm90CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5MzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1h cHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weTogQWRkZWQuCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWFwcC9ld3MvY29tbW9uL19faW5pdF9fLnB5OiBBZGRlZC4KKwogMjAxOC0xMS0y MyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1h cHBdIEFkZCBhIGNvbmZpZyBmaWxlCi0tIAoyLjE3LjIgKEFwcGxlIEdpdC0xMTMpCgo=