191933 2018-11-23 17:51:46 -0800 [ews-app] Add a config file 2018-11-27 11:35:59 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1481218 0 aakash_jain 2018-11-23 17:51:46 -0800 We should add a config file to store all the configuration in one place. 1481233 1 355549 aakash_jain 2018-11-23 19:04:24 -0800 Created attachment 355549 Proposed patch Part of patch series. Therefore wouldn't apply to ToT without applying other patches first. 1481700 2 355549 kocsen_chung 2018-11-26 14:56:10 -0800 Comment on attachment 355549 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355549&action=review > Tools/BuildSlaveSupport/ews-app/ews/config.py:1 > +# Copyright (C) 2018 Apple Inc. All rights reserved. We should be able to just leverage the Django Settings file: https://docs.djangoproject.com/en/2.1/topics/settings/ Located in: Tools/BuildSlaveSupport/ews-app/settings.py 1481808 3 aakash_jain 2018-11-26 19:15:27 -0800 Committed r238530: <http://trac.webkit.org/changeset/238530> 1481809 4 webkit-bug-importer 2018-11-26 19:16:26 -0800 <rdar://problem/46264850> 1481884 5 aakash_jain 2018-11-27 05:33:18 -0800 > We should be able to just leverage the Django Settings file: We could and I did considered that, but it doesn't look like a clean approach to me. I want to keep the app settings and project settings separate. There are a large number of project settings in Django settings file. Adding this app's configuration there might make it unreadable and hard to find. 1481995 6 kocsen_chung 2018-11-27 11:35:59 -0800 > Adding this app's configuration there might make it unreadable and hard to find. I disagree - since Django developers would _expect_ to find these variables in the settings.py file to begin with. 355549 2018-11-23 19:04:24 -0800 2018-11-26 12:46:50 -0800 Proposed patch 0004-ews-app-Add-a-config-file.patch text/plain 3078 aakash_jain RnJvbSBkZGUzZTM2Mjg3MmQ0ZmMyNGVjNmI1M2Q4ZjgyZTkxYzE4ZTA1MGY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBGcmksIDIzIE5vdiAyMDE4IDE3OjUzOjU0IC0wODAwClN1YmplY3Q6IFtQQVRDSCA0LzVd IFtld3MtYXBwXSBBZGQgYSBjb25maWcgZmlsZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MTkzMwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIEJ1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weTogQWRkZWQuCi0tLQogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29uZmlnLnB5IHwgMzUgKysrKysrKysrKysrKysr KysrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDkg KysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAw NjQ0IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weQoKZGlmZiAt LWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weSBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weQpuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uNTAwYjAzMDg1ZTQKLS0tIC9kZXYvbnVsbAorKysg Yi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb25maWcucHkKQEAgLTAsMCAr MSwzNSBAQAorIyBDb3B5cmlnaHQgKEMpIDIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuICBSZWRp c3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdo dAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2lu ZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3Qg cmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9m IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRv Y3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0 cmlidXRpb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBB TkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5ECisjIEFOWSBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVE CisjIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIgUFVSUE9TRSBBUkUKKyMgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUg SU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IKKyMgQU5ZIERJUkVDVCwgSU5E SVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTAor IyBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0Yg U1VCU1RJVFVURSBHT09EUyBPUgorIyBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBS T0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUgorIyBDQVVTRUQgQU5EIE9O IEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElB QklMSVRZLAorIyBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFS SVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitpbXBvcnQg b3MKKworQlVHX1NFUlZFUl9IT1NUID0gJ2J1Z3Mud2Via2l0Lm9yZycKK0JVSUxEQk9UX1NFUlZF Ul9IT1NUID0gJ2V3cy1idWlsZC53ZWJraXQtdWF0Lm9yZycKK0JVSUxEQk9UX1NFUlZFUl9QT1JU ID0gJzU1NTUnCitCVUlMREJPVF9QQl9VU0VSTkFNRSA9IG9zLmdldGVudignQlVJTERCT1RfUEJf VVNFUk5BTUUnLCAnc2FtcGxldXNlcicpCitCVUlMREJPVF9QQl9QQVNTV09SRCA9IG9zLmdldGVu dignQlVJTERCT1RfUEJfUEFTU1dPUkQnLCAnc2FtcGxlcGFzcycpCisKK1NVQ0NFU1MgPSAwCitF UlJfVU5FWFBFQ1RFRCA9IC0xCitFUlJfRVhJU1RJTkdfUEFUQ0ggPSAtMgorRVJSX05PTl9FWElT VElOR19QQVRDSCA9IC0zCitFUlJfSU5WQUxJRF9QQVRDSF9JRCA9IC00CmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjgwMTE0MDYxMDkuLjIzZWY2 OTk1MDUwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMTEtMjMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgorCisgICAgICAgIFtld3MtYXBwXSBBZGQgYSBjb25maWcgZmlsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTMzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy9jb25maWcucHk6IEFkZGVkLgorCiAyMDE4LTExLTIzICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWFwcF0gQWRkIG1l dGhvZHMgdG8gdXBkYXRlIFBhdGNoIGZpZWxkcwotLSAKMi4xNy4yIChBcHBsZSBHaXQtMTEzKQoK