191931 2018-11-23 17:00:32 -0800 [ews-app] Add methods to update Patch fields 2021-02-19 08:51:46 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1481212 0 aakash_jain 2018-11-23 17:00:32 -0800 Add methods to update Patch fields like set_obsolete, set_bug_id etc. These methods would help if someone wants to update a specific field in Patch. These methods would do necessary verification. 1481232 1 355548 aakash_jain 2018-11-23 19:01:34 -0800 Created attachment 355548 Proposed patch Part of patch series. Therefore wouldn't apply to ToT without applying other patches first. 1481638 2 355548 uptown1919 2018-11-26 12:42:49 -0800 Comment on attachment 355548 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355548&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:78 > + def set_sent_to_bb(cls, patchid, sent=True): I'm not sure if I like using 'bb' as an abbreviation for buildbot... it's not super clear for people who are new to the code/lingo. would it be terrible to use set_sent_to_buldbot ? Also... 'set' could be read multiple ways.... set: this is a set of cards set: set variable x to foo it wasn't obvious to me which usage this was, just by looking at the function name. > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:83 > + if patch.sent_to_bb == sent: could sent_to_bb be a boolean? 1481694 3 355548 kocsen_chung 2018-11-26 14:51:25 -0800 Comment on attachment 355548 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355548&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:78 >> + def set_sent_to_bb(cls, patchid, sent=True): > > I'm not sure if I like using 'bb' as an abbreviation for buildbot... it's not super clear for people who are new to the code/lingo. > would it be terrible to use set_sent_to_buldbot ? > > Also... 'set' could be read multiple ways.... > set: this is a set of cards > set: set variable x to foo > > it wasn't obvious to me which usage this was, just by looking at the function name. I agree, we should be explicit about as many things as we can. Ditto with patchid => patch_id. This is kind of orthogonal to this patch but another thing to keep in mind is to avoid redundant naming within a model. It a Patch has an id it should be Patch.id instead of Patch.patch_id etc. 1482530 4 355891 aakash_jain 2018-11-28 10:51:37 -0800 Created attachment 355891 Updated patch > I'm not sure if I like using 'bb' as an abbreviation for buildbot. Expanded bb to buildbot. > Also... 'set' could be read multiple ways. Not sure what might be a good alternative. mark_set_to_buildbot or set_property_sent_to_buildbot doesn't look good as well. Kept as is for now. > could sent_to_bb be a boolean? It is a boolean. 1482532 5 ews-watchlist 2018-11-28 10:53:52 -0800 Attachment 355891 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:79: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:80: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:82: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:83: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:84: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:85: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:87: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:88: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:89: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:90: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:94: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:95: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:97: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:98: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:98: multiple spaces before operator [pep8/E221] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:99: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:100: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:102: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:103: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:104: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:105: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:109: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:110: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:112: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:113: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:114: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:115: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:116: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:117: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:118: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:119: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:80: [Patch.set_sent_to_buildbot] Undefined variable 'ERR_NON_EXISTING_PATCH' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:82: [Patch.set_sent_to_buildbot] Class 'Patch' has no 'objects' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:85: [Patch.set_sent_to_buildbot] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:90: [Patch.set_sent_to_buildbot] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:95: [Patch.set_bug_id] Undefined variable 'ERR_NON_EXISTING_PATCH' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:97: [Patch.set_bug_id] Class 'Patch' has no 'objects' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:100: [Patch.set_bug_id] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:105: [Patch.set_bug_id] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:110: [Patch.set_obsolete] Undefined variable 'ERR_NON_EXISTING_PATCH' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:112: [Patch.set_obsolete] Class 'Patch' has no 'objects' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:115: [Patch.set_obsolete] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:119: [Patch.set_obsolete] Undefined variable 'SUCCESS' [pylint/E0602] [5] Total errors found: 43 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1482536 6 355893 aakash_jain 2018-11-28 11:04:02 -0800 Created attachment 355893 Updated patch 1482538 7 ews-watchlist 2018-11-28 11:07:02 -0800 Attachment 355893 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:82: [Patch.set_sent_to_buildbot] Class 'Patch' has no 'objects' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:97: [Patch.set_bug_id] Class 'Patch' has no 'objects' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:112: [Patch.set_obsolete] Class 'Patch' has no 'objects' member [pylint/E1101] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1482552 8 355891 lforschler 2018-11-28 11:38:20 -0800 Comment on attachment 355891 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=355891&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:83 > + if patch.sent_to_buildbot == sent: since the value of 'sent' is True or False, can we reduce this to: if patch.sent_to_buildbot: > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:87 > + patch.sent_to_buildbot = sent We chatted about never setting sent=False... if that is something we won't do, then it feels better to me to write this as: patch.sent_to_buildbot = True this removes any doubt that the value is being set to True. > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:113 > + if patch.obsolete == obsolete: can we simplify this also? if patch.obsolete: > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:116 > + patch.obsolete = obsolete We discussed if someone flips the state of the 'obsolete' flag inadvertently, or on purpose... so we need to make sure we handle the following cases: set obsolete = True when obsolete flag is already true (no op) (warning?) set obsolete = True when obsolete flag is false set obsolete = False when obsolete flag is already false (no op) (warning?) set obsolete = False when obsolete flag is true. Maybe the best way to do this is to simply change the _log.warn to: _log.warn('Patch {} is already marked with obsolete={}.'.format(patch_id, obsolete)) 1482553 9 355891 lforschler 2018-11-28 11:38:56 -0800 Comment on attachment 355891 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=355891&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:113 >> + if patch.obsolete == obsolete: > > can we simplify this also? > if patch.obsolete: (if we take the below approach, this should stay as written) 1482572 10 aakash_jain 2018-11-28 12:16:33 -0800 Incorporated above feedback. Committed r238627: <http://trac.webkit.org/changeset/238627> 1482573 11 webkit-bug-importer 2018-11-28 12:17:40 -0800 <rdar://problem/46317844> 355548 2018-11-23 19:01:34 -0800 2018-11-28 10:51:37 -0800 Proposed patch 0003-ews-app-Add-methods-to-update-Patch-fields.patch text/plain 3270 aakash_jain RnJvbSBhZTg0OTM1MTlkNmNlM2I2NDdjMjcwOTAzN2E2OWE2NjE0YWJlZjNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBGcmksIDIzIE5vdiAyMDE4IDE3OjQ1OjIxIC0wODAwClN1YmplY3Q6IFtQQVRDSCAzLzVd IFtld3MtYXBwXSBBZGQgbWV0aG9kcyB0byB1cGRhdGUgUGF0Y2ggZmllbGRzCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTMxCgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCiogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3BhdGNoLnB5 OgooUGF0Y2guc2V0X3NlbnRfdG9fYmIpOgooUGF0Y2guc2V0X2J1Z19pZCk6CihQYXRjaC5zZXRf b2Jzb2xldGUpOgotLS0KIC4uLi9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHkgICAgICAgICAg ICAgICB8IDQ0ICsrKysrKysrKysrKysrKysrKysKIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDU2IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3 cy9tb2RlbHMvcGF0Y2gucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9t b2RlbHMvcGF0Y2gucHkKaW5kZXggODc0NjQ3MjViYzAuLjAzZmIxY2U1Yjc4IDEwMDY0NAotLS0g YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHkKKysr IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3BhdGNoLnB5CkBA IC03MywzICs3Myw0NyBAQCBjbGFzcyBQYXRjaChtb2RlbHMuTW9kZWwpOgogICAgIEBjbGFzc21l dGhvZAogICAgIGRlZiBpc19wYXRjaF9zZW50X3RvX2JiKGNscywgcGF0Y2hpZCk6CiAgICAgICAg IHJldHVybiBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChwYXRjaGlkKSBhbmQgUGF0Y2gub2Jq ZWN0cy5nZXQocGs9cGF0Y2hpZCkuc2VudF90b19iYgorCisgICAgQGNsYXNzbWV0aG9kCisgICAg ZGVmIHNldF9zZW50X3RvX2JiKGNscywgcGF0Y2hpZCwgc2VudD1UcnVlKToKKyAgICAgICBpZiBu b3QgUGF0Y2guaXNfZXhpc3RpbmdfcGF0Y2hfaWQocGF0Y2hpZCk6CisgICAgICAgICAgIHJldHVy biBFUlJfTk9OX0VYSVNUSU5HX1BBVENICisKKyAgICAgICBwYXRjaCA9IFBhdGNoLm9iamVjdHMu Z2V0KHBrPXBhdGNoaWQpCisgICAgICAgaWYgcGF0Y2guc2VudF90b19iYiA9PSBzZW50OgorICAg ICAgICAgICBfbG9nLndhcm4oJ1BhdGNoIHt9IGhhcyBhbHJlYWR5IGJlZW4gc2VudCB0byBCdWls ZGJvdC4nLmZvcm1hdChwYXRjaGlkKSkKKyAgICAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAg ICAgIHBhdGNoLnNlbnRfdG9fYmIgPSBzZW50CisgICAgICAgcGF0Y2guc2F2ZSgpCisgICAgICAg X2xvZy5kZWJ1ZygnVXBkYXRlZCBwYXRjaCB7fSB3aXRoIHNlbnRfdG9fYmI9e30nLmZvcm1hdChw YXRjaGlkLCBzZW50KSkKKyAgICAgICByZXR1cm4gU1VDQ0VTUworCisgICAgQGNsYXNzbWV0aG9k CisgICAgZGVmIHNldF9idWdfaWQoY2xzLCBwYXRjaGlkLCBidWdfaWQpOgorICAgICAgIGlmIG5v dCBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChwYXRjaGlkKToKKyAgICAgICAgICAgcmV0dXJu IEVSUl9OT05fRVhJU1RJTkdfUEFUQ0gKKworICAgICAgIHBhdGNoID0gUGF0Y2gub2JqZWN0cy5n ZXQocGs9cGF0Y2hpZCkKKyAgICAgICBpZiBwYXRjaC5idWdfaWQgID09IGJ1Z19pZDoKKyAgICAg ICAgICAgX2xvZy53YXJuKCdQYXRjaCB7fSBhbHJlYWR5IGhhcyBidWcgaWQge30gc2V0LicuZm9y bWF0KHBhdGNoaWQsIGJ1Z19pZCkpCisgICAgICAgICAgIHJldHVybiBTVUNDRVNTCisKKyAgICAg ICBwYXRjaC5idWdfaWQgPSBidWdfaWQKKyAgICAgICBwYXRjaC5zYXZlKCkKKyAgICAgICBfbG9n LmRlYnVnKCdVcGRhdGVkIHBhdGNoIHt9IHdpdGggYnVnIGlkIHt9Jy5mb3JtYXQocGF0Y2hpZCwg YnVnX2lkKSkKKyAgICAgICByZXR1cm4gU1VDQ0VTUworCisgICAgQGNsYXNzbWV0aG9kCisgICAg ZGVmIHNldF9vYnNvbGV0ZShjbHMsIHBhdGNoaWQsIG9ic29sZXRlPVRydWUpOgorICAgICAgIGlm IG5vdCBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChwYXRjaGlkKToKKyAgICAgICAgICAgcmV0 dXJuIEVSUl9OT05fRVhJU1RJTkdfUEFUQ0gKKworICAgICAgIHBhdGNoID0gUGF0Y2gub2JqZWN0 cy5nZXQocGs9cGF0Y2hpZCkKKyAgICAgICBpZiBwYXRjaC5vYnNvbGV0ZSA9PSBvYnNvbGV0ZToK KyAgICAgICAgICAgX2xvZy53YXJuKCdQYXRjaCB7fSBpcyBhbHJlYWR5IG1hcmtlZCBvYnNvbGV0 ZS4nLmZvcm1hdChwYXRjaGlkKSkKKyAgICAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKyAgICAgICBw YXRjaC5vYnNvbGV0ZSA9IG9ic29sZXRlCisgICAgICAgcGF0Y2guc2F2ZSgpCisgICAgICAgX2xv Zy5kZWJ1ZygnTWFya2VkIHBhdGNoIHt9IGFzIG9ic29sZXRlPXt9Jy5mb3JtYXQocGF0Y2hpZCwg b2Jzb2xldGUpKQorICAgICAgIHJldHVybiBTVUNDRVNTCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODdkMWU0ZDQ1ZjcuLmI4MDExNDA2MTA5IDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTgtMTEtMjMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29t PgorCisgICAgICAgIFtld3MtYXBwXSBBZGQgbWV0aG9kcyB0byB1cGRhdGUgUGF0Y2ggZmllbGRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5MzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weToKKyAgICAgICAgKFBhdGNo LnNldF9zZW50X3RvX2JiKToKKyAgICAgICAgKFBhdGNoLnNldF9idWdfaWQpOgorICAgICAgICAo UGF0Y2guc2V0X29ic29sZXRlKToKKwogMjAxOC0xMS0yMyAgQWFrYXNoIEphaW4gIDxhYWthc2hf amFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1hcHBdIEFkZCBmaWVsZCBpbiBQYXRjaCBv YmplY3QgdG8gaW5kaWNhdGUgaWYgaXQgaGFzIGJlZW4gc2VudCB0byBCdWlsZGJvdAotLSAKMi4x Ny4yIChBcHBsZSBHaXQtMTEzKQoK 355891 2018-11-28 10:51:37 -0800 2018-11-28 12:14:52 -0800 Updated patch 0001-ews-app-Add-methods-to-update-Patch-fields.patch text/plain 3320 aakash_jain RnJvbSA0NjA5MzQwOWI1MzgyZjUyZTJlODg4YTcyMjE0ZDI1ZmNiZDc0N2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBGcmksIDIzIE5vdiAyMDE4IDE3OjQ1OjIxIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gW2V3 cy1hcHBdIEFkZCBtZXRob2RzIHRvIHVwZGF0ZSBQYXRjaCBmaWVsZHMKIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5MzEKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHk6CihQ YXRjaC5zZXRfc2VudF90b19iYik6CihQYXRjaC5zZXRfYnVnX2lkKToKKFBhdGNoLnNldF9vYnNv bGV0ZSk6Ci0tLQogLi4uL2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weSAgICAgICAgICAgICAg IHwgNDQgKysrKysrKysrKysrKysrKysrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMTIgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21v ZGVscy9wYXRjaC5weSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVs cy9wYXRjaC5weQppbmRleCAwOTJhNWFiOWFmMS4uOTc0MWQ2YzZkZjcgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weQorKysgYi9U b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHkKQEAgLTcz LDMgKzczLDQ3IEBAIGNsYXNzIFBhdGNoKG1vZGVscy5Nb2RlbCk6CiAgICAgQGNsYXNzbWV0aG9k CiAgICAgZGVmIGlzX3BhdGNoX3NlbnRfdG9fYnVpbGRib3QoY2xzLCBwYXRjaF9pZCk6CiAgICAg ICAgIHJldHVybiBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChwYXRjaF9pZCkgYW5kIFBhdGNo Lm9iamVjdHMuZ2V0KHBrPXBhdGNoX2lkKS5zZW50X3RvX2J1aWxkYm90CisKKyAgICBAY2xhc3Nt ZXRob2QKKyAgICBkZWYgc2V0X3NlbnRfdG9fYnVpbGRib3QoY2xzLCBwYXRjaF9pZCwgc2VudD1U cnVlKToKKyAgICAgICBpZiBub3QgUGF0Y2guaXNfZXhpc3RpbmdfcGF0Y2hfaWQocGF0Y2hfaWQp OgorICAgICAgICAgICByZXR1cm4gRVJSX05PTl9FWElTVElOR19QQVRDSAorCisgICAgICAgcGF0 Y2ggPSBQYXRjaC5vYmplY3RzLmdldChwaz1wYXRjaF9pZCkKKyAgICAgICBpZiBwYXRjaC5zZW50 X3RvX2J1aWxkYm90ID09IHNlbnQ6CisgICAgICAgICAgIF9sb2cud2FybignUGF0Y2gge30gaGFz IGFscmVhZHkgYmVlbiBzZW50IHRvIEJ1aWxkYm90LicuZm9ybWF0KHBhdGNoX2lkKSkKKyAgICAg ICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgICAgIHBhdGNoLnNlbnRfdG9fYnVpbGRib3QgPSBz ZW50CisgICAgICAgcGF0Y2guc2F2ZSgpCisgICAgICAgX2xvZy5kZWJ1ZygnVXBkYXRlZCBwYXRj aCB7fSB3aXRoIHNlbnRfdG9fYnVpbGRib3Q9e30nLmZvcm1hdChwYXRjaF9pZCwgc2VudCkpCisg ICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBzZXRfYnVn X2lkKGNscywgcGF0Y2hfaWQsIGJ1Z19pZCk6CisgICAgICAgaWYgbm90IFBhdGNoLmlzX2V4aXN0 aW5nX3BhdGNoX2lkKHBhdGNoX2lkKToKKyAgICAgICAgICAgcmV0dXJuIEVSUl9OT05fRVhJU1RJ TkdfUEFUQ0gKKworICAgICAgIHBhdGNoID0gUGF0Y2gub2JqZWN0cy5nZXQocGs9cGF0Y2hfaWQp CisgICAgICAgaWYgcGF0Y2guYnVnX2lkICA9PSBidWdfaWQ6CisgICAgICAgICAgIF9sb2cud2Fy bignUGF0Y2gge30gYWxyZWFkeSBoYXMgYnVnIGlkIHt9IHNldC4nLmZvcm1hdChwYXRjaF9pZCwg YnVnX2lkKSkKKyAgICAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgICAgIHBhdGNoLmJ1Z19p ZCA9IGJ1Z19pZAorICAgICAgIHBhdGNoLnNhdmUoKQorICAgICAgIF9sb2cuZGVidWcoJ1VwZGF0 ZWQgcGF0Y2gge30gd2l0aCBidWcgaWQge30nLmZvcm1hdChwYXRjaF9pZCwgYnVnX2lkKSkKKyAg ICAgICByZXR1cm4gU1VDQ0VTUworCisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIHNldF9vYnNv bGV0ZShjbHMsIHBhdGNoX2lkLCBvYnNvbGV0ZT1UcnVlKToKKyAgICAgICBpZiBub3QgUGF0Y2gu aXNfZXhpc3RpbmdfcGF0Y2hfaWQocGF0Y2hfaWQpOgorICAgICAgICAgICByZXR1cm4gRVJSX05P Tl9FWElTVElOR19QQVRDSAorCisgICAgICAgcGF0Y2ggPSBQYXRjaC5vYmplY3RzLmdldChwaz1w YXRjaF9pZCkKKyAgICAgICBpZiBwYXRjaC5vYnNvbGV0ZSA9PSBvYnNvbGV0ZToKKyAgICAgICAg ICAgX2xvZy53YXJuKCdQYXRjaCB7fSBpcyBhbHJlYWR5IG1hcmtlZCBvYnNvbGV0ZS4nLmZvcm1h dChwYXRjaF9pZCkpCisgICAgICAgICAgIHJldHVybiBTVUNDRVNTCisgICAgICAgcGF0Y2gub2Jz b2xldGUgPSBvYnNvbGV0ZQorICAgICAgIHBhdGNoLnNhdmUoKQorICAgICAgIF9sb2cuZGVidWco J01hcmtlZCBwYXRjaCB7fSBhcyBvYnNvbGV0ZT17fScuZm9ybWF0KHBhdGNoX2lkLCBvYnNvbGV0 ZSkpCisgICAgICAgcmV0dXJuIFNVQ0NFU1MKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4N2QxZTRkNDVmNy4uYjgwMTE0MDYxMDkgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxOC0xMS0yMyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CisKKyAg ICAgICAgW2V3cy1hcHBdIEFkZCBtZXRob2RzIHRvIHVwZGF0ZSBQYXRjaCBmaWVsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTkzMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3BhdGNoLnB5OgorICAgICAgICAoUGF0Y2guc2V0X3Nl bnRfdG9fYmIpOgorICAgICAgICAoUGF0Y2guc2V0X2J1Z19pZCk6CisgICAgICAgIChQYXRjaC5z ZXRfb2Jzb2xldGUpOgorCiAyMDE4LTExLTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFw cGxlLmNvbT4KIAogICAgICAgICBbZXdzLWFwcF0gQWRkIGZpZWxkIGluIFBhdGNoIG9iamVjdCB0 byBpbmRpY2F0ZSBpZiBpdCBoYXMgYmVlbiBzZW50IHRvIEJ1aWxkYm90Ci0tIAoyLjE3LjIgKEFw cGxlIEdpdC0xMTMpCgo= 355893 2018-11-28 11:04:02 -0800 2021-02-19 08:51:46 -0800 Updated patch 0001-ews-app-Add-methods-to-update-Patch-fields.patch text/plain 3595 aakash_jain RnJvbSBiZDJhNTU1ZjcyNWMxZmE0NmRmYjllMzRkOGYxYzc0NDBiMDg1YzkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBXZWQsIDI4IE5vdiAyMDE4IDExOjAyOjIzIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gW2V3 cy1hcHBdIEFkZCBtZXRob2RzIHRvIHVwZGF0ZSBQYXRjaCBmaWVsZHMKIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE5MzEKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHk6CihQ YXRjaC5zZXRfc2VudF90b19iYik6CihQYXRjaC5zZXRfYnVnX2lkKToKKFBhdGNoLnNldF9vYnNv bGV0ZSk6Ci0tLQogLi4uL2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weSAgICAgICAgICAgICAg IHwgNDYgKysrKysrKysrKysrKysrKysrLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMTIgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNTcgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weQppbmRleCAwOTJhNWFiOWFmMS4uZTRiZWI2MjBkNzAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9w YXRjaC5weQorKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMv cGF0Y2gucHkKQEAgLTI2LDcgKzI2LDcgQEAgaW1wb3J0IGxvZ2dpbmcKIAogZnJvbSBkamFuZ28u ZGIgaW1wb3J0IG1vZGVscwogCi1mcm9tIGV3cy5jb25maWcgaW1wb3J0ICoKK2Zyb20gZXdzLmNv bmZpZyBpbXBvcnQgRVJSX0VYSVNUSU5HX1BBVENILCBFUlJfSU5WQUxJRF9QQVRDSF9JRCwgRVJS X05PTl9FWElTVElOR19QQVRDSCwgU1VDQ0VTUwogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIo X19uYW1lX18pCiAKQEAgLTczLDMgKzczLDQ3IEBAIGNsYXNzIFBhdGNoKG1vZGVscy5Nb2RlbCk6 CiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIGlzX3BhdGNoX3NlbnRfdG9fYnVpbGRib3QoY2xz LCBwYXRjaF9pZCk6CiAgICAgICAgIHJldHVybiBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChw YXRjaF9pZCkgYW5kIFBhdGNoLm9iamVjdHMuZ2V0KHBrPXBhdGNoX2lkKS5zZW50X3RvX2J1aWxk Ym90CisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgc2V0X3NlbnRfdG9fYnVpbGRib3QoY2xz LCBwYXRjaF9pZCwgc2VudD1UcnVlKToKKyAgICAgICAgaWYgbm90IFBhdGNoLmlzX2V4aXN0aW5n X3BhdGNoX2lkKHBhdGNoX2lkKToKKyAgICAgICAgICAgIHJldHVybiBFUlJfTk9OX0VYSVNUSU5H X1BBVENICisKKyAgICAgICAgcGF0Y2ggPSBQYXRjaC5vYmplY3RzLmdldChwaz1wYXRjaF9pZCkK KyAgICAgICAgaWYgcGF0Y2guc2VudF90b19idWlsZGJvdCA9PSBzZW50OgorICAgICAgICAgICAg X2xvZy53YXJuKCdQYXRjaCB7fSBoYXMgYWxyZWFkeSBiZWVuIHNlbnQgdG8gQnVpbGRib3QuJy5m b3JtYXQocGF0Y2hfaWQpKQorICAgICAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgICAgICBw YXRjaC5zZW50X3RvX2J1aWxkYm90ID0gc2VudAorICAgICAgICBwYXRjaC5zYXZlKCkKKyAgICAg ICAgX2xvZy5kZWJ1ZygnVXBkYXRlZCBwYXRjaCB7fSB3aXRoIHNlbnRfdG9fYnVpbGRib3Q9e30n LmZvcm1hdChwYXRjaF9pZCwgc2VudCkpCisgICAgICAgIHJldHVybiBTVUNDRVNTCisKKyAgICBA Y2xhc3NtZXRob2QKKyAgICBkZWYgc2V0X2J1Z19pZChjbHMsIHBhdGNoX2lkLCBidWdfaWQpOgor ICAgICAgICBpZiBub3QgUGF0Y2guaXNfZXhpc3RpbmdfcGF0Y2hfaWQocGF0Y2hfaWQpOgorICAg ICAgICAgICAgcmV0dXJuIEVSUl9OT05fRVhJU1RJTkdfUEFUQ0gKKworICAgICAgICBwYXRjaCA9 IFBhdGNoLm9iamVjdHMuZ2V0KHBrPXBhdGNoX2lkKQorICAgICAgICBpZiBwYXRjaC5idWdfaWQg PT0gYnVnX2lkOgorICAgICAgICAgICAgX2xvZy53YXJuKCdQYXRjaCB7fSBhbHJlYWR5IGhhcyBi dWcgaWQge30gc2V0LicuZm9ybWF0KHBhdGNoX2lkLCBidWdfaWQpKQorICAgICAgICAgICAgcmV0 dXJuIFNVQ0NFU1MKKworICAgICAgICBwYXRjaC5idWdfaWQgPSBidWdfaWQKKyAgICAgICAgcGF0 Y2guc2F2ZSgpCisgICAgICAgIF9sb2cuZGVidWcoJ1VwZGF0ZWQgcGF0Y2gge30gd2l0aCBidWcg aWQge30nLmZvcm1hdChwYXRjaF9pZCwgYnVnX2lkKSkKKyAgICAgICAgcmV0dXJuIFNVQ0NFU1MK KworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBzZXRfb2Jzb2xldGUoY2xzLCBwYXRjaF9pZCwg b2Jzb2xldGU9VHJ1ZSk6CisgICAgICAgIGlmIG5vdCBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9p ZChwYXRjaF9pZCk6CisgICAgICAgICAgICByZXR1cm4gRVJSX05PTl9FWElTVElOR19QQVRDSAor CisgICAgICAgIHBhdGNoID0gUGF0Y2gub2JqZWN0cy5nZXQocGs9cGF0Y2hfaWQpCisgICAgICAg IGlmIHBhdGNoLm9ic29sZXRlID09IG9ic29sZXRlOgorICAgICAgICAgICAgX2xvZy53YXJuKCdQ YXRjaCB7fSBpcyBhbHJlYWR5IG1hcmtlZCBvYnNvbGV0ZS4nLmZvcm1hdChwYXRjaF9pZCkpCisg ICAgICAgICAgICByZXR1cm4gU1VDQ0VTUworICAgICAgICBwYXRjaC5vYnNvbGV0ZSA9IG9ic29s ZXRlCisgICAgICAgIHBhdGNoLnNhdmUoKQorICAgICAgICBfbG9nLmRlYnVnKCdNYXJrZWQgcGF0 Y2gge30gYXMgb2Jzb2xldGU9e30nLmZvcm1hdChwYXRjaF9pZCwgb2Jzb2xldGUpKQorICAgICAg ICByZXR1cm4gU1VDQ0VTUwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IDg3ZDFlNGQ0NWY3Li5iODAxMTQwNjEwOSAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEx LTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBbZXdz LWFwcF0gQWRkIG1ldGhvZHMgdG8gdXBkYXRlIFBhdGNoIGZpZWxkcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTMxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YXBwL2V3cy9tb2RlbHMvcGF0Y2gucHk6CisgICAgICAgIChQYXRjaC5zZXRfc2VudF90b19iYik6 CisgICAgICAgIChQYXRjaC5zZXRfYnVnX2lkKToKKyAgICAgICAgKFBhdGNoLnNldF9vYnNvbGV0 ZSk6CisKIDIwMTgtMTEtMjMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtld3MtYXBwXSBBZGQgZmllbGQgaW4gUGF0Y2ggb2JqZWN0IHRvIGluZGljYXRl IGlmIGl0IGhhcyBiZWVuIHNlbnQgdG8gQnVpbGRib3QKLS0gCjIuMTcuMiAoQXBwbGUgR2l0LTEx MykKCg==