191929 2018-11-23 16:41:07 -0800 [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot 2018-11-26 16:50:51 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1481206 0 aakash_jain 2018-11-23 16:41:07 -0800 We should add a field in Patch object to indicate if it has been sent to Buildbot. This would help in keeping track of the patch status, and whether the patch needs to be sent to Buildbot or not. For e.g.: if the Patch is downloaded and saved to Database, but 'buildbot try' command failed, there should be a way differentiate that patch in db from another patch which was successfully sent to Buildbot. Note that in order to trigger builds on multiple builders on Buildbot, ews just needs to execute a single 'buildbot try' command (with appropriate port number). So, one flag (in Patch table) is enough to keep track of whether the patch has been sent to Buildbot or not. 1481231 1 355547 aakash_jain 2018-11-23 19:00:14 -0800 Created attachment 355547 Proposed patch Part of patch series. Therefore wouldn't apply to ToT without applying other patches first. 1481640 2 355547 lforschler 2018-11-26 12:48:13 -0800 Comment on attachment 355547 Proposed patch lgtm. if we refactor bb to buildbot, it will need update here as well. 1481707 3 355547 kocsen_chung 2018-11-26 14:58:23 -0800 Comment on attachment 355547 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355547&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:38 > + sent_to_bb = models.BooleanField(default=False) Ditto from the other patch to expand `bb` to `buildbot`. > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:54 > _log.info('Saved patch in database, id: {}'.format(patchid)) Where does `_log` come from? Is there default Django logging when things save to the DB that we can leverage? 1481758 4 aakash_jain 2018-11-26 16:34:13 -0800 > Ditto from the other patch to expand `bb` to `buildbot`. Will expand bb to buildbot. > Where does `_log` come from? Is there default Django logging when things save to the DB that we can leverage? Using the python logging. Beginning of this file has: _log = logging.getLogger(__name__) 1481763 5 aakash_jain 2018-11-26 16:49:21 -0800 Committed r238532: <http://trac.webkit.org/changeset/238532> 1481764 6 webkit-bug-importer 2018-11-26 16:50:51 -0800 <rdar://problem/46261781> 355547 2018-11-23 19:00:14 -0800 2018-11-26 12:48:13 -0800 Proposed patch 0002-ews-app-Add-field-in-Patch-object-to-indicate-if-it-.patch text/plain 3067 aakash_jain RnJvbSA4Nzk4MTJmNTY4ZDY0MDYzNmVhZjIyNjFhMTcxOWEyOTA0Y2U5NTI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBGcmksIDIzIE5vdiAyMDE4IDE2OjQ2OjEzIC0wODAwClN1YmplY3Q6IFtQQVRDSCAyLzVd IFtld3MtYXBwXSBBZGQgZmllbGQgaW4gUGF0Y2ggb2JqZWN0IHRvIGluZGljYXRlIGlmIGl0IGhh cwogYmVlbiBzZW50IHRvIEJ1aWxkYm90IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTE5MjkKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBCdWlsZFNsYXZl U3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHk6CihQYXRjaCk6IEFkZGVkIHNlbnRf dG9fYmIgZmllbGQuCihQYXRjaC5pc19wYXRjaF9zZW50X3RvX2JiKTogQ2hlY2tzIGlmIHRoZSBw YXRjaCBoYXMgYmVlbiBzZW50IHRvIEJ1aWxkYm90LgotLS0KIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weSB8ICA5ICsrKysrKystLQogVG9vbHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTEgKysrKysrKysr KysKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0 Y2gucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gu cHkKaW5kZXggZGVmZTkyYjQzYTIuLjg3NDY0NzI1YmMwIDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHkKKysrIGIvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3BhdGNoLnB5CkBAIC0zNSw2ICszNSw3 IEBAIGNsYXNzIFBhdGNoKG1vZGVscy5Nb2RlbCk6CiAgICAgcGF0Y2hpZCA9IG1vZGVscy5JbnRl Z2VyRmllbGQocHJpbWFyeV9rZXk9VHJ1ZSkKICAgICBidWdfaWQgPSBtb2RlbHMuSW50ZWdlckZp ZWxkKCkKICAgICBvYnNvbGV0ZSA9IG1vZGVscy5Cb29sZWFuRmllbGQoZGVmYXVsdD1GYWxzZSkK KyAgICBzZW50X3RvX2JiID0gbW9kZWxzLkJvb2xlYW5GaWVsZChkZWZhdWx0PUZhbHNlKQogICAg IGNyZWF0ZWQgPSBtb2RlbHMuRGF0ZVRpbWVGaWVsZChhdXRvX25vd19hZGQ9VHJ1ZSkKICAgICBt b2RpZmllZCA9IG1vZGVscy5EYXRlVGltZUZpZWxkKGF1dG9fbm93PVRydWUpCiAKQEAgLTQyLDE0 ICs0MywxNCBAQCBjbGFzcyBQYXRjaChtb2RlbHMuTW9kZWwpOgogICAgICAgICByZXR1cm4gc3Ry KHNlbGYucGF0Y2hpZCkKIAogICAgIEBjbGFzc21ldGhvZAotICAgIGRlZiBzYXZlX3BhdGNoKGNs cywgcGF0Y2hpZCwgYnVnX2lkPS0xLCBvYnNvbGV0ZT1GYWxzZSk6CisgICAgZGVmIHNhdmVfcGF0 Y2goY2xzLCBwYXRjaGlkLCBidWdfaWQ9LTEsIG9ic29sZXRlPUZhbHNlLCBzZW50X3RvX2JiPUZh bHNlKToKICAgICAgICAgaWYgbm90IFBhdGNoLmlzX3ZhbGlkX3BhdGNoX2lkKHBhdGNoaWQpOgog ICAgICAgICAgICAgcmV0dXJuIEVSUl9JTlZBTElEX1BBVENIX0lECiAKICAgICAgICAgaWYgUGF0 Y2guaXNfZXhpc3RpbmdfcGF0Y2hfaWQocGF0Y2hpZCk6CiAgICAgICAgICAgICBfbG9nLmluZm8o IlBhdGNoIGlkIHt9IGFscmVhZHkgZXhpc3RzIGluIGRhdGFiYXNlLiBTa2lwcGVkIHNhdmluZy4i LmZvcm1hdChwYXRjaGlkKSkKICAgICAgICAgICAgIHJldHVybiBFUlJfRVhJU1RJTkdfUEFUQ0gK LSAgICAgICAgUGF0Y2gocGF0Y2hpZCwgYnVnX2lkLCBvYnNvbGV0ZSkuc2F2ZSgpCisgICAgICAg IFBhdGNoKHBhdGNoaWQsIGJ1Z19pZCwgb2Jzb2xldGUsIHNlbnRfdG9fYmIpLnNhdmUoKQogICAg ICAgICBfbG9nLmluZm8oJ1NhdmVkIHBhdGNoIGluIGRhdGFiYXNlLCBpZDoge30nLmZvcm1hdChw YXRjaGlkKSkKICAgICAgICAgcmV0dXJuIFNVQ0NFU1MKIApAQCAtNjgsMyArNjksNyBAQCBjbGFz cyBQYXRjaChtb2RlbHMuTW9kZWwpOgogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBpc19leGlz dGluZ19wYXRjaF9pZChjbHMsIHBhdGNoaWQpOgogICAgICAgICByZXR1cm4gYm9vbChQYXRjaC5v YmplY3RzLmZpbHRlcihwYXRjaGlkPXBhdGNoaWQpKQorCisgICAgQGNsYXNzbWV0aG9kCisgICAg ZGVmIGlzX3BhdGNoX3NlbnRfdG9fYmIoY2xzLCBwYXRjaGlkKToKKyAgICAgICAgcmV0dXJuIFBh dGNoLmlzX2V4aXN0aW5nX3BhdGNoX2lkKHBhdGNoaWQpIGFuZCBQYXRjaC5vYmplY3RzLmdldChw az1wYXRjaGlkKS5zZW50X3RvX2JiCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggZjY1ZTIyYzAyZjEuLjg3ZDFlNGQ0NWY3IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTgtMTEtMjMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgorCisgICAgICAg IFtld3MtYXBwXSBBZGQgZmllbGQgaW4gUGF0Y2ggb2JqZWN0IHRvIGluZGljYXRlIGlmIGl0IGhh cyBiZWVuIHNlbnQgdG8gQnVpbGRib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MTkyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3Bh dGNoLnB5OgorICAgICAgICAoUGF0Y2gpOiBBZGRlZCBzZW50X3RvX2JiIGZpZWxkLgorICAgICAg ICAoUGF0Y2guaXNfcGF0Y2hfc2VudF90b19iYik6IENoZWNrcyBpZiB0aGUgcGF0Y2ggaGFzIGJl ZW4gc2VudCB0byBCdWlsZGJvdC4KKwogMjAxOC0xMS0yMyAgQWFrYXNoIEphaW4gIDxhYWthc2hf amFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1hcHBdIEFkZCBtZXRob2RzIHRvIHNhdmUg cGF0Y2ggdG8gZGF0YWJhc2UKLS0gCjIuMTcuMiAoQXBwbGUgR2l0LTExMykKCg==