191928 2018-11-23 16:17:33 -0800 [ews-app] Add methods to save patch to database 2018-11-26 16:25:30 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1481204 0 aakash_jain 2018-11-23 16:17:33 -0800 We should add methods in ews/models/patch.py allowing to save a Patch to database after performing necessary verification on input data. 1481230 1 355546 aakash_jain 2018-11-23 18:57:25 -0800 Created attachment 355546 Proposed patch 1481629 2 355546 uptown1919 2018-11-26 12:31:55 -0800 Comment on attachment 355546 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355546&action=review lgtm, other than the refactor of patchid to patch_id. > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:45 > + def save_patch(cls, patchid, bug_id=-1, obsolete=False): can we use patch_id instead of patchid ? > Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:63 > + if not patchid or type(patchid) != int or patchid < 0: rare edge case...but could we have a patchid of 0? maybe this should be "patchid < 1" ? 1481639 3 355546 lforschler 2018-11-26 12:45:39 -0800 Comment on attachment 355546 Proposed patch lgtm, other than the refactor of patchid to patch_id. 1481691 4 355546 kocsen_chung 2018-11-26 14:45:33 -0800 Comment on attachment 355546 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355546&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:45 >> + def save_patch(cls, patchid, bug_id=-1, obsolete=False): > > can we use patch_id instead of patchid ? ++ 1481695 5 aakash_jain 2018-11-26 14:52:25 -0800 > can we use patch_id instead of patchid ? Sure, will use patch_id. > rare edge case...but could we have a patchid of 0? maybe this should be "patchid < 1" ? Sure, will change. 1481754 6 aakash_jain 2018-11-26 16:24:06 -0800 Committed r238529: <http://trac.webkit.org/changeset/238529> 1481755 7 webkit-bug-importer 2018-11-26 16:25:30 -0800 <rdar://problem/46260973> 355546 2018-11-23 18:57:25 -0800 2018-11-26 16:24:29 -0800 Proposed patch 0001-ews-app-Add-methods-to-save-patch-to-database.patch text/plain 3479 aakash_jain RnJvbSA0MGE5N2Y3NDQxMzUwODVmZDU1YzRhYTFhNjNkOTdjZTRlNjEyMGNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBGcmksIDIzIE5vdiAyMDE4IDE2OjI3OjI4IC0wODAwClN1YmplY3Q6IFtQQVRDSCAxLzVd IFtld3MtYXBwXSBBZGQgbWV0aG9kcyB0byBzYXZlIHBhdGNoIHRvIGRhdGFiYXNlCiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTI4CgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3BhdGNo LnB5OgooUGF0Y2guc2F2ZV9wYXRjaCk6IE1ldGhvZCB0byBzYXZlIHRoZSBwYXRjaCB0byBkYXRh YmFzZS4KKFBhdGNoLnNhdmVfcGF0Y2hlcyk6IE1ldGhvZCB0byBzYXZlIG11bHRpcGxlIHBhdGNo ZXMgdG8gZGF0YWJhc2UuCihQYXRjaC5pc192YWxpZF9wYXRjaF9pZCk6IENoZWNrcyBpZiB0aGUg cGF0Y2ggaWQgaXMgdmFsaWQuCihQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZCk6IENoZWNrcyBp ZiB0aGUgcGF0Y2ggaWQgYWxyZWFkeSBleGlzdHMgaW4gZGF0YWJhc2UuCi0tLQogLi4uL2V3cy1h cHAvZXdzL21vZGVscy9wYXRjaC5weSAgICAgICAgICAgICAgIHwgMzYgKysrKysrKysrKysrKysr KysrLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTMg KysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p CgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxz L3BhdGNoLnB5IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3Bh dGNoLnB5CmluZGV4IDY4YTg2NzhjYTA3Li5kZWZlOTJiNDNhMiAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3BhdGNoLnB5CisrKyBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9wYXRjaC5weQpAQCAtMjIsMTUg KzIyLDQ5IEBACiAKIGZyb20gX19mdXR1cmVfXyBpbXBvcnQgdW5pY29kZV9saXRlcmFscwogCitp bXBvcnQgbG9nZ2luZworCiBmcm9tIGRqYW5nby5kYiBpbXBvcnQgbW9kZWxzCiAKK2Zyb20gZXdz LmNvbmZpZyBpbXBvcnQgKgorCitfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCisK IAogY2xhc3MgUGF0Y2gobW9kZWxzLk1vZGVsKToKICAgICBwYXRjaGlkID0gbW9kZWxzLkludGVn ZXJGaWVsZChwcmltYXJ5X2tleT1UcnVlKQotICAgIGJ1Z2lkID0gbW9kZWxzLkludGVnZXJGaWVs ZCgpCisgICAgYnVnX2lkID0gbW9kZWxzLkludGVnZXJGaWVsZCgpCiAgICAgb2Jzb2xldGUgPSBt b2RlbHMuQm9vbGVhbkZpZWxkKGRlZmF1bHQ9RmFsc2UpCiAgICAgY3JlYXRlZCA9IG1vZGVscy5E YXRlVGltZUZpZWxkKGF1dG9fbm93X2FkZD1UcnVlKQogICAgIG1vZGlmaWVkID0gbW9kZWxzLkRh dGVUaW1lRmllbGQoYXV0b19ub3c9VHJ1ZSkKIAogICAgIGRlZiBfX3N0cl9fKHNlbGYpOgogICAg ICAgICByZXR1cm4gc3RyKHNlbGYucGF0Y2hpZCkKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRl ZiBzYXZlX3BhdGNoKGNscywgcGF0Y2hpZCwgYnVnX2lkPS0xLCBvYnNvbGV0ZT1GYWxzZSk6Cisg ICAgICAgIGlmIG5vdCBQYXRjaC5pc192YWxpZF9wYXRjaF9pZChwYXRjaGlkKToKKyAgICAgICAg ICAgIHJldHVybiBFUlJfSU5WQUxJRF9QQVRDSF9JRAorCisgICAgICAgIGlmIFBhdGNoLmlzX2V4 aXN0aW5nX3BhdGNoX2lkKHBhdGNoaWQpOgorICAgICAgICAgICAgX2xvZy5pbmZvKCJQYXRjaCBp ZCB7fSBhbHJlYWR5IGV4aXN0cyBpbiBkYXRhYmFzZS4gU2tpcHBlZCBzYXZpbmcuIi5mb3JtYXQo cGF0Y2hpZCkpCisgICAgICAgICAgICByZXR1cm4gRVJSX0VYSVNUSU5HX1BBVENICisgICAgICAg IFBhdGNoKHBhdGNoaWQsIGJ1Z19pZCwgb2Jzb2xldGUpLnNhdmUoKQorICAgICAgICBfbG9nLmlu Zm8oJ1NhdmVkIHBhdGNoIGluIGRhdGFiYXNlLCBpZDoge30nLmZvcm1hdChwYXRjaGlkKSkKKyAg ICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBzYXZlX3Bh dGNoZXMoY2xzLCBwYXRjaF9pZF9saXN0KToKKyAgICAgICAgZm9yIHBhdGNoX2lkIGluIHBhdGNo X2lkX2xpc3Q6CisgICAgICAgICAgICBQYXRjaC5zYXZlX3BhdGNoKHBhdGNoX2lkKQorCisgICAg QGNsYXNzbWV0aG9kCisgICAgZGVmIGlzX3ZhbGlkX3BhdGNoX2lkKGNscywgcGF0Y2hpZCk6Cisg ICAgICAgIGlmIG5vdCBwYXRjaGlkIG9yIHR5cGUocGF0Y2hpZCkgIT0gaW50IG9yIHBhdGNoaWQg PCAwOgorICAgICAgICAgICAgX2xvZy53YXJuKCdJbnZhbGlkIHBhdGNoIGlkOiB7fScuZm9ybWF0 KHBhdGNoaWQpKQorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisgICAgICAgIHJldHVybiBUcnVl CisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgaXNfZXhpc3RpbmdfcGF0Y2hfaWQoY2xzLCBw YXRjaGlkKToKKyAgICAgICAgcmV0dXJuIGJvb2woUGF0Y2gub2JqZWN0cy5maWx0ZXIocGF0Y2hp ZD1wYXRjaGlkKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCA4YzI2NTQxNWMwNC4uZjY1ZTIyYzAyZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0xMS0yMyAg QWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2V3cy1hcHBd IEFkZCBtZXRob2RzIHRvIHNhdmUgcGF0Y2ggdG8gZGF0YWJhc2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTkyOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw cC9ld3MvbW9kZWxzL3BhdGNoLnB5OgorICAgICAgICAoUGF0Y2guc2F2ZV9wYXRjaCk6IE1ldGhv ZCB0byBzYXZlIHRoZSBwYXRjaCB0byBkYXRhYmFzZS4KKyAgICAgICAgKFBhdGNoLnNhdmVfcGF0 Y2hlcyk6IE1ldGhvZCB0byBzYXZlIG11bHRpcGxlIHBhdGNoZXMgdG8gZGF0YWJhc2UuCisgICAg ICAgIChQYXRjaC5pc192YWxpZF9wYXRjaF9pZCk6IENoZWNrcyBpZiB0aGUgcGF0Y2ggaWQgaXMg dmFsaWQuCisgICAgICAgIChQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZCk6IENoZWNrcyBpZiB0 aGUgcGF0Y2ggaWQgYWxyZWFkeSBleGlzdHMgaW4gZGF0YWJhc2UuCisKIDIwMTgtMTEtMjMgIFdl bnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIGRy YWcgYW5kIGRyb3Agc3VwcG9ydCBmb3IgaU9TTWFjCi0tIAoyLjE3LjIgKEFwcGxlIEdpdC0xMTMp Cgo=