19192 2008-05-22 08:29:30 -0700 remove NPNVpluginEventModel, fix example plugin 2008-05-22 11:29:02 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 0 joshmoz webkit-unassigned oldest_to_newest 81204 0 joshmoz 2008-05-22 08:29:30 -0700 There is really no reason for anyone to get the NPNVpluginEventModel variable, the plugin should know it and it gives the illusion that there could be some disagreement with its NPPV sibling. Its existence is confusing and leads to bugs like the Cocoa event plugin mistakenly using it in a SetValue call. 81205 1 21293 joshmoz 2008-05-22 08:30:11 -0700 Created attachment 21293 fix v1.0 81206 2 21294 joshmoz 2008-05-22 08:32:52 -0700 Created attachment 21294 fix v1.1 Also fix the drawing models plugin. 81219 3 andersca 2008-05-22 11:17:11 -0700 <rdar://problem/5956429> 81220 4 21294 andersca 2008-05-22 11:28:53 -0700 Comment on attachment 21294 fix v1.1 Needs a ChangeLog, but I took care of that. 81221 5 andersca 2008-05-22 11:29:02 -0700 Committed revision 34026. 21293 2008-05-22 08:30:11 -0700 2008-05-22 08:32:52 -0700 fix v1.0 webkit_npapi1.patch text/plain 2214 joshmoz SW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3 Lm1tCShyZXZpc2lvbiAzMzk1NykKKysrIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2Nh cGVQbHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYyLDEyICsyNTYyLDYgQEAKICAg ICAgICAgICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKICAgICAgICAgfQogICAgICAgICAKLSAg ICAgICAgY2FzZSBOUE5WcGx1Z2luRXZlbnRNb2RlbDoKLSAgICAgICAgewotICAgICAgICAgICAg KihOUEV2ZW50TW9kZWwgKil2YWx1ZSA9IGV2ZW50TW9kZWw7Ci0gICAgICAgICAgICByZXR1cm4g TlBFUlJfTk9fRVJST1I7Ci0gICAgICAgIH0KLSAgICAgICAgCiAjaWZuZGVmIE5QX05PX0NBUkJP TgogICAgICAgICBjYXNlIE5QTlZzdXBwb3J0c0NhcmJvbkJvb2w6CiAgICAgICAgIHsKSW5kZXg6 IFdlYkNvcmUvYnJpZGdlL25wYXBpLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2UvbnBh cGkuaAkocmV2aXNpb24gMzM5NTcpCisrKyBXZWJDb3JlL2JyaWRnZS9ucGFwaS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zNzcsOCArMzc3LDcgQEAKICNlbmRpZgogICAgICwgTlBOVnN1cHBvcnRzQ29y ZUdyYXBoaWNzQm9vbCA9IDIwMDEgLyogVFJVRSBpZiB0aGUgYnJvd3NlciBzdXBwb3J0cyB0aGUg Q29yZUdyYXBoaWNzIGRyYXdpbmcgbW9kZWwgKi8KICAgICAsIE5QTlZzdXBwb3J0c09wZW5HTEJv b2wgPSAyMDAyIC8qIFRSVUUgaWYgdGhlIGJyb3dzZXIgc3VwcG9ydHMgdGhlIE9wZW5HTCBkcmF3 aW5nIG1vZGVsIChDR0wgb24gTWFjKSAqLwotICAgIAotICAgICwgTlBOVnBsdWdpbkV2ZW50TW9k ZWwgPSAxMDAxIC8qIFRoZSBOUEV2ZW50TW9kZWwgc3BlY2lmaWVkIGJ5IHRoZSBwbHVnaW4gKi8K KwogI2lmbmRlZiBOUF9OT19DQVJCT04KICAgICAsIE5QTlZzdXBwb3J0c0NhcmJvbkJvb2wgPSAy MDAzIC8qIFRSVUUgaWYgdGhlIGJyb3dzZXIgc3VwcG9ydHMgdGhlIENhcmJvbiBldmVudCBtb2Rl bCAqLwogI2VuZGlmCkluZGV4OiBXZWJLaXRFeGFtcGxlUGx1Z2lucy9OZXRzY2FwZUNvY29hUGx1 Z2luL21haW4ubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRFeGFtcGxlUGx1Z2lucy9OZXRzY2FwZUNv Y29hUGx1Z2luL21haW4ubQkocmV2aXNpb24gMzM5NTcpCisrKyBXZWJLaXRFeGFtcGxlUGx1Z2lu cy9OZXRzY2FwZUNvY29hUGx1Z2luL21haW4ubQkod29ya2luZyBjb3B5KQpAQCAtMTI3LDcgKzEy Nyw3IEBACiAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBBVElCTEVfVkVSU0lPTl9FUlJPUjsK ICAgICAKICAgICAvLyBJZiB0aGUgYnJvd3NlciBzdXBwb3J0cyB0aGUgQ29yZUdyYXBoaWNzIGRy YXdpbmcgbW9kZWwsIGVuYWJsZSBpdC4KLSAgICBicm93c2VyLT5zZXR2YWx1ZShpbnN0YW5jZSwg TlBOVnBsdWdpbkRyYXdpbmdNb2RlbCwgKHZvaWQgKilOUERyYXdpbmdNb2RlbENvcmVHcmFwaGlj cyk7CisgICAgYnJvd3Nlci0+c2V0dmFsdWUoaW5zdGFuY2UsIE5QUFZwbHVnaW5EcmF3aW5nTW9k ZWwsICh2b2lkICopTlBEcmF3aW5nTW9kZWxDb3JlR3JhcGhpY3MpOwogCiAgICAgLy8gSWYgdGhl IGJyb3dzZXIgc3VwcG9ydHMgdGhlIENvY29hIGV2ZW50IG1vZGVsLCBlbmFibGUgaXQuCiAgICAg TlBCb29sIHN1cHBvcnRzQ29jb2E7CkBAIC0xMzcsOSArMTM3LDggQEAKICAgICBpZiAoIXN1cHBv cnRzQ29jb2EpCiAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBBVElCTEVfVkVSU0lPTl9FUlJP UjsKICAgICAKLSAgICBicm93c2VyLT5zZXR2YWx1ZShpbnN0YW5jZSwgTlBOVnBsdWdpbkV2ZW50 TW9kZWwsICh2b2lkICopTlBFdmVudE1vZGVsQ29jb2EpOworICAgIGJyb3dzZXItPnNldHZhbHVl KGluc3RhbmNlLCBOUFBWcGx1Z2luRXZlbnRNb2RlbCwgKHZvaWQgKilOUEV2ZW50TW9kZWxDb2Nv YSk7CiAgICAgCi0gICAKICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CiB9CiAK 21294 2008-05-22 08:32:52 -0700 2008-05-22 11:28:53 -0700 fix v1.1 webkit_npapi2.patch text/plain 3252 joshmoz SW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3 Lm1tCShyZXZpc2lvbiAzMzk1NykKKysrIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlTmV0c2Nh cGVQbHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYyLDEyICsyNTYyLDYgQEAKICAg ICAgICAgICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKICAgICAgICAgfQogICAgICAgICAKLSAg ICAgICAgY2FzZSBOUE5WcGx1Z2luRXZlbnRNb2RlbDoKLSAgICAgICAgewotICAgICAgICAgICAg KihOUEV2ZW50TW9kZWwgKil2YWx1ZSA9IGV2ZW50TW9kZWw7Ci0gICAgICAgICAgICByZXR1cm4g TlBFUlJfTk9fRVJST1I7Ci0gICAgICAgIH0KLSAgICAgICAgCiAjaWZuZGVmIE5QX05PX0NBUkJP TgogICAgICAgICBjYXNlIE5QTlZzdXBwb3J0c0NhcmJvbkJvb2w6CiAgICAgICAgIHsKSW5kZXg6 IFdlYkNvcmUvYnJpZGdlL25wYXBpLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2UvbnBh cGkuaAkocmV2aXNpb24gMzM5NTcpCisrKyBXZWJDb3JlL2JyaWRnZS9ucGFwaS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zNzcsOCArMzc3LDcgQEAKICNlbmRpZgogICAgICwgTlBOVnN1cHBvcnRzQ29y ZUdyYXBoaWNzQm9vbCA9IDIwMDEgLyogVFJVRSBpZiB0aGUgYnJvd3NlciBzdXBwb3J0cyB0aGUg Q29yZUdyYXBoaWNzIGRyYXdpbmcgbW9kZWwgKi8KICAgICAsIE5QTlZzdXBwb3J0c09wZW5HTEJv b2wgPSAyMDAyIC8qIFRSVUUgaWYgdGhlIGJyb3dzZXIgc3VwcG9ydHMgdGhlIE9wZW5HTCBkcmF3 aW5nIG1vZGVsIChDR0wgb24gTWFjKSAqLwotICAgIAotICAgICwgTlBOVnBsdWdpbkV2ZW50TW9k ZWwgPSAxMDAxIC8qIFRoZSBOUEV2ZW50TW9kZWwgc3BlY2lmaWVkIGJ5IHRoZSBwbHVnaW4gKi8K KwogI2lmbmRlZiBOUF9OT19DQVJCT04KICAgICAsIE5QTlZzdXBwb3J0c0NhcmJvbkJvb2wgPSAy MDAzIC8qIFRSVUUgaWYgdGhlIGJyb3dzZXIgc3VwcG9ydHMgdGhlIENhcmJvbiBldmVudCBtb2Rl bCAqLwogI2VuZGlmCkluZGV4OiBXZWJLaXRFeGFtcGxlUGx1Z2lucy9OZXRzY2FwZUlucHV0TWV0 aG9kUGx1Z2luL21haW4ubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRFeGFtcGxlUGx1Z2lucy9OZXRz Y2FwZUlucHV0TWV0aG9kUGx1Z2luL21haW4ubQkocmV2aXNpb24gMzM5NTcpCisrKyBXZWJLaXRF eGFtcGxlUGx1Z2lucy9OZXRzY2FwZUlucHV0TWV0aG9kUGx1Z2luL21haW4ubQkod29ya2luZyBj b3B5KQpAQCAtMTMxLDcgKzEzMSw3IEBACiAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBBVElC TEVfVkVSU0lPTl9FUlJPUjsKICAgICAKICAgICAvLyBJZiB0aGUgYnJvd3NlciBzdXBwb3J0cyB0 aGUgQ29yZUdyYXBoaWNzIGRyYXdpbmcgbW9kZWwsIGVuYWJsZSBpdC4KLSAgICBicm93c2VyLT5z ZXR2YWx1ZShpbnN0YW5jZSwgTlBOVnBsdWdpbkRyYXdpbmdNb2RlbCwgKHZvaWQgKilOUERyYXdp bmdNb2RlbENvcmVHcmFwaGljcyk7CisgICAgYnJvd3Nlci0+c2V0dmFsdWUoaW5zdGFuY2UsIE5Q UFZwbHVnaW5EcmF3aW5nTW9kZWwsICh2b2lkICopTlBEcmF3aW5nTW9kZWxDb3JlR3JhcGhpY3Mp OwogCiAgICAgLy8gSWYgdGhlIGJyb3dzZXIgc3VwcG9ydHMgdGhlIENvY29hIGV2ZW50IG1vZGVs LCBlbmFibGUgaXQuCiAgICAgTlBCb29sIHN1cHBvcnRzQ29jb2E7CkBAIC0xNDEsNyArMTQxLDcg QEAKICAgICBpZiAoIXN1cHBvcnRzQ29jb2EpCiAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBB VElCTEVfVkVSU0lPTl9FUlJPUjsKICAgICAKLSAgICBicm93c2VyLT5zZXR2YWx1ZShpbnN0YW5j ZSwgTlBOVnBsdWdpbkV2ZW50TW9kZWwsICh2b2lkICopTlBFdmVudE1vZGVsQ29jb2EpOworICAg IGJyb3dzZXItPnNldHZhbHVlKGluc3RhbmNlLCBOUFBWcGx1Z2luRXZlbnRNb2RlbCwgKHZvaWQg KilOUEV2ZW50TW9kZWxDb2NvYSk7CiAKICAgICBvYmotPnRleHRGaWVsZFJlY3QgPSBOU01ha2VS ZWN0KDEwLCAxMCwgMjAwLCAxMDApOwogCkluZGV4OiBXZWJLaXRFeGFtcGxlUGx1Z2lucy9OZXRz Y2FwZUNvY29hUGx1Z2luL21haW4ubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRFeGFtcGxlUGx1Z2lu cy9OZXRzY2FwZUNvY29hUGx1Z2luL21haW4ubQkocmV2aXNpb24gMzM5NTcpCisrKyBXZWJLaXRF eGFtcGxlUGx1Z2lucy9OZXRzY2FwZUNvY29hUGx1Z2luL21haW4ubQkod29ya2luZyBjb3B5KQpA QCAtMTI3LDcgKzEyNyw3IEBACiAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBBVElCTEVfVkVS U0lPTl9FUlJPUjsKICAgICAKICAgICAvLyBJZiB0aGUgYnJvd3NlciBzdXBwb3J0cyB0aGUgQ29y ZUdyYXBoaWNzIGRyYXdpbmcgbW9kZWwsIGVuYWJsZSBpdC4KLSAgICBicm93c2VyLT5zZXR2YWx1 ZShpbnN0YW5jZSwgTlBOVnBsdWdpbkRyYXdpbmdNb2RlbCwgKHZvaWQgKilOUERyYXdpbmdNb2Rl bENvcmVHcmFwaGljcyk7CisgICAgYnJvd3Nlci0+c2V0dmFsdWUoaW5zdGFuY2UsIE5QUFZwbHVn aW5EcmF3aW5nTW9kZWwsICh2b2lkICopTlBEcmF3aW5nTW9kZWxDb3JlR3JhcGhpY3MpOwogCiAg ICAgLy8gSWYgdGhlIGJyb3dzZXIgc3VwcG9ydHMgdGhlIENvY29hIGV2ZW50IG1vZGVsLCBlbmFi bGUgaXQuCiAgICAgTlBCb29sIHN1cHBvcnRzQ29jb2E7CkBAIC0xMzcsOSArMTM3LDggQEAKICAg ICBpZiAoIXN1cHBvcnRzQ29jb2EpCiAgICAgICAgIHJldHVybiBOUEVSUl9JTkNPTVBBVElCTEVf VkVSU0lPTl9FUlJPUjsKICAgICAKLSAgICBicm93c2VyLT5zZXR2YWx1ZShpbnN0YW5jZSwgTlBO VnBsdWdpbkV2ZW50TW9kZWwsICh2b2lkICopTlBFdmVudE1vZGVsQ29jb2EpOworICAgIGJyb3dz ZXItPnNldHZhbHVlKGluc3RhbmNlLCBOUFBWcGx1Z2luRXZlbnRNb2RlbCwgKHZvaWQgKilOUEV2 ZW50TW9kZWxDb2NvYSk7CiAgICAgCi0gICAKICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CiB9 CiAK