191917 2018-11-22 18:57:41 -0800 [Cocoa] clang emits a warning when building WebKit after r238293 2018-11-22 20:02:17 -0800 1 1 1 Unclassified WebKit WebKit API Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh achristensen commit-queue mitz thorton webkit-bug-importer oldest_to_newest 1481049 0 wenson_hsieh 2018-11-22 18:57:41 -0800 This is the warning: CompileC WKShareSheet.o Ld WebKit ld: warning: instance method 'isSafeBrowsingEnabled' in category from /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o overrides method from class in /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o ld: warning: instance method 'setSafeBrowsingEnabled:' in category from /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o overrides method from class in /Users/whsieh/Build/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource17-mm.o PhaseScriptExecution Check For Weak VTables and Externals PhaseScriptExecution Check For Inappropriate Objective-C Class Names ...it looks like both -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled are implemented in the WKPrivate category, but should instead be implemented in the main category. 1481050 1 355495 wenson_hsieh 2018-11-22 19:03:56 -0800 Created attachment 355495 Patch 1481054 2 355495 commit-queue 2018-11-22 20:00:38 -0800 Comment on attachment 355495 Patch Clearing flags on attachment: 355495 Committed r238455: <https://trac.webkit.org/changeset/238455> 1481055 3 commit-queue 2018-11-22 20:00:39 -0800 All reviewed patches have been landed. Closing bug. 1481056 4 webkit-bug-importer 2018-11-22 20:02:17 -0800 <rdar://problem/46217146> 355495 2018-11-22 19:03:56 -0800 2018-11-22 20:00:38 -0800 Patch bug-191917-20181122190354.patch text/plain 2020 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU2ZmU4YzFiMzMzY2RiZTcy YmY1MWVjOWRkYzZlNGFhNjkxZDM1YzEuLmE3MjE0NGU0NzEyN2IyZTQxYzY1NGQ4N2QyNmQxNzE4 ODNhMzJkODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTEtMjIgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBjbGFuZyBl bWl0cyBhIHdhcm5pbmcgd2hlbiBidWlsZGluZyBXZWJLaXQgYWZ0ZXIgcjIzODI5MworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxOTE3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgaW1wbGVt ZW50YXRpb25zIG9mIC1zZXRTYWZlQnJvd3NpbmdFbmFibGVkOiBhbmQgLWlzU2FmZUJyb3dzaW5n RW5hYmxlZCB0byB0aGUgbWFpbiBpbXBsZW1lbnRhdGlvbiBvZgorICAgICAgICBXS1ByZWZlcmVu Y2VzIHRvIGZpeCB0aGUgd2FybmluZy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBzZXRTYWZlQnJvd3Np bmdFbmFibGVkOl0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIGlzU2FmZUJyb3dzaW5nRW5h YmxlZF0pOgorCiAyMDE4LTExLTIyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZHJlc3MgcG9zdC1yZXZpZXcgZmVlZGJhY2sgYWZ0ZXIgcjIzODQz OApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVy ZW5jZXMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl cy5tbQppbmRleCA2ZGJkY2E2NWJkYjExZTcxYjU5MTAwOTJhMGIzMWQ3ZWNmYmMzMzEyLi5lZGE5 YzgxOGU2NjEyM2JjMTQ4ODc1YWZiNzM3ZWRkY2IwNjE2N2JiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQpAQCAtMTQwLDYgKzE0 MCwxNiBAQCAtICh2b2lkKV9zZXRTdG9yYWdlQWNjZXNzUHJvbXB0c0VuYWJsZWQ6KEJPT0wpZW5h YmxlZAogICAgIF9wcmVmZXJlbmNlcy0+c2V0U3RvcmFnZUFjY2Vzc1Byb21wdHNFbmFibGVkKGVu YWJsZWQpOwogfQogCistICh2b2lkKXNldFNhZmVCcm93c2luZ0VuYWJsZWQ6KEJPT0wpZW5hYmxl ZAoreworICAgIF9wcmVmZXJlbmNlcy0+c2V0U2FmZUJyb3dzaW5nRW5hYmxlZChlbmFibGVkKTsK K30KKworLSAoQk9PTClpc1NhZmVCcm93c2luZ0VuYWJsZWQKK3sKKyAgICByZXR1cm4gX3ByZWZl cmVuY2VzLT5zYWZlQnJvd3NpbmdFbmFibGVkKCk7Cit9CisKICNwcmFnbWEgbWFyayBPUyBYLXNw ZWNpZmljIG1ldGhvZHMKIAogI2lmIFBMQVRGT1JNKE1BQykKQEAgLTY5NywxNiArNzA3LDYgQEAg LSAodm9pZClfc2V0SUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZDooQk9PTCllbmFibGVkCiAg ICAgX3ByZWZlcmVuY2VzLT5zZXRJQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkKGVuYWJsZWQp OwogfQogCi0tICh2b2lkKXNldFNhZmVCcm93c2luZ0VuYWJsZWQ6KEJPT0wpZW5hYmxlZAotewot ICAgIF9wcmVmZXJlbmNlcy0+c2V0U2FmZUJyb3dzaW5nRW5hYmxlZChlbmFibGVkKTsKLX0KLQot LSAoQk9PTClpc1NhZmVCcm93c2luZ0VuYWJsZWQKLXsKLSAgICByZXR1cm4gX3ByZWZlcmVuY2Vz LT5zYWZlQnJvd3NpbmdFbmFibGVkKCk7Ci19Ci0KIC0gKEJPT0wpX3dlYlJUQ0xlZ2FjeUFQSUVu YWJsZWQKIHsKICAgICByZXR1cm4gTk87Cg==