191914 2018-11-22 12:53:40 -0800 Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation 2018-11-23 03:36:11 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis cdumez beidson commit-queue ggaren koivisto rniwa webkit-bug-importer oldest_to_newest 1481016 0 rbuis 2018-11-22 12:53:40 -0800 Steps to repro: 1. Start mini browser 2. Go to google.com 3. Search for something, for example I entered "autosport". 4. Click a hit. 5. Go back. At this point google.com is indicated in the location bar but nothing is rendered. A bit later mini browser will likely crash. 1481017 1 rbuis 2018-11-22 12:55:50 -0800 Assigning to Chris since my bisecting seems to point to https://bugs.webkit.org/show_bug.cgi?id=191781. First of all I would be interested if it is reproducible or just my system/setup though. 1481019 2 cdumez 2018-11-22 13:37:57 -0800 Will look, thanks. 1481020 3 cdumez 2018-11-22 13:40:19 -0800 Do you process "Process Swap on Cross-Site navigation" enabled in experimental features? 1481024 4 cdumez 2018-11-22 14:44:10 -0800 (In reply to Chris Dumez from comment #3) > Do you process "Process Swap on Cross-Site navigation" enabled in > experimental features? Do you *have* "Process Swap on Cross-Site navigation" enabled in experimental features? 1481026 5 cdumez 2018-11-22 14:53:47 -0800 > A bit later mini browser will likely crash. Crash log? I wasn't able to reproduce in Safari. Will try Minibrowser soon. 1481033 6 cdumez 2018-11-22 15:37:11 -0800 Ok, I was able to reproduce in Minibrowser. 1481034 7 cdumez 2018-11-22 15:44:42 -0800 I see a DecidePolicyForResponse sent why the about-to-be-suspended process to the SuspendedPageProxy but no DidFinishLoadForFrame. 1481037 8 cdumez 2018-11-22 15:55:50 -0800 (In reply to Chris Dumez from comment #7) > I see a DecidePolicyForResponse sent why the about-to-be-suspended process > to the SuspendedPageProxy but no DidFinishLoadForFrame. In Safari, I get no DecidePolicyForNavigationResponse and I get a DidFinishProgress IPC. 1481040 9 cdumez 2018-11-22 16:02:17 -0800 DocumentLoader::maybeLoadEmpty() returns false in Minibrowser but true in Safari. It returns false because SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument(m_request.url().protocol().toStringWithoutCopying())) check fails 1481045 10 355493 cdumez 2018-11-22 17:10:57 -0800 Created attachment 355493 Patch 1481059 11 355493 commit-queue 2018-11-22 20:36:47 -0800 Comment on attachment 355493 Patch Clearing flags on attachment: 355493 Committed r238456: <https://trac.webkit.org/changeset/238456> 1481060 12 commit-queue 2018-11-22 20:36:49 -0800 All reviewed patches have been landed. Closing bug. 1481061 13 webkit-bug-importer 2018-11-22 20:37:28 -0800 <rdar://problem/46217302> 1481099 14 rbuis 2018-11-23 03:36:11 -0800 (In reply to Chris Dumez from comment #3) > Do you process "Process Swap on Cross-Site navigation" enabled in > experimental features? I did have that enabled. Thanks for fixing! 355493 2018-11-22 17:10:57 -0800 2018-11-22 20:36:47 -0800 Patch bug-191914-20181122171056.patch text/plain 3806 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE4Nzc5MzQ1NDNlMmFkYzEy NWQ3ZGI4NDEyMWE4YTUyMGQ3ZGJlYTcuLjgzNzAwNzc4MDE5MmQ5ODZkYjlmNTc4NmM1NjE4NzI4 ZTBlNTZhM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMTEtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzgzNTMpIExv YWQgc29tZXRpbWVzIGhhbmdzIHdoZW4gbmF2aWdhdGluZyBiYWNrIGFmdGVyIGEgY3Jvc3Mtc2l0 ZSBuYXZpZ2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTE5MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXaGVuIHByb2Nlc3Mtc3dhcHBpbmcgb24gYSBjcm9zcy1zaXRlIHNlcnZlci1zaWRlIHJl ZGlyZWN0LCB3ZSBlbmQgdXAgZG9pbmcgYSBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uUmVzcG9u c2UKKyAgICAgICAgcG9saWN5IGNoZWNrIGZvciB0aGUgYWJvdXQ6Ymxhbmsgc3VzcGVuc2lvbiBs b2FkLiBUaGlzIHBvbGljeSBkZWNpc2lvbiBpcyBpZ25vcmVkIGJ5IHRoZSBVSVByb2Nlc3MgYmVj YXVzZQorICAgICAgICBTdXNwZW5kZWRQYWdlUHJveHkgZG9lcyBub3QgaGFuZGxlIHRoaXMgcGFy dGljdWxhciBJUEMgbWVzc2FnZS4gVG8gaGFuZGxlIHRoZSBpc3N1ZSwgbWFrZSBzdXJlIHRoZSBX ZWJQcm9jZXNzCisgICAgICAgIG5ldmVyIHNlbmRzIGEgRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlv blJlc3BvbnNlIElQQyB0byB0aGUgVUlQcm9jZXNzIGZvciBhYm91dDpibGFuayBzdXNwZW5zaW9u IGxvYWRzIGFuZCBsZXQKKyAgICAgICAgdGhlIGxvYWQgcHJvY2VlZC4KKworICAgICAgICBUaGUg aXNzdWUgd2FzIGFscmVhZHkgdGhlcmUgYmVmb3JlIHIyMzgzNTMgYnV0IGl0IHdhcyBtYWRlIG9i dmlvdXMgYnkgcjIzODM1MyB3aGljaCBjYXVzZWQgYSBoYW5nIHdoZW4gdHJ5aW5nCisgICAgICAg IHRvIHJldXNlIGEgU3VzcGVuZGVkIHBhZ2Ugd2hpY2ggaXMgaGFuZ2luZyB3aGlsZSB0cnlpbmcg dG8gc3VzcGVuZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVu dDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNwb25zZSk6CisKIDIwMTgtMTEtMjIgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJvbGxvdXQgcjIzODQzMjogQnJl YWtzIGludGVybmFsIE1hYyBidWlsZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcApp bmRleCAzZTY1MDgzYzZjZTVjMWM2MDkzNmEwNDY1YmYxMmNiNmMyMTEzYmQ3Li43NmJjYmYyZWY4 YmJhZjZmNTAzNzUwYjU3OGQ4MDFjMzBhNTZiZDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNs aWVudC5jcHAKQEAgLTczOCw2ICs3MzgsMTIgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6 ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnMKICAg ICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIC8vIEZvciBzdXNwZW5zaW9uIGxvYWRzIHRvIGFi b3V0OmJsYW5rLCBubyBuZWVkIHRvIGFzayB0aGUgU3VzcGVuZGVkUGFnZVByb3h5LgorICAgIGlm IChyZXF1ZXN0LnVybCgpID09IGJsYW5rVVJMKCkgJiYgd2ViUGFnZS0+aXNTdXNwZW5kZWQoKSkg eworICAgICAgICBmdW5jdGlvbihQb2xpY3lBY3Rpb246OlVzZSk7CisgICAgICAgIHJldHVybjsK KyAgICB9CisKICAgICBSZWZQdHI8QVBJOjpPYmplY3Q+IHVzZXJEYXRhOwogCiAgICAgLy8gTm90 aWZ5IHRoZSBidW5kbGUgY2xpZW50LgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDllZTE1YzRlMDJmYTA5MzE3NjM2NWMxMjM4Njg0YjliZmRhMjFl YzIuLjIxMDI1YWY2OTNjYjBlNjEyOGYzNDYxZTg2Y2M1Njc0ODg2MGYzNGMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOC0xMS0yMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFJl Z3Jlc3Npb24ocjIzODM1MykgTG9hZCBzb21ldGltZXMgaGFuZ3Mgd2hlbiBuYXZpZ2F0aW5nIGJh Y2sgYWZ0ZXIgYSBjcm9zcy1zaXRlIG5hdmlnYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTkxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBBUEkgdGVzdCBjb3ZlcmFnZS4KKworICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRp b24ubW06CisKIDIwMTgtMTEtMjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtJRkNdIE9mZnNldCBmb3JtYXR0aW5nIGNvbnRleHQgcm9vdCBydW5zIHdp dGggaG9yaXpvbnRhbCBtYXJnaW5zLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbSBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0KaW5k ZXggMTBmMDU5ZDdmMmNhZTllMmNkNTNmZmI0NTBlZjFhMDVkMmY4MmFlNy4uZGI2NjRmNDVkY2Jl YzM4MGY2ODQ5NWUwMzI1ZWUyODNhYzgxZjhjNiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQorKysgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0 aW9uLm1tCkBAIC0xMzE5LDYgKzEzMTksMTUgQEAgVEVTVChQcm9jZXNzU3dhcCwgU2VydmVyUmVk aXJlY3QyKQogICAgIEVYUEVDVF9GQUxTRShzZXJ2ZXJSZWRpcmVjdGVkKTsKICAgICBFWFBFQ1Rf RVEoMywgbnVtYmVyT2ZEZWNpZGVQb2xpY3lDYWxscyk7CiAgICAgRVhQRUNUX0VRKDJ1LCBzZWVu UElEcy5zaXplKCkpOworCisgICAgRVhQRUNUX1dLX1NUUkVRKEAicHNvbjovL3d3dy5hcHBsZS5j b20vbWFpbi5odG1sIiwgW1t3ZWJWaWV3IFVSTF0gYWJzb2x1dGVTdHJpbmddKTsKKworICAgIFt3 ZWJWaWV3IGdvQmFja107CisKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOwor ICAgIGRvbmUgPSBmYWxzZTsKKworICAgIEVYUEVDVF9XS19TVFJFUShAInBzb246Ly93d3cud2Vi a2l0Lm9yZy9tYWluMS5odG1sIiwgW1t3ZWJWaWV3IFVSTF0gYWJzb2x1dGVTdHJpbmddKTsKIH0K IAogZW51bSBjbGFzcyBTaG91bGRFbmFibGVQU09OIHsgTm8sIFllcyB9Owo=