191904 2018-11-22 05:00:05 -0800 [GStreamer][WebRTC] Do not run device monitor for device type we do not handle 2018-11-28 04:41:36 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier tsaunier commit-queue pnormand webkit-bug-importer oldest_to_newest 1480945 0 tsaunier 2018-11-22 05:00:05 -0800 [GStreamer][WebRTC] Do not run device monitor for device type we do not handle 1480946 1 355468 tsaunier 2018-11-22 05:00:42 -0800 Created attachment 355468 Minor ChangeLog enhancement 1480951 2 355468 pnormand 2018-11-22 06:10:57 -0800 Comment on attachment 355468 Minor ChangeLog enhancement View in context: https://bugs.webkit.org/attachment.cgi?id=355468&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:113 > + } else { > + return; > } The curly braces can be removed :) > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:-112 > - // FIXME: Add monitor for added/removed messages on the bus. Why is this removed? Doesn't need to be fixed? 1482030 3 tsaunier 2018-11-27 12:06:56 -0800 (In reply to Philippe Normand from comment #2) > Comment on attachment 355468 [details] > Minor ChangeLog enhancement > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355468&action=review > > > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:113 > > + } else { > > + return; > > } > > The curly braces can be removed :) Done. > > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:-112 > > - // FIXME: Add monitor for added/removed messages on the bus. > > Why is this removed? Doesn't need to be fixed? Right, just moving it and forgot to commit the addition. Re added now. 1482031 4 355758 tsaunier 2018-11-27 12:08:12 -0800 Created attachment 355758 Patch 1482394 5 355758 commit-queue 2018-11-28 04:40:16 -0800 Comment on attachment 355758 Patch Clearing flags on attachment: 355758 Committed r238605: <https://trac.webkit.org/changeset/238605> 1482395 6 commit-queue 2018-11-28 04:40:17 -0800 All reviewed patches have been landed. Closing bug. 1482396 7 webkit-bug-importer 2018-11-28 04:41:36 -0800 <rdar://problem/46306708> 355468 2018-11-22 05:00:42 -0800 2018-11-27 12:08:09 -0800 Minor ChangeLog enhancement bug-191904-20181122100041.patch text/plain 1859 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2ZGI0MmQ5MjBjMjNi NTVkYjU3MzNkZTc3OWM2NzViYmU3ZDRkMS4uZTRhYTg3MDRkNDlhZDMwMTllY2YyZjEyY2IyNjI3 ZDUwZTljYTFmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTIyICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCBydW4gZGV2aWNlIG1vbml0b3IgZm9yIGRldmljZSB0eXBlIHdlIGRv IG5vdCBoYW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MTkwNAorCisgICAgICAgIFRoaXMgaXMgdXNlbGVzcyB3b3JrIGFuZCBpdCB0aHJvd3Mg d2FybmluZyBhYm91dCB1c2UgR3N0RGV2aWNlTW9uaXRvciB3aXRob3V0IGZpbHRlcnMuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQ2FwdHVyZURldmljZU1hbmFnZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R1N0cmVhbWVyQ2FwdHVyZURldmljZU1hbmFnZXI6OnJlZnJlc2hD YXB0dXJlRGV2aWNlcyk6CisKIDIwMTgtMTEtMjAgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmll ckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdW1dlYlJUQ10gVXNlIExpYldlYlJU QyBwcm92aWRlZCB2cDggZGVjb2RlcnMgYW5kIGVuY29kZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQ2FwdHVyZURl dmljZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0 cmVhbWVyL0dTdHJlYW1lckNhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcAppbmRleCAzYjc4Mjg3ZTdh YWY1MGRkZjc5NWRiZDgzNmFhYjUyMDg2Y2RiMzM4Li4yZTA0NmUxYjU5MDg4MGM3ZmVkZTMzZDA1 MmQ2YmM4YTZhMmY2YTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQ2FwdHVyZURldmljZU1hbmFnZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJD YXB0dXJlRGV2aWNlTWFuYWdlci5jcHAKQEAgLTEwOCw4ICsxMDgsOSBAQCB2b2lkIEdTdHJlYW1l ckNhcHR1cmVEZXZpY2VNYW5hZ2VyOjpyZWZyZXNoQ2FwdHVyZURldmljZXMoKQogICAgICAgICB9 IGVsc2UgaWYgKHR5cGUgPT0gQ2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6TWljcm9waG9uZSkg ewogICAgICAgICAgICAgR1JlZlB0cjxHc3RDYXBzPiBjYXBzID0gYWRvcHRHUmVmKGdzdF9jYXBz X25ld19lbXB0eV9zaW1wbGUoImF1ZGlvL3gtcmF3IikpOwogICAgICAgICAgICAgZ3N0X2Rldmlj ZV9tb25pdG9yX2FkZF9maWx0ZXIobV9kZXZpY2VNb25pdG9yLmdldCgpLCAiQXVkaW8vU291cmNl IiwgY2Fwcy5nZXQoKSk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KLSAgICAgICAgLy8gRklYTUU6IEFkZCBtb25pdG9yIGZvciBhZGRlZC9yZW1vdmVk IG1lc3NhZ2VzIG9uIHRoZSBidXMuCiAgICAgfQogCiAgICAgaWYgKCFnc3RfZGV2aWNlX21vbml0 b3Jfc3RhcnQobV9kZXZpY2VNb25pdG9yLmdldCgpKSkgewo= 355758 2018-11-27 12:08:12 -0800 2018-11-28 04:40:16 -0800 Patch bug-191904-20181127170811.patch text/plain 2047 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc0YjE1YWMyNDBmZTc0 Mjg0ZGEzN2U1MjUwYTE4YWNmNDExZGJiNy4uMTdhYjEyODg0NTY4ZDhiZTc4MjJhYWI4N2M0Y2Iz MjVhYWI0NzJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTIyICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCBydW4gZGV2aWNlIG1vbml0b3IgZm9yIGRldmljZSB0eXBlIHdlIGRv IG5vdCBoYW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MTkwNAorCisgICAgICAgIFRoaXMgaXMgdXNlbGVzcyB3b3JrIGFuZCBpdCB0aHJvd3Mg d2FybmluZyBhYm91dCB1c2UgR3N0RGV2aWNlTW9uaXRvciB3aXRob3V0IGZpbHRlcnMuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQ2FwdHVyZURldmljZU1hbmFnZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R1N0cmVhbWVyQ2FwdHVyZURldmljZU1hbmFnZXI6OnJlZnJlc2hD YXB0dXJlRGV2aWNlcyk6CisKIDIwMTgtMTEtMjAgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmll ckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdW1dlYlJUQ10gVXNlIExpYldlYlJU QyBwcm92aWRlZCB2cDggZGVjb2RlcnMgYW5kIGVuY29kZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQ2FwdHVyZURl dmljZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0 cmVhbWVyL0dTdHJlYW1lckNhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcAppbmRleCAzYjc4Mjg3ZTdh YWY1MGRkZjc5NWRiZDgzNmFhYjUyMDg2Y2RiMzM4Li5hMjczZDQ0YTU4MWRjNWY2Mzc4MGE4NzVh NWRmYzk2ODUyMmQ4YjZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQ2FwdHVyZURldmljZU1hbmFnZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJD YXB0dXJlRGV2aWNlTWFuYWdlci5jcHAKQEAgLTEwOCwxMCArMTA4LDExIEBAIHZvaWQgR1N0cmVh bWVyQ2FwdHVyZURldmljZU1hbmFnZXI6OnJlZnJlc2hDYXB0dXJlRGV2aWNlcygpCiAgICAgICAg IH0gZWxzZSBpZiAodHlwZSA9PSBDYXB0dXJlRGV2aWNlOjpEZXZpY2VUeXBlOjpNaWNyb3Bob25l KSB7CiAgICAgICAgICAgICBHUmVmUHRyPEdzdENhcHM+IGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2Nh cHNfbmV3X2VtcHR5X3NpbXBsZSgiYXVkaW8veC1yYXciKSk7CiAgICAgICAgICAgICBnc3RfZGV2 aWNlX21vbml0b3JfYWRkX2ZpbHRlcihtX2RldmljZU1vbml0b3IuZ2V0KCksICJBdWRpby9Tb3Vy Y2UiLCBjYXBzLmdldCgpKTsKLSAgICAgICAgfQotICAgICAgICAvLyBGSVhNRTogQWRkIG1vbml0 b3IgZm9yIGFkZGVkL3JlbW92ZWQgbWVzc2FnZXMgb24gdGhlIGJ1cy4KKyAgICAgICAgfSBlbHNl CisgICAgICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgLy8gRklYTUU6IEFkZCBtb25pdG9y IGZvciBhZGRlZC9yZW1vdmVkIG1lc3NhZ2VzIG9uIHRoZSBidXMuCiAgICAgaWYgKCFnc3RfZGV2 aWNlX21vbml0b3Jfc3RhcnQobV9kZXZpY2VNb25pdG9yLmdldCgpKSkgewogICAgICAgICBHU1Rf V0FSTklOR19PQkpFQ1QobV9kZXZpY2VNb25pdG9yLmdldCgpLCAiQ291bGQgbm90IHN0YXJ0IGRl dmljZSBtb25pdG9yIik7CiAgICAgICAgIG1fZGV2aWNlTW9uaXRvciA9IG51bGxwdHI7Cg==