191896 2018-11-21 14:36:00 -0800 [LFC] LayoutState should always be initialized with the initial containing block. 2018-11-21 15:26:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1480835 0 zalan 2018-11-21 14:36:00 -0800 and not with some random formatting context root. 1480837 1 355440 zalan 2018-11-21 14:52:09 -0800 Created attachment 355440 Patch 1480840 2 355440 koivisto 2018-11-21 15:12:10 -0800 Comment on attachment 355440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355440&action=review > Source/WebCore/layout/Verification.cpp:324 > + auto& initialContainingBlock = *m_initialContainingBlock; The local here doesn't do much. 1480843 3 zalan 2018-11-21 15:25:19 -0800 Committed r238431: <https://trac.webkit.org/changeset/238431> 1480844 4 webkit-bug-importer 2018-11-21 15:26:29 -0800 <rdar://problem/46205042> 355440 2018-11-21 14:52:09 -0800 2018-11-21 15:12:10 -0800 Patch bug-191896-20181121145208.patch text/plain 7614 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTllYjUzYjNhZmM0YThl YzBiZGMzYWVmOTBhMDBjNDdkMTkxYzNjNy4uOTUxYzNkMjI4N2VmZGEzZDcyY2Y5NTE0Yzg4ZGUw NGZhOWQwMjYyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTExLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gTGF5b3V0U3RhdGUg c2hvdWxkIGFsd2F5cyBiZSBpbml0aWFsaXplZCB3aXRoIHRoZSBpbml0aWFsIGNvbnRhaW5pbmcg YmxvY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTE4OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGVyZSBzaG91bGQgYWx3YXlzIGJlIG9ubHkgb25lIExheW91dFN0YXRlIHBlciBsYXlvdXQgdHJl ZSAoaXQgZG9lcyBub3QgbWVhbiB0aGF0IGxheW91dCBhbHdheXMgc3RhcnRzIGF0IHRoZSBJQ0Ip LgorICAgICAgICBUaGUgSUNCIGlzIGEgc3BlY2lhbCBmb3JtYXR0aW5nIGNvbnRleHQgcm9vdCBi ZWNhdXNlIGl0IGRvZXMgbm90IGhhdmUgYSBwYXJlbnQgZm9ybWF0dGluZyBjb250ZXh0LiBBbGwg dGhlIG90aGVyIGZvcm1hdHRpbmcgY29udGV4dHMKKyAgICAgICAgZmlyc3QgbmVlZCB0byBiZSBs YWlkIG91dCAocGFydGlhbGx5IGF0IGxlYXN0IGUuZyBtYXJnaW4pIGluIHRoZWlyIHBhcmVudCBm b3JtYXR0aW5nIGNvbnRleHQuCisgICAgICAgIEhhdmluZyBhIG5vbi1udWxsIHBhcmVudCBmb3Jt YXR0aW5nIGNvbnRleHQgYXMgcm9vdCBjb3VsZCBsZWFkIHRvIHVuZGVmaW5lZCBiZWhhdmlvdXIu IAorCisgICAgICAgICogbGF5b3V0L0xheW91dEZvcm1hdHRpbmdTdGF0ZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkxheW91dFN0YXRlOjpMYXlvdXRTdGF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OkxheW91dFN0YXRlOjppbml0aWFsaXplUm9vdCk6IERlbGV0ZWQuCisg ICAgICAgICogbGF5b3V0L0xheW91dEZvcm1hdHRpbmdTdGF0ZS5oOgorICAgICAgICAqIGxheW91 dC9WZXJpZmljYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMYXlvdXRTdGF0 ZTo6dmVyaWZ5QW5kT3V0cHV0TWlzbWF0Y2hpbmdMYXlvdXRUcmVlIGNvbnN0KToKKyAgICAgICAg KiBwYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bGF5 b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCk6CisKIDIwMTgtMTEtMjEgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIEJvcmRlciBzaG91bGQgYmUg Y29uc2lkZXJlZCBhcyBub24tYnJlYWthYmxlIHNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvTGF5b3V0Rm9ybWF0dGluZ1N0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9MYXlvdXRGb3JtYXR0aW5nU3RhdGUuY3BwCmluZGV4IDhiNGM5MzZkNjY4YjM5OWJmNDM4 ZDUxYWZjN2JjMmM5ZTUwMjM3MTEuLmI1OWFlMGEyZmI2ZDk1YTVlNGY0OGJkYWE3YzJhZWIzNzg3 MTNlZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRGb3JtYXR0aW5n U3RhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRGb3JtYXR0aW5nU3Rh dGUuY3BwCkBAIC00NSwyOSArNDUsMjUgQEAgbmFtZXNwYWNlIExheW91dCB7CiAKIFdURl9NQUtF X0lTT19BTExPQ0FURURfSU1QTChMYXlvdXRTdGF0ZSk7CiAKLUxheW91dFN0YXRlOjpMYXlvdXRT dGF0ZSgpCitMYXlvdXRTdGF0ZTo6TGF5b3V0U3RhdGUoY29uc3QgQ29udGFpbmVyJiBpbml0aWFs Q29udGFpbmluZ0Jsb2NrLCBjb25zdCBMYXlvdXRTaXplJiBjb250YWluZXJTaXplKQorICAgIDog bV9pbml0aWFsQ29udGFpbmluZ0Jsb2NrKG1ha2VXZWFrUHRyKGluaXRpYWxDb250YWluaW5nQmxv Y2spKQogewotfQotCi12b2lkIExheW91dFN0YXRlOjppbml0aWFsaXplUm9vdChjb25zdCBDb250 YWluZXImIHJvb3QsIGNvbnN0IExheW91dFNpemUmIGNvbnRhaW5lclNpemUpCi17Ci0gICAgQVNT RVJUKHJvb3QuZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKTsKKyAgICAvLyBMYXlvdXRT dGF0ZSBpcyBhbHdheXMgaW5pdGlhdGVkIHdpdGggdGhlIElDQi4KKyAgICBBU1NFUlQoIWluaXRp YWxDb250YWluaW5nQmxvY2sucGFyZW50KCkpOworICAgIEFTU0VSVChpbml0aWFsQ29udGFpbmlu Z0Jsb2NrLmVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dCgpKTsKIAotICAgIG1fcm9v dCA9IG1ha2VXZWFrUHRyKHJvb3QpOwotICAgIGF1dG8mIGRpc3BsYXlCb3ggPSBkaXNwbGF5Qm94 Rm9yTGF5b3V0Qm94KHJvb3QpOwotCi0gICAgLy8gRklYTUU6IG1fcm9vdCBjb3VsZCB2ZXJ5IHdl bGwgYmUgYSBmb3JtYXR0aW5nIGNvbnRleHQgcm9vdCB3aXRoIGFuY2VzdG9ycyBhbmQgcmVzb2x2 YWJsZSBib3JkZXIgYW5kIHBhZGRpbmcgKGFzIG9wcG9zZWQgdG8gdGhlIHRvcG1vc3Qgcm9vdCkK KyAgICBhdXRvJiBkaXNwbGF5Qm94ID0gZGlzcGxheUJveEZvckxheW91dEJveChpbml0aWFsQ29u dGFpbmluZ0Jsb2NrKTsKICAgICBkaXNwbGF5Qm94LnNldEhvcml6b250YWxNYXJnaW4oeyB9KTsK ICAgICBkaXNwbGF5Qm94LnNldEhvcml6b250YWxOb25Db21wdXRlZE1hcmdpbih7IH0pOwogICAg IGRpc3BsYXlCb3guc2V0VmVydGljYWxNYXJnaW4oeyB9KTsKICAgICBkaXNwbGF5Qm94LnNldFZl cnRpY2FsTm9uQ29sbGFwc2VkTWFyZ2luKHsgfSk7CiAgICAgZGlzcGxheUJveC5zZXRCb3JkZXIo eyB9KTsKICAgICBkaXNwbGF5Qm94LnNldFBhZGRpbmcoeyB9KTsKKyAgICBkaXNwbGF5Qm94LnNl dFRvcExlZnQoeyB9KTsKICAgICBkaXNwbGF5Qm94LnNldENvbnRlbnRCb3hIZWlnaHQoY29udGFp bmVyU2l6ZS5oZWlnaHQoKSk7CiAgICAgZGlzcGxheUJveC5zZXRDb250ZW50Qm94V2lkdGgoY29u dGFpbmVyU2l6ZS53aWR0aCgpKTsKLSAgICBkaXNwbGF5Qm94LnNldFRvcExlZnQoeyB9KTsKIAot ICAgIG1fZm9ybWF0dGluZ0NvbnRleHRSb290TGlzdEZvckxheW91dC5hZGQoJnJvb3QpOworICAg IG1fZm9ybWF0dGluZ0NvbnRleHRSb290TGlzdEZvckxheW91dC5hZGQoJmluaXRpYWxDb250YWlu aW5nQmxvY2spOwogfQogCiB2b2lkIExheW91dFN0YXRlOjp1cGRhdGVMYXlvdXQoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dEZvcm1hdHRpbmdTdGF0ZS5oIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dEZvcm1hdHRpbmdTdGF0ZS5oCmluZGV4IGUyMDNlNjcy ZmQ5OTFiMGM0YTQwMzljYWJkZDk2YTMzMjdiZTlhOTYuLmVkNzZkY2M2YmI5NTUyNDk1OGI0M2Yx ZDBiMjllNjgyN2M5N2ZlYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlv dXRGb3JtYXR0aW5nU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0Rm9y bWF0dGluZ1N0YXRlLmgKQEAgLTQ5LDE4ICs0OSwxNyBAQCBjbGFzcyBCb3g7CiBjbGFzcyBDb250 YWluZXI7CiBjbGFzcyBGb3JtYXR0aW5nU3RhdGU7CiAKLS8vIExheW91dFN0YXRlIGlzIHRoZSBl bnRyeSBwb2ludCBmb3IgbGF5b3V0LiBJdCB0YWtlcyBhIChmb3JtYXR0aW5nIHJvb3QpY29udGFp bmVyIHdoaWNoIGFjdHMgYXMgdGhlIHJvb3Qgb2YgdGhlIGxheW91dCBjb250ZXh0LgorLy8gTGF5 b3V0U3RhdGUgaXMgdGhlIGVudHJ5IHBvaW50IGZvciBsYXlvdXQuIEl0IHRha2VzIHRoZSBpbml0 aWFsIGNvbnRhaW5pbmcgYmxvY2sgd2hpY2ggYWN0cyBhcyB0aGUgcm9vdCBvZiB0aGUgbGF5b3V0 IGNvbnRleHQuCiAvLyBMYXlvdXRTdGF0ZTo6bGF5b3V0KCkgZ2VuZXJhdGVzIHRoZSBkaXNwbGF5 IHRyZWUgZm9yIHRoZSByb290IGNvbnRhaW5lcidzIHN1YnRyZWUgKGl0IGRvZXMgbm90IHJ1biBs YXlvdXQgb24gdGhlIHJvb3QgdGhvdWdoKS4KLS8vIE5vdGUsIHdoaWxlIHRoZSByb290IGNvbnRh aW5lciBpcyBzdXBwcG9zZWQgdG8gYmUgdGhlIGVudHJ5IHBvaW50IGZvciB0aGUgaW5pdGlhbCBs YXlvdXQsIGl0IGRvZXMgbm90IG5lY2Vzc2FyaWx5IG5lZWQgdG8gYmUgdGhlIGVudHJ5IHBvaW50 IG9mIGFueQorLy8gTm90ZSwgd2hpbGUgdGhlIGluaXRpYWwgY29udGFpbmluZyBibG9jayBpcyBl bnRyeSBwb2ludCBmb3IgdGhlIGluaXRpYWwgbGF5b3V0LCBpdCBkb2VzIG5vdCBuZWNlc3Nhcmls eSBuZWVkIHRvIGJlIHRoZSBlbnRyeSBwb2ludCBvZiBhbnkKIC8vIHN1YnNlcXVlbnQgbGF5b3V0 cyAoc3VidHJlZSBsYXlvdXQpLiBBIG5vbi1pbml0aWFsLCBzdWJ0cmVlIGxheW91dCBjb3VsZCBi ZSBpbml0aWF0ZWQgb24gbXVsdGlwbGUgZm9ybWF0dGluZyBjb250ZXh0cy4KIC8vIEVhY2ggZm9y bWF0dGluZyBjb250ZXh0IGhhcyBhbiBlbnRyeSBwb2ludCBmb3IgbGF5b3V0LCB3aGljaCBwb3Rl bml0YWxseSBtZWFucyBtdWx0aXBsZSBlbnRyeSBwb2ludHMgcGVyIGxheW91dCBmcmFtZS4KIC8v IExheW91dFN0YXRlIGFsc28gaG9sZHMgdGhlIGZvcm1hdHRpbmcgc3RhdGVzLiBUaGV5IGNhY2hl IGZvcm1hdHRpbmcgY29udGV4dCBzcGVjaWZpYyBkYXRhIHRvIGVuYWJsZSBwZXJmb3JtYW50IGlu Y3JlbWVudGFsIGxheW91dHMuCiBjbGFzcyBMYXlvdXRTdGF0ZSB7CiAgICAgV1RGX01BS0VfSVNP X0FMTE9DQVRFRChMYXlvdXRTdGF0ZSk7CiBwdWJsaWM6Ci0gICAgTGF5b3V0U3RhdGUoKTsKKyAg ICBMYXlvdXRTdGF0ZShjb25zdCBDb250YWluZXImIGluaXRpYWxDb250YWluaW5nQmxvY2ssIGNv bnN0IExheW91dFNpemUmKTsKIAotICAgIHZvaWQgaW5pdGlhbGl6ZVJvb3QoY29uc3QgQ29udGFp bmVyJiwgY29uc3QgTGF5b3V0U2l6ZSYpOwogICAgIHZvaWQgdXBkYXRlTGF5b3V0KCk7CiAgICAg dm9pZCBzdHlsZUNoYW5nZWQoY29uc3QgQm94JiwgU3R5bGVEaWZmKTsKICAgICB2b2lkIHNldElu UXVpcmtzTW9kZShib29sIGluUXVpcmtzTW9kZSkgeyBtX2luUXVpcmtzTW9kZSA9IGluUXVpcmtz TW9kZTsgfQpAQCAtODgsNyArODcsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIHZvaWQgbGF5 b3V0Rm9ybWF0dGluZ0NvbnRleHRTdWJ0cmVlKGNvbnN0IEJveCYpOwogCi0gICAgV2Vha1B0cjxj b25zdCBDb250YWluZXI+IG1fcm9vdDsKKyAgICBXZWFrUHRyPGNvbnN0IENvbnRhaW5lcj4gbV9p bml0aWFsQ29udGFpbmluZ0Jsb2NrOwogICAgIEhhc2hTZXQ8Y29uc3QgQ29udGFpbmVyKj4gbV9m b3JtYXR0aW5nQ29udGV4dFJvb3RMaXN0Rm9yTGF5b3V0OwogICAgIEhhc2hNYXA8Y29uc3QgQm94 Kiwgc3RkOjp1bmlxdWVfcHRyPEZvcm1hdHRpbmdTdGF0ZT4+IG1fZm9ybWF0dGluZ1N0YXRlczsK ICAgICBtdXRhYmxlIEhhc2hNYXA8Y29uc3QgQm94Kiwgc3RkOjp1bmlxdWVfcHRyPERpc3BsYXk6 OkJveD4+IG1fbGF5b3V0VG9EaXNwbGF5Qm94OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L1ZlcmlmaWNhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0 aW9uLmNwcAppbmRleCBlNWRiNzZiZjlkYTIwZWUzNDZjOTIxMzQyZDNiZGYzODgwMTI3MWU3Li4w MDRjOTljMzA0MGM2N2JkNTUxNmFhZTA4MThjYWMxYjJlNTE3NWJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvVmVyaWZpY2F0aW9uLmNwcApAQCAtMzIxLDEyICszMjEsMTMgQEAgc3RhdGljIGJvb2wg dmVyaWZ5QW5kT3V0cHV0U3VidHJlZShUZXh0U3RyZWFtJiBzdHJlYW0sIGNvbnN0IExheW91dFN0 YXRlJiBjb250ZXgKIHZvaWQgTGF5b3V0U3RhdGU6OnZlcmlmeUFuZE91dHB1dE1pc21hdGNoaW5n TGF5b3V0VHJlZShjb25zdCBSZW5kZXJWaWV3JiByZW5kZXJWaWV3KSBjb25zdAogewogICAgIFRl eHRTdHJlYW0gc3RyZWFtOwotICAgIGF1dG8gbWlzbWF0Y2hpbmdHZW9tZXRyeSA9IHZlcmlmeUFu ZE91dHB1dFN1YnRyZWUoc3RyZWFtLCAqdGhpcywgcmVuZGVyVmlldywgKm1fcm9vdC5nZXQoKSk7 CisgICAgYXV0byYgaW5pdGlhbENvbnRhaW5pbmdCbG9jayA9ICptX2luaXRpYWxDb250YWluaW5n QmxvY2s7CisgICAgYXV0byBtaXNtYXRjaGluZ0dlb21ldHJ5ID0gdmVyaWZ5QW5kT3V0cHV0U3Vi dHJlZShzdHJlYW0sICp0aGlzLCByZW5kZXJWaWV3LCBpbml0aWFsQ29udGFpbmluZ0Jsb2NrKTsK ICAgICBpZiAoIW1pc21hdGNoaW5nR2VvbWV0cnkpCiAgICAgICAgIHJldHVybjsKICNpZiBFTkFC TEUoVFJFRV9ERUJVR0dJTkcpCiAgICAgc2hvd1JlbmRlclRyZWUoJnJlbmRlclZpZXcpOwotICAg IHNob3dMYXlvdXRUcmVlKCptX3Jvb3QuZ2V0KCksIHRoaXMpOworICAgIHNob3dMYXlvdXRUcmVl KGluaXRpYWxDb250YWluaW5nQmxvY2ssIHRoaXMpOwogI2VuZGlmCiAgICAgV1RGTG9nQWx3YXlz KCIlcyIsIHN0cmVhbS5yZWxlYXNlKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlld0xheW91 dENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXdMYXlvdXRDb250ZXh0 LmNwcAppbmRleCBiNjczNDZmZjhhMzU0MDg4MDA4MjgxOGMyZmU5NTkyN2U2MzQyM2Y4Li43YTk5 NTdhMTdmODZiN2ZkYjAxOGQyYjVlN2FjZGNhYjdjZmEzZmZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5jcHAKQEAgLTU2LDggKzU2LDcgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogc3RhdGljIHZvaWQgbGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4 dChjb25zdCBSZW5kZXJWaWV3JiByZW5kZXJWaWV3KQogewogICAgIGF1dG8gaW5pdGlhbENvbnRh aW5pbmdCbG9jayA9IExheW91dDo6VHJlZUJ1aWxkZXI6OmNyZWF0ZUxheW91dFRyZWUocmVuZGVy Vmlldyk7Ci0gICAgYXV0byBsYXlvdXRTdGF0ZSA9IHN0ZDo6bWFrZV91bmlxdWU8TGF5b3V0OjpM YXlvdXRTdGF0ZT4oKTsKLSAgICBsYXlvdXRTdGF0ZS0+aW5pdGlhbGl6ZVJvb3QoKmluaXRpYWxD b250YWluaW5nQmxvY2ssIHJlbmRlclZpZXcuc2l6ZSgpKTsKKyAgICBhdXRvIGxheW91dFN0YXRl ID0gc3RkOjptYWtlX3VuaXF1ZTxMYXlvdXQ6OkxheW91dFN0YXRlPigqaW5pdGlhbENvbnRhaW5p bmdCbG9jaywgcmVuZGVyVmlldy5zaXplKCkpOwogICAgIGxheW91dFN0YXRlLT5zZXRJblF1aXJr c01vZGUocmVuZGVyVmlldy5kb2N1bWVudCgpLmluUXVpcmtzTW9kZSgpKTsKICAgICBsYXlvdXRT dGF0ZS0+dXBkYXRlTGF5b3V0KCk7CiAgICAgbGF5b3V0U3RhdGUtPnZlcmlmeUFuZE91dHB1dE1p c21hdGNoaW5nTGF5b3V0VHJlZShyZW5kZXJWaWV3KTsK