191888 2018-11-21 07:56:07 -0800 [SOUP] Certificate decoder always returns GByteArray with zero size 2018-11-21 08:38:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez berto cgarcia commit-queue csaavedra ews-watchlist gustavo hi joepeck mcatanzaro sam webkit-bug-importer zan oldest_to_newest 1480756 0 aperez 2018-11-21 07:56:07 -0800 [SOUP] Certificate decoder always returns GByteArray with zero size 1480757 1 355413 aperez 2018-11-21 07:59:24 -0800 Created attachment 355413 Patch 1480759 2 355413 zan 2018-11-21 08:11:23 -0800 Comment on attachment 355413 Patch Can you check other similar cases (i.e. g_byte_array_sized_new() calls without the subsequent g_byte_array_set_size() call), if any? 1480760 3 csaavedra 2018-11-21 08:13:17 -0800 (In reply to Zan Dobersek from comment #2) > Comment on attachment 355413 [details] > Patch > > Can you check other similar cases (i.e. g_byte_array_sized_new() calls > without the subsequent g_byte_array_set_size() call), if any? This is only needed here because we're writing directly to the array->bytes instead of calling g_byte_array_append(), which saves us one allocation, but has this drawback. 1480761 4 aperez 2018-11-21 08:13:34 -0800 (In reply to Zan Dobersek from comment #2) > Comment on attachment 355413 [details] > Patch > > Can you check other similar cases (i.e. g_byte_array_sized_new() calls > without the subsequent g_byte_array_set_size() call), if any? Sure, I'll take a look and if needed (hopefully not!) then add new bug reports for them :) 1480762 5 aperez 2018-11-21 08:17:36 -0800 (In reply to Adrian Perez from comment #4) > (In reply to Zan Dobersek from comment #2) > > Comment on attachment 355413 [details] > > Patch > > > > Can you check other similar cases (i.e. g_byte_array_sized_new() calls > > without the subsequent g_byte_array_set_size() call), if any? > > Sure, I'll take a look and if needed (hopefully not!) then add new > bug reports for them :) The only other use of “g_byte_array_sized_new()” is in “WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp” (line 103), and in that case is followed by a call to “g_byte_array_append()” instead 👍 1480764 6 355413 commit-queue 2018-11-21 08:37:36 -0800 Comment on attachment 355413 Patch Clearing flags on attachment: 355413 Committed r238417: <https://trac.webkit.org/changeset/238417> 1480765 7 commit-queue 2018-11-21 08:37:38 -0800 All reviewed patches have been landed. Closing bug. 1480766 8 webkit-bug-importer 2018-11-21 08:38:25 -0800 <rdar://problem/46201982> 355413 2018-11-21 07:59:24 -0800 2018-11-21 08:37:36 -0800 Patch bug-191888-20181121195841.patch text/plain 1586 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQyMGEzMzk3M2QzOWQ0 NDM2ZDYwMGEwYjQyOThhZjQ5YjMyYmExMy4uZTBhZTAxYjdhYWMzMzljNGIyYWYzOWZiYzYxOWI3 NzU3OWY2YWNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTIxICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1NPVVBd IENlcnRpZmljYXRlIGRlY29kZXIgYWx3YXlzIHJldHVybnMgR0J5dGVBcnJheSB3aXRoIHplcm8g c2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkx ODg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9DZXJ0 aWZpY2F0ZUluZm8uaDoKKyAgICAgICAgKFdURjo6UGVyc2lzdGVuY2U6OkNvZGVyPEdSZWZQdHI8 R0J5dGVBcnJheT4+OjpkZWNvZGUpOiBBZGQgbWlzc2luZworICAgICAgICBjYWxsIHRvIGdfYnl0 ZV9hcnJheV9zZXRfc2l6ZSgpIHRvIG1ha2Ugc3VyZSBieXRlQXJyYXktPmxlbiBoYXMgdGhlCisg ICAgICAgIGNvcnJlY3QgdmFsdWUuCisKIDIwMTgtMTEtMjEgIFphbGFuIEJ1dGphcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIFRha2Ugbm9uQnJlYWthYmxlU3RhcnQv RW5kIGludG8gdXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL0NlcnRpZmljYXRlSW5mby5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL0NlcnRpZmljYXRlSW5mby5oCmluZGV4IGJhMzFmYzFlMGM2YjQ2ZThiMzc0MjQ1M2Fl NzdhZjM1MzQ0YTI2NmIuLmEwYTc2ZGFiZTI4MjMxMWZhOWQxNTc5YmYyNjdkNGJhNzAxYjI5NTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9DZXJ0aWZp Y2F0ZUluZm8uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ2Vy dGlmaWNhdGVJbmZvLmgKQEAgLTgzLDcgKzgzLDggQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQ29kZXI8 R1JlZlB0cjxHQnl0ZUFycmF5Pj4gewogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAg ICAgIGJ5dGVBcnJheSA9IGFkb3B0R1JlZihnX2J5dGVfYXJyYXlfc2l6ZWRfbmV3KHNpemUpKTsK LSAgICAgICAgcmV0dXJuIGRlY29kZXIuZGVjb2RlRml4ZWRMZW5ndGhEYXRhKGJ5dGVBcnJheS0+ ZGF0YSwgYnl0ZUFycmF5LT5sZW4pOworICAgICAgICBnX2J5dGVfYXJyYXlfc2V0X3NpemUoYnl0 ZUFycmF5LmdldCgpLCBzaXplKTsKKyAgICAgICAgcmV0dXJuIGRlY29kZXIuZGVjb2RlRml4ZWRM ZW5ndGhEYXRhKGJ5dGVBcnJheS0+ZGF0YSwgc2l6ZSk7CiAgICAgfQogfTsKIAo=