191874 2018-11-20 20:55:13 -0800 Mutation observers doesn't get notified of character data mutation made by the parser 2018-11-21 13:34:29 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez dbates esprehn+autocc ews-watchlist kangil.han koivisto webkit-bug-importer wenson_hsieh oldest_to_newest 1480662 0 rniwa 2018-11-20 20:55:13 -0800 When MutationObserver is observing a text node e.g. via a subtree observation, and the HTML parser appends more data to it, the observer never gets invoked with mutation records of the character data mutation made by the parser. <rdar://problem/42477645> 1480663 1 355381 rniwa 2018-11-20 20:57:26 -0800 Created attachment 355381 Fixes the bug 1480705 2 355381 koivisto 2018-11-21 01:26:51 -0800 Comment on attachment 355381 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=355381&action=review > Source/WebCore/dom/CharacterData.cpp:102 > + String oldData; > + if (UNLIKELY(mutationRecipients)) > + oldData = m_data; Maybe just set oldData unconditionally? It is not clear that a branch is faster than minor ref churn. 1480825 3 rniwa 2018-11-21 13:24:17 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 355381 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355381&action=review > > > Source/WebCore/dom/CharacterData.cpp:102 > > + String oldData; > > + if (UNLIKELY(mutationRecipients)) > > + oldData = m_data; > > Maybe just set oldData unconditionally? It is not clear that a branch is > faster than minor ref churn. Okay. I guess we'd catch it on perf bots if it regressed perf. 1480826 4 rniwa 2018-11-21 13:33:51 -0800 Committed r238429: <https://trac.webkit.org/changeset/238429> 1480827 5 webkit-bug-importer 2018-11-21 13:34:29 -0800 <rdar://problem/46204294> 355381 2018-11-20 20:57:26 -0800 2018-11-21 01:26:51 -0800 Fixes the bug bug-191874-20181120205725.patch text/plain 4742 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODQxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE11dGF0aW9uIG9ic2VydmVycyBk b2Vzbid0IGdldCBub3RpZmllZCBvZiBjaGFyYWN0ZXIgZGF0YSBtdXRhdGlvbiBtYWRlIGJ5IHRo ZSBwYXJzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MTg3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVkIHRoZSBidWcgdGhhdCBDaGFyYWN0ZXJEYXRhOjpwYXJzZXJBcHBlbmREYXRhIHdhcyBu ZXZlciBub3RpZnlpbmcgTXV0YXRpb25PYnNlcnZlci4KKworICAgICAgICBUZXN0OiBmYXN0L2Rv bS9NdXRhdGlvbk9ic2VydmVyL29ic2VydmUtcGFyc2VyLWNoYXJhY3Rlci1kYXRhLWNoYW5nZS5o dG1sCisKKyAgICAgICAgKiBkb20vQ2hhcmFjdGVyRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDaGFyYWN0ZXJEYXRhOjpwYXJzZXJBcHBlbmREYXRhKToKKwogMjAxOC0xMS0yMCAgRGVhbiBK YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZpbmcgdXNpbmcgbmFtZXNw YWNlIFdlYkNvcmUgZnJvbSBXZWJMYXllcgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0NoYXJh Y3RlckRhdGEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9DaGFyYWN0ZXJE YXRhLmNwcAkocmV2aXNpb24gMjM4NDA4KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0NoYXJhY3Rl ckRhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Niw2ICs5NiwxMSBAQCB1bnNpZ25lZCBDaGFy YWN0ZXJEYXRhOjpwYXJzZXJBcHBlbmREYXRhCiAgICAgaWYgKCFjaGFyYWN0ZXJMZW5ndGhMaW1p dCkKICAgICAgICAgcmV0dXJuIDA7CiAKKyAgICBhdXRvIG11dGF0aW9uUmVjaXBpZW50cyA9IE11 dGF0aW9uT2JzZXJ2ZXJJbnRlcmVzdEdyb3VwOjpjcmVhdGVGb3JDaGFyYWN0ZXJEYXRhTXV0YXRp b24oKnRoaXMpOworICAgIFN0cmluZyBvbGREYXRhOworICAgIGlmIChVTkxJS0VMWShtdXRhdGlv blJlY2lwaWVudHMpKQorICAgICAgICBvbGREYXRhID0gbV9kYXRhOworCiAgICAgaWYgKHN0cmlu Zy5pczhCaXQoKSkKICAgICAgICAgbV9kYXRhLmFwcGVuZChzdHJpbmcuY2hhcmFjdGVyczgoKSAr IG9mZnNldCwgY2hhcmFjdGVyTGVuZ3RoTGltaXQpOwogICAgIGVsc2UKQEAgLTEwNiw2ICsxMTEs OSBAQCB1bnNpZ25lZCBDaGFyYWN0ZXJEYXRhOjpwYXJzZXJBcHBlbmREYXRhCiAgICAgICAgIGRv d25jYXN0PFRleHQ+KCp0aGlzKS51cGRhdGVSZW5kZXJlckFmdGVyQ29udGVudENoYW5nZShvbGRM ZW5ndGgsIDApOwogCiAgICAgbm90aWZ5UGFyZW50QWZ0ZXJDaGFuZ2UoQ29udGFpbmVyTm9kZTo6 Q2hpbGRDaGFuZ2VTb3VyY2U6OlBhcnNlcik7CisgICAgCisgICAgaWYgKFVOTElLRUxZKG11dGF0 aW9uUmVjaXBpZW50cykpCisgICAgICAgIG11dGF0aW9uUmVjaXBpZW50cy0+ZW5xdWV1ZU11dGF0 aW9uUmVjb3JkKE11dGF0aW9uUmVjb3JkOjpjcmVhdGVDaGFyYWN0ZXJEYXRhKCp0aGlzLCBvbGRE YXRhKSk7CiAKICAgICByZXR1cm4gY2hhcmFjdGVyTGVuZ3RoTGltaXQ7CiB9CkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAyMzg0MDkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAxOC0xMS0yMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KKworICAgICAgICBNdXRhdGlvbiBvYnNlcnZlcnMgZG9lc24ndCBnZXQgbm90aWZpZWQg b2YgY2hhcmFjdGVyIGRhdGEgbXV0YXRpb24gbWFkZSBieSB0aGUgcGFyc2VyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE4NzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Npb24g dGVzdC4KKworICAgICAgICAqIGZhc3QvZG9tL011dGF0aW9uT2JzZXJ2ZXIvb2JzZXJ2ZS1wYXJz ZXItY2hhcmFjdGVyLWRhdGEtY2hhbmdlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9kb20vTXV0YXRpb25PYnNlcnZlci9vYnNlcnZlLXBhcnNlci1jaGFyYWN0ZXItZGF0YS1j aGFuZ2UuaHRtbDogQWRkZWQuCisKIDIwMTgtMTEtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgSW5wdXQgZWxlbWVudCBnYWlucyBmb2N1cyB3aGVuIGEgc2Vs ZWN0c3RhcnQgZXZlbnQgbGlzdGVuZXIgb24gZG9jdW1lbnQgcHJldmVudHMgdGhlIGRlZmF1bHQg YWN0aW9uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9NdXRhdGlvbk9ic2VydmVyL29ic2Vy dmUtcGFyc2VyLWNoYXJhY3Rlci1kYXRhLWNoYW5nZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vTXV0YXRpb25PYnNlcnZlci9vYnNlcnZlLXBhcnNlci1j aGFyYWN0ZXItZGF0YS1jaGFuZ2UtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL011dGF0aW9uT2JzZXJ2ZXIvb2JzZXJ2ZS1wYXJzZXItY2hhcmFjdGVy LWRhdGEtY2hhbmdlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQgQEAK K1RoaXMgdGVzdHMgb2JzZXJ2aW5nIHRoZSBjaGFyYWN0ZXIgZGF0YSBjaGFuZ2UgYnkgdGhlIEhU TUwgcGFyc2VyLgorCitQQVNTCithYgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vTXV0YXRp b25PYnNlcnZlci9vYnNlcnZlLXBhcnNlci1jaGFyYWN0ZXItZGF0YS1jaGFuZ2UuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9NdXRhdGlvbk9ic2VydmVyL29ic2VydmUt cGFyc2VyLWNoYXJhY3Rlci1kYXRhLWNoYW5nZS5odG1sCShub25leGlzdGVudCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL011dGF0aW9uT2JzZXJ2ZXIvb2JzZXJ2ZS1wYXJzZXItY2hhcmFjdGVy LWRhdGEtY2hhbmdlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzNyBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyBvYnNlcnZpbmcgdGhlIGNo YXJhY3RlciBkYXRhIGNoYW5nZSBieSB0aGUgSFRNTCBwYXJzZXIuPC9wPgorPHByZSBpZD0ibG9n Ij48L3ByZT4KKzxkaXYgaWQ9InBhcmVudCI+PHNjcmlwdD4KKworaWYgKHdpbmRvdy50ZXN0UnVu bmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitjb25zdCBsb2cgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnbG9nJyk7CisKK2RvY3VtZW50LndyaXRlKCdhJyk7CitsZXQgb2Jz ZXJ2ZXIgPSBuZXcgTXV0YXRpb25PYnNlcnZlcigobXV0YXRpb25zKSA9PiB7CisgICAgbGV0IHJl c3VsdCA9ICdQQVNTJzsKKyAgICBpZiAobXV0YXRpb25zLmxlbmd0aCAhPSAxKQorICAgICAgICBy ZXN1bHQgPSBgRkFJTCAtIGV4cGVjdGVkIDEgbXV0YXRpb24gcmVjb3JkIGJ1dCBnb3QgJHttdXRh dGlvbnMubGVuZ3RofWA7CisgICAgZWxzZSBpZiAobXV0YXRpb25zWzBdLnR5cGUgIT0gJ2NoYXJh Y3RlckRhdGEnKQorICAgICAgICByZXN1bHQgPSBgRkFJTCAtIGV4cGVjdGVkIGNoYXJhY3RlckRh dGEgbXV0YXRpb24gcmVjb3JkIGJ1dCBnb3QgJHttdXRhdGlvbnNbMF0udHlwZX1gOworICAgIGVs c2UgaWYgKG11dGF0aW9uc1swXS5vbGRWYWx1ZSAhPSAnYScpCisgICAgICAgIHJlc3VsdCA9IGBG QUlMIC0gZXhwZWN0ZWQgb2xkVmFsdWUgdG8gYmUgImEiIGJ1dCBnb3QgIiR7bXV0YXRpb25zWzBd Lm9sZFZhbHVlfSJgOworICAgIGxvZy50ZXh0Q29udGVudCA9IHJlc3VsdDsKK30pOworb2JzZXJ2 ZXIub2JzZXJ2ZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncGFyZW50JyksIHtjaGlsZExpc3Q6 IHRydWUsIHN1YnRyZWU6IHRydWUsIGNoYXJhY3RlckRhdGE6IHRydWUsIGNoYXJhY3RlckRhdGFP bGRWYWx1ZTogdHJ1ZX0pOworZG9jdW1lbnQud3JpdGUoJ2InKTsKKworZnVuY3Rpb24gZmFpbCgp IHsKKyAgICBpZiAoIWxvZy50ZXh0Q29udGVudCkKKyAgICAgICAgbG9nLnRleHRDb250ZW50ID0g J0ZBSUwgLSBkaWQgbm90IHJlY2VpdmUgYSBtdXRhdGlvbiByZWNvcmQgaW4gdGltZSc7Cit9CisK K1Byb21pc2UucmVzb2x2ZSgpLnRoZW4oZmFpbCk7Cit3aW5kb3cub25sb2FkID0gKCkgPT4gZmFp bDsKKworPC9zY3JpcHQ+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQo=