191851 2018-11-19 22:16:41 -0800 Document::focusNavigationStartingNode doesn't take shadow tree into account 2018-11-20 06:13:42 -0800 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=191694 InRadar P2 Normal --- 148695 1 rniwa webkit-unassigned cfleizach jcraig koivisto webkit-bug-importer wenson_hsieh oldest_to_newest 1480381 0 rniwa 2018-11-19 22:16:41 -0800 Document::focusNavigationStartingNode needs to take shadow tree and slotted content into account. This is a bit tricky because this code needs to traverse the composed tree forward & backward. 1480382 1 rniwa 2018-11-19 22:18:10 -0800 Antti, what do you think about adding the support for traversing backwards to ElementAndTextDescendantIterator and ComposedTreeIterator? 1480383 2 webkit-bug-importer 2018-11-19 22:18:41 -0800 <rdar://problem/46178587> 1480385 3 355311 rniwa 2018-11-19 22:21:42 -0800 Created attachment 355311 A patch to add a test case 1480461 4 koivisto 2018-11-20 06:13:42 -0800 (In reply to Ryosuke Niwa from comment #1) > Antti, what do you think about adding the support for traversing backwards > to ElementAndTextDescendantIterator and ComposedTreeIterator? Good idea! 355311 2018-11-19 22:21:42 -0800 2018-11-19 22:21:42 -0800 A patch to add a test case test191851.patch text/plain 2136 rniwa SW5kZXg6IExheW91dFRlc3RzL3Jlc291cmNlcy91aS1oZWxwZXIuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcmVzb3VyY2VzL3VpLWhlbHBlci5qcwkocmV2aXNpb24gMjM4MzgyKQorKysg TGF5b3V0VGVzdHMvcmVzb3VyY2VzL3VpLWhlbHBlci5qcwkod29ya2luZyBjb3B5KQpAQCAtNjYs NiArNjYsMTQgQEAKICAgICAgICAgfSk7CiAgICAgfQogCisgICAgc3RhdGljIHNlcXVlbnRpYWxG b2N1c05hdmlnYXRpb24oZGlyZWN0aW9uKQorICAgIHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQo ZGlyZWN0aW9uID09ICdmb3J3YXJkJyB8fCBkaXJlY3Rpb24gPT0gJ2JhY2t3YXJkJyk7CisgICAg ICAgIGlmIChkaXJlY3Rpb24gPT0gJ2ZvcndhcmQnKQorICAgICAgICAgICAgcmV0dXJuIFVJSGVs cGVyLmtleURvd24oIlx0Iik7CisgICAgICAgIHJldHVybiBVSUhlbHBlci5rZXlEb3duKCJcdCIs IFsic2hpZnRLZXkiXSk7CisgICAgfQorCiAgICAgc3RhdGljIGVuc3VyZVByZXNlbnRhdGlvblVw ZGF0ZSgpCiAgICAgewogICAgICAgICBpZiAoIXRoaXMuaXNXZWJLaXQyKCkpIHsKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9zZXF1ZW50aWFsLWZvY3VzLW5hdmlnYXRpb24tc3Rh cnRpbmctcG9pbnQtaW4tc2xvdHRlZC1jb250ZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9zaGFkb3ctZG9tL3NlcXVlbnRpYWwtZm9jdXMtbmF2aWdhdGlvbi1zdGFydGlu Zy1wb2ludC1pbi1zbG90dGVkLWNvbnRlbnQuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRU ZXN0cy9mYXN0L3NoYWRvdy1kb20vc2VxdWVudGlhbC1mb2N1cy1uYXZpZ2F0aW9uLXN0YXJ0aW5n LXBvaW50LWluLXNsb3R0ZWQtY29udGVudC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MzAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxkaXYgaWQ9Imhvc3QiPjxp bnB1dCBpZD0iYSIgc2xvdD0iYSIgdHlwZT0idGV4dCIgdmFsdWU9ImZvY3VzIG1lIj48aW5wdXQg aWQ9ImIiIHNsb3Q9ImIiIHR5cGU9InRleHQiPjwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jl c291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKGBUaGlz IHRlc3RzIHRoZSBzZXF1ZW50aWFsIG5hdmlnYXRpb24gd291bGQgY29udGludWUgZnJvbSB3aGVy ZSB0aGUgZm9jdXNlZCBlbGVtZW50IHdhcyBhZnRlciBpdHMgcmVtb3ZhbC48YnI+CitUbyBtYW5h dWxseSB0ZXN0LCBmb2N1cyBvbiB0aGUgZmlyc3QgdGV4dCBmaWVsZCBiZWxvdywgdGhlbiBwcmVz cyBhIHRhYiBrZXkuYCk7CisKK2NvbnN0IHNoYWRvd1Jvb3QgPSBob3N0LmF0dGFjaFNoYWRvdyh7 bW9kZTogJ2Nsb3NlZCd9KTsKK3NoYWRvd1Jvb3QuaW5uZXJIVE1MID0gJzxzcGFuPjxpbnB1dCBp ZD0iYyIgdHlwZT0idGV4dCI+PHNsb3QgbmFtZT0iYSI+PC9zbG90PjxzbG90IG5hbWU9ImIiPjwv c2xvdD48L3NwYW4+JzsKKworaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgIHdpbmRvdy5v bmxvYWQgPSBhc3luYyAoKSA9PiB7CisgICAgICAgIGF3YWl0IFVJSGVscGVyLmFjdGl2YXRlRm9y bUNvbnRyb2woYSk7CisgICAgICAgIGEucmVtb3ZlKCk7CisgICAgICAgIGF3YWl0IFVJSGVscGVy LnNlcXVlbnRpYWxGb2N1c05hdmlnYXRpb24oKTsKKyAgICAgICAgc2hvdWxkQmUoJ2RvY3VtZW50 LmFjdGl2ZUVsZW1lbnQnLCAnYicpOworICAgIH0KKyAgICBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsK K30gZWxzZSBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgZG9jdW1lbnQud3JpdGUoJ1RoaXMg dGVzdCByZXF1aXJlcyBldmVudFNlbmRlcicpOworZWxzZQorICAgIGEuYWRkRXZlbnRMaXN0ZW5l cignZm9jdXMnLCAoKSA9PiBzZXRUaW1lb3V0KCgpID0+IGEucmVtb3ZlKCksIDEwMCkpOworCis8 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K