<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191848</bug_id>
          
          <creation_ts>2018-11-19 17:35:25 -0800</creation_ts>
          <short_desc>Simplify platform check in WebEditorClient</short_desc>
          <delta_ts>2018-11-19 19:05:32 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fujii</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1480337</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-11-19 17:35:25 -0800</bug_when>
    <thetext>#if !PLATFORM(GTK) &amp;&amp; !PLATFORM(COCOA) &amp;&amp; !PLATFORM(WPE) is PLATFORM(WIN)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480341</commentid>
    <comment_count>1</comment_count>
      <attachid>355302</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2018-11-19 17:39:32 -0800</bug_when>
    <thetext>Created attachment 355302
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480355</commentid>
    <comment_count>2</comment_count>
      <attachid>355302</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-19 19:04:43 -0800</bug_when>
    <thetext>Comment on attachment 355302
Patch

Clearing flags on attachment: 355302

Committed r238389: &lt;https://trac.webkit.org/changeset/238389&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480356</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-11-19 19:04:44 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480357</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-11-19 19:05:32 -0800</bug_when>
    <thetext>&lt;rdar://problem/46176789&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>355302</attachid>
            <date>2018-11-19 17:39:32 -0800</date>
            <delta_ts>2018-11-19 19:04:43 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-191848.diff</filename>
            <type>text/plain</type>
            <size>1642</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggOTU5ZWUwMWZiM2IuLjM5NDAzOWNlMmU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx
LDE1IEBACisyMDE4LTExLTE5ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+
CisKKyAgICAgICAgU2ltcGxpZnkgcGxhdGZvcm0gY2hlY2sgaW4gV2ViRWRpdG9yQ2xpZW50Cisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE4NDgKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAhUExBVEZPUk0o
R1RLKSAmJiAhUExBVEZPUk0oQ09DT0EpICYmICFQTEFURk9STShXUEUpIGNhbiBiZSBiZXR0ZXIK
KyAgICAgICAgcmVwcmVzZW50ZWQgYXMgUExBVEZPUk0oV0lOKS4KKworICAgICAgICAqIFdlYlBy
b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcDoKKwogMjAxOC0xMS0xOSAg
VG9tb2tpIEltYWkgIDxUb21va2kuSW1haUBzb255LmNvbT4KIAogICAgICAgICBbY2Fpcm9dIEJh
Y2tpbmdTdG9yZTo6aW5jb3Jwb3JhdGVVcGRhdGUgc2hvdWxkIHVzZSBDb21wb3NpdGVDb3B5IHRv
IHN1cHBvcnQgZHJhd3NCYWNrZ3JvdW5kPWZhbHNlIGluIGdlbmVyYWwgQ2Fpcm8gcG9ydHMKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0
b3JDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl
YkVkaXRvckNsaWVudC5jcHAKaW5kZXggYWNkZTJmMDBkN2QuLmFiMzM2N2FhNjc2IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xp
ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi
RWRpdG9yQ2xpZW50LmNwcApAQCAtMzU5LDcgKzM1OSw3IEBAIHZvaWQgV2ViRWRpdG9yQ2xpZW50
OjpyZWRvKCkKICAgICBtX3BhZ2UtPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkV4
ZWN1dGVVbmRvUmVkbyhVbmRvT3JSZWRvOjpSZWRvKSwgTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6
RXhlY3V0ZVVuZG9SZWRvOjpSZXBseSgpKTsKIH0KIAotI2lmICFQTEFURk9STShHVEspICYmICFQ
TEFURk9STShDT0NPQSkgJiYgIVBMQVRGT1JNKFdQRSkKKyNpZiBQTEFURk9STShXSU4pCiB2b2lk
IFdlYkVkaXRvckNsaWVudDo6aGFuZGxlS2V5Ym9hcmRFdmVudChLZXlib2FyZEV2ZW50KiBldmVu
dCkKIHsKICAgICBpZiAobV9wYWdlLT5oYW5kbGVFZGl0aW5nS2V5Ym9hcmRFdmVudChldmVudCkp
CkBAIC0zNzAsNyArMzcwLDcgQEAgdm9pZCBXZWJFZGl0b3JDbGllbnQ6OmhhbmRsZUlucHV0TWV0
aG9kS2V5ZG93bihLZXlib2FyZEV2ZW50KikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQot
I2VuZGlmCisjZW5kaWYgLy8gUExBVEZPUk0oV0lOKQogCiB2b2lkIFdlYkVkaXRvckNsaWVudDo6
dGV4dEZpZWxkRGlkQmVnaW5FZGl0aW5nKEVsZW1lbnQqIGVsZW1lbnQpCiB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>