191847 2018-11-19 17:27:26 -0800 [WPE] Fix some feature guards in WebKit 2018-11-20 07:32:43 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead aperez bugs-noreply commit-queue mcatanzaro oldest_to_newest 1480334 0 don.olmstead 2018-11-19 17:27:26 -0800 There are some feature guards that are incorrect in WPE code. 1480336 1 355301 don.olmstead 2018-11-19 17:33:56 -0800 Created attachment 355301 Patch 1480434 2 355301 aperez 2018-11-20 02:11:55 -0800 Comment on attachment 355301 Patch Patch LGTM (informally reviewing). 1480483 3 355301 commit-queue 2018-11-20 07:32:41 -0800 Comment on attachment 355301 Patch Clearing flags on attachment: 355301 Committed r238397: <https://trac.webkit.org/changeset/238397> 1480484 4 commit-queue 2018-11-20 07:32:43 -0800 All reviewed patches have been landed. Closing bug. 355301 2018-11-19 17:33:56 -0800 2018-11-20 07:32:41 -0800 Patch bug-191847.diff text/plain 3457 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTU5ZWUwMWZiM2IuLjE0ZGMwMDZkOWIzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDE4LTExLTE5ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+ CisKKyAgICAgICAgW1dQRV0gRml4IHNvbWUgZmVhdHVyZSBndWFyZHMgaW4gV2ViS2l0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE4NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIGZlYXR1cmUg Z3VhcmRzIGFyZSBub3QgcHJlc2VudCBpbiB0aGVzZSBmaWxlcy4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvd3BlL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3dwZS9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy93cGUvV2ViUHJvY2Vz c1Bvb2xXUEUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1J bml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTgtMTEtMTkgIFRvbW9raSBJbWFpICA8VG9tb2tp LkltYWlAc29ueS5jb20+CiAKICAgICAgICAgW2NhaXJvXSBCYWNraW5nU3RvcmU6OmluY29ycG9y YXRlVXBkYXRlIHNob3VsZCB1c2UgQ29tcG9zaXRlQ29weSB0byBzdXBwb3J0IGRyYXdzQmFja2dy b3VuZD1mYWxzZSBpbiBnZW5lcmFsIENhaXJvIHBvcnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1BhZ2VDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS93cGUvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IDY2Y2ZlNzdmZjg3Li5k YTllNmQ3ODc0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9Q YWdlQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9Q YWdlQ2xpZW50SW1wbC5jcHAKQEAgLTE4MSw2ICsxODEsNyBAQCB2b2lkIFBhZ2VDbGllbnRJbXBs Ojpkb25lV2l0aEtleUV2ZW50KGNvbnN0IE5hdGl2ZVdlYktleWJvYXJkRXZlbnQmLCBib29sKQog ewogfQogCisjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKIHZvaWQgUGFnZUNsaWVudEltcGw6OmRv bmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRpdmVXZWJUb3VjaEV2ZW50JiB0b3VjaEV2ZW50LCBi b29sIHdhc0V2ZW50SGFuZGxlZCkKIHsKICAgICBpZiAod2FzRXZlbnRIYW5kbGVkKQpAQCAtMjI3 LDYgKzIyOCw3IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OmRvbmVXaXRoVG91Y2hFdmVudChjb25z dCBOYXRpdmVXZWJUb3VjaEV2ZW50JiB0b3VjaEV2ZW50LCBiCiAKICAgICBwYWdlLmhhbmRsZU1v dXNlRXZlbnQoTmF0aXZlV2ViTW91c2VFdmVudCgmcG9pbnRlckV2ZW50LCBwYWdlLmRldmljZVNj YWxlRmFjdG9yKCkpKTsKIH0KKyNlbmRpZgogCiB2b2lkIFBhZ2VDbGllbnRJbXBsOjp3aGVlbEV2 ZW50V2FzTm90SGFuZGxlZEJ5V2ViQ29yZShjb25zdCBOYXRpdmVXZWJXaGVlbEV2ZW50JikKIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvUGFnZUNsaWVudElt cGwuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvUGFnZUNsaWVudEltcGwuaApp bmRleCBkMDFkZTBiYzFmMi4uZDZkNWE2OTJhOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS93cGUvUGFnZUNsaWVudEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvd3BlL1BhZ2VDbGllbnRJbXBsLmgKQEAgLTg5LDcgKzg5LDkgQEAgcHJpdmF0 ZToKICAgICBXZWJDb3JlOjpJbnRSZWN0IHJvb3RWaWV3VG9TY3JlZW4oY29uc3QgV2ViQ29yZTo6 SW50UmVjdCYpIG92ZXJyaWRlOwogCiAgICAgdm9pZCBkb25lV2l0aEtleUV2ZW50KGNvbnN0IE5h dGl2ZVdlYktleWJvYXJkRXZlbnQmLCBib29sKSBvdmVycmlkZTsKKyNpZiBFTkFCTEUoVE9VQ0hf RVZFTlRTKQogICAgIHZvaWQgZG9uZVdpdGhUb3VjaEV2ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNo RXZlbnQmLCBib29sKSBvdmVycmlkZTsKKyNlbmRpZgogICAgIHZvaWQgd2hlZWxFdmVudFdhc05v dEhhbmRsZWRCeVdlYkNvcmUoY29uc3QgTmF0aXZlV2ViV2hlZWxFdmVudCYpIG92ZXJyaWRlOwog CiAgICAgUmVmUHRyPFdlYlBvcHVwTWVudVByb3h5PiBjcmVhdGVQb3B1cE1lbnVQcm94eShXZWJQ YWdlUHJveHkmKSBvdmVycmlkZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L3dwZS9XZWJQcm9jZXNzUG9vbFdQRS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93cGUv V2ViUHJvY2Vzc1Bvb2xXUEUuY3BwCmluZGV4IGMwM2U0ZTg2NDc3Li44NTkzYzZjNWY3ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mvd3BlL1dlYlByb2Nlc3NQb29sV1BFLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93cGUvV2ViUHJvY2Vzc1Bvb2xXUEUuY3Bw CkBAIC0zNCwxMyArMzQsMTkgQEAKICNpbmNsdWRlICJXZWJDb29raWVNYW5hZ2VyUHJveHkuaCIK ICNpbmNsdWRlICJXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgiCiAjaW5jbHVkZSAiV2Vi UHJvY2Vzc01lc3NhZ2VzLmgiCi0jaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvUmVtb3RlSW5zcGVj dG9yU2VydmVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GaWxlU3lzdGVtLmg+Ci0jaW5jbHVkZSA8 V2ViQ29yZS9HU3RyZWFtZXJDb21tb24uaD4KICNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVu dGVkLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9TY2hlbWVSZWdpc3RyeS5oPgogI2luY2x1ZGUgPGNz dGRsaWI+CisKKyNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKKyNpbmNsdWRlIDxKYXZhU2Ny aXB0Q29yZS9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuaD4KICNpbmNsdWRlIDx3dGYvZ2xpYi9HVW5p cXVlUHRyLmg+CisjZW5kaWYKKworI2lmIFVTRShHU1RSRUFNRVIpCisjaW5jbHVkZSA8V2ViQ29y ZS9HU3RyZWFtZXJDb21tb24uaD4KKyNlbmRpZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAt ODksNyArOTUsNiBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQ cm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmCiAjaWYgVVNFKEdTVFJFQU1FUikK ICAgICBwYXJhbWV0ZXJzLmdzdHJlYW1lck9wdGlvbnMgPSBXZWJDb3JlOjpleHRyYWN0R1N0cmVh bWVyT3B0aW9uc0Zyb21Db21tYW5kTGluZSgpOwogI2VuZGlmCi0KIH0KIAogdm9pZCBXZWJQcm9j ZXNzUG9vbDo6cGxhdGZvcm1JbnZhbGlkYXRlQ29udGV4dCgpCg==