191812 2018-11-17 14:11:58 -0800 Regression(r238330) ProcessSwap.WebInspector API test is a flaky crash in debug 2018-11-18 23:31:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191814 InRadar P2 Normal --- 191740 1 cdumez joepeck bburg commit-queue hi inspector-bugzilla-changes joepeck koivisto rniwa ryanhaddad timothy tsavell webkit-bug-importer oldest_to_newest 1479967 0 cdumez 2018-11-17 14:11:58 -0800 ProcessSwap.WebInspector API test is a flaky crash in debug: TestWebKitAPI.ProcessSwap.WebInspector _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. ASSERTION FAILED: !m_frontendConnection /Volumes/Data/slave/mojave-debug/build/Source/WebKit/WebProcess/WebPage/WebInspector.cpp(80) : void WebKit::WebInspector::setFrontendConnection(IPC::Attachment) 1 0x646e526f9 WTFCrash 2 0x630002a2b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x631030c2a WebKit::WebInspector::setFrontendConnection(IPC::Attachment) 4 0x6310f1d48 void IPC::callMemberFunctionImpl<WebKit::WebInspector, void (WebKit::WebInspector::*)(IPC::Attachment), std::__1::tuple<IPC::Attachment>, 0ul>(WebKit::WebInspector*, void (WebKit::WebInspector::*)(IPC::Attachment), std::__1::tuple<IPC::Attachment>&&, std::__1::integer_sequence<unsigned long, 0ul>) 5 0x6310f1c70 void IPC::callMemberFunction<WebKit::WebInspector, void (WebKit::WebInspector::*)(IPC::Attachment), std::__1::tuple<IPC::Attachment>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<IPC::Attachment>&&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(IPC::Attachment)) 6 0x6310f16a4 void IPC::handleMessage<Messages::WebInspector::SetFrontendConnection, WebKit::WebInspector, void (WebKit::WebInspector::*)(IPC::Attachment)>(IPC::Decoder&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(IPC::Attachment)) 7 0x6310f092c WebKit::WebInspector::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 8 0x63111ad32 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x6300b1e9a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 10 0x630db5b1d WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 11 0x630049f2c IPC::Connection::dispatchMessage(IPC::Decoder&) 12 0x63003c311 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 13 0x63004acf7 IPC::Connection::dispatchOneIncomingMessage() 14 0x63006b828 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 15 0x63006b739 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 16 0x646e79ffd WTF::Function<void ()>::operator()() const 17 0x646ed2e5d WTF::RunLoop::performWork() 18 0x646ed3704 WTF::RunLoop::performWork(void*) 19 0x7fff4189cf09 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 20 0x7fff4189ceaf __CFRunLoopDoSource0 21 0x7fff41880d5c __CFRunLoopDoSources0 22 0x7fff41880303 __CFRunLoopRun 23 0x7fff4187fbe6 CFRunLoopRunSpecific 24 0x7fff43c043ba -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 25 0x7fff43c0428f -[NSRunLoop(NSRunLoop) run] 26 0x7fff6ed31ee6 _xpc_objc_main 27 0x7fff6ed319e5 _xpc_copy_xpcservice_dictionary 28 0x1073c2055 WebKit::XPCServiceMain(int, char const**) 29 0x1073c2342 main 30 0x7fff6eafb08d start _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. Received data during response processing, queuing it. LEAK: 2 WebProcessPool /Volumes/Data/slave/mojave-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2075 Expected: (pid2) != (pid3), actual: 29417 vs 29417 /Volumes/Data/slave/mojave-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2076 Expected equality of these values: numberOfDecidePolicyCalls Which is: 4 3 1479968 1 cdumez 2018-11-17 14:13:14 -0800 https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK1%20%28Tests%29/builds/739/steps/run-api-tests/logs/stdio 1479971 2 cdumez 2018-11-17 14:16:26 -0800 I was unable to reproduce locally. 1480008 3 rniwa 2018-11-17 17:26:49 -0800 I can reproduce it locally on iMac Pro: $ ./Tools/Scripts/run-api-tests --debug ProcessSwap.WebInspector Running tests _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. ASSERTION FAILED: !m_frontendConnection /Volumes/Data/webkit2/Source/WebKit/WebProcess/WebPage/WebInspector.cpp(80) : void WebKit::WebInspector::setFrontendConnection(IPC::Attachment) 1 0x11f66f419 WTFCrash 2 0x10af0d19b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10bf349ea WebKit::WebInspector::setFrontendConnection(IPC::Attachment) 4 0x10bff5d78 void IPC::callMemberFunctionImpl<WebKit::WebInspector, void (WebKit::WebInspector::*)(IPC::Attachment), std::__1::tuple<IPC::Attachment>, 0ul>(WebKit::WebInspector*, void (WebKit::WebInspector::*)(IPC::Attachment), std::__1::tuple<IPC::Attachment>&&, std::__1::integer_sequence<unsigned long, 0ul>) 5 0x10bff5ca0 void IPC::callMemberFunction<WebKit::WebInspector, void (WebKit::WebInspector::*)(IPC::Attachment), std::__1::tuple<IPC::Attachment>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<IPC::Attachment>&&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(IPC::Attachment)) 6 0x10bff56d4 void IPC::handleMessage<Messages::WebInspector::SetFrontendConnection, WebKit::WebInspector, void (WebKit::WebInspector::*)(IPC::Attachment)>(IPC::Decoder&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(IPC::Attachment)) 7 0x10bff495c WebKit::WebInspector::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 8 0x10c01efe2 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x10afbc5da IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 10 0x10bcbc45d WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 11 0x10af5466c IPC::Connection::dispatchMessage(IPC::Decoder&) 12 0x10af46a51 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 13 0x10af55437 IPC::Connection::dispatchOneIncomingMessage() 14 0x10af75f68 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 15 0x10af75e79 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 16 0x11f696c5d WTF::Function<void ()>::operator()() const 17 0x11f6ef90d WTF::RunLoop::performWork() 18 0x11f6f01b4 WTF::RunLoop::performWork(void*) ... Received data during response processing, queuing it. Received data during response processing, queuing it. LEAK: 2 WebProcessPool /Volumes/Data/webkit2/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2076 Expected: (pid2) != (pid3), actual: 36821 vs 36821 /Volumes/Data/webkit2/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2077 Expected equality of these values: numberOfDecidePolicyCalls Which is: 4 3 1480117 4 joepeck 2018-11-18 20:38:30 -0800 (In reply to Ryosuke Niwa from comment #3) > I can reproduce it locally on iMac Pro: > > $ ./Tools/Scripts/run-api-tests --debug ProcessSwap.WebInspector This also reproduces the issue for me. I'm taking a look. 1480118 5 cdumez 2018-11-18 20:43:14 -0800 (In reply to Joseph Pecoraro from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > I can reproduce it locally on iMac Pro: > > > > $ ./Tools/Scripts/run-api-tests --debug ProcessSwap.WebInspector > > This also reproduces the issue for me. I'm taking a look. FYI, https://bugs.webkit.org/show_bug.cgi?id=191814 is probably more urgent. 1480120 6 joepeck 2018-11-18 21:23:43 -0800 My understanding of what is going on so far is: • WebProcess (A) asks UIProcess for inspector • UIProcess launches InspectorProcess • InspectorProcess launches, sends new connection attachment (1) to UIProcess (on way to WebProcess) * UIProcess navigates * Swaps WebProcess (A) swaps to (B) * Asks InspectorProcess for a new connection * InspectorProcess, sends new connection attachment (2) to UIProcess (on way to WebProcess) • UIProcess receives (1) sends to current WebProcess (B) • UIProcess receives (2) sends to current WebProcess (B) So this looks like its just message ordering due to very quickly performing actions in the UIProcess before receiving messages from the InspectorProcess. In this case it would be harmless for WebProcess (B) to use the latest IPC attachment, and in fact we will always want to use the most current IPC::Attachment. I just want to verify a few things, like that we aren't getting messages in suspended processes. Maybe it's possible for the UIProcess avoid sending multiple messages to a WebProcess but just using the latest is the simplest path forward. 1480130 7 355255 joepeck 2018-11-18 22:01:13 -0800 Created attachment 355255 [PATCH] Proposed Fix 1480155 8 355255 commit-queue 2018-11-18 23:29:22 -0800 Comment on attachment 355255 [PATCH] Proposed Fix Clearing flags on attachment: 355255 Committed r238369: <https://trac.webkit.org/changeset/238369> 1480156 9 commit-queue 2018-11-18 23:29:24 -0800 All reviewed patches have been landed. Closing bug. 1480157 10 webkit-bug-importer 2018-11-18 23:31:18 -0800 <rdar://problem/46162470> 355255 2018-11-18 22:01:13 -0800 2018-11-18 23:29:22 -0800 [PATCH] Proposed Fix swap-1.patch text/plain 1936 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMjk1YjM1MTQ1ZjEuLmZkZTYzMzgzOTJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE4LTExLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgUmVncmVzc2lvbihyMjM4MzMwKSBQcm9jZXNzU3dhcC5XZWJJbnNwZWN0b3Ig QVBJIHRlc3QgaXMgYSBmbGFreSBjcmFzaCBpbiBkZWJ1ZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVj dG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yOjpzZXRGcm9udGVuZENvbm5l Y3Rpb24pOgorICAgICAgICBJdCBjYW4gYmUgcG9zc2libGUgdG8gcmVjZWl2ZSBhIGZyb250ZW5k IGNvbm5lY3Rpb24gbXVsdGlwbGUgdGltZXMKKyAgICAgICAgaWYgYW5vdGhlciBXZWJQcm9jZXNz IG9wZW5lZCB0aGUgaW5zcGVjdG9yIGFuZCB0aGlzIFdlYlByb2Nlc3MgZ290CisgICAgICAgIHN3 YXBwZWQgaW4gYmVmb3JlIHRoZSBJbnNwZWN0b3JQcm9jZXNzIG5vdGlmaWVkIHRoZSBXZWJQcm9j ZXNzIG9mCisgICAgICAgIGEgY29ubmVjdGlvbiB0byB1c2UuIEl0IGlzIGFsd2F5cyBiZXN0IHRv IHVzZSB0aGUgbGF0ZXN0IGNvbm5lY3Rpb24KKyAgICAgICAgd2UgaGF2ZSByZWNlaXZlZCwgc2lu Y2UgYW55IG90aGVycyB3b3VsZCBoYXZlIGJlZW4gaW52YWxpZGF0ZWQuCisKIDIwMTgtMTEtMTgg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNz aW9uKHIyMzgzMzApOiBBIGxvdCBvZiBXZWJJbnNwZWN0b3IgdGVzdHMgYXJlIGNyYXNoaW5nIG9u IHRoZSBib3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJJbnNwZWN0b3IuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5z cGVjdG9yLmNwcAppbmRleCA5NTI4OThkMTY5YS4uYTZmMjI0YmE0NTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmNwcApAQCAtNzcsNyAr NzcsMTIgQEAgdm9pZCBXZWJJbnNwZWN0b3I6Om9wZW5Mb2NhbEluc3BlY3RvckZyb250ZW5kKGJv b2wgdW5kZXJUZXN0KQogCiB2b2lkIFdlYkluc3BlY3Rvcjo6c2V0RnJvbnRlbmRDb25uZWN0aW9u KElQQzo6QXR0YWNobWVudCBlbmNvZGVkQ29ubmVjdGlvbklkZW50aWZpZXIpCiB7Ci0gICAgQVNT RVJUKCFtX2Zyb250ZW5kQ29ubmVjdGlvbik7CisgICAgLy8gV2UgbWlnaHQgcmVjZWl2ZSBtdWx0 aXBsZSB1cGRhdGVzIGlmIHRoaXMgd2ViIHByb2Nlc3MgZ290IHN3YXBwZWQgaW50byBhIFdlYlBh Z2VQcm94eQorICAgIC8vIHNob3J0bHkgYWZ0ZXIgYW5vdGhlciBwcm9jZXNzIGVzdGFibGlzaGVk IHRoZSBjb25uZWN0aW9uLgorICAgIGlmIChtX2Zyb250ZW5kQ29ubmVjdGlvbikgeworICAgICAg ICBtX2Zyb250ZW5kQ29ubmVjdGlvbi0+aW52YWxpZGF0ZSgpOworICAgICAgICBtX2Zyb250ZW5k Q29ubmVjdGlvbiA9IG51bGxwdHI7CisgICAgfQogCiAjaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tF VFMpCiAgICAgSVBDOjpDb25uZWN0aW9uOjpJZGVudGlmaWVyIGNvbm5lY3Rpb25JZGVudGlmaWVy KGVuY29kZWRDb25uZWN0aW9uSWRlbnRpZmllci5yZWxlYXNlRmlsZURlc2NyaXB0b3IoKSk7Cg==