191784 2018-11-16 15:25:36 -0800 Provide default implementation of Widget 2018-11-16 18:47:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue don.olmstead mcatanzaro webkit-bug-importer oldest_to_newest 1479680 0 ross.kirsling 2018-11-16 15:25:36 -0800 Provide default implementation of Widget 1479687 1 355142 ross.kirsling 2018-11-16 15:30:52 -0800 Created attachment 355142 Patch 1479795 2 355142 commit-queue 2018-11-16 18:46:59 -0800 Comment on attachment 355142 Patch Clearing flags on attachment: 355142 Committed r238336: <https://trac.webkit.org/changeset/238336> 1479796 3 commit-queue 2018-11-16 18:47:00 -0800 All reviewed patches have been landed. Closing bug. 1479797 4 webkit-bug-importer 2018-11-16 18:47:26 -0800 <rdar://problem/46146112> 355142 2018-11-16 15:30:52 -0800 2018-11-16 18:46:59 -0800 Patch bug-191784-20181116153051.patch text/plain 7562 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQwOWY2ZWNhMWY4ZGZh ZjY0NGU2MDE1MTM5OGFmMzVlNDhhMDY3Zi4uMzBlMTAxYWI3ZDIwNjRlMDczMjZkNzYyZjAyN2U0 MjcyYTliOGExMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE4LTExLTE2ICBSb3Nz IEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KKworICAgICAgICBQcm92aWRlIGRl ZmF1bHQgaW1wbGVtZW50YXRpb24gb2YgV2lkZ2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE3ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZXNXUEUudHh0OgorICAgICAgICAqIHBsYXRm b3JtL1dpZGdldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6OldpZGdldCk6CisgICAg ICAgIChXZWJDb3JlOjpXaWRnZXQ6OmZyYW1lUmVjdCBjb25zdCk6CisgICAgICAgIChXZWJDb3Jl OjpXaWRnZXQ6On5XaWRnZXQpOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpzZXRGcmFtZVJl Y3QpOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpwYWludCk6CisgICAgICAgIChXZWJDb3Jl OjpXaWRnZXQ6OnNldEZvY3VzKToKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6c2V0Q3Vyc29y KToKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6c2hvdyk6CisgICAgICAgIChXZWJDb3JlOjpX aWRnZXQ6OmhpZGUpOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpzZXRJc1NlbGVjdGVkKToK KyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvV2lkZ2V0R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldpZGdldDo6V2lkZ2V0KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6ZnJh bWVSZWN0IGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vV2lkZ2V0V2lu LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6V2lkZ2V0KTogRGVsZXRlZC4KKyAgICAg ICAgKFdlYkNvcmU6OldpZGdldDo6ZnJhbWVSZWN0IGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAg KiBwbGF0Zm9ybS93cGUvV2lkZ2V0V1BFLmNwcDogUmVtb3ZlZC4KKwogMjAxOC0xMS0xNiAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBSZWR1Y2Ug dGhlIHVzZSBvZiBXS1NJIGxpYnJhcnkgY2FsbHM6IENGTmV0d29yawpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvU291cmNlc1dQRS50eHQgYi9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzV1BFLnR4 dAppbmRleCA4N2QyODY5MWQ1YWRlNjBmNWQzMTJjNjliZTk1YjIxZDdjMmIxOGVkLi40N2Q1Mzk0 OWQ2ZDdhODJiZDg5YjFlMTZlNTcwNDk1ODcwMTZhNjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Tb3VyY2VzV1BFLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzV1BFLnR4dApA QCAtODAsNiArODAsNSBAQCBwbGF0Zm9ybS93cGUvUGxhdGZvcm1TY3JlZW5XUEUuY3BwCiBwbGF0 Zm9ybS93cGUvUmVuZGVyVGhlbWVXUEUuY3BwCiBwbGF0Zm9ybS93cGUvU2Nyb2xsYmFyVGhlbWVX UEUuY3BwCiBwbGF0Zm9ybS93cGUvVGhlbWVXUEUuY3BwCi1wbGF0Zm9ybS93cGUvV2lkZ2V0V1BF LmNwcAogCiBwbGF0Zm9ybS94ZGcvTUlNRVR5cGVSZWdpc3RyeVhkZy5jcHAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1dpZGdldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9XaWRnZXQuY3BwCmluZGV4IGYyODNkZDRiZGIyYTAxNjcwYTA3YmQ1NmE0NGQyMDJmZDRm MmIwM2EuLmZjOTQxZjQ3MDQxMmU5YjUzNjNiOWQxZDU3YTYxZmJjNzIwOTE5MmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1dpZGdldC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vV2lkZ2V0LmNwcApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSAiRnJh bWVWaWV3LmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgorI2luY2x1ZGUgIk5vdEltcGxlbWVudGVk LmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpA QCAtMTQ5LDYgKzE1MCwxNyBAQCBJbnRQb2ludCBXaWRnZXQ6OmNvbnZlcnRUb0NvbnRhaW5pbmdX aW5kb3coY29uc3QgSW50UG9pbnQmIGxvY2FsUG9pbnQpIGNvbnN0CiB9CiAKICNpZiAhUExBVEZP Uk0oQ09DT0EpCisKK1dpZGdldDo6V2lkZ2V0KFBsYXRmb3JtV2lkZ2V0IHdpZGdldCkKK3sKKyAg ICBpbml0KHdpZGdldCk7Cit9CisKK0ludFJlY3QgV2lkZ2V0OjpmcmFtZVJlY3QoKSBjb25zdAor eworICAgIHJldHVybiBtX2ZyYW1lOworfQorCiBJbnRSZWN0IFdpZGdldDo6Y29udmVydEZyb21S b290VG9Db250YWluaW5nV2luZG93KGNvbnN0IFdpZGdldCosIGNvbnN0IEludFJlY3QmIHJlY3Qp CiB7CiAgICAgcmV0dXJuIHJlY3Q7CkBAIC0xNjgsNyArMTgwLDggQEAgSW50UG9pbnQgV2lkZ2V0 Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3dUb1Jvb3QoY29uc3QgV2lkZ2V0KiwgY29uc3Qg SW50UG9pbnQKIHsKICAgICByZXR1cm4gcG9pbnQ7CiB9Ci0jZW5kaWYKKworI2VuZGlmIC8vICFQ TEFURk9STShDT0NPQSkKIAogSW50UmVjdCBXaWRnZXQ6OmNvbnZlcnRUb0NvbnRhaW5pbmdWaWV3 KGNvbnN0IEludFJlY3QmIGxvY2FsUmVjdCkgY29uc3QKIHsKQEAgLTIxMiw0ICsyMjUsNTAgQEAg SW50UG9pbnQgV2lkZ2V0Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdWaWV3KGNvbnN0IEludFBvaW50 JiBwYXJlbnRQb2ludCkgY29uc3QKICAgICByZXR1cm4gcGFyZW50UG9pbnQ7CiB9CiAKKyNpZiAh UExBVEZPUk0oQ09DT0EpICYmICFQTEFURk9STShHVEspICYmICFQTEFURk9STShXSU4pCisKK1dp ZGdldDo6fldpZGdldCgpCit7CisgICAgQVNTRVJUKCFwYXJlbnQoKSk7CisgICAgbm90SW1wbGVt ZW50ZWQoKTsKK30KKwordm9pZCBXaWRnZXQ6OnNldEZyYW1lUmVjdChjb25zdCBJbnRSZWN0JiBy ZWN0KQoreworICAgIG1fZnJhbWUgPSByZWN0OworICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisK K3ZvaWQgV2lkZ2V0OjpwYWludChHcmFwaGljc0NvbnRleHQmLCBjb25zdCBJbnRSZWN0JiwgU2Vj dXJpdHlPcmlnaW5QYWludFBvbGljeSkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworfQorCit2 b2lkIFdpZGdldDo6c2V0Rm9jdXMoYm9vbCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworfQor Cit2b2lkIFdpZGdldDo6c2V0Q3Vyc29yKGNvbnN0IEN1cnNvciYpCit7CisgICAgbm90SW1wbGVt ZW50ZWQoKTsKK30KKwordm9pZCBXaWRnZXQ6OnNob3coKQoreworICAgIG5vdEltcGxlbWVudGVk KCk7Cit9CisKK3ZvaWQgV2lkZ2V0OjpoaWRlKCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOwor fQorCit2b2lkIFdpZGdldDo6c2V0SXNTZWxlY3RlZChib29sKQoreworICAgIG5vdEltcGxlbWVu dGVkKCk7Cit9CisKKyNlbmRpZiAvLyAhUExBVEZPUk0oQ09DT0EpICYmICFQTEFURk9STShHVEsp ICYmICFQTEFURk9STShXSU4pCisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaWRnZXRHdGsuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHAKaW5kZXggODc0MTI5MzM5NzkzYWQyZTZiM2Rh ZDlmNzE5ZmEwNjA1YjQ1MjBhZC4uZTQ5ZTNlYTkzODZkZjJkMzQwNmY5ZDJkMWJjNjAyZTg0YTM3 N2ZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHAKQEAgLTQw LDExICs0MCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotV2lkZ2V0OjpXaWRnZXQoUGxh dGZvcm1XaWRnZXQgd2lkZ2V0KQotewotICAgIGluaXQod2lkZ2V0KTsKLX0KLQogV2lkZ2V0Ojp+ V2lkZ2V0KCkKIHsKICAgICBBU1NFUlQoIXBhcmVudCgpKTsKQEAgLTk5LDExICs5NCw2IEBAIHZv aWQgV2lkZ2V0OjpzZXRJc1NlbGVjdGVkKGJvb2wgaXNTZWxlY3RlZCkKICAgICBnX29iamVjdF9z ZXQocGxhdGZvcm1XaWRnZXQoKSwgIndlYmtpdC13aWRnZXQtaXMtc2VsZWN0ZWQiLCBpc1NlbGVj dGVkLCBOVUxMKTsKIH0KIAotSW50UmVjdCBXaWRnZXQ6OmZyYW1lUmVjdCgpIGNvbnN0Ci17Ci0g ICAgcmV0dXJuIG1fZnJhbWU7Ci19Ci0KIHZvaWQgV2lkZ2V0OjpzZXRGcmFtZVJlY3QoY29uc3Qg SW50UmVjdCYgcmVjdCkKIHsKICAgICBtX2ZyYW1lID0gcmVjdDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9XaWRnZXRXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL1dpZGdldFdpbi5jcHAKaW5kZXggOGJkYzAyM2E0Mzc2NmQ0NWYzYzFhOWZjYThj ZTA5M2VmOTM1ZDdiOS4uZmZkODZhMDQ0MDM2ZWY4Y2VhMTQ0ZDA2MzFlM2YxMjVlODQwMWVjZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1dpZGdldFdpbi5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1dpZGdldFdpbi5jcHAKQEAgLTQwLDExICs0 MCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotV2lkZ2V0OjpXaWRnZXQoUGxhdGZvcm1X aWRnZXQgd2lkZ2V0KQotewotICAgIGluaXQod2lkZ2V0KTsKLX0KLQogV2lkZ2V0Ojp+V2lkZ2V0 KCkgCiB7CiAgICAgQVNTRVJUKCFwYXJlbnQoKSk7CkBAIC04NywxMSArODIsNiBAQCB2b2lkIFdp ZGdldDo6c2V0SXNTZWxlY3RlZChib29sKQogewogfQogCi1JbnRSZWN0IFdpZGdldDo6ZnJhbWVS ZWN0KCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9mcmFtZTsKLX0KLQogdm9pZCBXaWRnZXQ6OnNl dEZyYW1lUmVjdChjb25zdCBJbnRSZWN0JiByZWN0KQogewogICAgIG1fZnJhbWUgPSByZWN0Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1dpZGdldFdQRS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvV2lkZ2V0V1BFLmNwcApkZWxldGVkIGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggNWY2NjMzMGM1MjM5ODdhNjcwODUwMDA0YjM5ODljY2FjNjQwZmI1ZC4u MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS93cGUvV2lkZ2V0V1BFLmNwcAorKysgL2Rldi9udWxsCkBAIC0xLDg1ICsw LDAgQEAKLS8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTQgSWdhbGlhIFMuTC4KLSAqCi0gKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAqIDEuIFJlZGlzdHJpYnV0aW9ucyBv ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu Ci0gKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQotICogICAgZG9jdW1lbnRhdGlvbiBh bmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KLSAq Ci0gKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05U UklCVVRPUlMgYGBBUyBJUycnCi0gKiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5U SUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKLSAqIFRIRSBJTVBMSUVEIFdBUlJB TlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKLSAq IFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1Ig SVRTIENPTlRSSUJVVE9SUwotICogQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwg SU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUgotICogQ09OU0VRVUVOVElBTCBEQU1B R0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YKLSAqIFNV QlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRT OyBPUiBCVVNJTkVTUwotICogSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5Z IFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4KLSAqIENPTlRSQUNULCBTVFJJQ1QgTElB QklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpCi0gKiBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ RiBBRFZJU0VEIE9GCi0gKiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCi0gKi8KLQot I2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIldpZGdldC5oIgotCi0jaW5jbHVkZSAiTm90 SW1wbGVtZW50ZWQuaCIKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi1XaWRnZXQ6OldpZGdldChQ bGF0Zm9ybVdpZGdldCB3aWRnZXQpCi17Ci0gICAgaW5pdCh3aWRnZXQpOwotfQotCi1XaWRnZXQ6 On5XaWRnZXQoKQotewotICAgIEFTU0VSVCghcGFyZW50KCkpOwotICAgIG5vdEltcGxlbWVudGVk KCk7Ci19Ci0KLXZvaWQgV2lkZ2V0OjpzZXRGcmFtZVJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkK LXsKLSAgICBtX2ZyYW1lID0gcmVjdDsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCi1JbnRS ZWN0IFdpZGdldDo6ZnJhbWVSZWN0KCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9mcmFtZTsKLX0K LQotdm9pZCBXaWRnZXQ6OnBhaW50KEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IEludFJlY3QmLCBT ZWN1cml0eU9yaWdpblBhaW50UG9saWN5KQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0K LXZvaWQgV2lkZ2V0OjpzZXRGb2N1cyhib29sKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci19 Ci0KLXZvaWQgV2lkZ2V0OjpzZXRDdXJzb3IoY29uc3QgQ3Vyc29yJikKLXsKLSAgICBub3RJbXBs ZW1lbnRlZCgpOwotfQotCi12b2lkIFdpZGdldDo6c2hvdygpCi17Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLX0KLQotdm9pZCBXaWRnZXQ6OmhpZGUoKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7 Ci19Ci0KLXZvaWQgV2lkZ2V0OjpzZXRJc1NlbGVjdGVkKGJvb2wpCi17Ci0gICAgbm90SW1wbGVt ZW50ZWQoKTsKLX0KLQotfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=