191783 2018-11-16 15:25:20 -0800 REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS 2018-11-16 20:24:24 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189148 InRadar P2 Normal --- 1 ryanhaddad rniwa cdumez rniwa tsavell webkit-bug-importer oldest_to_newest 1479679 0 ryanhaddad 2018-11-16 15:25:20 -0800 The following API test is failing on iOS after https://trac.webkit.org/changeset/238294: TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:269 Expected equality of these values: WKErrorWebContentProcessTerminated Which is: 2 error.code Which is: 3 /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:262 Expected equality of these values: WKErrorWebContentProcessTerminated Which is: 2 error.code Which is: 3 /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:255 Expected equality of these values: WKErrorWebContentProcessTerminated Which is: 2 error.code Which is: 3 https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1015/steps/run-api-tests/logs/stdio 1479773 1 rniwa 2018-11-16 17:26:38 -0800 Looking into this now. 1479806 2 rniwa 2018-11-16 19:07:50 -0800 Hm... I can't reproduce this failure locally. 1479807 3 cdumez 2018-11-16 19:08:40 -0800 (In reply to Ryosuke Niwa from comment #2) > Hm... I can't reproduce this failure locally. Probably flaky? 1479810 4 rniwa 2018-11-16 19:28:39 -0800 (In reply to Chris Dumez from comment #3) > (In reply to Ryosuke Niwa from comment #2) > > Hm... I can't reproduce this failure locally. > > Probably flaky? Possibly. I've ran it like 5 times and couldn't repro. I am using debug instead of release builds so I'm gonna try release now. Sigh... another 40min wait... 1479814 5 cdumez 2018-11-16 19:40:22 -0800 (In reply to Ryosuke Niwa from comment #4) > (In reply to Chris Dumez from comment #3) > > (In reply to Ryosuke Niwa from comment #2) > > > Hm... I can't reproduce this failure locally. > > > > Probably flaky? > > Possibly. I've ran it like 5 times and couldn't repro. I am using debug > instead of release builds so I'm gonna try release now. Sigh... another > 40min wait... Honestly, the test is calling [view _close] so getting a WKErrorWebViewInvalidated error instead of WKErrorWebContentProcessTerminated is not technically wrong. I think we should allow both. It is not the first time this test has started failing with WKErrorWebViewInvalidated errors, see Bug 189148. 1479815 6 cdumez 2018-11-16 19:41:01 -0800 (In reply to Chris Dumez from comment #5) > (In reply to Ryosuke Niwa from comment #4) > > (In reply to Chris Dumez from comment #3) > > > (In reply to Ryosuke Niwa from comment #2) > > > > Hm... I can't reproduce this failure locally. > > > > > > Probably flaky? > > > > Possibly. I've ran it like 5 times and couldn't repro. I am using debug > > instead of release builds so I'm gonna try release now. Sigh... another > > 40min wait... > > Honestly, the test is calling [view _close] so getting a > WKErrorWebViewInvalidated error instead of > WKErrorWebContentProcessTerminated is not technically wrong. > > I think we should allow both. It is not the first time this test has started > failing with WKErrorWebViewInvalidated errors, see Bug 189148. I wrote the test and what it was really testing was not the error code but the fact that all callbacks get invalidated. 1479816 7 cdumez 2018-11-16 19:41:30 -0800 (In reply to Chris Dumez from comment #6) > (In reply to Chris Dumez from comment #5) > > (In reply to Ryosuke Niwa from comment #4) > > > (In reply to Chris Dumez from comment #3) > > > > (In reply to Ryosuke Niwa from comment #2) > > > > > Hm... I can't reproduce this failure locally. > > > > > > > > Probably flaky? > > > > > > Possibly. I've ran it like 5 times and couldn't repro. I am using debug > > > instead of release builds so I'm gonna try release now. Sigh... another > > > 40min wait... > > > > Honestly, the test is calling [view _close] so getting a > > WKErrorWebViewInvalidated error instead of > > WKErrorWebContentProcessTerminated is not technically wrong. > > > > I think we should allow both. It is not the first time this test has started > > failing with WKErrorWebViewInvalidated errors, see Bug 189148. > > I wrote the test and what it was really testing was not the error code but > the fact that all callbacks get invalidated. Whether we get WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated error seems to be a matter of timing. 1479827 8 355176 rniwa 2018-11-16 20:21:02 -0800 Created attachment 355176 Allow both errors 1479828 9 355176 cdumez 2018-11-16 20:21:44 -0800 Comment on attachment 355176 Allow both errors r=me 1479829 10 355176 rniwa 2018-11-16 20:23:33 -0800 Comment on attachment 355176 Allow both errors Clearing flags on attachment: 355176 Committed r238340: <https://trac.webkit.org/changeset/238340> 1479830 11 rniwa 2018-11-16 20:23:36 -0800 All reviewed patches have been landed. Closing bug. 1479833 12 webkit-bug-importer 2018-11-16 20:24:24 -0800 <rdar://problem/46146920> 355176 2018-11-16 20:21:02 -0800 2018-11-16 20:23:33 -0800 Allow both errors bug-191783-20181116202101.patch text/plain 4017 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWRmMTA1MDcwYjRmODJhZjY4MGM1MzQ5ZTQ4ODdmMGQw NmYyZmNlZi4uYTM4MDhlMzM3YzQwNTllZjkzMDliZThjMTJjNjNjN2ViYzg0NGU0MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTExLTE2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIyMzgyOTQpOiBUZXN0V2ViS2l0QVBJLldLTmF2aWdhdGlvbi5Qcm9j ZXNzQ3Jhc2hEdXJpbmdDYWxsYmFjayBmYWlsaW5nIG9uIGlPUworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzgzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgZWl0aGVyIFdLRXJyb3JXZWJDb250 ZW50UHJvY2Vzc1Rlcm1pbmF0ZWQgb3IgV0tFcnJvcldlYlZpZXdJbnZhbGlkYXRlZCBzaW5jZSB0 aGUgdGVzdAorICAgICAgICBpcyBjbG9zaW5nIFdlYlZpZXcsIHRoZXJlYnkgaW52YWxpZGF0aW5n IHRoZSB2aWV3LCB3aGljaCBpcyByYWNpbmcgd2l0aCB0aGUgcHJvY2VzcyB0ZXJtaW5hdGlvbi4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2ViQ29udGVudFBy b2Nlc3NEaWRUZXJtaW5hdGUubW06CisgICAgICAgIChURVNUKToKKwogMjAxOC0xMS0xNiAgUnlh biBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgYnVpbGRi b3QgZGFzaGJvYXJkIGFmdGVyIFdpbmRvd3MgNy8xMCB1cGRhdGVzCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dlYkNvbnRlbnRQcm9jZXNzRGlkVGVy bWluYXRlLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJDb250 ZW50UHJvY2Vzc0RpZFRlcm1pbmF0ZS5tbQppbmRleCBjZDhiYWI4YmIzOGE1YWE3ZWU1NDQ3M2Ux NGE5MmExMWNjMDVjYTU4Li5lNDViNjQ5MTNjYmEyYjg3ZmNlOGMxYmQ0MGVhZDc0ZDZlZjNjODE3 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dlYkNv bnRlbnRQcm9jZXNzRGlkVGVybWluYXRlLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Q29jb2EvV2ViQ29udGVudFByb2Nlc3NEaWRUZXJtaW5hdGUubW0KQEAgLTIzMCwy MSArMjMwLDIxIEBAIFRFU1QoV0tOYXZpZ2F0aW9uLCBQcm9jZXNzQ3Jhc2hEdXJpbmdDYWxsYmFj aykKICAgICBfX2Jsb2NrIFdLV2ViVmlldyAqdmlldyA9IHdlYlZpZXcuZ2V0KCk7CiAgICAgW3dl YlZpZXcgX2dldENvbnRlbnRzQXNTdHJpbmdXaXRoQ29tcGxldGlvbkhhbmRsZXI6XihOU1N0cmlu ZyAqY29udGVudHMsIE5TRXJyb3IgKmVycm9yKSB7CiAgICAgICAgIGlmICghIWVycm9yKQotICAg ICAgICAgICAgRVhQRUNUX0VRKFdLRXJyb3JXZWJDb250ZW50UHJvY2Vzc1Rlcm1pbmF0ZWQsIGVy cm9yLmNvZGUpOworICAgICAgICAgICAgRVhQRUNUX1RSVUUoZXJyb3IuY29kZSA9PSBXS0Vycm9y V2ViQ29udGVudFByb2Nlc3NUZXJtaW5hdGVkIHx8IGVycm9yLmNvZGUgPT0gV0tFcnJvcldlYlZp ZXdJbnZhbGlkYXRlZCk7CiAgICAgICAgICsrY2FsbGJhY2tDb3VudDsKICAgICAgICAgaWYgKGNh bGxiYWNrQ291bnQgPT0gNikKICAgICAgICAgICAgIGNhbGxlZEFsbENhbGxiYWNrcyA9IHRydWU7 CiAgICAgfV07CiAgICAgW3dlYlZpZXcgX2dldENvbnRlbnRzQXNTdHJpbmdXaXRoQ29tcGxldGlv bkhhbmRsZXI6XihOU1N0cmluZyAqY29udGVudHMsIE5TRXJyb3IgKmVycm9yKSB7CiAgICAgICAg IGlmICghIWVycm9yKQotICAgICAgICAgICAgRVhQRUNUX0VRKFdLRXJyb3JXZWJDb250ZW50UHJv Y2Vzc1Rlcm1pbmF0ZWQsIGVycm9yLmNvZGUpOworICAgICAgICAgICAgRVhQRUNUX1RSVUUoZXJy b3IuY29kZSA9PSBXS0Vycm9yV2ViQ29udGVudFByb2Nlc3NUZXJtaW5hdGVkIHx8IGVycm9yLmNv ZGUgPT0gV0tFcnJvcldlYlZpZXdJbnZhbGlkYXRlZCk7CiAgICAgICAgICsrY2FsbGJhY2tDb3Vu dDsKICAgICAgICAgaWYgKGNhbGxiYWNrQ291bnQgPT0gNikKICAgICAgICAgICAgIGNhbGxlZEFs bENhbGxiYWNrcyA9IHRydWU7CiAgICAgfV07CiAgICAgW3dlYlZpZXcgX2dldENvbnRlbnRzQXNT dHJpbmdXaXRoQ29tcGxldGlvbkhhbmRsZXI6XihOU1N0cmluZyAqY29udGVudHMsIE5TRXJyb3Ig KmVycm9yKSB7CiAgICAgICAgIGlmICghIWVycm9yKQotICAgICAgICAgICAgRVhQRUNUX0VRKFdL RXJyb3JXZWJDb250ZW50UHJvY2Vzc1Rlcm1pbmF0ZWQsIGVycm9yLmNvZGUpOworICAgICAgICAg ICAgRVhQRUNUX1RSVUUoZXJyb3IuY29kZSA9PSBXS0Vycm9yV2ViQ29udGVudFByb2Nlc3NUZXJt aW5hdGVkIHx8IGVycm9yLmNvZGUgPT0gV0tFcnJvcldlYlZpZXdJbnZhbGlkYXRlZCk7CiAgICAg ICAgIFt2aWV3IF9jbG9zZV07IC8vIENhbGxpbmcgX2Nsb3NlIHdpbGwgYWxzbyBpbnZhbGlkYXRl IGFsbCBjYWxsYmFja3MuCiAgICAgICAgICsrY2FsbGJhY2tDb3VudDsKICAgICAgICAgaWYgKGNh bGxiYWNrQ291bnQgPT0gNikKQEAgLTI1MiwyMSArMjUyLDIxIEBAIFRFU1QoV0tOYXZpZ2F0aW9u LCBQcm9jZXNzQ3Jhc2hEdXJpbmdDYWxsYmFjaykKICAgICB9XTsKICAgICBbd2ViVmlldyBfZ2V0 Q29udGVudHNBc1N0cmluZ1dpdGhDb21wbGV0aW9uSGFuZGxlcjpeKE5TU3RyaW5nICpjb250ZW50 cywgTlNFcnJvciAqZXJyb3IpIHsKICAgICAgICAgaWYgKCEhZXJyb3IpCi0gICAgICAgICAgICBF WFBFQ1RfRVEoV0tFcnJvcldlYkNvbnRlbnRQcm9jZXNzVGVybWluYXRlZCwgZXJyb3IuY29kZSk7 CisgICAgICAgICAgICBFWFBFQ1RfVFJVRShlcnJvci5jb2RlID09IFdLRXJyb3JXZWJDb250ZW50 UHJvY2Vzc1Rlcm1pbmF0ZWQgfHwgZXJyb3IuY29kZSA9PSBXS0Vycm9yV2ViVmlld0ludmFsaWRh dGVkKTsKICAgICAgICAgKytjYWxsYmFja0NvdW50OwogICAgICAgICBpZiAoY2FsbGJhY2tDb3Vu dCA9PSA2KQogICAgICAgICAgICAgY2FsbGVkQWxsQ2FsbGJhY2tzID0gdHJ1ZTsKICAgICB9XTsK ICAgICBbd2ViVmlldyBfZ2V0Q29udGVudHNBc1N0cmluZ1dpdGhDb21wbGV0aW9uSGFuZGxlcjpe KE5TU3RyaW5nICpjb250ZW50cywgTlNFcnJvciAqZXJyb3IpIHsKICAgICAgICAgaWYgKCEhZXJy b3IpCi0gICAgICAgICAgICBFWFBFQ1RfRVEoV0tFcnJvcldlYkNvbnRlbnRQcm9jZXNzVGVybWlu YXRlZCwgZXJyb3IuY29kZSk7CisgICAgICAgICAgICBFWFBFQ1RfVFJVRShlcnJvci5jb2RlID09 IFdLRXJyb3JXZWJDb250ZW50UHJvY2Vzc1Rlcm1pbmF0ZWQgfHwgZXJyb3IuY29kZSA9PSBXS0Vy cm9yV2ViVmlld0ludmFsaWRhdGVkKTsKICAgICAgICAgKytjYWxsYmFja0NvdW50OwogICAgICAg ICBpZiAoY2FsbGJhY2tDb3VudCA9PSA2KQogICAgICAgICAgICAgY2FsbGVkQWxsQ2FsbGJhY2tz ID0gdHJ1ZTsKICAgICB9XTsKICAgICBbd2ViVmlldyBfZ2V0Q29udGVudHNBc1N0cmluZ1dpdGhD b21wbGV0aW9uSGFuZGxlcjpeKE5TU3RyaW5nICpjb250ZW50cywgTlNFcnJvciAqZXJyb3IpIHsK ICAgICAgICAgaWYgKCEhZXJyb3IpCi0gICAgICAgICAgICBFWFBFQ1RfRVEoV0tFcnJvcldlYkNv bnRlbnRQcm9jZXNzVGVybWluYXRlZCwgZXJyb3IuY29kZSk7CisgICAgICAgICAgICBFWFBFQ1Rf VFJVRShlcnJvci5jb2RlID09IFdLRXJyb3JXZWJDb250ZW50UHJvY2Vzc1Rlcm1pbmF0ZWQgfHwg ZXJyb3IuY29kZSA9PSBXS0Vycm9yV2ViVmlld0ludmFsaWRhdGVkKTsKICAgICAgICAgKytjYWxs YmFja0NvdW50OwogICAgICAgICBpZiAoY2FsbGJhY2tDb3VudCA9PSA2KQogICAgICAgICAgICAg Y2FsbGVkQWxsQ2FsbGJhY2tzID0gdHJ1ZTsK