191778 2018-11-16 14:52:48 -0800 Optimize composited iframe layer hookup 2018-11-17 12:51:07 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191673 InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1479652 0 simon.fraser 2018-11-16 14:52:48 -0800 Optimize composited iframe layer hookup 1479656 1 355132 simon.fraser 2018-11-16 14:54:15 -0800 Created attachment 355132 Patch 1479659 2 simon.fraser 2018-11-16 14:55:02 -0800 Also made the paint layer dumping show some renderer info, making them easier to identify. 1479802 3 355132 commit-queue 2018-11-16 19:06:30 -0800 Comment on attachment 355132 Patch Clearing flags on attachment: 355132 Committed r238337: <https://trac.webkit.org/changeset/238337> 1479803 4 commit-queue 2018-11-16 19:06:31 -0800 All reviewed patches have been landed. Closing bug. 1479805 5 webkit-bug-importer 2018-11-16 19:07:25 -0800 <rdar://problem/46146331> 1479838 6 cdumez 2018-11-16 20:37:14 -0800 Can this have caused these failures? https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r238338%20(1072)/results.html 1479949 7 simon.fraser 2018-11-17 12:51:07 -0800 (In reply to Chris Dumez from comment #6) > Can this have caused these failures? > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > r238338%20(1072)/results.html No, I think those are all the Mojave WindowServer bug that causes WK1 snapshots to be blank or cyan sometimes. 355132 2018-11-16 14:54:15 -0800 2018-11-16 19:06:30 -0800 Patch bug-191778-20181116145414.patch text/plain 2798 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4Mjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzZiYzM2NjE3OTlmYjBl MDQ5NTM0NzljMWE5NzkyZDgzNDU5NGQ0ZC4uODRmMmQxYTcyNjYyOTllMGI1MzQwZDlhYjdkNTAx MzQxYmY5MDNjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTExLTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE9wdGltaXplIGNv bXBvc2l0ZWQgaWZyYW1lIGxheWVyIGhvb2t1cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5nZSBtYWRlIGluIHIyMzgyMjkgY2FuIGJlIG1v cmUgdGFyZ2V0ZWQ7IHdlIG9ubHkgbmVlZCB0byBob29rIHVwIGlmcmFtZSBjb250ZW50CisgICAg ICAgIGxheWVycyB3aGVuIHRoZSBsYXllciBpcyBhbHJlYWR5IGNvbXBvc2l0ZWQgKG90aGVyd2lz ZSB0aGUgdXBkYXRlQmFja2luZygpIGFib3ZlIHdvdWxkIGhhdmUgdHJpZ2dlcmVkCisgICAgICAg IHRoZSB3b3JrKSwgYW5kIHdoZW4gaXQncyBhIFJlbmRlcldpZGdldCBsYXllci4KKyAgICAgICAg CisgICAgICAgIFRlc3RlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpvdXRwdXRQYWludE9yZGVyVHJl ZVJlY3Vyc2l2ZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmxheWVyU3R5bGVD aGFuZ2VkKToKKwogMjAxOC0xMS0xNiAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4K IAogICAgICAgICBTdG9yaW5nIGJsb2JzIGluIElEQiBvbiBpT1M6ICJFcnJvciBwcmVwYXJpbmcg YmxvYi9maWxlIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXgg NzU1MTExYWQ0NTYxM2ZhY2RhMTVhNjFmNWQ0YjYwZTMzODk4OTNkZC4uY2JjMmEyMmU2ZWQ0ODBm YWY0ZmYxMzcwMDgxNWE5NTFkMDE1MjQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwCkBAIC02NzAxLDcgKzY3MDEsNyBAQCBzdGF0aWMgdm9pZCBvdXRwdXRQYWlu dE9yZGVyVHJlZVJlY3Vyc2l2ZShUZXh0U3RyZWFtJiBzdHJlYW0sIGNvbnN0IFdlYkNvcmU6OlJl bgogCiAgICAgYXV0byBsYXllclJlY3QgPSBsYXllci5yZWN0KCk7CiAKLSAgICBzdHJlYW0gPDwg JmxheWVyIDw8ICIgIiA8PCBsYXllclJlY3Q7CisgICAgc3RyZWFtIDw8ICZsYXllciA8PCAiICIg PDwgbGF5ZXJSZWN0IDw8ICIgIiA8PCBsYXllci5uYW1lKCk7CiAgICAgc3RyZWFtLm5leHRMaW5l KCk7CiAKICAgICBjb25zdF9jYXN0PFdlYkNvcmU6OlJlbmRlckxheWVyJj4obGF5ZXIpLnVwZGF0 ZUxheWVyTGlzdHNJZk5lZWRlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCBjNTI0NzljMmY2MjBiNTg1Mjg5MjZlM2Vj OGU5NGY3NzhkMzZlNjAyLi4xYmQ1MGE2NzE5MDlhN2I5MWNkZmQ5NjVhMjA3ZjIzNTAxMjFmNTJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcApAQCAtMTM4Nyw5ICsxMzg3LDggQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6 OmxheWVyU3R5bGVDaGFuZ2VkKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBSZW5kZXJMYXllciYKICAg ICAgICAgfQogICAgIH0KIAotICAgIC8vIEZJWE1FOiB0aGlzIGlzIG5lY2Vzc2FyeSB0byBnZXQg aWZyYW1lIGxheWVycyBob29rZWQgdXAgaW4gcmVzcG9uc2UgdG8gc2NoZWR1bGVJbnZhbGlkYXRl U3R5bGVBbmRMYXllckNvbXBvc2l0aW9uKCksCi0gICAgLy8gYnV0IHdlIHNob3VsZCBhdm9pZCB0 cmlnZ2VyaW5nIGNvbmZpZyB1cGRhdGVzIG9uIGV2ZXJ5IHJlY29tcG9zaXRlTGF5ZXIuCi0gICAg aWYgKGRpZmYgPT0gU3R5bGVEaWZmZXJlbmNlOjpSZWNvbXBvc2l0ZUxheWVyKQorICAgIC8vIFRo aXMgaXMgbmVjZXNzYXJ5IHRvIGdldCBpZnJhbWUgbGF5ZXJzIGhvb2tlZCB1cCBpbiByZXNwb25z ZSB0byBzY2hlZHVsZUludmFsaWRhdGVTdHlsZUFuZExheWVyQ29tcG9zaXRpb24oKS4KKyAgICBp ZiAoZGlmZiA9PSBTdHlsZURpZmZlcmVuY2U6OlJlY29tcG9zaXRlTGF5ZXIgJiYgbGF5ZXIuaXND b21wb3NpdGVkKCkgJiYgaXM8UmVuZGVyV2lkZ2V0PihsYXllci5yZW5kZXJlcigpKSkKICAgICAg ICAgbGF5ZXIuc2V0TmVlZHNDb21wb3NpdGluZ0NvbmZpZ3VyYXRpb25VcGRhdGUoKTsKIAogICAg IGlmIChkaWZmID49IFN0eWxlRGlmZmVyZW5jZTo6UmVjb21wb3NpdGVMYXllciAmJiBvbGRTdHls ZSkgewo=