191769 2018-11-16 13:56:19 -0800 webkitpy: Retry app installation on watchOS simulators 2018-11-26 12:55:51 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler oldest_to_newest 1479600 0 jbedard 2018-11-16 13:56:19 -0800 It takes a few seconds for apps to be installable on freshly booted watchOS simulators. 1479605 1 355115 jbedard 2018-11-16 14:00:01 -0800 Created attachment 355115 Patch 1479608 2 355115 aakash_jain 2018-11-16 14:04:20 -0800 Comment on attachment 355115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355115&action=review r=me after the changes. > Tools/Scripts/webkitpy/xcode/simulated_device.py:548 > + for i in xrange(3): Please move 3 to a variable. e.g.: NUM_RETRIES_FOR_WATCH_INSTALL > Tools/Scripts/webkitpy/xcode/simulated_device.py:552 > + if exit_code != 204: what does 204 indicate? maybe worth adding a comment. > Tools/Scripts/webkitpy/xcode/simulated_device.py:553 > + break why break instead of return? 1479615 3 355120 jbedard 2018-11-16 14:18:52 -0800 Created attachment 355120 Patch 1479623 4 webkit-bug-importer 2018-11-16 14:28:53 -0800 <rdar://problem/46139850> 1479626 5 355120 aakash_jain 2018-11-16 14:32:25 -0800 Comment on attachment 355120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355120&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:553 > + # Return code indicates that the devices is booting and a retry may be successful. This is confusing. Which return code indicates device is booting? If 204 indicates booting, then it might be simpler/more-readable to check for 204. something like: elif exit_code == 204: # Return code 204 indicates that the devices is booting. Retry after 5s. time.sleep(5) else: return False return False 1479641 6 355128 jbedard 2018-11-16 14:41:44 -0800 Created attachment 355128 Patch 1479676 7 355139 jbedard 2018-11-16 15:22:34 -0800 Created attachment 355139 Patch 1479705 8 355139 commit-queue 2018-11-16 16:02:23 -0800 Comment on attachment 355139 Patch Clearing flags on attachment: 355139 Committed r238319: <https://trac.webkit.org/changeset/238319> 1479706 9 commit-queue 2018-11-16 16:02:24 -0800 All reviewed patches have been landed. Closing bug. 1481596 10 jbedard 2018-11-26 11:09:38 -0800 Reopening to attach new patch. 1481597 11 355658 jbedard 2018-11-26 11:09:38 -0800 Created attachment 355658 Patch 1481644 12 355658 commit-queue 2018-11-26 12:55:49 -0800 Comment on attachment 355658 Patch Clearing flags on attachment: 355658 Committed r238514: <https://trac.webkit.org/changeset/238514> 1481645 13 commit-queue 2018-11-26 12:55:51 -0800 All reviewed patches have been landed. Closing bug. 355115 2018-11-16 14:00:01 -0800 2018-11-16 14:18:51 -0800 Patch bug-191769-20181116140002.patch text/plain 1774 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODI5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTExLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbiBvbiB3YXRjaE9T IHNpbXVsYXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MTc2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAg ICAoU2ltdWxhdGVkRGV2aWNlLmluc3RhbGxfYXBwKTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbnMu CisKIDIwMTgtMTEtMTYgIFRha2FzaGkgS29tb3JpICA8VGFrYXNoaS5Lb21vcmlAc29ueS5jb20+ CiAKICAgICAgICAgW1dpbkNhaXJvXVtXZWJLaXRUZXN0UnVubmVyXSBUZXN0IGNvbnRlbnRzIHdp bmRvdyBpcyBkaXNwbGF5ZWQgd2hpbGUgdGVzdGluZy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDIzODI5NykK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29y a2luZyBjb3B5KQpAQCAtNTQ0LDcgKzU0NCwxNSBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2Uob2Jq ZWN0KToKICAgICAgICAgICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVE X0RFVklDRVMucmVtb3ZlKGRldmljZSkKIAogICAgIGRlZiBpbnN0YWxsX2FwcChzZWxmLCBhcHBf cGF0aCwgZW52PU5vbmUpOgotICAgICAgICByZXR1cm4gbm90IHNlbGYuZXhlY3V0aXZlLnJ1bl9j b21tYW5kKFsneGNydW4nLCAnc2ltY3RsJywgJ2luc3RhbGwnLCBzZWxmLnVkaWQsIGFwcF9wYXRo XSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQorICAgICAgICAjIEV2ZW4gYWZ0ZXIgY2Fyb3VzZWwg aXMgcnVubmluZywgaXQgdGFrZXMgYSBmZXcgc2Vjb25kcyBmb3Igd2F0Y2hPUyB0byBhbGxvdyBp bnN0YWxscy4KKyAgICAgICAgZm9yIGkgaW4geHJhbmdlKDMpOgorICAgICAgICAgICAgZXhpdF9j b2RlID0gc2VsZi5leGVjdXRpdmUucnVuX2NvbW1hbmQoWyd4Y3J1bicsICdzaW1jdGwnLCAnaW5z dGFsbCcsIHNlbGYudWRpZCwgYXBwX3BhdGhdLCByZXR1cm5fZXhpdF9jb2RlPVRydWUpCisgICAg ICAgICAgICBpZiBleGl0X2NvZGUgPT0gMDoKKyAgICAgICAgICAgICAgICByZXR1cm4gVHJ1ZQor ICAgICAgICAgICAgaWYgZXhpdF9jb2RlICE9IDIwNDoKKyAgICAgICAgICAgICAgICBicmVhawor ICAgICAgICAgICAgdGltZS5zbGVlcCg1KQorICAgICAgICByZXR1cm4gRmFsc2UKIAogICAgICMg RklYTUU6IEluY3JlYXNlIHRpbWVvdXQgZm9yIDxyZGFyOi8vcHJvYmxlbS8zMTMzMTU3Nj4KICAg ICBkZWYgbGF1bmNoX2FwcChzZWxmLCBidW5kbGVfaWQsIGFyZ3MsIGVudj1Ob25lLCB0aW1lb3V0 PTMwMCk6Cg== 355120 2018-11-16 14:18:52 -0800 2018-11-16 14:41:43 -0800 Patch bug-191769-20181116141853.patch text/plain 2092 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODI5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTExLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbiBvbiB3YXRjaE9T IHNpbXVsYXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MTc2OQorCisgICAgICAgIFJldmlld2VkIGJ5IEFha2FzaCBKYWluLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAo U2ltdWxhdGVkRGV2aWNlLmluc3RhbGxfYXBwKTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbnMuCisK IDIwMTgtMTEtMTYgIFRha2FzaGkgS29tb3JpICA8VGFrYXNoaS5Lb21vcmlAc29ueS5jb20+CiAK ICAgICAgICAgW1dpbkNhaXJvXVtXZWJLaXRUZXN0UnVubmVyXSBUZXN0IGNvbnRlbnRzIHdpbmRv dyBpcyBkaXNwbGF5ZWQgd2hpbGUgdGVzdGluZy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDIzODI5NykKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29ya2lu ZyBjb3B5KQpAQCAtNDU0LDYgKzQ1NCw3IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmplY3Qp OgogICAgICAgICBCT09URUQgPSAzCiAgICAgICAgIFNIVVRUSU5HX0RPV04gPSA0CiAKKyAgICBO VU1fSU5TVEFMTF9SRVRSSUVTID0gMwogICAgIE5BTUVfRk9SX1NUQVRFID0gWwogICAgICAgICAn Q1JFQVRJTkcnLAogICAgICAgICAnU0hVVERPV04nLApAQCAtNTQ0LDcgKzU0NSwxNiBAQCBjbGFz cyBTaW11bGF0ZWREZXZpY2Uob2JqZWN0KToKICAgICAgICAgICAgICAgICBTaW11bGF0ZWREZXZp Y2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVMucmVtb3ZlKGRldmljZSkKIAogICAgIGRlZiBp bnN0YWxsX2FwcChzZWxmLCBhcHBfcGF0aCwgZW52PU5vbmUpOgotICAgICAgICByZXR1cm4gbm90 IHNlbGYuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsneGNydW4nLCAnc2ltY3RsJywgJ2luc3RhbGwn LCBzZWxmLnVkaWQsIGFwcF9wYXRoXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQorICAgICAgICAj IEV2ZW4gYWZ0ZXIgY2Fyb3VzZWwgaXMgcnVubmluZywgaXQgdGFrZXMgYSBmZXcgc2Vjb25kcyBm b3Igd2F0Y2hPUyB0byBhbGxvdyBpbnN0YWxscy4KKyAgICAgICAgZm9yIGkgaW4geHJhbmdlKHNl bGYuTlVNX0lOU1RBTExfUkVUUklFUyk6CisgICAgICAgICAgICBleGl0X2NvZGUgPSBzZWxmLmV4 ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJ3NpbWN0bCcsICdpbnN0YWxsJywgc2VsZi51 ZGlkLCBhcHBfcGF0aF0sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSkKKyAgICAgICAgICAgIGlmIGV4 aXRfY29kZSA9PSAwOgorICAgICAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAgICAgICAj IFJldHVybiBjb2RlIGluZGljYXRlcyB0aGF0IHRoZSBkZXZpY2VzIGlzIGJvb3RpbmcgYW5kIGEg cmV0cnkgbWF5IGJlIHN1Y2Nlc3NmdWwuCisgICAgICAgICAgICBpZiBleGl0X2NvZGUgIT0gMjA0 OgorICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQorICAgICAgICAgICAgdGltZS5zbGVlcCg1 KQorICAgICAgICByZXR1cm4gRmFsc2UKIAogICAgICMgRklYTUU6IEluY3JlYXNlIHRpbWVvdXQg Zm9yIDxyZGFyOi8vcHJvYmxlbS8zMTMzMTU3Nj4KICAgICBkZWYgbGF1bmNoX2FwcChzZWxmLCBi dW5kbGVfaWQsIGFyZ3MsIGVudj1Ob25lLCB0aW1lb3V0PTMwMCk6Cg== 355128 2018-11-16 14:41:44 -0800 2018-11-16 15:22:33 -0800 Patch bug-191769-20181116144145.patch text/plain 2159 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODMwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTExLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbiBvbiB3YXRjaE9T IHNpbXVsYXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MTc2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYxMzk4NTA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hj b2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2UuaW5zdGFs bF9hcHApOiBSZXRyeSBhcHAgaW5zdGFsbGF0aW9ucy4KKwogMjAxOC0xMS0xNiAgVGFrYXNoaSBL b21vcmkgIDxUYWthc2hpLktvbW9yaUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dW1dl YktpdFRlc3RSdW5uZXJdIFRlc3QgY29udGVudHMgd2luZG93IGlzIGRpc3BsYXllZCB3aGlsZSB0 ZXN0aW5nLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2 aWNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxh dGVkX2RldmljZS5weQkocmV2aXNpb24gMjM4MzA0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NTQsNiArNDU0 LDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlKG9iamVjdCk6CiAgICAgICAgIEJPT1RFRCA9IDMK ICAgICAgICAgU0hVVFRJTkdfRE9XTiA9IDQKIAorICAgIE5VTV9JTlNUQUxMX1JFVFJJRVMgPSAz CiAgICAgTkFNRV9GT1JfU1RBVEUgPSBbCiAgICAgICAgICdDUkVBVElORycsCiAgICAgICAgICdT SFVURE9XTicsCkBAIC01NDQsNyArNTQ1LDE4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmpl Y3QpOgogICAgICAgICAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURf REVWSUNFUy5yZW1vdmUoZGV2aWNlKQogCiAgICAgZGVmIGluc3RhbGxfYXBwKHNlbGYsIGFwcF9w YXRoLCBlbnY9Tm9uZSk6Ci0gICAgICAgIHJldHVybiBub3Qgc2VsZi5leGVjdXRpdmUucnVuX2Nv bW1hbmQoWyd4Y3J1bicsICdzaW1jdGwnLCAnaW5zdGFsbCcsIHNlbGYudWRpZCwgYXBwX3BhdGhd LCByZXR1cm5fZXhpdF9jb2RlPVRydWUpCisgICAgICAgICMgRXZlbiBhZnRlciBjYXJvdXNlbCBp cyBydW5uaW5nLCBpdCB0YWtlcyBhIGZldyBzZWNvbmRzIGZvciB3YXRjaE9TIHRvIGFsbG93IGlu c3RhbGxzLgorICAgICAgICBmb3IgaSBpbiB4cmFuZ2Uoc2VsZi5OVU1fSU5TVEFMTF9SRVRSSUVT KToKKyAgICAgICAgICAgIGV4aXRfY29kZSA9IHNlbGYuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsn eGNydW4nLCAnc2ltY3RsJywgJ2luc3RhbGwnLCBzZWxmLnVkaWQsIGFwcF9wYXRoXSwgcmV0dXJu X2V4aXRfY29kZT1UcnVlKQorICAgICAgICAgICAgaWYgZXhpdF9jb2RlID09IDA6CisgICAgICAg ICAgICAgICAgcmV0dXJuIFRydWUKKworICAgICAgICAgICAgIyBSZXR1cm4gY29kZSAyMDQgaW5k aWNhdGVzIHRoYXQgdGhlIGRldmljZXMgaXMgYm9vdGluZyBhbmQgYSByZXRyeSBtYXkgYmUgc3Vj Y2Vzc2Z1bC4KKyAgICAgICAgICAgIGlmIGV4aXRfY29kZSA9PSAyMDQ6CisgICAgICAgICAgICAg ICAgdGltZS5zbGVlcCg1KQorICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICBy ZXR1cm4gRmFsc2UKKyAgICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICAjIEZJWE1FOiBJbmNyZWFz ZSB0aW1lb3V0IGZvciA8cmRhcjovL3Byb2JsZW0vMzEzMzE1NzY+CiAgICAgZGVmIGxhdW5jaF9h cHAoc2VsZiwgYnVuZGxlX2lkLCBhcmdzLCBlbnY9Tm9uZSwgdGltZW91dD0zMDApOgo= 355139 2018-11-16 15:22:34 -0800 2018-11-26 11:09:36 -0800 Patch bug-191769-20181116152235.patch text/plain 2155 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODMwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTExLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbiBvbiB3YXRjaE9T IHNpbXVsYXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MTc2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYxMzk4NTA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hj b2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2UuaW5zdGFs bF9hcHApOiBSZXRyeSBhcHAgaW5zdGFsbGF0aW9ucy4KKwogMjAxOC0xMS0xNiAgVGFrYXNoaSBL b21vcmkgIDxUYWthc2hpLktvbW9yaUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dW1dl YktpdFRlc3RSdW5uZXJdIFRlc3QgY29udGVudHMgd2luZG93IGlzIGRpc3BsYXllZCB3aGlsZSB0 ZXN0aW5nLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2 aWNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxh dGVkX2RldmljZS5weQkocmV2aXNpb24gMjM4MzA0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NTQsNiArNDU0 LDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlKG9iamVjdCk6CiAgICAgICAgIEJPT1RFRCA9IDMK ICAgICAgICAgU0hVVFRJTkdfRE9XTiA9IDQKIAorICAgIE5VTV9JTlNUQUxMX1JFVFJJRVMgPSAz CiAgICAgTkFNRV9GT1JfU1RBVEUgPSBbCiAgICAgICAgICdDUkVBVElORycsCiAgICAgICAgICdT SFVURE9XTicsCkBAIC01NDQsNyArNTQ1LDE4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmpl Y3QpOgogICAgICAgICAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTElaRURf REVWSUNFUy5yZW1vdmUoZGV2aWNlKQogCiAgICAgZGVmIGluc3RhbGxfYXBwKHNlbGYsIGFwcF9w YXRoLCBlbnY9Tm9uZSk6Ci0gICAgICAgIHJldHVybiBub3Qgc2VsZi5leGVjdXRpdmUucnVuX2Nv bW1hbmQoWyd4Y3J1bicsICdzaW1jdGwnLCAnaW5zdGFsbCcsIHNlbGYudWRpZCwgYXBwX3BhdGhd LCByZXR1cm5fZXhpdF9jb2RlPVRydWUpCisgICAgICAgICMgRXZlbiBhZnRlciBjYXJvdXNlbCBp cyBydW5uaW5nLCBpdCB0YWtlcyBhIGZldyBzZWNvbmRzIGZvciB3YXRjaE9TIHRvIGFsbG93IGlu c3RhbGxzLgorICAgICAgICBmb3IgaSBpbiB4cmFuZ2Uoc2VsZi5OVU1fSU5TVEFMTF9SRVRSSUVT KToKKyAgICAgICAgICAgIGV4aXRfY29kZSA9IHNlbGYuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsn eGNydW4nLCAnc2ltY3RsJywgJ2luc3RhbGwnLCBzZWxmLnVkaWQsIGFwcF9wYXRoXSwgcmV0dXJu X2V4aXRfY29kZT1UcnVlKQorICAgICAgICAgICAgaWYgZXhpdF9jb2RlID09IDA6CisgICAgICAg ICAgICAgICAgcmV0dXJuIFRydWUKKworICAgICAgICAgICAgIyBSZXR1cm4gY29kZSAyMDQgaW5k aWNhdGVzIHRoYXQgdGhlIGRldmljZSBpcyBib290aW5nLCBhIHJldHJ5IG1heSBiZSBzdWNjZXNz ZnVsLgorICAgICAgICAgICAgaWYgZXhpdF9jb2RlID09IDIwNDoKKyAgICAgICAgICAgICAgICB0 aW1lLnNsZWVwKDUpCisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgICAgIHJldHVy biBGYWxzZQorICAgICAgICByZXR1cm4gRmFsc2UKIAogICAgICMgRklYTUU6IEluY3JlYXNlIHRp bWVvdXQgZm9yIDxyZGFyOi8vcHJvYmxlbS8zMTMzMTU3Nj4KICAgICBkZWYgbGF1bmNoX2FwcChz ZWxmLCBidW5kbGVfaWQsIGFyZ3MsIGVudj1Ob25lLCB0aW1lb3V0PTMwMCk6Cg== 355658 2018-11-26 11:09:38 -0800 2018-11-26 12:55:49 -0800 Patch bug-191769-20181126110938.patch text/plain 1163 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODUwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTExLTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmV0cnkgYXBwIGluc3RhbGxhdGlvbiBvbiB3YXRjaE9T IHNpbXVsYXRvcnMgKEZvbGxvdy11cCBmaXgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTE3NjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2MTM5 ODUwPgorCisgICAgICAgIFVucmV2aWV3ZWQgaW5mcmFzdHJ1Y3R1cmUgZml4LgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAo U2ltdWxhdGVkRGV2aWNlKTogSW5jcmVhc2UgcmV0cnkgYXR0ZW1wdHMuCisKIDIwMTgtMTEtMjYg IEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gUmVk dWNlIHRoZSB1c2Ugb2YgV0tTSSBsaWJyYXJ5IGNhbGxzOiBDb3JlQW5pbWF0aW9uCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CShy ZXZpc2lvbiAyMzg1MDIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRl ZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ1NCw3ICs0NTQsNyBAQCBjbGFzcyBTaW11 bGF0ZWREZXZpY2Uob2JqZWN0KToKICAgICAgICAgQk9PVEVEID0gMwogICAgICAgICBTSFVUVElO R19ET1dOID0gNAogCi0gICAgTlVNX0lOU1RBTExfUkVUUklFUyA9IDMKKyAgICBOVU1fSU5TVEFM TF9SRVRSSUVTID0gNQogICAgIE5BTUVfRk9SX1NUQVRFID0gWwogICAgICAgICAnQ1JFQVRJTkcn LAogICAgICAgICAnU0hVVERPV04nLAo=