<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>191768</bug_id>
          
          <creation_ts>2018-11-16 13:36:26 -0800</creation_ts>
          <short_desc>[iOS] Cannot prevent default key command in onkeydown handler</short_desc>
          <delta_ts>2019-01-16 19:02:02 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>UI Events</component>
          <version>WebKit Local Build</version>
          <rep_platform>iPhone / iPad</rep_platform>
          <op_sys>iOS 12</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>192897</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>190571</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1479590</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-11-16 13:36:26 -0800</bug_when>
    <thetext>A web page may implement their own key command handling and want to prevent the default browser behavior by calling Event.preventDefault() in their onkeydown handler. For example, a page may implement their own Find-in-page feature that is toggled by listening for Command + F, the same key command to trigger the default browser Find-in-page feature. Calling Event.preventDefault() in their onkeydown handler when they receive Command + F should prevent Safari from showing the Find-in-page UI. But it does not on iOS. It does on Mac.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1495369</commentid>
    <comment_count>1</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-01-16 19:01:40 -0800</bug_when>
    <thetext>(In reply to Daniel Bates from comment #0)
&gt; A web page may implement their own key command handling and want to prevent
&gt; the default browser behavior by calling Event.preventDefault() in their
&gt; onkeydown handler. For example, a page may implement their own Find-in-page
&gt; feature that is toggled by listening for Command + F, the same key command
&gt; to trigger the default browser Find-in-page feature. Calling
&gt; Event.preventDefault() in their onkeydown handler when they receive Command
&gt; + F should prevent Safari from showing the Find-in-page UI. But it does not
&gt; on iOS. It does on Mac.

App key commands, like Command + F, should only be prevented from a key press handler to match Mac and the UIEvents spec.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1495370</commentid>
    <comment_count>2</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-01-16 19:01:47 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 192897 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1495372</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-01-16 19:02:01 -0800</bug_when>
    <thetext>&lt;rdar://problem/47338324&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1495373</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-01-16 19:02:02 -0800</bug_when>
    <thetext>&lt;rdar://problem/47338325&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>