191730 2018-11-15 17:58:03 -0800 RegExpObject's collectMatches should not be using JSArray::push to fill in its match results. 2018-11-15 21:33:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ddkilzer ews-watchlist guijemont guijemont+jsc-armv7-ews keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1479208 0 mark.lam 2018-11-15 17:58:03 -0800 According to the spec https://www.ecma-international.org/ecma-262/9.0/index.html#sec-regexp.prototype-@@match, the RegExp match results are filling in using the spec's CreateDataProperty() which does not consult the prototype for setters. JSArray:push() consults the prototype for setters. We should be using putDirectIndex() instead. <rdar://problem/46048517> 1479210 1 355006 mark.lam 2018-11-15 18:08:54 -0800 Created attachment 355006 proposed patch. 1479224 2 355006 ddkilzer 2018-11-15 18:49:20 -0800 Comment on attachment 355006 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=355006&action=review > JSTests/ChangeLog:10 > 2018-11-13 Saam Barati <sbarati@apple.com> Nit: Blank line before the new entry 1479235 3 355006 ews-watchlist 2018-11-15 19:41:27 -0800 Comment on attachment 355006 proposed patch. Attachment 355006 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/10011421 New failing tests: stress/regress-187006.js.ftl-eager-no-cjit-b3o1 stress/regress-187006.js.ftl-no-cjit-small-pool stress/regress-187006.js.ftl-no-cjit-validate-sampling-profiler stress/regress-187006.js.default stress/regress-187006.js.dfg-eager-no-cjit-validate stress/regress-187006.js.ftl-eager stress/regress-187006.js.dfg-eager stress/regress-187006.js.dfg-maximal-flush-validate-no-cjit stress/regress-187006.js.ftl-no-cjit-no-put-stack-validate stress/regress-187006.js.no-ftl stress/regress-187006.js.ftl-no-cjit-b3o1 stress/regress-187006.js.no-llint stress/regress-187006.js.ftl-eager-no-cjit stress/regress-187006.js.ftl-no-cjit-no-inline-validate stress/regress-187006.js.no-cjit-validate-phases stress/regress-187006.js.no-cjit-collect-continuously apiTests 1479240 4 355006 saam 2018-11-15 20:03:29 -0800 Comment on attachment 355006 proposed patch. r=me 1479243 5 mark.lam 2018-11-15 20:22:57 -0800 (In reply to Build Bot from comment #3) > New failing tests: > stress/regress-187006.js.ftl-eager-no-cjit-b3o1 ... > apiTests Turns out, the regress-187006.js test is invalid. It expects a setter in Array.prototype to be called when RegExp.match creates its match array, which violates the spec. 1479245 6 355017 mark.lam 2018-11-15 20:27:11 -0800 Created attachment 355017 patch for landing. 1479258 7 mark.lam 2018-11-15 21:33:56 -0800 Thanks for the review. Landed in r238270: <http://trac.webkit.org/r238270>. 355006 2018-11-15 18:08:54 -0800 2018-11-15 20:27:11 -0800 proposed patch. bug-191730.patch text/plain 3444 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzgyNjQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE4LTExLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSZWdFeHBPYmplY3QncyBjb2xsZWN0TWF0Y2hlcyBzaG91bGQgbm90IGJl IHVzaW5nIEpTQXJyYXk6OnB1c2ggdG8gZmlsbCBpbiBpdHMgbWF0Y2ggcmVzdWx0cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTczMAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNDYwNDg1MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcmVncmVzcy0xOTE3MzAuanM6IEFkZGVkLgog MjAxOC0xMS0xMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBU eXBlUHJvZmlsZUxvZzo6cHJvY2Vzc0xvZ0VudHJpZXMgc2hvdWxkIHN0YXNoIGF3YXkgYW55IHBl bmRpbmcgZXhjZXB0aW9ucyBhbmQgcmUtYXBwbHkgdGhlbSB0byB0aGUgVk0KSW5kZXg6IEpTVGVz dHMvc3RyZXNzL3JlZ3Jlc3MtMTkxNzMwLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNz L3JlZ3Jlc3MtMTkxNzMwLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jl c3MtMTkxNzMwLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjUgQEAKK2Z1bmN0aW9uIGFz c2VydEVxKGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBpZiAoYWN0dWFsICE9IGV4cGVjdGVkKQor ICAgICAgICB0aHJvdyAoIkV4cGVjdGVkOiAiICsgZXhwZWN0ZWQgKyAiLCBhY3R1YWw6ICIgKyBh Y3R1YWwpOworfQorCit2YXIgb3RoZXJHbG9iYWwgPSAkdm0uY3JlYXRlR2xvYmFsT2JqZWN0KCk7 CisKK0FycmF5LnByb3RvdHlwZS5fX2RlZmluZVNldHRlcl9fKDcsICgpID0+IHsKKyAgICBhcnJb MF0gPSB7IH07Cit9KTsKKworbGV0IGFyciA9IG5ldyBvdGhlckdsb2JhbC5BcnJheSgxLjEsIDIu MiwgMy4zKTsKKworZnVuY3Rpb24gZm9vKGFyciwgcmVnZXhwLCBzdHIpeworICAgIHZhciByZXN1 bHQgPSByZWdleHBbU3ltYm9sLm1hdGNoXShzdHIpOworICAgIGFyclsxXSA9IDMuNTQ0ODQ4MDU4 ODk2MjZlLTMxMDsKKyAgICByZXR1cm4gYXJyWzBdOworfQorCitsZXQgcmVnZXhwID0gL2EvZzsK K2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7IGkrKykKKyAgICBmb28oYXJyLCByZWdleHAsICJh YWFhIik7CisKK2xldCByID0gZm9vKGFyciwgcmVnZXhwLCAiYWFhYWFhYWEiKTsKK2Fzc2VydEVx KGFyclsxXSwgIjMuNTQ0ODQ4MDU4ODk2MjZlLTMxMCIpOwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzgxOTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTEtMTUgIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJlZ0V4cE9iamVjdCdzIGNvbGxlY3RN YXRjaGVzIHNob3VsZCBub3QgYmUgdXNpbmcgSlNBcnJheTo6cHVzaCB0byBmaWxsIGluIGl0cyBt YXRjaCByZXN1bHRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkxNzMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjA0ODUxNz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvUmVnRXhw T2JqZWN0SW5saW5lcy5oOgorICAgICAgICAoSlNDOjpjb2xsZWN0TWF0Y2hlcyk6CisKIDIwMTgt MTEtMTQgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIGluIENvZGVDYWNoZSBpbiByMjM3MjU0CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3RJbmxpbmVzLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0SW5saW5l cy5oCShyZXZpc2lvbiAyMzgxOTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9S ZWdFeHBPYmplY3RJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNiArMSw2IEBACiAvKgog ICogIENvcHlyaWdodCAoQykgMTk5OS0yMDAwIEhhcnJpIFBvcnRlbiAocG9ydGVuQGtkZS5vcmcp Ci0gKiAgQ29weXJpZ2h0IChDKSAyMDAzLCAyMDA3LCAyMDA4LCAyMDEyLCAyMDE2IEFwcGxlIElu Yy4gQWxsIFJpZ2h0cyBSZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDMtMjAxOCBBcHBs ZSBJbmMuIEFsbCBSaWdodHMgUmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBmcmVl IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkgaXQg dW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCkBAIC0xNjAs MTAgKzE2MCwxMSBAQCBKU1ZhbHVlIGNvbGxlY3RNYXRjaGVzKFZNJiB2bSwgRXhlY1N0YXRlCiAg ICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgeyB9KTsKIAogICAgIGJvb2wgaGFzRXhjZXB0 aW9uID0gZmFsc2U7CisgICAgdW5zaWduZWQgYXJyYXlJbmRleCA9IDA7CiAgICAgYXV0byBpdGVy YXRlID0gWyZdICgpIHsKICAgICAgICAgc2l6ZV90IGVuZCA9IHJlc3VsdC5lbmQ7CiAgICAgICAg IHNpemVfdCBsZW5ndGggPSBlbmQgLSByZXN1bHQuc3RhcnQ7Ci0gICAgICAgIGFycmF5LT5wdXNo KGV4ZWMsIEpTUm9wZVN0cmluZzo6Y3JlYXRlU3Vic3RyaW5nT2ZSZXNvbHZlZCh2bSwgc3RyaW5n LCByZXN1bHQuc3RhcnQsIGxlbmd0aCkpOworICAgICAgICBhcnJheS0+cHV0RGlyZWN0SW5kZXgo ZXhlYywgYXJyYXlJbmRleCsrLCBKU1JvcGVTdHJpbmc6OmNyZWF0ZVN1YnN0cmluZ09mUmVzb2x2 ZWQodm0sIHN0cmluZywgcmVzdWx0LnN0YXJ0LCBsZW5ndGgpKTsKICAgICAgICAgaWYgKFVOTElL RUxZKHNjb3BlLmV4Y2VwdGlvbigpKSkgewogICAgICAgICAgICAgaGFzRXhjZXB0aW9uID0gdHJ1 ZTsKICAgICAgICAgICAgIHJldHVybjsK 355017 2018-11-15 20:27:11 -0800 2018-11-15 20:27:11 -0800 patch for landing. bug-191730b.patch text/plain 4589 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzgyNjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE4LTExLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSZWdFeHBPYmplY3QncyBjb2xsZWN0TWF0Y2hlcyBzaG91bGQgbm90IGJl IHVzaW5nIEpTQXJyYXk6OnB1c2ggdG8gZmlsbCBpbiBpdHMgbWF0Y2ggcmVzdWx0cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTczMAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNDYwNDg1MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FhbSBC YXJhdGkuCisKKyAgICAgICAgKiBzdHJlc3MvcmVncmVzcy0xODcwMDYuanM6IFJlbW92ZWQuCisg ICAgICAgICAgLSB0aGlzIHRlc3QgaXMgaW52YWxpZCBiZWNhdXNlIGl0cyBzb2xlIHB1cnBvc2Ug aXMgdG8gdGVzdCBmb3IgdGhlIG5vbi1zcGVjCisgICAgICAgICAgICBjb21wbGlhbnQgYmVoYXZp b3IgdGhhdCB3ZSBqdXN0IGZpeGVkLgorCisgICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTkxNzMw LmpzOiBBZGRlZC4KKwogMjAxOC0xMS0xMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNv bT4KIAogICAgICAgICBUeXBlUHJvZmlsZUxvZzo6cHJvY2Vzc0xvZ0VudHJpZXMgc2hvdWxkIHN0 YXNoIGF3YXkgYW55IHBlbmRpbmcgZXhjZXB0aW9ucyBhbmQgcmUtYXBwbHkgdGhlbSB0byB0aGUg Vk0KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg3MDA2LmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg3MDA2LmpzCShyZXZpc2lvbiAyMzgxOTEpCisrKyBK U1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4NzAwNi5qcwkobm9uZXhpc3RlbnQpCkBAIC0xLDE2ICsw LDAgQEAKLU9iamVjdC5kZWZpbmVQcm9wZXJ0eShBcnJheS5wcm90b3R5cGUsICcwJywgewotICAg IGdldCgpIHsgfSwKLSAgICBzZXQoKSB7IHRocm93IG5ldyBFcnJvcigpOyB9Ci19KTsKLQotdmFy IF9fdl83NzcyID0gIkdHQ0NHR0dUQUFBR1RHR0NUQ0FDR0NDVEdUQUFUQ0NDQUdDQUNUVFRBQ0ND Q0NDR0FHR0NHR0dDR0dBIjsKLXZhciBleGNlcHRpb247Ci0KLXRyeSB7Ci0gICAgX192Xzc3NzIu bWF0Y2goL1tjZ3RdZ2dndGFhYXx0dHRhY2NjW2FjZ10vaWcpOwotfSBjYXRjaCAoZSkgewotICAg IGV4Y2VwdGlvbiA9IGU7Ci19Ci0KLWlmIChleGNlcHRpb24gIT0gIkVycm9yIikKLSAgICB0aHJv dyAiRkFJTEVEIjsKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTkxNzMwLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTkxNzMwLmpzCShub25leGlzdGVudCkK KysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTkxNzMwLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMjUgQEAKK2Z1bmN0aW9uIGFzc2VydEVxKGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBp ZiAoYWN0dWFsICE9IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyAoIkV4cGVjdGVkOiAiICsgZXhw ZWN0ZWQgKyAiLCBhY3R1YWw6ICIgKyBhY3R1YWwpOworfQorCit2YXIgb3RoZXJHbG9iYWwgPSAk dm0uY3JlYXRlR2xvYmFsT2JqZWN0KCk7CisKK0FycmF5LnByb3RvdHlwZS5fX2RlZmluZVNldHRl cl9fKDcsICgpID0+IHsKKyAgICBhcnJbMF0gPSB7IH07Cit9KTsKKworbGV0IGFyciA9IG5ldyBv dGhlckdsb2JhbC5BcnJheSgxLjEsIDIuMiwgMy4zKTsKKworZnVuY3Rpb24gZm9vKGFyciwgcmVn ZXhwLCBzdHIpeworICAgIHZhciByZXN1bHQgPSByZWdleHBbU3ltYm9sLm1hdGNoXShzdHIpOwor ICAgIGFyclsxXSA9IDMuNTQ0ODQ4MDU4ODk2MjZlLTMxMDsKKyAgICByZXR1cm4gYXJyWzBdOwor fQorCitsZXQgcmVnZXhwID0gL2EvZzsKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7IGkrKykK KyAgICBmb28oYXJyLCByZWdleHAsICJhYWFhIik7CisKK2xldCByID0gZm9vKGFyciwgcmVnZXhw LCAiYWFhYWFhYWEiKTsKK2Fzc2VydEVxKGFyclsxXSwgIjMuNTQ0ODQ4MDU4ODk2MjZlLTMxMCIp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzgxOTEpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTgtMTEtMTUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAg IFJlZ0V4cE9iamVjdCdzIGNvbGxlY3RNYXRjaGVzIHNob3VsZCBub3QgYmUgdXNpbmcgSlNBcnJh eTo6cHVzaCB0byBmaWxsIGluIGl0cyBtYXRjaCByZXN1bHRzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxNzMwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NjA0ODUxNz4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAg ICAgICBBY2NvcmRpbmcgdG8gdGhlIHNwZWMgaHR0cHM6Ly93d3cuZWNtYS1pbnRlcm5hdGlvbmFs Lm9yZy9lY21hLTI2Mi85LjAvaW5kZXguaHRtbCNzZWMtcmVnZXhwLnByb3RvdHlwZS1AQG1hdGNo LAorICAgICAgICB0aGUgUmVnRXhwIG1hdGNoIHJlc3VsdHMgYXJlIGZpbGxlZCBpbiB1c2luZyB0 aGUgc3BlYydzIENyZWF0ZURhdGFQcm9wZXJ0eSgpCisgICAgICAgIGZ1bmN0aW9uIHdoaWNoIGRv ZXMgbm90IGNvbnN1bHQgdGhlIHByb3RvdHlwZSBmb3Igc2V0dGVycy4gIEpTQXJyYXk6cHVzaCgp CisgICAgICAgIGNvbnN1bHRzIHRoZSBwcm90b3R5cGUgZm9yIHNldHRlcnMuICBXZSBzaG91bGQg YmUgdXNpbmcgcHV0RGlyZWN0SW5kZXgoKSBpbnN0ZWFkLgorCisgICAgICAgICogcnVudGltZS9S ZWdFeHBPYmplY3RJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OmNvbGxlY3RNYXRjaGVzKToKKwog MjAxOC0xMS0xNCAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93c3RhcnQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgaW4gQ29kZUNhY2hlIGluIHIyMzcyNTQKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE9iamVjdElubGluZXMuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3RJ bmxpbmVzLmgJKHJldmlzaW9uIDIzODE5MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1JlZ0V4cE9iamVjdElubGluZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDYgQEAK IC8qCiAgKiAgQ29weXJpZ2h0IChDKSAxOTk5LTIwMDAgSGFycmkgUG9ydGVuIChwb3J0ZW5Aa2Rl Lm9yZykKLSAqICBDb3B5cmlnaHQgKEMpIDIwMDMsIDIwMDcsIDIwMDgsIDIwMTIsIDIwMTYgQXBw bGUgSW5jLiBBbGwgUmlnaHRzIFJlc2VydmVkLgorICogIENvcHlyaWdodCAoQykgMjAwMy0yMDE4 IEFwcGxlIEluYy4gQWxsIFJpZ2h0cyBSZXNlcnZlZC4KICAqCiAgKiAgVGhpcyBsaWJyYXJ5IGlz IGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogIG1vZGlm eSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKQEAg LTE2MCwxMCArMTYwLDExIEBAIEpTVmFsdWUgY29sbGVjdE1hdGNoZXMoVk0mIHZtLCBFeGVjU3Rh dGUKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB7IH0pOwogCiAgICAgYm9vbCBoYXNF eGNlcHRpb24gPSBmYWxzZTsKKyAgICB1bnNpZ25lZCBhcnJheUluZGV4ID0gMDsKICAgICBhdXRv IGl0ZXJhdGUgPSBbJl0gKCkgewogICAgICAgICBzaXplX3QgZW5kID0gcmVzdWx0LmVuZDsKICAg ICAgICAgc2l6ZV90IGxlbmd0aCA9IGVuZCAtIHJlc3VsdC5zdGFydDsKLSAgICAgICAgYXJyYXkt PnB1c2goZXhlYywgSlNSb3BlU3RyaW5nOjpjcmVhdGVTdWJzdHJpbmdPZlJlc29sdmVkKHZtLCBz dHJpbmcsIHJlc3VsdC5zdGFydCwgbGVuZ3RoKSk7CisgICAgICAgIGFycmF5LT5wdXREaXJlY3RJ bmRleChleGVjLCBhcnJheUluZGV4KyssIEpTUm9wZVN0cmluZzo6Y3JlYXRlU3Vic3RyaW5nT2ZS ZXNvbHZlZCh2bSwgc3RyaW5nLCByZXN1bHQuc3RhcnQsIGxlbmd0aCkpOwogICAgICAgICBpZiAo VU5MSUtFTFkoc2NvcGUuZXhjZXB0aW9uKCkpKSB7CiAgICAgICAgICAgICBoYXNFeGNlcHRpb24g PSB0cnVlOwogICAgICAgICAgICAgcmV0dXJuOwo=