191729 2018-11-15 17:53:18 -0800 KnownCellUse should also have SpecCellCheck as its type filter 2018-11-16 12:43:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1479202 0 saam 2018-11-15 17:53:18 -0800 We write transformations in the compiler like this where we emit edges with KnownCellUse if we know we're inserting code at a point where we're dominated by a Cell check: a: SomeValue b: Something(Cell:@a) c: SomethingElse(@b) d: CheckNotEmpty(@a) => a: SomeValue b: Something(Cell:@a) e: RandomOtherThing(KnownCellUse:@a) c: SomethingElse(@b) d: CheckNotEmpty(@a) However, doing this may lead to subtly incorrect programs since KnownCellUse doesn't allow the empty value to flow through it. We end up deleting @d in the above program, which is wrong. We need to have KnownCellUse allow the empty value to flow through. 1479203 1 saam 2018-11-15 17:53:53 -0800 <rdar://problem/45872852> 1479209 2 355005 saam 2018-11-15 17:59:35 -0800 Created attachment 355005 patch 1479569 3 355005 commit-queue 2018-11-16 12:43:01 -0800 Comment on attachment 355005 patch Clearing flags on attachment: 355005 Committed r238297: <https://trac.webkit.org/changeset/238297> 1479570 4 commit-queue 2018-11-16 12:43:03 -0800 All reviewed patches have been landed. Closing bug. 355005 2018-11-15 17:59:35 -0800 2018-11-16 12:43:01 -0800 patch c-backup.diff text/plain 3653 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzgyNjQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTExLTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEtub3duQ2VsbFVzZSBzaG91bGQgYWxzbyBoYXZlIFNwZWNDZWxsQ2hl Y2sgYXMgaXRzIHR5cGUgZmlsdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTE3MjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1ODcyODUyPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNz L2tub3duLWNlbGwtdHlwZS1jaGVjay1zaG91bGQtYWxsb3ctZW1wdHktdmFsdWUtdG8tZmxvdy10 aHJvdWdoLmpzOiBBZGRlZC4KKyAgICAgICAgKEMpOgorCiAyMDE4LTExLTEzICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFR5cGVQcm9maWxlTG9nOjpwcm9jZXNz TG9nRW50cmllcyBzaG91bGQgc3Rhc2ggYXdheSBhbnkgcGVuZGluZyBleGNlcHRpb25zIGFuZCBy ZS1hcHBseSB0aGVtIHRvIHRoZSBWTQpJbmRleDogSlNUZXN0cy9zdHJlc3Mva25vd24tY2VsbC10 eXBlLWNoZWNrLXNob3VsZC1hbGxvdy1lbXB0eS12YWx1ZS10by1mbG93LXRocm91Z2guanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mva25vd24tY2VsbC10eXBlLWNoZWNrLXNob3VsZC1h bGxvdy1lbXB0eS12YWx1ZS10by1mbG93LXRocm91Z2guanMJKG5vbmV4aXN0ZW50KQorKysgSlNU ZXN0cy9zdHJlc3Mva25vd24tY2VsbC10eXBlLWNoZWNrLXNob3VsZC1hbGxvdy1lbXB0eS12YWx1 ZS10by1mbG93LXRocm91Z2guanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorLy9A IHJ1bkRlZmF1bHQoIi0taml0UG9saWN5U2NhbGU9MCIsICItLXVzZUNvbmN1cnJlbnRKSVQ9MCIp CisKK2NsYXNzIEMgZXh0ZW5kcyBjbGFzcyB7fSB7CisgICAgY29uc3RydWN0b3IoYmVmb3JlU3Vw ZXIpIHsKKyAgICAgICAgbGV0IGYgPSAoKSA9PiB7CisgICAgICAgICAgICBmb3IgKGxldCBqPTA7 IGo8MTA7IGorKykgeworICAgICAgICAgICAgICAgIHRyeSB7CisgICAgICAgICAgICAgICAgICAg IHRoaXMueAorICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgICAgICAgICB9 CisgICAgICAgICAgICB9CisgICAgICAgIH07CisgICAgICAgIGlmIChiZWZvcmVTdXBlcikgewor ICAgICAgICAgICAgZigpOworICAgICAgICAgICAgc3VwZXIoKTsKKyAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgIHN1cGVyKCk7CisgICAgICAgICAgICBmKCk7CisgICAgICAgIH0KKyAgICB9 Cit9OworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CisgICAgbmV3IEMoZmFsc2Up OworICAgIG5ldyBDKHRydWUpOworfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiAyMzgyNTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMzYgQEAKKzIwMTgtMTEtMTUgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CisKKyAgICAgICAgS25vd25DZWxsVXNlIHNob3VsZCBhbHNvIGhhdmUgU3Bl Y0NlbGxDaGVjayBhcyBpdHMgdHlwZSBmaWx0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTcyOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDU4 NzI4NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2Ugd3JpdGUgdHJhbnNmb3JtYXRpb25zIGluIHRoZSBjb21waWxlciBsaWtlIHRoaXMgd2hlcmUg d2UgZW1pdCBlZGdlcyB3aXRoCisgICAgICAgIEtub3duQ2VsbFVzZSBpZiB3ZSBrbm93IHdlJ3Jl IGluc2VydGluZyBjb2RlIGF0IGEgcG9pbnQgd2hlcmUgd2UncmUgZG9taW5hdGVkCisgICAgICAg IGJ5IGEgQ2VsbCBjaGVjazoKKyAgICAgICAgCisgICAgICAgIGE6IFNvbWVWYWx1ZQorICAgICAg ICBiOiBTb21ldGhpbmcoQ2VsbDpAYSkKKyAgICAgICAgYzogU29tZXRoaW5nRWxzZShAYikKKyAg ICAgICAgZDogQ2hlY2tOb3RFbXB0eShAYSkKKyAgICAgICAgCisgICAgICAgID0+CisgICAgICAg IAorICAgICAgICBhOiBTb21lVmFsdWUKKyAgICAgICAgYjogU29tZXRoaW5nKENlbGw6QGEpCisg ICAgICAgIGU6IFJhbmRvbU90aGVyVGhpbmcoS25vd25DZWxsVXNlOkBhKQorICAgICAgICBjOiBT b21ldGhpbmdFbHNlKEBiKQorICAgICAgICBkOiBDaGVja05vdEVtcHR5KEBhKQorICAgICAgICAK KyAgICAgICAgSG93ZXZlciwgZG9pbmcgdGhpcyB1c2VkIHRvIGxlYWQgdG8gc3VidGx5IGluY29y cmVjdCBwcm9ncmFtcyBzaW5jZSBLbm93bkNlbGxVc2UKKyAgICAgICAgZGlkIG5vdCBhbGxvdyB0 aGUgZW1wdHkgdmFsdWUgdG8gZmxvdyB0aHJvdWdoIGl0LiBXZSB1c2VkIHRvIGVuZCB1cCBpbmNv cnJlY3RseQorICAgICAgICBkZWxldGluZyBAZCBpbiB0aGUgYWJvdmUgcHJvZ3JhbS4gV2UgZml4 IHRoaXMsIHdlIG1ha2UgS25vd25DZWxsVXNlIGFsbG93IHRoZSBlbXB0eQorICAgICAgICB2YWx1 ZSB0byBmbG93IHRocm91Z2guCisKKyAgICAgICAgKiBkZmcvREZHVXNlS2luZC5oOgorICAgICAg ICAoSlNDOjpERkc6OnR5cGVGaWx0ZXJGb3IpOgorCiAyMDE4LTExLTE1ICBLZWl0aCBSb2xsaW4g IDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBEZWxldGUgb2xkIC54Y2ZpbGVsaXN0IGZp bGVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1VzZUtpbmQuaAkocmV2aXNpb24g MjM4MjUwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdVc2VLaW5kLmgJKHdvcmtp bmcgY29weSkKQEAgLTExOSw5ICsxMTksOCBAQCBpbmxpbmUgU3BlY3VsYXRlZFR5cGUgdHlwZUZp bHRlckZvcihVc2VLCiAgICAgY2FzZSBLbm93bkJvb2xlYW5Vc2U6CiAgICAgICAgIHJldHVybiBT cGVjQm9vbGVhbjsKICAgICBjYXNlIENlbGxVc2U6Ci0gICAgICAgIHJldHVybiBTcGVjQ2VsbENo ZWNrOwogICAgIGNhc2UgS25vd25DZWxsVXNlOgotICAgICAgICByZXR1cm4gU3BlY0NlbGw7Cisg ICAgICAgIHJldHVybiBTcGVjQ2VsbENoZWNrOwogICAgIGNhc2UgQ2VsbE9yT3RoZXJVc2U6CiAg ICAgICAgIHJldHVybiBTcGVjQ2VsbENoZWNrIHwgU3BlY090aGVyOwogICAgIGNhc2UgT2JqZWN0 VXNlOgo=